[jira] [Commented] (KAFKA-17096) Fix kafka_log4j_appender.py
[ https://issues.apache.org/jira/browse/KAFKA-17096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863978#comment-17863978 ] xuanzhang gong commented on KAFKA-17096: hello，i will handle this issue. Please assign to me. > Fix kafka_log4j_appender.py > --- > > Key: KAFKA-17096 > URL: https://issues.apache.org/jira/browse/KAFKA-17096 > Project: Kafka > Issue Type: Test >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > > see [https://github.com/apache/kafka/pull/12148#issuecomment-2214584773] for > root cause -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-17012) Enable testMeasureCommitSyncDuration, testMeasureCommittedDurationOnFailure, testInvalidGroupMetadata, testMeasureCommittedDuration, testOffsetsForTimesTimeout, testBe
[ https://issues.apache.org/jira/browse/KAFKA-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856648#comment-17856648 ] xuanzhang gong commented on KAFKA-17012: hello,i will handle this issue,plz ticked me > Enable testMeasureCommitSyncDuration, testMeasureCommittedDurationOnFailure, > testInvalidGroupMetadata, testMeasureCommittedDuration, > testOffsetsForTimesTimeout, testBeginningOffsetsTimeout and > testEndOffsetsTimeout for AsyncConsumer > > > Key: KAFKA-17012 > URL: https://issues.apache.org/jira/browse/KAFKA-17012 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > > just test my fingers - it seems "testMeasureCommitSyncDuration, > testMeasureCommittedDurationOnFailure, testInvalidGroupMetadata, > testMeasureCommittedDuration, testOffsetsForTimesTimeout, > testBeginningOffsetsTimeout, testEndOffsetsTimeout" can work with > AsyncConsumer. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KAFKA-16993) Flaky test RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener.shouldInvokeUserDefinedGlobalStateRestoreListener()
[
https://issues.apache.org/jira/browse/KAFKA-16993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuanzhang gong updated KAFKA-16993:
---
Attachment: (was: kafka权威指南中文版.pdf)
> Flaky test
> RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener.shouldInvokeUserDefinedGlobalStateRestoreListener()
> ---
>
> Key: KAFKA-16993
> URL: https://issues.apache.org/jira/browse/KAFKA-16993
> Project: Kafka
> Issue Type: Test
> Components: streams, unit tests
>Reporter: Matthias J. Sax
>Priority: Major
> Attachments:
> 6u4a4e27e2oh2-org.apache.kafka.streams.integration.RestoreIntegrationTest-shouldInvokeUserDefinedGlobalStateRestoreListener()-1-output.txt
>
>
> {code:java}
> org.opentest4j.AssertionFailedError: expected: but was: at
> org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)at
>
> org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)at
> org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)at
> org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)at
> org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)at
> org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)at
> org.apache.kafka.streams.integration.RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener(RestoreIntegrationTest.java:611)at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)at
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)at
> java.lang.reflect.Method.invoke(Method.java:498)at
> org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:728)at
>
> org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)at
>
> org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)at
>
> org.junit.jupiter.engine.extension.SameThreadTimeoutInvocation.proceed(SameThreadTimeoutInvocation.java:45)at
>
> org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156)at
>
> org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:147)at
>
> org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:86)at
>
> org.junit.jupiter.engine.execution.InterceptingExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(InterceptingExecutableInvoker.java:103)at
>
> org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93)at
>
> org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)at
>
> org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)at
>
> org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)at
>
> org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)at
>
> org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:92)at
>
> org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:86)at
>
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:218)at
>
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)at
>
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:214)at
>
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:139)at
>
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:69)at
>
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)at
>
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)at
>
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)at
> org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)at
>
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)at
>
>
[jira] [Updated] (KAFKA-16993) Flaky test RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener.shouldInvokeUserDefinedGlobalStateRestoreListener()
[
https://issues.apache.org/jira/browse/KAFKA-16993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuanzhang gong updated KAFKA-16993:
---
Attachment: kafka权威指南中文版.pdf
> Flaky test
> RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener.shouldInvokeUserDefinedGlobalStateRestoreListener()
> ---
>
> Key: KAFKA-16993
> URL: https://issues.apache.org/jira/browse/KAFKA-16993
> Project: Kafka
> Issue Type: Test
> Components: streams, unit tests
>Reporter: Matthias J. Sax
>Priority: Major
> Attachments:
> 6u4a4e27e2oh2-org.apache.kafka.streams.integration.RestoreIntegrationTest-shouldInvokeUserDefinedGlobalStateRestoreListener()-1-output.txt
>
>
> {code:java}
> org.opentest4j.AssertionFailedError: expected: but was: at
> org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)at
>
> org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)at
> org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)at
> org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)at
> org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)at
> org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)at
> org.apache.kafka.streams.integration.RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener(RestoreIntegrationTest.java:611)at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)at
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)at
> java.lang.reflect.Method.invoke(Method.java:498)at
> org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:728)at
>
> org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)at
>
> org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)at
>
> org.junit.jupiter.engine.extension.SameThreadTimeoutInvocation.proceed(SameThreadTimeoutInvocation.java:45)at
>
> org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156)at
>
> org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:147)at
>
> org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:86)at
>
> org.junit.jupiter.engine.execution.InterceptingExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(InterceptingExecutableInvoker.java:103)at
>
> org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93)at
>
> org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)at
>
> org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)at
>
> org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)at
>
> org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)at
>
> org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:92)at
>
> org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:86)at
>
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:218)at
>
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)at
>
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:214)at
>
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:139)at
>
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:69)at
>
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)at
>
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)at
>
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)at
> org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)at
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)at
>
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)at
>
>
[jira] [Commented] (KAFKA-16546) add docs to explain how to update cluster-wide default by Admin#incrementalAlterConfigs
[ https://issues.apache.org/jira/browse/KAFKA-16546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855163#comment-17855163 ] xuanzhang gong commented on KAFKA-16546: I will handle this issue > add docs to explain how to update cluster-wide default by > Admin#incrementalAlterConfigs > --- > > Key: KAFKA-16546 > URL: https://issues.apache.org/jira/browse/KAFKA-16546 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia Chuan Yu >Priority: Minor > > We have good docs about updating cluster-wide configs by commend tool > (https://kafka.apache.org/documentation/#dynamicbrokerconfigs), and it would > be great Admin#incrementalAlterConfigs has such good docs also. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KAFKA-16896) upgrade spotless version after we drop JDK8
[ https://issues.apache.org/jira/browse/KAFKA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuanzhang gong updated KAFKA-16896: --- Summary: upgrade spotless version after we drop JDK8 (was: upgrade spotless version and apply ) > upgrade spotless version after we drop JDK8 > --- > > Key: KAFKA-16896 > URL: https://issues.apache.org/jira/browse/KAFKA-16896 > Project: Kafka > Issue Type: Improvement > Components: build >Affects Versions: 3.7.0 >Reporter: xuanzhang gong >Assignee: xuanzhang gong >Priority: Major > Fix For: 4.0.0 > > > we import spotless plugin in order to unify Kafka code style. > Spotless version > 6.14- support JDK8 > 6.15.0+ require JDK11 > 6.23.3+ support JDK 21 but build error in JDK 8 even though we apply false in > plugin block. > We couldn't find a suitable way to be compatible with all versions. > So far, here's how we do it: use 6.14.0 version, compatibility JDK8 , skip > JDK21. > We will upgrade spotless version to the latest when kafka drop support JDK8 > and drop CI in JDK8 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-16896) upgrade spotless version and apply
xuanzhang gong created KAFKA-16896: -- Summary: upgrade spotless version and apply Key: KAFKA-16896 URL: https://issues.apache.org/jira/browse/KAFKA-16896 Project: Kafka Issue Type: Improvement Components: build Affects Versions: 3.7.0 Reporter: xuanzhang gong Assignee: xuanzhang gong Fix For: 4.0.0 we import spotless plugin in order to unify Kafka code style. Spotless version 6.14- support JDK8 6.15.0+ require JDK11 6.23.3+ support JDK 21 but build error in JDK 8 even though we apply false in plugin block. We couldn't find a suitable way to be compatible with all versions. So far, here's how we do it: use 6.14.0 version, compatibility JDK8 , skip JDK21. We will upgrade spotless version to the latest when kafka drop support JDK8 and drop CI in JDK8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16771) First log directory printed twice when formatting storage
[
https://issues.apache.org/jira/browse/KAFKA-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846781#comment-17846781
]
xuanzhang gong commented on KAFKA-16771:
i will handle this issue
> First log directory printed twice when formatting storage
> -
>
> Key: KAFKA-16771
> URL: https://issues.apache.org/jira/browse/KAFKA-16771
> Project: Kafka
> Issue Type: Task
> Components: tools
>Affects Versions: 3.7.0
>Reporter: Mickael Maison
>Priority: Major
>
> If multiple log directories are set, when running bin/kafka-storage.sh
> format, the first directory is printed twice. For example:
> {noformat}
> bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c
> config/kraft/server.properties --release-version 3.6
> metaPropertiesEnsemble=MetaPropertiesEnsemble(metadataLogDir=Optional.empty,
> dirs={/tmp/kraft-combined-logs: EMPTY, /tmp/kraft-combined-logs2: EMPTY})
> Formatting /tmp/kraft-combined-logs with metadata.version 3.6-IV2.
> Formatting /tmp/kraft-combined-logs with metadata.version 3.6-IV2.
> Formatting /tmp/kraft-combined-logs2 with metadata.version 3.6-IV2.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-16705) the flag "started" of RaftClusterInstance is false even though the cluster is started
[ https://issues.apache.org/jira/browse/KAFKA-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845775#comment-17845775 ] xuanzhang gong commented on KAFKA-16705: I will fix the bug. please ticketd me > the flag "started" of RaftClusterInstance is false even though the cluster is > started > - > > Key: KAFKA-16705 > URL: https://issues.apache.org/jira/browse/KAFKA-16705 > Project: Kafka > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > > we should set `started` to true after > https://github.com/apache/kafka/blob/643db430a707479c9e87eec1ad67e1d4f43c9268/core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java#L113 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16643) Add ModifierOrder checkstyle rule
[ https://issues.apache.org/jira/browse/KAFKA-16643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844598#comment-17844598 ] xuanzhang gong commented on KAFKA-16643: I have finished this modification task link:https://github.com/apache/kafka/pull/15890 > Add ModifierOrder checkstyle rule > - > > Key: KAFKA-16643 > URL: https://issues.apache.org/jira/browse/KAFKA-16643 > Project: Kafka > Issue Type: Task > Components: build >Reporter: Greg Harris >Priority: Minor > > Checkstyle offers the ModifierOrder rule: > [https://checkstyle.sourceforge.io/checks/modifier/modifierorder.html] that > Kafka violates in a lot of places. We should decide if this is a checkstyle > rule we should be following or not, and potentially enable it moving forward. -- This message was sent by Atlassian Jira (v8.20.10#820010)
