[GitHub] [kafka] mjsax commented on pull request #13142: KAFKA-14491: [2/N] Refactor RocksDB store open iterator management

2023-01-26 Thread via GitHub 


mjsax commented on PR #13142:
URL: https://github.com/apache/kafka/pull/13142#issuecomment-1405947882

   Checkstyle error:
   ```
   > Task :streams:checkstyleTest
   
   [2023-01-26T22:45:54.179Z] [ant:checkstyle] [ERROR] 
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-13142/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBRangeIteratorTest.java:396:44:
 '{' is not followed by whitespace. [WhitespaceAround]
   
   [2023-01-26T22:45:54.179Z] [ant:checkstyle] [ERROR] 
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-13142/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBRangeIteratorTest.java:396:45:
 '}' is not preceded with whitespace. [WhitespaceAround]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #13142: KAFKA-14491: [2/N] Refactor RocksDB store open iterator management

2023-01-26 Thread via GitHub 


mjsax commented on PR #13142:
URL: https://github.com/apache/kafka/pull/13142#issuecomment-1404744058

   There is a test failure -- seems you need to update `shouldCloseIterator()` 
test and set a callback via `onClose()`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org