[kbuild] drivers/net/wireless/intel/iwlwifi/pcie/rx.c:1869 iwl_pcie_irq_handler() error: call of '__iwl_err' with no format argument
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Johannes Berg CC: Luca Coelho tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cfb92440ee71adcc2105b0890bb01ac3cddb8507 commit: e5f1cc98cc1bd07bc6d4f75e34d89db06a2f8bdb iwlwifi: allow rate-limited error messages date: 4 months ago :: branch date: 9 hours ago :: commit date: 4 months ago config: ia64-randconfig-m031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202211320.vtxl4ied-...@intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/wireless/intel/iwlwifi/pcie/rx.c:1869 iwl_pcie_irq_handler() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/rx.c:2286 iwl_pcie_irq_msix_handler() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/queue/tx.c:1108 iwl_txq_dyn_alloc_dma() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/queue/tx.c:1271 iwl_txq_gen2_init() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/trans.c:65 iwl_trans_pcie_dump_regs() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/trans.c:620 iwl_pcie_prepare_card_hw() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/trans.c:675 iwl_pcie_load_firmware_chunk() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1331 iwl_trans_pcie_start_fw() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1540 iwl_trans_pcie_d3_resume() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/trans.c:1732 iwl_trans_pcie_clear_persistence_bit() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2077 __iwl_trans_pcie_grab_nic_access() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2434 iwl_pcie_dump_csr() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/fw/dump.c:162 iwl_fwrt_dump_umac_error_log() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/fw/dump.c:212 iwl_fwrt_dump_lmac_error_log() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/fw/dump.c:358 iwl_fwrt_dump_iml_error_log() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/fw/dump.c:399 iwl_fwrt_dump_fseq_regs() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/fw/dump.c:412 iwl_fwrt_dump_error_logs() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/iwl-io.c:315 iwl_dump_rfh() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/iwl-io.c:392 iwl_dump_fh() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/ctxt-info-gen3.c:71 iwl_pcie_ctxt_info_dbg_enable() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c:390 iwl_send_phy_db_data() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1230 get_crf_id() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c:121 iwl_pcie_gen2_enqueue_hcmd() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:95 iwl_eeprom_verify_signature() warn: excess argument passed to '__iwl_err' drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:95 iwl_eeprom_verify_signature() warn: excess argument passed to '__iwl_err' drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:123 iwl_nvm_is_otp() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:188 iwl_read_otp_word() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:214 iwl_is_otp_empty() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:326 iwl_read_eeprom() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c:432 iwl_trans_pcie_gen2_start_fw() error: call of '__iwl_err' with no format argument drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c:1034 iwl_set_hw_address_fami
[kbuild] drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() error: we previously assumed 'ring' could be null (see line 5673)
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Maciej Fijalkowski CC: Tony Nguyen tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cfb92440ee71adcc2105b0890bb01ac3cddb8507 commit: e72bba21355dbb67512a0d666fec9f4b56dbfc2f ice: split ice_ring onto Tx/Rx separate structs date: 4 months ago :: branch date: 7 hours ago :: commit date: 4 months ago config: ia64-randconfig-m031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202211208.rslrugsa-...@intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() error: we previously assumed 'ring' could be null (see line 5673) vim +/ring +5677 drivers/net/ethernet/intel/ice/ice_main.c fcea6f3da546b9 Anirudh Venkataramanan 2018-03-20 5654 49d358e0e746dc Marta Plantykow2020-05-15 5655 /** 49d358e0e746dc Marta Plantykow2020-05-15 5656 * ice_update_vsi_tx_ring_stats - Update VSI Tx ring stats counters 49d358e0e746dc Marta Plantykow2020-05-15 5657 * @vsi: the VSI to be updated 49d358e0e746dc Marta Plantykow2020-05-15 5658 * @rings: rings to work on 49d358e0e746dc Marta Plantykow2020-05-15 5659 * @count: number of rings 49d358e0e746dc Marta Plantykow2020-05-15 5660 */ 49d358e0e746dc Marta Plantykow2020-05-15 5661 static void e72bba21355dbb Maciej Fijalkowski 2021-08-19 5662 ice_update_vsi_tx_ring_stats(struct ice_vsi *vsi, struct ice_tx_ring **rings, 49d358e0e746dc Marta Plantykow2020-05-15 5663 u16 count) 49d358e0e746dc Marta Plantykow2020-05-15 5664 { 49d358e0e746dc Marta Plantykow2020-05-15 5665 struct rtnl_link_stats64 *vsi_stats = &vsi->net_stats; 49d358e0e746dc Marta Plantykow2020-05-15 5666 u16 i; 49d358e0e746dc Marta Plantykow2020-05-15 5667 49d358e0e746dc Marta Plantykow2020-05-15 5668 for (i = 0; i < count; i++) { e72bba21355dbb Maciej Fijalkowski 2021-08-19 5669 struct ice_tx_ring *ring; e72bba21355dbb Maciej Fijalkowski 2021-08-19 5670 u64 pkts = 0, bytes = 0; 49d358e0e746dc Marta Plantykow2020-05-15 5671 49d358e0e746dc Marta Plantykow2020-05-15 5672 ring = READ_ONCE(rings[i]); e72bba21355dbb Maciej Fijalkowski 2021-08-19 @5673 if (ring) e72bba21355dbb Maciej Fijalkowski 2021-08-19 5674 ice_fetch_u64_stats_per_ring(&ring->syncp, ring->stats, &pkts, &bytes); 49d358e0e746dc Marta Plantykow2020-05-15 5675 vsi_stats->tx_packets += pkts; 49d358e0e746dc Marta Plantykow2020-05-15 5676 vsi_stats->tx_bytes += bytes; 49d358e0e746dc Marta Plantykow2020-05-15 @5677 vsi->tx_restart += ring->tx_stats.restart_q; 49d358e0e746dc Marta Plantykow2020-05-15 5678 vsi->tx_busy += ring->tx_stats.tx_busy; 49d358e0e746dc Marta Plantykow2020-05-15 5679 vsi->tx_linearize += ring->tx_stats.tx_linearize; 49d358e0e746dc Marta Plantykow2020-05-15 5680 } 49d358e0e746dc Marta Plantykow2020-05-15 5681 } 49d358e0e746dc Marta Plantykow2020-05-15 5682 :: The code at line 5677 was first introduced by commit :: 49d358e0e746dc24bfb1b1cf98c17064e5177424 ice: Add XDP Tx to VSI ring stats :: TO: Marta Plantykow :: CC: Jeff Kirsher --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
kbuild@lists.01.org
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Stefan Assmann CC: Tony Nguyen tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cfb92440ee71adcc2105b0890bb01ac3cddb8507 commit: 5ac49f3c2702f269d31cc37eb9308bc557953c4d iavf: use mutexes for locking of critical sections date: 6 months ago :: branch date: 5 hours ago :: commit date: 6 months ago config: ia64-randconfig-m031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202211059.wmst3x8t-...@intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/net/ethernet/intel/iavf/iavf_main.c:2309 iavf_reset_task() warn: inconsistent returns '&adapter->crit_lock'. vim +2309 drivers/net/ethernet/intel/iavf/iavf_main.c dedecb6d429bd3 drivers/net/ethernet/intel/i40evf/i40evf_main.c Joe Perches 2016-11-01 2088 5eae00c57f5e42 drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose 2013-12-21 2089 /** 129cf89e585676 drivers/net/ethernet/intel/iavf/i40evf_main.c Jesse Brandeburg 2018-09-14 2090 * iavf_reset_task - Call-back task to handle hardware reset 5eae00c57f5e42 drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose 2013-12-21 2091 * @work: pointer to work_struct 5eae00c57f5e42 drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose 2013-12-21 2092 * 5eae00c57f5e42 drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose 2013-12-21 2093 * During reset we need to shut down and reinitialize the admin queue 5eae00c57f5e42 drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose 2013-12-21 2094 * before we can use it to communicate with the PF again. We also clear 5eae00c57f5e42 drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose 2013-12-21 2095 * and reinit the rings because that context is lost as well. 5eae00c57f5e42 drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose 2013-12-21 2096 **/ 129cf89e585676 drivers/net/ethernet/intel/iavf/i40evf_main.c Jesse Brandeburg 2018-09-14 2097 static void iavf_reset_task(struct work_struct *work) 5eae00c57f5e42 drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose 2013-12-21 2098 { 129cf89e585676 drivers/net/ethernet/intel/iavf/i40evf_main.c Jesse Brandeburg 2018-09-14 2099 struct iavf_adapter *adapter = container_of(work, 129cf89e585676 drivers/net/ethernet/intel/iavf/i40evf_main.c Jesse Brandeburg 2018-09-14 2100 struct iavf_adapter, ef8693eb90ae38 drivers/net/ethernet/intel/i40evf/i40evf_main.c Mitch Williams 2014-02-13 2101 reset_task); 0075fa0fadd0ac drivers/net/ethernet/intel/i40evf/i40evf_main.c Harshitha Ramamurthy 2018-01-23 2102 struct virtchnl_vf_resource *vfres = adapter->vf_res; ac833bbf7958bb drivers/net/ethernet/intel/i40evf/i40evf_main.c Mitch Williams 2015-01-29 2103 struct net_device *netdev = adapter->netdev; f349daa58809ae drivers/net/ethernet/intel/iavf/iavf_main.c Jesse Brandeburg 2018-09-14 2104 struct iavf_hw *hw = &adapter->hw; 9e05229190380f drivers/net/ethernet/intel/iavf/iavf_main.c Stefan Assmann 2019-12-17 2105 struct iavf_mac_filter *f, *ftmp; 129cf89e585676 drivers/net/ethernet/intel/iavf/i40evf_main.c Jesse Brandeburg 2018-09-14 2106 struct iavf_vlan_filter *vlf; 129cf89e585676 drivers/net/ethernet/intel/iavf/i40evf_main.c Jesse Brandeburg 2018-09-14 2107 struct iavf_cloud_filter *cf; ee5c1e92dd01d3 drivers/net/ethernet/intel/i40evf/i40evf_main.c Mitch Williams 2015-08-28 2108 u32 reg_val; ac833bbf7958bb drivers/net/ethernet/intel/i40evf/i40evf_main.c Mitch Williams 2015-01-29 2109 int i = 0, err; 44b034b406211f drivers/net/ethernet/intel/i40evf/i40evf_main.c Jacob Keller 2017-10-27 2110 bool running; 5eae00c57f5e42 drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose 2013-12-21 2111 06aa040f039404 drivers/net/ethernet/intel/i40evf/i40evf_main.c Avinash Dayanand 2017-12-18 2112 /* When device is being removed it doesn't make sense to run the reset 06aa040f039404 drivers/net/ethernet/intel/i40evf/i40evf_main.c Avinash Dayanand 2017-12-18 2113* task, just return in such a case. 06aa040f039404 drivers/net/ethernet/intel/i40evf/i40evf_main.c Avinash Dayanand 2017-12-18 2114*/ 5ac49f3c2702f2 drivers/net/ethernet/intel/iavf/iavf_main.c Stefan Assmann 2021-08-04 2115 if (mutex_is_locked(&adapter->remove_lock)) 06aa040f039404 drivers/net/ethernet/intel/i40evf/i40evf_main.c Avinash Dayanand 2017-12-18 2116 return; 06aa040f039404 drive
[kbuild] kernel/kcsan/kcsan_test.c:953:1: warning: the frame size of 2928 bytes is larger than 2048 bytes
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Ilya Leoshkevich CC: Heiko Carstens Hi Ilya, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 77478077349f14c78e30faeac358cf1187c0f0c1 commit: e37b3dd063a1a68e28a7cfaf77c84c472112e330 s390: enable KCSAN date: 7 months ago :: branch date: 5 hours ago :: commit date: 7 months ago config: s390-randconfig-p002-20220220 (https://download.01.org/0day-ci/archive/20220221/202202210849.bnxkhus8-...@intel.com/config) compiler: s390-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e37b3dd063a1a68e28a7cfaf77c84c472112e330 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout e37b3dd063a1a68e28a7cfaf77c84c472112e330 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash kernel/kcsan/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): kernel/kcsan/kcsan_test.c: In function 'test_atomic_builtins': kernel/kcsan/kcsan_test.c:945:17: warning: 'atomic_thread_fence' is not supported with '-fsanitize=thread' [-Wtsan] 945 | __atomic_thread_fence(__ATOMIC_SEQ_CST); | ^~~ >> kernel/kcsan/kcsan_test.c:953:1: warning: the frame size of 2928 bytes is >> larger than 2048 bytes [-Wframe-larger-than=] 953 | } | ^ vim +953 kernel/kcsan/kcsan_test.c 1fe84fd4a4027a kernel/kcsan/kcsan-test.c Marco Elver 2020-05-05 901 f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 902 /* f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 903 * Test atomic builtins work and required instrumentation functions exist. We f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 904 * also test that KCSAN understands they're atomic by racing with them via f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 905 * test_kernel_atomic_builtins(), and expect no reports. f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 906 * f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 907 * The atomic builtins _SHOULD NOT_ be used in normal kernel code! f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 908 */ f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 909 static void test_atomic_builtins(struct kunit *test) f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 910 { f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 911bool match_never = false; f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 912 f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 913 begin_test_checks(test_kernel_atomic_builtins, test_kernel_atomic_builtins); f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 914do { f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 915 long tmp; f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 916 f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 917 kcsan_enable_current(); f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 918 f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 919 __atomic_store_n(&test_var, 42L, __ATOMIC_RELAXED); f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 920 KUNIT_EXPECT_EQ(test, 42L, __atomic_load_n(&test_var, __ATOMIC_RELAXED)); f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 921 f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 922 KUNIT_EXPECT_EQ(test, 42L, __atomic_exchange_n(&test_var, 20, __ATOMIC_RELAXED)); f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 923 KUNIT_EXPECT_EQ(test, 20L, test_var); f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 924 f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 925 tmp = 20L; f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 926 KUNIT_EXPECT_TRUE(test, __atomic_compare_exchange_n(&test_var, &tmp, 30L, f9ea6319313547 kernel/kcsan/kcsan-test.c Marco Elver 2020-07-03 927 0, __ATOMIC_RELA
[kbuild] drivers/gpu/drm/i915/gt/mock_engine.c:48 mock_timeline_pin() warn: inconsistent returns 'tl->hwsp_ggtt->obj->base.resv'.
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Maarten Lankhorst CC: Daniel Vetter CC: "Thomas Hellström" tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cfb92440ee71adcc2105b0890bb01ac3cddb8507 commit: 2c8ab3339e398bbbcb0980933e266b93bedaae52 drm/i915: Pin timeline map after first timeline pin, v4. date: 11 months ago :: branch date: 3 hours ago :: commit date: 11 months ago config: i386-randconfig-m021-20220214 (https://download.01.org/0day-ci/archive/20220221/202202210828.jfppmkn8-...@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/gpu/drm/i915/gt/mock_engine.c:48 mock_timeline_pin() warn: inconsistent returns 'tl->hwsp_ggtt->obj->base.resv'. vim +48 drivers/gpu/drm/i915/gt/mock_engine.c f97fbf9606a1a9 drivers/gpu/drm/i915/selftests/mock_engine.c Chris Wilson 2017-02-13 34 2c8ab3339e398b drivers/gpu/drm/i915/gt/mock_engine.cMaarten Lankhorst 2021-03-23 35 static int mock_timeline_pin(struct intel_timeline *tl) 5013eb8cd601c3 drivers/gpu/drm/i915/selftests/mock_engine.c Chris Wilson 2019-01-28 36 { 2c8ab3339e398b drivers/gpu/drm/i915/gt/mock_engine.cMaarten Lankhorst 2021-03-23 37int err; 2c8ab3339e398b drivers/gpu/drm/i915/gt/mock_engine.cMaarten Lankhorst 2021-03-23 38 2c8ab3339e398b drivers/gpu/drm/i915/gt/mock_engine.cMaarten Lankhorst 2021-03-23 39if (WARN_ON(!i915_gem_object_trylock(tl->hwsp_ggtt->obj))) 2c8ab3339e398b drivers/gpu/drm/i915/gt/mock_engine.cMaarten Lankhorst 2021-03-23 40return -EBUSY; 2c8ab3339e398b drivers/gpu/drm/i915/gt/mock_engine.cMaarten Lankhorst 2021-03-23 41 2c8ab3339e398b drivers/gpu/drm/i915/gt/mock_engine.cMaarten Lankhorst 2021-03-23 42err = intel_timeline_pin_map(tl); 2c8ab3339e398b drivers/gpu/drm/i915/gt/mock_engine.cMaarten Lankhorst 2021-03-23 43i915_gem_object_unlock(tl->hwsp_ggtt->obj); 2c8ab3339e398b drivers/gpu/drm/i915/gt/mock_engine.cMaarten Lankhorst 2021-03-23 44if (err) 2c8ab3339e398b drivers/gpu/drm/i915/gt/mock_engine.cMaarten Lankhorst 2021-03-23 45return err; 2c8ab3339e398b drivers/gpu/drm/i915/gt/mock_engine.cMaarten Lankhorst 2021-03-23 46 ccb23d2dcc300d drivers/gpu/drm/i915/gt/mock_engine.cChris Wilson 2019-08-15 47atomic_inc(&tl->pin_count); 2c8ab3339e398b drivers/gpu/drm/i915/gt/mock_engine.cMaarten Lankhorst 2021-03-23 @48return 0; 5013eb8cd601c3 drivers/gpu/drm/i915/selftests/mock_engine.c Chris Wilson 2019-01-28 49 } 5013eb8cd601c3 drivers/gpu/drm/i915/selftests/mock_engine.c Chris Wilson 2019-01-28 50 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] drivers/net/wireless/intel/iwlwifi/fw/pnvm.c:332 iwl_pnvm_load() error: uninitialized symbol 'len'.
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Luca Coelho tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3324e6e803156b429697f566892e4e3f4fcf commit: 9dad325f9d57508b154f0bebbc341a8528e5729c iwlwifi: support loading the reduced power table from UEFI date: 8 months ago :: branch date: 3 hours ago :: commit date: 8 months ago config: ia64-randconfig-m031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202210804.timjfm53-...@intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/net/wireless/intel/iwlwifi/fw/pnvm.c:332 iwl_pnvm_load() error: uninitialized symbol 'len'. vim +/len +332 drivers/net/wireless/intel/iwlwifi/fw/pnvm.c cdda18fbbefafc Luca Coelho 2021-02-10 255 cdda18fbbefafc Luca Coelho 2021-02-10 256 int iwl_pnvm_load(struct iwl_trans *trans, cdda18fbbefafc Luca Coelho 2021-02-10 257 struct iwl_notif_wait_data *notif_wait) cdda18fbbefafc Luca Coelho 2021-02-10 258 { cdda18fbbefafc Luca Coelho 2021-02-10 259u8 *data; cdda18fbbefafc Luca Coelho 2021-02-10 260size_t len; 84c3c9952afbf7 Luca Coelho 2021-06-21 261struct pnvm_sku_package *package; cdda18fbbefafc Luca Coelho 2021-02-10 262struct iwl_notification_wait pnvm_wait; cdda18fbbefafc Luca Coelho 2021-02-10 263static const u16 ntf_cmds[] = { WIDE_ID(REGULATORY_AND_NVM_GROUP, cdda18fbbefafc Luca Coelho 2021-02-10 264 PNVM_INIT_COMPLETE_NTFY) }; cdda18fbbefafc Luca Coelho 2021-02-10 265int ret; cdda18fbbefafc Luca Coelho 2021-02-10 266 cdda18fbbefafc Luca Coelho 2021-02-10 267/* if the SKU_ID is empty, there's nothing to do */ cdda18fbbefafc Luca Coelho 2021-02-10 268if (!trans->sku_id[0] && !trans->sku_id[1] && !trans->sku_id[2]) cdda18fbbefafc Luca Coelho 2021-02-10 269return 0; cdda18fbbefafc Luca Coelho 2021-02-10 270 cdda18fbbefafc Luca Coelho 2021-02-10 271/* cdda18fbbefafc Luca Coelho 2021-02-10 272 * If we already loaded (or tried to load) it before, we just cdda18fbbefafc Luca Coelho 2021-02-10 273 * need to set it again. cdda18fbbefafc Luca Coelho 2021-02-10 274 */ cdda18fbbefafc Luca Coelho 2021-02-10 275if (trans->pnvm_loaded) { cdda18fbbefafc Luca Coelho 2021-02-10 276ret = iwl_trans_set_pnvm(trans, NULL, 0); cdda18fbbefafc Luca Coelho 2021-02-10 277if (ret) cdda18fbbefafc Luca Coelho 2021-02-10 278return ret; cdda18fbbefafc Luca Coelho 2021-02-10 279goto skip_parse; cdda18fbbefafc Luca Coelho 2021-02-10 280} cdda18fbbefafc Luca Coelho 2021-02-10 281 a1a6a4cf49eceb Luca Coelho 2021-02-11 282/* First attempt to get the PNVM from BIOS */ 84c3c9952afbf7 Luca Coelho 2021-06-21 283package = iwl_uefi_get_pnvm(trans, &len); 84c3c9952afbf7 Luca Coelho 2021-06-21 284if (!IS_ERR_OR_NULL(package)) { 84c3c9952afbf7 Luca Coelho 2021-06-21 285data = kmemdup(package->data, len, GFP_KERNEL); 84c3c9952afbf7 Luca Coelho 2021-06-21 286 84c3c9952afbf7 Luca Coelho 2021-06-21 287/* free package regardless of whether kmemdup succeeded */ 84c3c9952afbf7 Luca Coelho 2021-06-21 288kfree(package); 84c3c9952afbf7 Luca Coelho 2021-06-21 289 84c3c9952afbf7 Luca Coelho 2021-06-21 290if (data) { 84c3c9952afbf7 Luca Coelho 2021-06-21 291/* we need only the data size */ 84c3c9952afbf7 Luca Coelho 2021-06-21 292len -= sizeof(*package); a1a6a4cf49eceb Luca Coelho 2021-02-11 293goto parse; 84c3c9952afbf7 Luca Coelho 2021-06-21 294} 84c3c9952afbf7 Luca Coelho 2021-06-21 295} a1a6a4cf49eceb Luca Coelho 2021-02-11 296 a1a6a4cf49eceb Luca Coelho 2021-02-11 297/* If it's not available, try from the filesystem */ cdda18fbbefafc Luca Coelho 2021-02-10 298ret = iwl_pnvm_get_from_fs(trans, &data, &len); cdda18fbbefafc Luca Coelho 2021-02-10 299if (ret) { 82a08d0cd7b503 Johannes Berg 2021-01-15 300/* 82a08d0cd7b503 Johannes Berg 2021-01-15 301 * Pretend we've loaded it - at least we've tried and 82a08d0cd7b503 Johannes Berg 2021-01-15 302 * couldn't load it at all, so there's no point in 82a08d0cd7b503 Johannes Berg 2021-01-15 303 * trying again over and over. 82a08d0cd7b503 Johannes Berg 2021-01-15 304 */ 82a08d0cd7b503 Johannes Berg 2021-01-15 305trans->pnvm_loaded = true; 6972592850c00e Luca Coelho 2020-10-08 306 cdda18fbbefafc Luca Coelho 2021-02-10 307goto sk
[kbuild] drivers/iommu/apple-dart.c:671:22: warning: Value stored to 'res' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
CC: l...@lists.linux.dev CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Sven Peter CC: Joerg Roedel tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3324e6e803156b429697f566892e4e3f4fcf commit: 46d1fb072e76b161b0fb1ada9e37bf7e4d1f123f iommu/dart: Add DART iommu driver date: 6 months ago :: branch date: 2 hours ago :: commit date: 6 months ago config: riscv-randconfig-c006-20220215 (https://download.01.org/0day-ci/archive/20220221/202202210746.ixocdpkb-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 37f422f4ac31c8b8041c6b62065263314282dab6) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=46d1fb072e76b161b0fb1ada9e37bf7e4d1f123f git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 46d1fb072e76b161b0fb1ada9e37bf7e4d1f123f # save the config file to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv clang-analyzer If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot clang-analyzer warnings: (new ones prefixed by >>) include/linux/list.h:511:2: note: expanded from macro 'list_entry' container_of(ptr, type, member) ^ include/linux/kernel.h:495:2: note: expanded from macro 'container_of' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^ note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all) include/linux/compiler_types.h:328:2: note: expanded from macro 'compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ include/linux/compiler_types.h:316:2: note: expanded from macro '_compiletime_assert' __compiletime_assert(condition, msg, prefix, suffix) ^ include/linux/compiler_types.h:306:2: note: expanded from macro '__compiletime_assert' do {\ ^ drivers/base/regmap/regmap-debugfs.c:75:3: note: Calling 'list_del' list_del(&c->list); ^~ include/linux/list.h:146:2: note: Calling '__list_del_entry' __list_del_entry(entry); ^~~ include/linux/list.h:132:2: note: Taking false branch if (!__list_del_entry_valid(entry)) ^ include/linux/list.h:135:13: note: Use of memory after it is freed __list_del(entry->prev, entry->next); ^~~ Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 7 warnings generated. Suppressed 7 warnings (7 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 8 warnings generated. fs/ubifs/tnc_misc.c:51:35: warning: Access to field 'level' results in a dereference of a null pointer (loaded from variable 'zr') [clang-analyzer-core.NullDereference] ubifs_assert(c, znode->level <= zr->level); ^ fs/ubifs/debug.h:143:17: note: expanded from macro 'ubifs_assert' if (unlikely(!(expr))) { \ ^~~~ include/linux/compiler.h:78:42: note: expanded from macro 'unlikely' # define unlikely(x)__builtin_expect(!!(x), 0) ^ fs/ubifs/tnc_misc.c:36:2: note: Assuming 'zr' is null ubifs_assert(c, zr); ^ fs/ubifs/debug.h:143:15: note: expanded from macro 'ubifs_assert' if (unlikely(!(expr))) { \ ~^~~~ include/linux/compiler.h:78:42: note: expanded from macro 'unlikely' # define unlikely(x)__builtin_expect(!!(x), 0) ^ fs/ubifs/tnc_misc.c:36:2: note: Taking true branch ubifs_assert(c, zr); ^ fs/ubifs/debug.h:143:2: note: expanded from macro 'ubifs_assert' if (unlikely(!(expr))) { \ ^ fs/ubifs/tnc_misc.c:36:2: note: Loop condition is false. Exiting loop ubifs_assert(c, zr); ^ fs/ubifs/debug.h:142:31: n
[kbuild] [ceph-client:wip-fscrypt 29/63] fs/ceph/mds_client.c:3915:19: warning: Assigned value is garbage or undefined [clang-analyzer-core.uninitialized.Assign]
CC: l...@lists.linux.dev CC: kbuild-...@lists.01.org CC: ceph-de...@vger.kernel.org TO: Jeff Layton tree: https://github.com/ceph/ceph-client.git wip-fscrypt head: 4ec0d0e0cc68c6525ace02e7a8a5bb57a4242997 commit: 16a6682845642c1929a94e826c4426c22ef909d4 [29/63] ceph: add encrypted fname handling to ceph_mdsc_build_path :: branch date: 33 hours ago :: commit date: 33 hours ago config: x86_64-randconfig-c007 (https://download.01.org/0day-ci/archive/20220221/202202210649.1d2hrquz-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/ceph/ceph-client/commit/16a6682845642c1929a94e826c4426c22ef909d4 git remote add ceph-client https://github.com/ceph/ceph-client.git git fetch --no-tags ceph-client wip-fscrypt git checkout 16a6682845642c1929a94e826c4426c22ef909d4 # save the config file to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 clang-analyzer If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot clang-analyzer warnings: (new ones prefixed by >>) fs/notify/fanotify/fanotify_user.c:1598:24: note: Left side of '&&' is false if (mask & FAN_RENAME && !(fid_mode & FAN_REPORT_NAME)) ^ fs/notify/fanotify/fanotify_user.c:1601:6: note: Assuming the condition is false if (flags & FAN_MARK_FLUSH) { ^~ fs/notify/fanotify/fanotify_user.c:1601:2: note: Taking false branch if (flags & FAN_MARK_FLUSH) { ^ fs/notify/fanotify/fanotify_user.c:1614:6: note: Assuming 'ret' is 0 if (ret) ^~~ fs/notify/fanotify/fanotify_user.c:1614:2: note: Taking false branch if (ret) ^ fs/notify/fanotify/fanotify_user.c:1617:6: note: Assuming the condition is false if (flags & FAN_MARK_ADD) { ^~~~ fs/notify/fanotify/fanotify_user.c:1617:2: note: Taking false branch if (flags & FAN_MARK_ADD) { ^ fs/notify/fanotify/fanotify_user.c:1623:6: note: Assuming 'fid_mode' is 0 if (fid_mode) { ^~~~ fs/notify/fanotify/fanotify_user.c:1623:2: note: Taking false branch if (fid_mode) { ^ fs/notify/fanotify/fanotify_user.c:1636:6: note: 'mark_type' is not equal to FAN_MARK_INODE if (mark_type == FAN_MARK_INODE) ^ fs/notify/fanotify/fanotify_user.c:1636:2: note: Taking false branch if (mark_type == FAN_MARK_INODE) ^ fs/notify/fanotify/fanotify_user.c:1642:6: note: Assuming 'mnt' is null if (mnt || !S_ISDIR(inode->i_mode)) { ^~~ fs/notify/fanotify/fanotify_user.c:1642:6: note: Left side of '||' is false fs/notify/fanotify/fanotify_user.c:1642:14: note: Access to field 'i_mode' results in a dereference of a null pointer (loaded from variable 'inode') if (mnt || !S_ISDIR(inode->i_mode)) { ^ include/uapi/linux/stat.h:23:22: note: expanded from macro 'S_ISDIR' #define S_ISDIR(m) (((m) & S_IFMT) == S_IFDIR) ^~ Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 4 warnings generated. Suppressed 4 warnings (4 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 4 warnings generated. Suppressed 4 warnings (4 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 4 warnings generated. Suppressed 4 warnings (4 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 4 warnings generated. Suppressed 4 warnings (4 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 6 warnings generated. drivers/acpi/power.c:951:2: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy] strcpy(acpi_device_name(device), ACPI_POWER_DEVICE_NAME); ^~ drivers/acpi/power.c:951:2: note: Call to function 'st
[kbuild] drivers/net/ethernet/intel/ice/ice_flow.c:663 ice_flow_xtract_fld() error: testing array offset 'sib' after use.
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Qi Zhang CC: Tony Nguyen CC: Dan Nowlin tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 77478077349f14c78e30faeac358cf1187c0f0c1 commit: b199dddbd399536d5470e10e6bfd7d0e1b5fb71a ice: Support non word aligned input set field date: 11 months ago :: branch date: 3 hours ago :: commit date: 11 months ago config: ia64-randconfig-m031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202210600.1bgzxghc-...@intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/ethernet/intel/ice/ice_flow.c:663 ice_flow_xtract_fld() error: testing array offset 'sib' after use. Old smatch warnings: drivers/net/ethernet/intel/ice/ice_flow.c:1698 ice_add_rss_cfg_sync() error: we previously assumed 'prof' could be null (see line 1680) vim +/sib +663 drivers/net/ethernet/intel/ice/ice_flow.c 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 511 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 512 /** 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 513 * ice_flow_xtract_fld - Create an extraction sequence entry for the given field 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 514 * @hw: pointer to the HW struct 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 515 * @params: information about the flow to be processed 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 516 * @seg: packet segment index of the field to be extracted 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 517 * @fld: ID of field to be extracted b199dddbd39953 Qi Zhang 2021-03-09 518 * @match: bit field of all fields 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 519 * 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 520 * This function determines the protocol ID, offset, and size of the given 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 521 * field. It then allocates one or more extraction sequence entries for the 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 522 * given field, and fill the entries with protocol ID and offset information. 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 523 */ 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 524 static enum ice_status 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 525 ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params, b199dddbd39953 Qi Zhang 2021-03-09 526u8 seg, enum ice_flow_field fld, u64 match) 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 527 { b199dddbd39953 Qi Zhang 2021-03-09 528enum ice_flow_field sib = ICE_FLOW_FIELD_IDX_MAX; 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 529enum ice_prot_id prot_id = ICE_PROT_ID_INVAL; 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 530u8 fv_words = hw->blk[params->blk].es.fvw; 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 531struct ice_flow_fld_info *flds; 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 532u16 cnt, ese_bits, i; b199dddbd39953 Qi Zhang 2021-03-09 533u16 sib_mask = 0; b199dddbd39953 Qi Zhang 2021-03-09 534u16 mask; 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 535u16 off; 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 536 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 537flds = params->prof->segs[seg].fields; 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 538 31ad4e4ee1e4e2 Tony Nguyen 2020-01-17 539switch (fld) { 390bd141808d50 Qi Zhang 2021-03-09 540case ICE_FLOW_FIELD_IDX_ETH_DA: 390bd141808d50 Qi Zhang 2021-03-09 541case ICE_FLOW_FIELD_IDX_ETH_SA: 390bd141808d50 Qi Zhang 2021-03-09 542case ICE_FLOW_FIELD_IDX_S_VLAN: 390bd141808d50 Qi Zhang 2021-03-09 543case ICE_FLOW_FIELD_IDX_C_VLAN: 390bd141808d50 Qi Zhang 2021-03-09 544prot_id = seg == 0 ? ICE_PROT_MAC_OF_OR_S : ICE_PROT_MAC_IL; 390bd141808d50 Qi Zhang 2021-03-09 545break; 390bd141808d50 Qi Zhang 2021-03-09 546case ICE_FLOW_FIELD_IDX_ETH_TYPE: 390bd141808d50 Qi Zhang 2021-03-09 547prot_id = seg == 0 ? ICE_PROT_ETYPE_OL : ICE_PROT_ETYPE_IL; 390bd141808d50 Qi Zhang 2021-03-09 548break; b199dddbd39953 Qi Zhang 2021-03-09 549case ICE_FLOW_FIELD_IDX_IPV4_DSCP: b199dddbd39953 Qi Zhang 2021-03-09 550prot_id = seg == 0 ? ICE_PROT_IPV4_OF_OR_S : ICE_PROT_IPV4_IL; b199dddbd39953 Qi Zhang 2021-03-09 551break; b199dddbd39953 Qi Zhang 2021-03-09 552case ICE_FLOW_FIELD_IDX_IPV6_DSCP: b199dddbd39953 Qi Zhang 2021-03-09 553prot_id = s
[kbuild] drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111)
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Maxime Ripard CC: Laurent Pinchart tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4f12b742eb2b3a850ac8be7dc4ed52976fc6cb0b commit: dec92020671c48da231189eb06a5f755f492f87f drm: Use the state pointer directly in planes atomic_check date: 12 months ago :: branch date: 2 days ago :: commit date: 12 months ago config: arm-randconfig-m031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202210558.azkwuczf-...@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111) vim +/state +124 drivers/gpu/drm/armada/armada_plane.c d40af7b1ae23da Russell King 2018-07-30 107 d40af7b1ae23da Russell King 2018-07-30 108 int armada_drm_plane_atomic_check(struct drm_plane *plane, 7c11b99a8e58c0 Maxime Ripard 2021-02-19 109struct drm_atomic_state *state) d40af7b1ae23da Russell King 2018-07-30 110 { 7c11b99a8e58c0 Maxime Ripard 2021-02-19 @111struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state, 7c11b99a8e58c0 Maxime Ripard 2021-02-19 112 plane); ba5c1649465d40 Maxime Ripard 2021-02-19 113struct armada_plane_state *st = to_armada_plane_state(new_plane_state); ba5c1649465d40 Maxime Ripard 2021-02-19 114struct drm_crtc *crtc = new_plane_state->crtc; d40af7b1ae23da Russell King 2018-07-30 115struct drm_crtc_state *crtc_state; 1d1547ec12bc7d Russell King 2019-01-25 116bool interlace; 1d1547ec12bc7d Russell King 2019-01-25 117int ret; 1d1547ec12bc7d Russell King 2019-01-25 118 ba5c1649465d40 Maxime Ripard 2021-02-19 119if (!new_plane_state->fb || WARN_ON(!new_plane_state->crtc)) { ba5c1649465d40 Maxime Ripard 2021-02-19 120 new_plane_state->visible = false; 1d1547ec12bc7d Russell King 2019-01-25 121return 0; 1d1547ec12bc7d Russell King 2019-01-25 122} d40af7b1ae23da Russell King 2018-07-30 123 dec92020671c48 Maxime Ripard 2021-02-19 @124if (state) dec92020671c48 Maxime Ripard 2021-02-19 125crtc_state = drm_atomic_get_existing_crtc_state(state, ba5c1649465d40 Maxime Ripard 2021-02-19 126 crtc); d40af7b1ae23da Russell King 2018-07-30 127else d40af7b1ae23da Russell King 2018-07-30 128crtc_state = crtc->state; 1d1547ec12bc7d Russell King 2019-01-25 129 ba5c1649465d40 Maxime Ripard 2021-02-19 130ret = drm_atomic_helper_check_plane_state(new_plane_state, crtc_state, ba5c1649465d40 Maxime Ripard 2021-02-19 131 0, 1d1547ec12bc7d Russell King 2019-01-25 132 INT_MAX, true, false); 1d1547ec12bc7d Russell King 2019-01-25 133if (ret) 1d1547ec12bc7d Russell King 2019-01-25 134return ret; 1d1547ec12bc7d Russell King 2019-01-25 135 1d1547ec12bc7d Russell King 2019-01-25 136interlace = crtc_state->adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE; 1d1547ec12bc7d Russell King 2019-01-25 137if (interlace) { ba5c1649465d40 Maxime Ripard 2021-02-19 138if ((new_plane_state->dst.y1 | new_plane_state->dst.y2) & 1) 1d1547ec12bc7d Russell King 2019-01-25 139return -EINVAL; ba5c1649465d40 Maxime Ripard 2021-02-19 140st->src_hw = drm_rect_height(&new_plane_state->src) >> 17; ba5c1649465d40 Maxime Ripard 2021-02-19 141st->dst_yx = new_plane_state->dst.y1 >> 1; ba5c1649465d40 Maxime Ripard 2021-02-19 142st->dst_hw = drm_rect_height(&new_plane_state->dst) >> 1; d40af7b1ae23da Russell King 2018-07-30 143} else { ba5c1649465d40 Maxime Ripard 2021-02-19 144st->src_hw = drm_rect_height(&new_plane_state->src) >> 16; ba5c1649465d40 Maxime Ripard 2021-02-19 145st->dst_yx = new_plane_state->dst.y1; ba5c1649465d40 Maxime Ripard 2021-02-19 146st->dst_hw = drm_rect_height(&new_plane_state->dst); d40af7b1ae23da Russell King 2018-07-30 147} 1d1547ec12bc7d Russell King 2019-01-25 148 1d1547ec12bc7d Russell King 2019-01-25 149st->src_hw <<= 16; ba5c1649465d40 Maxime Ripard 2021-02-19 150st->src_hw |= drm_rect_width(&new_plane_state->src) >> 16; 1d1547ec12bc7d Russell King 2019-01-25 151st->dst_yx <<= 16; ba5c1649465d40 Maxime Ripard 2021-02-19 152st->dst_yx |= new_plane_state->dst.x1 & 0x; 1d1547ec12bc7d Rus