[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #6 from Antonio Russo --- Created attachment 99927 --> https://bugs.kde.org/attachment.cgi?id=99927&action=edit Revised complete patchset tar.gz of 6 patches -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #7 from Antonio Russo --- The revised patchset has support for all default color schemes. There should be no issues using these color schemes. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #10 from Antonio Russo --- I am glad that the patch works for others. Sorry if this is turning into spam. I made a review request https://git.reviewboard.kde.org/r/128390/ but since I have a series of patches that depend on the previous one, I was not sure how to upload the sequence without squashing all the commits. What should I now do? Wait for someone to review my draft proposal? Thanks, Antonio -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #12 from Antonio Russo --- I really appreciate your getting back to me. Thank you. I cannot "publish" the patch without it having a "review"---and I don't think I am allowed to review it myself (?). The first step in the patch creation process required uploading a diff---which for subsequent patches is rejected because the parent revision is not yet known to reviewboard (or, it was not properly detected). I think. Hindenburg glanced at this bug a couple months ago. Could you possibly contact him, or should I maybe ping him directly? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #3 from Antonio Russo --- The attachment should be a tar.gz with 7 patches. On my debian machine it extracts with tar -xf . I've been using a version of konsole with these patches applied for about a month now, and haven't hit any bugs. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #5 from Antonio Russo --- The patch depends on a color style to implement the "faint" intensities for each color. I did this specifically for Linux.colorscheme (and it should is included in the patch) but did not get around to the other themes. My eye is not particularly suited for aesthetic choices, and the choice of faint colors for the themes is such a choice (in particular the solarized and light themes seemed to require some thought). Assuming this bug gets enough attention to be included, but not enough for other people with better aesthetics than me to work on the themes, I'll hack up some faint colors. I'll point out that the patch also includes in a fully functional (but completely untested) gui for setting the faint color theme---right next to setting the other colors and intense colors. Notwithstanding that, the overline and strikeout font effects should function correctly. Are you seeing those with the patch applied? If not, could you confirm that your terminal font supports overline and strikeout effects? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] New: Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 Bug ID: 362171 Summary: Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline) Product: konsole Version: master Platform: Other OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: emulation Assignee: konsole-de...@kde.org Reporter: antonio.e.ru...@gmail.com Escape codes SGR 2, SGR 8, SGR 9, and SGR 53 are not implemented in Konsole. All except SGR 53 are implemented in xterm. Reproducible: Always Steps to Reproduce: echo -e 'D\e[2mD\e[9mD\e[53mD\e[8mD' Actual Results: 5 D symbols, all identical Expected Results: 4 D symbols, the last three with "dim," "faint" or "half" intensity, the last two with "strikeout" font, and the last one overlined. The final, fifth D should not be visible. I posted an earlier, less-complete patch set to the development mailing list. I don't know if that was the correct venue---or if this one is either. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #1 from Antonio Russo --- Created attachment 98546 --> https://bugs.kde.org/attachment.cgi?id=98546&action=edit SGR Implementation -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] New: Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 Bug ID: 362171 Summary: Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline) Product: konsole Version: master Platform: Other OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: emulation Assignee: konsole-de...@kde.org Reporter: antonio.e.ru...@gmail.com Escape codes SGR 2, SGR 8, SGR 9, and SGR 53 are not implemented in Konsole. All except SGR 53 are implemented in xterm. Reproducible: Always Steps to Reproduce: echo -e 'D\e[2mD\e[9mD\e[53mD\e[8mD' Actual Results: 5 D symbols, all identical Expected Results: 4 D symbols, the last three with "dim," "faint" or "half" intensity, the last two with "strikeout" font, and the last one overlined. The final, fifth D should not be visible. I posted an earlier, less-complete patch set to the development mailing list. I don't know if that was the correct venue---or if this one is either. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #1 from Antonio Russo --- Created attachment 98546 --> https://bugs.kde.org/attachment.cgi?id=98546&action=edit SGR Implementation -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #3 from Antonio Russo --- The attachment should be a tar.gz with 7 patches. On my debian machine it extracts with tar -xf . I've been using a version of konsole with these patches applied for about a month now, and haven't hit any bugs. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #5 from Antonio Russo --- The patch depends on a color style to implement the "faint" intensities for each color. I did this specifically for Linux.colorscheme (and it should is included in the patch) but did not get around to the other themes. My eye is not particularly suited for aesthetic choices, and the choice of faint colors for the themes is such a choice (in particular the solarized and light themes seemed to require some thought). Assuming this bug gets enough attention to be included, but not enough for other people with better aesthetics than me to work on the themes, I'll hack up some faint colors. I'll point out that the patch also includes in a fully functional (but completely untested) gui for setting the faint color theme---right next to setting the other colors and intense colors. Notwithstanding that, the overline and strikeout font effects should function correctly. Are you seeing those with the patch applied? If not, could you confirm that your terminal font supports overline and strikeout effects? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #6 from Antonio Russo --- Created attachment 99927 --> https://bugs.kde.org/attachment.cgi?id=99927&action=edit Revised complete patchset tar.gz of 6 patches -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #7 from Antonio Russo --- The revised patchset has support for all default color schemes. There should be no issues using these color schemes. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #10 from Antonio Russo --- I am glad that the patch works for others. Sorry if this is turning into spam. I made a review request https://git.reviewboard.kde.org/r/128390/ but since I have a series of patches that depend on the previous one, I was not sure how to upload the sequence without squashing all the commits. What should I now do? Wait for someone to review my draft proposal? Thanks, Antonio -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #12 from Antonio Russo --- I really appreciate your getting back to me. Thank you. I cannot "publish" the patch without it having a "review"---and I don't think I am allowed to review it myself (?). The first step in the patch creation process required uploading a diff---which for subsequent patches is rejected because the parent revision is not yet known to reviewboard (or, it was not properly detected). I think. Hindenburg glanced at this bug a couple months ago. Could you possibly contact him, or should I maybe ping him directly? -- You are receiving this mail because: You are watching all bug changes.