[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 Nate Graham changed: What|Removed |Added Version Fixed In|5.19.0 |5.18.2 --- Comment #14 from Nate Graham --- Thanks! -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 Cyril Rossi changed: What|Removed |Added Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla |sma-desktop/6d3d3ffa76a5125 |sma-desktop/56fd983308d1e86 |da843fe6f58a684bdba6e6d26 |d63db9d566dabd0967df91133 --- Comment #13 from Cyril Rossi --- Git commit 56fd983308d1e86d63db9d566dabd0967df91133 by Cyril Rossi. Committed on 21/02/2020 at 14:21. Pushed by crossi into branch 'Plasma/5.18'. KCM look and feel : set proper default values for kwin kdecoration when applying global style Summary: BUG: 397595 Test Plan: KCM Look and feel, apply Breeze or Breeze Dark global style, then go to KCM KWin Decoration (Window Decoration), no decoration is highlighted in the grid. In kwinrc, the group `[org.kde.kdecoration2]` has a `theme=` with no value. With this patch, applying Breeze or Breeze Dark global theme will write the proper value in kwinrc and the KCM KWin Decoration will show the correct decoration highlighted. Reviewers: ervin, bport, meven, davidedmundson, #plasma, ngraham Reviewed By: ngraham Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D27483 (cherry picked from commit 6d3d3ffa76a5125da843fe6f58a684bdba6e6d26) M +3-3kcms/lookandfeel/kcm.cpp https://commits.kde.org/plasma-desktop/56fd983308d1e86d63db9d566dabd0967df91133 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 Nate Graham changed: What|Removed |Added Version Fixed In|5.16.0 |5.19.0 --- Comment #12 from Nate Graham --- This should also be on the Plasma/5.18 branch. :) Can you cherry-pick it? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 Cyril Rossi changed: What|Removed |Added Resolution|--- |FIXED Latest Commit|https://cgit.kde.org/kwin.g |https://commits.kde.org/pla |it/commit/?id=8350c0f2ce666 |sma-desktop/6d3d3ffa76a5125 |e60ad468a0f2fdce6086d2210f2 |da843fe6f58a684bdba6e6d26 Status|CONFIRMED |RESOLVED --- Comment #11 from Cyril Rossi --- Git commit 6d3d3ffa76a5125da843fe6f58a684bdba6e6d26 by Cyril Rossi. Committed on 21/02/2020 at 09:08. Pushed by crossi into branch 'master'. KCM look and feel : set proper default values for kwin kdecoration when applying global style Summary: BUG: 397595 Test Plan: KCM Look and feel, apply Breeze or Breeze Dark global style, then go to KCM KWin Decoration (Window Decoration), no decoration is highlighted in the grid. In kwinrc, the group `[org.kde.kdecoration2]` has a `theme=` with no value. With this patch, applying Breeze or Breeze Dark global theme will write the proper value in kwinrc and the KCM KWin Decoration will show the correct decoration highlighted. Reviewers: ervin, bport, meven, davidedmundson, #plasma, ngraham Reviewed By: ngraham Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D27483 M +3-3kcms/lookandfeel/kcm.cpp https://commits.kde.org/plasma-desktop/6d3d3ffa76a5125da843fe6f58a684bdba6e6d26 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 Nate Graham changed: What|Removed |Added Status|REOPENED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 --- Comment #10 from Cyril Rossi --- Can reproduce here. When I apply Breeze or Breeze Dark theme in the KCM Look and Feel, it writes a `theme=` with no value in kwinrc, then the KCM KWin Decoration can not highlight Breeze theme. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 Cyril Rossi changed: What|Removed |Added CC||cyril.ro...@enioka.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 --- Comment #9 from Patrick Silva --- This issue persists on Plasma 5.18 beta. I can reproduce switching between Breeze and Breeze dark global themes. Operating System: Arch Linux KDE Plasma Version: 5.17.90 KDE Frameworks Version: 5.66.0 Qt Version: 5.14.1 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 --- Comment #8 from Patrick Silva --- plasma 5.16 beta has the same bug. Operating System: Arch Linux KDE Plasma Version: 5.15.90 KDE Frameworks Version: 5.58.0 Qt Version: 5.13.0 beta3 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 Nate Graham changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #7 from Nate Graham --- Can confirm. :( Valerio, any ideas? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 --- Comment #6 from Patrick Silva --- Created attachment 118895 --> https://bugs.kde.org/attachment.cgi?id=118895=edit screenshot taken on neon dev unstable This bug persists with the new kcm on neon dev unstable. Operating System: KDE neon Developer Edition KDE Plasma Version: 5.15.80 KDE Frameworks Version: 5.57.0 Qt Version: 5.12.0 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595
Nate Graham changed:
What|Removed |Added
Latest Commit||https://cgit.kde.org/kwin.g
||it/commit/?id=8350c0f2ce666
||e60ad468a0f2fdce6086d2210f2
Version Fixed In||5.16.0
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #5 from Nate Graham ---
author Valerio Pilo 2019-02-07 16:32:05 +0100
committer Valerio Pilo 2019-02-10 13:01:04
+0100
commit 8350c0f2ce666e60ad468a0f2fdce6086d2210f2 (patch)
treec5eb4d45b0ff004111b32afeaca8cfd790ab09c9
parent 698b40dbbde327a6824c2c6495201a27b34bc4a2 (diff)
[kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a
ConfigModuleHEADmaster
Summary:
* Wrote new KCM based on KQuickAddons::ConfigModule.
* Remade QMLs for Buttons and Themes tabs.
* Updated bridge model code for new plugin lookup API (fixes warnings).
* Fixed decoration shadow changing messing with the previews sizes.
* Fixed button drag and drop issues (see D18104).
* Fixed default settings button behavior and detection of settings changes.
* Updated Get Hot New Stuff.
* Removed apply button in previewbridge.cpp: After applying changes, a theme's
KCModule is invalidated.
BUG: 389431
BUG: 350122
BUG: 346222
BUG: 342816
BUG: 397595
{F6574963} | {F6574962} | {F6574961} | {F6574960}
Test Plan:
* Verified saving and loading for every setting
* Checked shadows of Breeze and Oxygen
* Tested all possible drag operations on both sides of the fake titlebar
* Changed color schemes (with `kcmshell5 colors`) while showing the Themes tab
to see if all previews update correctly their palettes
* Tested on a fresh Neon-developer account, via kcmshell and systemsettings
Reviewers: #vdg, abetts, ngraham, #kwin, davidedmundson
Reviewed By: #vdg, #kwin, davidedmundson
Subscribers: zzag, GB_2, ngraham, broulik, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D18458
--
You are receiving this mail because:
You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 Nate Graham changed: What|Removed |Added Status|REOPENED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 Nate Graham changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #4 from Nate Graham --- That commit doesn't fully fix the issue for me. The active decoration theme is correctly selected when opening the KCM standalone in `kcmshell5`, but not from within System Settings itself. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 Valerio Pilo changed: What|Removed |Added CC||valerio.pilo+...@gmail.com Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #3 from Valerio Pilo --- Fixed by commit ef1692eea6912c7a70773901bcfd91fb70d0b8cf in kwin: [kcmkwin/kwindecoration] Set current decoration index on start Summary: Fixes the preselected decoration style on module load. Also: * Prevent the module state to be set to modified on resize. * Fix QML errors in logs. Reviewers: davidedmundson Reviewed By: davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D17775 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 397595] Window Decorations are not properly highlighting the selected theme
https://bugs.kde.org/show_bug.cgi?id=397595 Christoph Feck changed: What|Removed |Added Product|systemsettings |kwin Assignee|plasma-b...@kde.org |kwin-bugs-n...@kde.org Component|general |general -- You are receiving this mail because: You are watching all bug changes.
