[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 Ilya Bizyaev changed: What|Removed |Added CC||bizy...@zoho.com --- Comment #18 from Ilya Bizyaev --- This fixes Godot for me with Qt 6.6.2 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 fanzhuyi...@gmail.com changed: What|Removed |Added Version Fixed In||6.0.3 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 fanzhuyi...@gmail.com changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/kwin/-/commit/111657ad04 |ma/kwin/-/commit/5af86d18f4 |e7627d6e3c7b345a48670459cde |06da03d194c464ac63bbb600aeb |acc |c89 --- Comment #17 from fanzhuyi...@gmail.com --- Git commit 5af86d18f406da03d194c464ac63bbb600aebc89 by Yifan Zhu. Committed on 20/03/2024 at 21:37. Pushed by fanzhuyifan into branch 'Plasma/6.0'. x11window: round border size to integral XNative units Both frameSize and clientSize are rounded to integral XNative units. So their difference must also be rounded to integral XNative units. Otherwise we get cycles of rounding that can cause growing window sizes. (cherry picked from commit 111657ad04e7627d6e3c7b345a48670459cdeacc) M +5-0src/utils/xcbutils.cpp M +7-0src/utils/xcbutils.h M +14 -8src/x11window.cpp https://invent.kde.org/plasma/kwin/-/commit/5af86d18f406da03d194c464ac63bbb600aebc89 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 fanzhuyi...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/plas ||ma/kwin/-/commit/111657ad04 ||e7627d6e3c7b345a48670459cde ||acc --- Comment #16 from fanzhuyi...@gmail.com --- Git commit 111657ad04e7627d6e3c7b345a48670459cdeacc by Yifan Zhu. Committed on 20/03/2024 at 21:24. Pushed by fanzhuyifan into branch 'master'. x11window: round border size to integral XNative units Both frameSize and clientSize are rounded to integral XNative units. So their difference must also be rounded to integral XNative units. Otherwise we get cycles of rounding that can cause growing window sizes. M +5-0src/utils/xcbutils.cpp M +7-0src/utils/xcbutils.h M +14 -8src/x11window.cpp https://invent.kde.org/plasma/kwin/-/commit/111657ad04e7627d6e3c7b345a48670459cdeacc -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #15 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5489 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 --- Comment #14 from fanzhuyi...@gmail.com --- (In reply to fanzhuyifan from comment #13) > Currently toXNative [0] rounds halfs away from 0, and we get increasing > window sizes. If we change it to round halfs towards 0, we get decreasing > window sizes. If we change it to round halfs to even, the problem seems to > disappear. > > It seems the scale 1.25 is special because it can exactly generate integer + > 0.5 when multiplied by an integer. I have no idea what the root cause of the > problem is though. (This hypothesis is consistent with the problem also > being reported for scale=1.5 and and scale=2.5). > > [0] > https://invent.kde.org/plasma/kwin/-/blob/master/src/utils/xcbutils. > cpp?ref_type=heads#L624 The actual problem seems to be that the code is rounding both frame size and client size to have integral XNative sizes. However, their difference, the border size, does not always have integral XNative sizes [1]. Hence, we get cycles of rounding, and in this particular case, this leads to infinitely growing window sizes when we round up. [1] https://invent.kde.org/plasma/kwin/-/blob/master/src/x11window.cpp?ref_type=heads#L2834 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 --- Comment #13 from fanzhuyi...@gmail.com --- Currently toXNative [0] rounds halfs away from 0, and we get increasing window sizes. If we change it to round halfs towards 0, we get decreasing window sizes. If we change it to round halfs to even, the problem seems to disappear. It seems the scale 1.25 is special because it can exactly generate integer + 0.5 when multiplied by an integer. I have no idea what the root cause of the problem is though. (This hypothesis is consistent with the problem also being reported for scale=1.5 and and scale=2.5). [0] https://invent.kde.org/plasma/kwin/-/blob/master/src/utils/xcbutils.cpp?ref_type=heads#L624 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 --- Comment #12 from fanzhuyi...@gmail.com --- As mentioned in Bug 483605, a necessary condition is checking Legacy Applications Apply Scaling themselves. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 fanzhuyi...@gmail.com changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #11 from fanzhuyi...@gmail.com --- (In reply to fanzhuyifan from comment #10) > *** Bug 483605 has been marked as a duplicate of this bug. *** I can also reproduce with 250%, as reported in 483605. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 fanzhuyi...@gmail.com changed: What|Removed |Added CC||rronnan...@gmail.com --- Comment #10 from fanzhuyi...@gmail.com --- *** Bug 483605 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 fanzhuyi...@gmail.com changed: What|Removed |Added CC||fanzhuyi...@gmail.com --- Comment #9 from fanzhuyi...@gmail.com --- FWIW I can reproduce with 125% scale, 2560x1600 screen. Qt 6.7, arch linux, wayland, zoom 5.17.10-1. The 125% scale seems quite important, since I can't reproduce if I use 115%, 120%, 130%, or 135% scale. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 Vlad Zahorodnii changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=483605 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 --- Comment #8 from Iyán Méndez Veiga --- (In reply to David Edmundson from comment #7) > I was unable to sort out having a zoom account, could you test something for > me > > - create a window rule for zoom > - force the title or something so you know the rule is matching > - set "obey geometry restrictions" and force it to no > > See if the bug still manifests The bug still manifests. I was not sure if the rule was matching so I tested with settings fullscreen force set to yes. In that case, all Zoom windows are indeed fullscreen, including the share screen one (without the bug in this case). But with "obey geometry restrictions" set to no, I still have the same issue. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 David Edmundson changed: What|Removed |Added Priority|NOR |HI -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #7 from David Edmundson --- I was unable to sort out having a zoom account, could you test something for me - create a window rule for zoom - force the title or something so you know the rule is matching - set "obey geometry restrictions" and force it to no See if the bug still manifests -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481460] With fractional scale factors on Wayland, Zoom window enlarges continuously without user interaction
https://bugs.kde.org/show_bug.cgi?id=481460 Nate Graham changed: What|Removed |Added Keywords||wayland CC||n...@kde.org Summary|Zoom window enlarges|With fractional scale |continuously without user |factors on Wayland, Zoom |interaction |window enlarges ||continuously without user ||interaction -- You are receiving this mail because: You are watching all bug changes.
