Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones
> On March 17, 2016, 5:26 p.m., Dominik Haumann wrote: > > The only real difference to the original version is that the line > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > is removed. This somehow implies that this check is too restrictive. If > > this indeed is the case, then this might very well be a bug in libmtp. > > > > I haved tried to find something in the net, especially since other > > mtp-clients (from other DEs) are said to work, but couldn't really find > > something useful for now... > > Dominik Haumann wrote: > Found something dating back to 2011: > https://sourceforge.net/p/libmtp/mailman/libmtp-discuss/?viewmonth=201101=21=flat > Here it says: > > One more thing. the mtp-probe did not work on older ubuntu's than > 10.10. > Further investigating showed that it fails at > LIBMTP_Check_Specific_Device () only because libusb does not populate > the correct dev->devnum (i.e. usb device number. > > However if I manually run mtp-probe, later after a few seconds of > device > plugged in, it works properly. > > Looks like libusb takes a while to get the correct device number. Is > this a known libusb issue or something else? > > Might it be that we are hit by this issue? According to the link, newer > versions of libusb should probably not have this issue. > > Anyone familiar with this? > > Dominik Haumann wrote: > More on this, grepping the entire git repo of gvfs > (https://github.com/GNOME/gvfs.git) shows that gvfs does not use > LIBMTP_Check_Specific_Device() at all. > Similarly, grepping through simple-mtp-fs > (https://github.com/phatina/simple-mtpfs) also shows no usage of > LIBMTP_Check_Specific_Device(). > However, both solutions use the other LIBMTP calls similarly to how > kio-mtp does. > > What if we really just omit this check. The worst thing that can happen > is that we iterate over all device numbers and get no hit, which just takes a > bit longer. > > Question would be: Do we get too many devices, as Kai was saying? No > idea, but this really solves the issue for many users, then this might well > be worth a try. > > Opinions? > > Dominik Haumann wrote: > I asked ok libmtp-discuss > (https://sourceforge.net/p/libmtp/mailman/message/34948820/) and the answer > is as follows: > > This function probes an USB device for MTP specific properties, in > some form > of MTP property auto detection. This auto-detection does not > necessarily work for all MTP devices, > as it is was never well defined or documemted. > > It also does not check against our existing USB ID database. > > If you have a device that is in our USB ID database already, > LIBMTP_Detect_Raw_Devices will do the by-id detection (and you do > that later in the code). > > Only as fallback you should try LIBMTP_Check_Specific_Device(). > > In other words, following this reasoning, we should not use > LIBMTP_Check_Specific_Device() at all as an initial check/filter, meaning > that he patch is correct. > > I don't think I will find more info about this issue without much more > investigation. But given the infos we have, I would like to commit - thoungs? > > @Kai: You were talking about 3 devices that are listed, only one of these > working. Can you test or comment on this again? I got another reply, stating That call is in libmtp for one single reason, and it is for the udev helper program mtp-detect to probe a device to see if it is MTP if all other checks (like against the existing device database) have failed. Using it in any other code is not adviced, use the detection for raw devices as Marcus points out. In other words: This patch should be correct: - it adds a nullptr check (probably not requried, but won't hurt) - it removes the buggy call of LIBMTP_Check_Specific_Device(). - Dominik --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/#review93660 --- On March 16, 2016, 4:41 p.m., Dominik Haumann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127386/ > --- > > (Updated March 16, 2016, 4:41 p.m.) > > > Review request for KDE Frameworks, David Faure and Philipp Schmidt. > > > Bugs: 325335 > https://bugs.kde.org/show_bug.cgi?id=325335 > > > Repository: kio-extras > > > Description > --- > > Right now, Windows Phones (Nokia HW) is not properly recognized by kio-mtp. > > It seems the device is listed
Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 2 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Mar 2016 15:19:40 + Build duration: 6 min 51 sec CHANGE SET Revision db660fb9d8744eeec1a47c038d3d56390ca94bff by dhaumann: (change tab with to 4 instead of 8) change: edit src/utils/kateconfig.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 23/27 (85%)FILES 278/314 (89%)CLASSES 278/314 (89%)LINE 29942/46706 (64%)CONDITIONAL 15502/21293 (73%) By packages autotests.src FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 3941/4250 (93%)CONDITIONAL 1882/3546 (53%) autotests.src.vimode FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 3154/3169 (100%)CONDITIONAL 374/632 (59%) src.buffer FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1666/1803 (92%)CONDITIONAL 1255/1560 (80%) src.completion FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1796/3186 (56%)CONDITIONAL 1206/1618 (75%) src.completion.expandingtree FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 190/474 (40%)CONDITIONAL 77/132 (58%) src.dialogs FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/925 (0%)CONDITIONAL 0/0 (100%) src.document FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1854/3271 (57%)CONDITIONAL 1438/1982 (73%) src.export FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 111/128 (87%)CONDITIONAL 106/152 (70%) src.include.ktexteditor FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 190/229 (83%)CONDITIONAL 144/178 (81%) src.inputmode FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 180/331 (54%)CONDITIONAL 55/73 (75%) src.mode FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/440 (38%)CONDITIONAL 97/115 (84%) src.printing FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/882 (0%)CONDITIONAL 0/0 (100%) src.render FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 933/1247 (75%)CONDITIONAL 603/766 (79%) src.schema FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1537 (1%)CONDITIONAL 7/8 (88%) src.script FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 712/1072 (66%)CONDITIONAL 292/408 (72%) src.search FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 900/1389 (65%)CONDITIONAL 519/675 (77%) src.spellcheck FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 387/1332 (29%)CONDITIONAL 205/328 (63%) src.swapfile FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 120/361 (33%)CONDITIONAL 57/74 (77%) src.syntax FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1672/2165 (77%)CONDITIONAL 1034/1238 (84%) src.syntax.data FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 54/72 (75%)CONDITIONAL 73/92 (79%) src.undo FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 684/783 (87%)CONDITIONAL 321/400 (80%) src.utils FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2544/3845 (66%)CONDITIONAL 1244/1685 (74%) src.variableeditor FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/664 (0%)CONDITIONAL 0/0 (100%) src.view FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3087/6128 (50%)CONDITIONAL 1364/1835 (74%) src.vimode FILES 34/35 (97%)CLASSES 34/35 (97%)LINE 2327/3135 (74%)CONDITIONAL 1298/1651 (79%) src.vimode.config FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/138 (0%)CONDITIONAL 0/0 (100%) src.vimode.modes FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3254/3750 (87%)CONDITIONAL 1851/2145 (86%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 2 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Mar 2016 15:19:40 + Build duration: 6 min 51 sec CHANGE SET Revision db660fb9d8744eeec1a47c038d3d56390ca94bff by dhaumann: (change tab with to 4 instead of 8) change: edit src/utils/kateconfig.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 23/27 (85%)FILES 278/314 (89%)CLASSES 278/314 (89%)LINE 29942/46706 (64%)CONDITIONAL 15502/21293 (73%) By packages autotests.src FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 3941/4250 (93%)CONDITIONAL 1882/3546 (53%) autotests.src.vimode FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 3154/3169 (100%)CONDITIONAL 374/632 (59%) src.buffer FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1666/1803 (92%)CONDITIONAL 1255/1560 (80%) src.completion FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1796/3186 (56%)CONDITIONAL 1206/1618 (75%) src.completion.expandingtree FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 190/474 (40%)CONDITIONAL 77/132 (58%) src.dialogs FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/925 (0%)CONDITIONAL 0/0 (100%) src.document FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1854/3271 (57%)CONDITIONAL 1438/1982 (73%) src.export FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 111/128 (87%)CONDITIONAL 106/152 (70%) src.include.ktexteditor FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 190/229 (83%)CONDITIONAL 144/178 (81%) src.inputmode FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 180/331 (54%)CONDITIONAL 55/73 (75%) src.mode FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/440 (38%)CONDITIONAL 97/115 (84%) src.printing FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/882 (0%)CONDITIONAL 0/0 (100%) src.render FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 933/1247 (75%)CONDITIONAL 603/766 (79%) src.schema FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1537 (1%)CONDITIONAL 7/8 (88%) src.script FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 712/1072 (66%)CONDITIONAL 292/408 (72%) src.search FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 900/1389 (65%)CONDITIONAL 519/675 (77%) src.spellcheck FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 387/1332 (29%)CONDITIONAL 205/328 (63%) src.swapfile FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 120/361 (33%)CONDITIONAL 57/74 (77%) src.syntax FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1672/2165 (77%)CONDITIONAL 1034/1238 (84%) src.syntax.data FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 54/72 (75%)CONDITIONAL 73/92 (79%) src.undo FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 684/783 (87%)CONDITIONAL 321/400 (80%) src.utils FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2544/3845 (66%)CONDITIONAL 1244/1685 (74%) src.variableeditor FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/664 (0%)CONDITIONAL 0/0 (100%) src.view FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3087/6128 (50%)CONDITIONAL 1364/1835 (74%) src.vimode FILES 34/35 (97%)CLASSES 34/35 (97%)LINE 2327/3135 (74%)CONDITIONAL 1298/1651 (79%) src.vimode.config FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/138 (0%)CONDITIONAL 0/0 (100%) src.vimode.modes FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3254/3750 (87%)CONDITIONAL 1851/2145 (86%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Mar 2016 15:19:40 + Build duration: 6 min 5 sec CHANGE SET Revision db660fb9d8744eeec1a47c038d3d56390ca94bff by dhaumann: (change tab with to 4 instead of 8) change: edit src/utils/kateconfig.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 23/27 (85%)FILES 278/314 (89%)CLASSES 278/314 (89%)LINE 29967/46706 (64%)CONDITIONAL 15532/21323 (73%) By packages autotests.src FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 3941/4250 (93%)CONDITIONAL 1882/3546 (53%) autotests.src.vimode FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 3154/3169 (100%)CONDITIONAL 374/632 (59%) src.buffer FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1666/1803 (92%)CONDITIONAL 1255/1560 (80%) src.completion FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1796/3186 (56%)CONDITIONAL 1206/1618 (75%) src.completion.expandingtree FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 190/474 (40%)CONDITIONAL 77/132 (58%) src.dialogs FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/925 (0%)CONDITIONAL 0/0 (100%) src.document FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1854/3271 (57%)CONDITIONAL 1439/1982 (73%) src.export FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 111/128 (87%)CONDITIONAL 106/152 (70%) src.include.ktexteditor FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 190/229 (83%)CONDITIONAL 144/178 (81%) src.inputmode FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 186/331 (56%)CONDITIONAL 64/83 (77%) src.mode FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/440 (38%)CONDITIONAL 97/115 (84%) src.printing FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/882 (0%)CONDITIONAL 0/0 (100%) src.render FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 933/1247 (75%)CONDITIONAL 603/766 (79%) src.schema FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1537 (1%)CONDITIONAL 7/8 (88%) src.script FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 712/1072 (66%)CONDITIONAL 292/408 (72%) src.search FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 900/1389 (65%)CONDITIONAL 519/675 (77%) src.spellcheck FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 387/1332 (29%)CONDITIONAL 205/328 (63%) src.swapfile FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 120/361 (33%)CONDITIONAL 57/74 (77%) src.syntax FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1672/2165 (77%)CONDITIONAL 1034/1238 (84%) src.syntax.data FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 54/72 (75%)CONDITIONAL 73/92 (79%) src.undo FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 684/783 (87%)CONDITIONAL 321/400 (80%) src.utils FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2544/3845 (66%)CONDITIONAL 1244/1685 (74%) src.variableeditor FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/664 (0%)CONDITIONAL 0/0 (100%) src.view FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3106/6128 (51%)CONDITIONAL 1384/1855 (75%) src.vimode FILES 34/35 (97%)CLASSES 34/35 (97%)LINE 2327/3135 (74%)CONDITIONAL 1298/1651 (79%) src.vimode.config FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/138 (0%)CONDITIONAL 0/0 (100%) src.vimode.modes FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3254/3750 (87%)CONDITIONAL 1851/2145 (86%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Mar 2016 15:19:40 + Build duration: 6 min 5 sec CHANGE SET Revision db660fb9d8744eeec1a47c038d3d56390ca94bff by dhaumann: (change tab with to 4 instead of 8) change: edit src/utils/kateconfig.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 23/27 (85%)FILES 278/314 (89%)CLASSES 278/314 (89%)LINE 29967/46706 (64%)CONDITIONAL 15532/21323 (73%) By packages autotests.src FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 3941/4250 (93%)CONDITIONAL 1882/3546 (53%) autotests.src.vimode FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 3154/3169 (100%)CONDITIONAL 374/632 (59%) src.buffer FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1666/1803 (92%)CONDITIONAL 1255/1560 (80%) src.completion FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1796/3186 (56%)CONDITIONAL 1206/1618 (75%) src.completion.expandingtree FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 190/474 (40%)CONDITIONAL 77/132 (58%) src.dialogs FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/925 (0%)CONDITIONAL 0/0 (100%) src.document FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1854/3271 (57%)CONDITIONAL 1439/1982 (73%) src.export FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 111/128 (87%)CONDITIONAL 106/152 (70%) src.include.ktexteditor FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 190/229 (83%)CONDITIONAL 144/178 (81%) src.inputmode FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 186/331 (56%)CONDITIONAL 64/83 (77%) src.mode FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/440 (38%)CONDITIONAL 97/115 (84%) src.printing FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/882 (0%)CONDITIONAL 0/0 (100%) src.render FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 933/1247 (75%)CONDITIONAL 603/766 (79%) src.schema FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1537 (1%)CONDITIONAL 7/8 (88%) src.script FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 712/1072 (66%)CONDITIONAL 292/408 (72%) src.search FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 900/1389 (65%)CONDITIONAL 519/675 (77%) src.spellcheck FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 387/1332 (29%)CONDITIONAL 205/328 (63%) src.swapfile FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 120/361 (33%)CONDITIONAL 57/74 (77%) src.syntax FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1672/2165 (77%)CONDITIONAL 1034/1238 (84%) src.syntax.data FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 54/72 (75%)CONDITIONAL 73/92 (79%) src.undo FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 684/783 (87%)CONDITIONAL 321/400 (80%) src.utils FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2544/3845 (66%)CONDITIONAL 1244/1685 (74%) src.variableeditor FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/664 (0%)CONDITIONAL 0/0 (100%) src.view FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3106/6128 (51%)CONDITIONAL 1384/1855 (75%) src.vimode FILES 34/35 (97%)CLASSES 34/35 (97%)LINE 2327/3135 (74%)CONDITIONAL 1298/1651 (79%) src.vimode.config FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/138 (0%)CONDITIONAL 0/0 (100%) src.vimode.modes FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3254/3750 (87%)CONDITIONAL 1851/2145 (86%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127473: Add const variant to getter method
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127473/ --- (Updated March 23, 2016, 3:25 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 88c73542a89a1c5c4a7d4c2327047f97b3907b7f by Aleix Pol to branch master. Repository: attica Description --- Otherwise the icons cannot be fetched if the object is `const`. Diffs - src/content.h 455e903 src/content.cpp fd63444 Diff: https://git.reviewboard.kde.org/r/127473/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127473: Add const variant to getter method
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127473/#review93901 --- Ship it! Ship It! - David Edmundson On March 23, 2016, 2:16 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127473/ > --- > > (Updated March 23, 2016, 2:16 p.m.) > > > Review request for KDE Frameworks. > > > Repository: attica > > > Description > --- > > Otherwise the icons cannot be fetched if the object is `const`. > > > Diffs > - > > src/content.h 455e903 > src/content.cpp fd63444 > > Diff: https://git.reviewboard.kde.org/r/127473/diff/ > > > Testing > --- > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 127473: Add const variant to getter method
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127473/ --- Review request for KDE Frameworks. Repository: attica Description --- Otherwise the icons cannot be fetched if the object is `const`. Diffs - src/content.h 455e903 src/content.cpp fd63444 Diff: https://git.reviewboard.kde.org/r/127473/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127469: Use QQuickWidget for QML KCMs
> On March 23, 2016, 12:07 p.m., Marco Martin wrote: > > In theory using QQuickWidget is the correct way, but... > > That widget is really not reliable, it has a structural (and probably > > unfixable at least on x11) problem in which anybody calling winId() > > anywhere on any window on the application will turn all QQuickWidgets in > > black rectangles for the whole application lifecycle. > > > > since systemsettings loads a lot of random c++ code from plugins, we can't > > ensure this will not happen. > > Aleix Pol Gonzalez wrote: > Maybe QQuickWidget can be fixed? If it works here, there must be a way to > get QQuickWidget to work. It only turns black when calling winId() on the QQuickWidget, calling it on any other widgets is not an issue (in this case Qt::AA_DontCreateNativeWidgetSiblings probably helps, but it seems to work fine even without it). We can't ensure it won't happen, but it is highly unlikely as this QQuickWidget is not a window. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/#review93895 --- On March 23, 2016, 10:29 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127469/ > --- > > (Updated March 23, 2016, 10:29 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 359124 > https://bugs.kde.org/show_bug.cgi?id=359124 > > > Repository: kcmutils > > > Description > --- > > Fix position of QtQuickControls popups. > > BUG: 359124 > > > Diffs > - > > CMakeLists.txt 60cf4bb > src/CMakeLists.txt 58352f6 > src/kcmoduleqml.cpp c52769b > > Diff: https://git.reviewboard.kde.org/r/127469/diff/ > > > Testing > --- > > Popups are now in correct position in systemsettings and kcmshell > > > Thanks, > > David Rosca > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127469: Use QQuickWidget for QML KCMs
> On March 23, 2016, 1:07 p.m., Marco Martin wrote: > > In theory using QQuickWidget is the correct way, but... > > That widget is really not reliable, it has a structural (and probably > > unfixable at least on x11) problem in which anybody calling winId() > > anywhere on any window on the application will turn all QQuickWidgets in > > black rectangles for the whole application lifecycle. > > > > since systemsettings loads a lot of random c++ code from plugins, we can't > > ensure this will not happen. Maybe QQuickWidget can be fixed? If it works here, there must be a way to get QQuickWidget to work. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/#review93895 --- On March 23, 2016, 11:29 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127469/ > --- > > (Updated March 23, 2016, 11:29 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 359124 > https://bugs.kde.org/show_bug.cgi?id=359124 > > > Repository: kcmutils > > > Description > --- > > Fix position of QtQuickControls popups. > > BUG: 359124 > > > Diffs > - > > CMakeLists.txt 60cf4bb > src/CMakeLists.txt 58352f6 > src/kcmoduleqml.cpp c52769b > > Diff: https://git.reviewboard.kde.org/r/127469/diff/ > > > Testing > --- > > Popups are now in correct position in systemsettings and kcmshell > > > Thanks, > > David Rosca > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126949: Remove Air and Oxygen themes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/ --- (Updated March 23, 2016, 12:15 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Plasma. Bugs: 358533 http://bugs.kde.org/show_bug.cgi?id=358533 Repository: plasma-framework Description --- They are untested, unmaintained and most importantly, broken. Let's remove them from our releases and move them to kde-look.org for grabs. Diffs - src/desktoptheme/air/CMakeLists.txt 40ea382 src/desktoptheme/air/colors 5c4e53d src/desktoptheme/air/dialogs/background.svgz 81ef460 src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f src/desktoptheme/air/icons/amarok.svgz e3c157e src/desktoptheme/air/icons/audio.svgz 540cc77 src/desktoptheme/air/icons/battery.svgz 88f864e src/desktoptheme/air/icons/configure.svgz a433b3c src/desktoptheme/air/icons/device.svgz 23df094 src/desktoptheme/air/icons/document.svgz 6e89dd8 src/desktoptheme/air/icons/edit.svgz d0e1ca4 src/desktoptheme/air/icons/go.svgz ad3a4b2 src/desktoptheme/air/icons/kget.svgz 1f1702f src/desktoptheme/air/icons/klipper.svgz 4afd33c src/desktoptheme/air/icons/konv_message.svgz 10e31cd src/desktoptheme/air/icons/konversation.svgz 376211a src/desktoptheme/air/icons/kopete.svgz 5f41c4c src/desktoptheme/air/icons/korgac.svgz 8c8f700 src/desktoptheme/air/icons/kpackagekit.svgz 234e6da src/desktoptheme/air/icons/ktorrent.svgz dc623d8 src/desktoptheme/air/icons/list.svgz 0a25bb0 src/desktoptheme/air/icons/media.svgz 23653bd src/desktoptheme/air/icons/nepomuk.svgz 5c8545e src/desktoptheme/air/icons/network.svgz a8e8b16 src/desktoptheme/air/icons/notification.svgz db12260 src/desktoptheme/air/icons/preferences.svgz 12e6588 src/desktoptheme/air/icons/printer.svgz 199ab95 src/desktoptheme/air/icons/quassel.svgz b004749 src/desktoptheme/air/icons/slc.svgz 9fd376b src/desktoptheme/air/icons/wallet.svgz 4ad3691 src/desktoptheme/air/icons/window.svgz eecc37f src/desktoptheme/air/icons/zoom.svgz c159491 src/desktoptheme/air/metadata.desktop 0be4bd5 src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b src/desktoptheme/air/widgets/action-overlays.svgz 4259105 src/desktoptheme/air/widgets/actionbutton.svgz e1713ea src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 src/desktoptheme/air/widgets/arrows.svgz b987b32 src/desktoptheme/air/widgets/background.svgz 174a8fc src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d src/desktoptheme/air/widgets/branding.svgz c6316fb src/desktoptheme/air/widgets/busywidget.svgz f638cfb src/desktoptheme/air/widgets/button.svgz 2c529bf src/desktoptheme/air/widgets/calendar.svgz 2d80a49 src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 src/desktoptheme/air/widgets/clock.svgz 3839dac src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 src/desktoptheme/air/widgets/containment-controls.svgz a3166ce src/desktoptheme/air/widgets/dragger.svgz 3629591 src/desktoptheme/air/widgets/extender-background.svgz 4003079 src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f src/desktoptheme/air/widgets/frame.svgz 327c284 src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 src/desktoptheme/air/widgets/identiconshapes.svgz 67fe725 src/desktoptheme/air/widgets/identicontheme.svgz ad881cd src/desktoptheme/air/widgets/labeltexture.svgz f52a78d src/desktoptheme/air/widgets/line.svgz 70efca4 src/desktoptheme/air/widgets/lineedit.svgz 22347db src/desktoptheme/air/widgets/listitem.svgz ec7e89a src/desktoptheme/air/widgets/media-delegate.svgz e28b313 src/desktoptheme/air/widgets/monitor.svgz 13a22fd src/desktoptheme/air/widgets/pager.svgz 2dcbbcd src/desktoptheme/air/widgets/panel-background.svgz 080a65d src/desktoptheme/air/widgets/picker.svgz c15eb0e src/desktoptheme/air/widgets/plot-background.svgz f4c7957 src/desktoptheme/air/widgets/scrollbar.svgz c0ea8f5 src/desktoptheme/air/widgets/scrollwidget.svgz 3281ad6
Re: Review Request 127469: Use QQuickWidget for QML KCMs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/#review93895 --- In theory using QQuickWidget is the correct way, but... That widget is really not reliable, it has a structural (and probably unfixable at least on x11) problem in which anybody calling winId() anywhere on any window on the application will turn all QQuickWidgets in black rectangles for the whole application lifecycle. since systemsettings loads a lot of random c++ code from plugins, we can't ensure this will not happen. - Marco Martin On March 23, 2016, 10:29 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127469/ > --- > > (Updated March 23, 2016, 10:29 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 359124 > https://bugs.kde.org/show_bug.cgi?id=359124 > > > Repository: kcmutils > > > Description > --- > > Fix position of QtQuickControls popups. > > BUG: 359124 > > > Diffs > - > > CMakeLists.txt 60cf4bb > src/CMakeLists.txt 58352f6 > src/kcmoduleqml.cpp c52769b > > Diff: https://git.reviewboard.kde.org/r/127469/diff/ > > > Testing > --- > > Popups are now in correct position in systemsettings and kcmshell > > > Thanks, > > David Rosca > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows
> On März 21, 2016, 8:42 nachm., Dominik Haumann wrote: > > ping > > Marco Martin wrote: > +1, to me the latest version could be fine, would like a last word from > windowmanager people tough As mentioned, I ceased to care. I'm providing input while phasing out (and promise it to be on best knowledge) but won't take decisions which do no longer affect me in their consequences. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127424/#review93837 --- On März 20, 2016, 12:06 nachm., Dominik Haumann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127424/ > --- > > (Updated März 20, 2016, 12:06 nachm.) > > > Review request for KDE Frameworks, kdewin, kwin, and Marco Martin. > > > Repository: kcompletion > > > Description > --- > > In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags > were change from Qt::ToolTip to Qt::Window. > > As consequence, the completion popup of the Kate command line gets a full > window decoration, which is obviously wrong, see attached screenshot. > > Changing the type to Qt::Popup shows the proper popup, but key presses are > not forwarded, so typing is not possible, and additionally, on losing focus > the popup keeps staying open. > Therefore, this patch reverts the type back to Qt::ToolTip. > > Better fixes are of course welcome ;) Any ideas? > > > Diffs > - > > src/kcompletionbox.cpp 005aff8 > > Diff: https://git.reviewboard.kde.org/r/127424/diff/ > > > Testing > --- > > Works on Windows as expected. > > > File Attachments > > > Completion Popup > > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png > > > Thanks, > > Dominik Haumann > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
> On March 23, 2016, 10:51 a.m., Marco Martin wrote: > > Ship It! (as in, ignore my comment about the option, I'm fine with the added option now) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review93888 --- On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > --- > > Tested toggling MarkPartial on SMB, SFTP slaves. > > FISH slave was and still is ignoring it (no .part extension). > > I didn't test NFS and others. > > > Thanks, > > Martin Kostolný > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review93888 --- Ship it! Ship It! - Marco Martin On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > --- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > --- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > - > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > --- > > Tested toggling MarkPartial on SMB, SFTP slaves. > > FISH slave was and still is ignoring it (no .part extension). > > I didn't test NFS and others. > > > Thanks, > > Martin Kostolný > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127469: Use QQuickWidget for QML KCMs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/ --- (Updated March 23, 2016, 10:29 a.m.) Review request for KDE Frameworks. Changes --- Bring back the ifdef Bugs: 359124 https://bugs.kde.org/show_bug.cgi?id=359124 Repository: kcmutils Description (updated) --- Fix position of QtQuickControls popups. BUG: 359124 Diffs (updated) - CMakeLists.txt 60cf4bb src/CMakeLists.txt 58352f6 src/kcmoduleqml.cpp c52769b Diff: https://git.reviewboard.kde.org/r/127469/diff/ Testing --- Popups are now in correct position in systemsettings and kcmshell Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 127469: Use QQuickWidget for QML KCMs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/ --- Review request for KDE Frameworks. Bugs: 359124 https://bugs.kde.org/show_bug.cgi?id=359124 Repository: kcmutils Description --- Fix position of QtQuickControls popups. Also remove ifdef for Qt 5.4 BUG: 359124 Diffs - CMakeLists.txt 60cf4bb src/CMakeLists.txt 58352f6 src/kcmoduleqml.cpp c52769b Diff: https://git.reviewboard.kde.org/r/127469/diff/ Testing --- Popups are now in correct position in systemsettings and kcmshell Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
