Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 185 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/185/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Aug 2016 03:19:29 + Build duration: 8 min 11 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 51 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27798/51202 (54%)CONDITIONAL 15456/37965 (41%) By packages autotests FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7706/8024 (96%)CONDITIONAL 4307/8410 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7790/14127 (55%)CONDITIONAL 4250/9057 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2310/7572 (31%)CONDITIONAL 920/4403 (21%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 434/832 (52%)CONDITIONAL 326/719 (45%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 (47%)CONDITIONAL 1258/3434 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 602/831 (72%) src.ioslaves.trash FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 375/753 (50%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 102/138 (74%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 144/256 (56%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 146/542 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 14/22 (64%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 333/414 (80%) src.widgets FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3374/10888 (31%)CONDITIONAL 1604/6902 (23%)
Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 185 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/185/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Aug 2016 03:19:29 + Build duration: 8 min 11 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 51 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27798/51202 (54%)CONDITIONAL 15456/37965 (41%) By packages autotests FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7706/8024 (96%)CONDITIONAL 4307/8410 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7790/14127 (55%)CONDITIONAL 4250/9057 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2310/7572 (31%)CONDITIONAL 920/4403 (21%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 434/832 (52%)CONDITIONAL 326/719 (45%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 (47%)CONDITIONAL 1258/3434 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 602/831 (72%) src.ioslaves.trash FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 375/753 (50%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 102/138 (74%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 144/256 (56%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 146/542 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 14/22 (64%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 333/414 (80%) src.widgets FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3374/10888 (31%)CONDITIONAL 1604/6902 (23%)
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 100 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/100/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Aug 2016 03:18:34 + Build duration: 5 min 37 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kservicetest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5456/7983 (68%)CONDITIONAL 2947/6138 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 (94%)CONDITIONAL 884/1768 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1760/3042 (58%)CONDITIONAL 756/1888 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 (73%)CONDITIONAL 1222/2054 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 102 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/102/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Aug 2016 03:08:14 + Build duration: 7 min 55 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.ksycocathreadtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5448/7982 (68%)CONDITIONAL 2954/6138 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1426/1530 (93%)CONDITIONAL 884/1768 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3041 (58%)CONDITIONAL 758/1888 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 (73%)CONDITIONAL 1227/2054 (60%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 101 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Aug 2016 02:50:52 + Build duration: 5 min 47 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.ksycocathreadtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5464/7982 (68%)CONDITIONAL 2959/6138 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 (94%)CONDITIONAL 889/1768 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 (58%)CONDITIONAL 757/1888 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2797 (73%)CONDITIONAL 1228/2054 (60%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kitemviews master stable-kf5-qt5 » Linux,gcc - Build # 45 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kitemviews%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/45/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Aug 2016 02:36:50 + Build duration: 1 min 7 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 2/17 (12%)CLASSES 2/17 (12%)LINE 101/1930 (5%)CONDITIONAL 40/1126 (4%) By packages autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 23/23 (100%)CONDITIONAL 15/28 (54%) src FILES 1/16 (6%)CLASSES 1/16 (6%)LINE 78/1907 (4%)CONDITIONAL 25/1098 (2%)
Jenkins-kde-ci: kitemviews master stable-kf5-qt5 » Linux,gcc - Build # 45 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kitemviews%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/45/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Aug 2016 02:36:50 + Build duration: 1 min 7 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 2/17 (12%)CLASSES 2/17 (12%)LINE 101/1930 (5%)CONDITIONAL 40/1126 (4%) By packages autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 23/23 (100%)CONDITIONAL 15/28 (54%) src FILES 1/16 (6%)CLASSES 1/16 (6%)LINE 78/1907 (4%)CONDITIONAL 25/1098 (2%)
Jenkins-kde-ci: kitemviews master stable-kf5-qt5 » Linux,gcc - Build # 44 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kitemviews%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/44/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Aug 2016 02:26:32 + Build duration: 1 min 5 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.kitemviews-klistwidgetsearchlinetest COBERTURA RESULTS Cobertura Coverage Report By packages
Re: Review Request 128533: Create a test that validates projects' appstream information
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128533/ --- (Updated Aug. 24, 2016, 4:12 a.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules, KDE Frameworks, Matthias Klumpp, Scarlett Clark, and Harald Sitter. Changes --- Submitted with commit 47d580f9de23ef1ef5e71f054ea893b23702e097 by Aleix Pol to branch master. Repository: extra-cmake-modules Description --- At the moment, we're validating it in build.kde.org, but I feel it will be easier for developers to test if we do so locally. This patch does it by seeing which `*.appdata.xml` files are being installed and validating them. This way we can keep it generic for all KDE projects. Diffs - kde-modules/KDECMakeSettings.cmake dd37e7f kde-modules/appstreamtest.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128533/diff/ Testing --- Tested on some projects, locally. Thanks, Aleix Pol Gonzalez
Re: Review Request 128533: Create a test that validates projects' appstream information
> On Aug. 6, 2016, 10:41 a.m., David Faure wrote: > > The test fails in CI (and locally for me), please fix ;) > > > > https://build.kde.org/view/Frameworks%20kf5-qt5/job/kpackage%20master%20kf5-qt5/88/PLATFORM=Linux,compiler=gcc/testReport/junit/(root)/TestSuite/testfallbackpackage_appstream/ > > > > http://ci-logs.kde.flaska.net/1f/1fdab49485172a5693ecddf48d7640c481e23298/rebuilddep/rebuilddep-kf5-qt57-clang-el7/531a3ae/shell_output.log > > > > Locally: diff -bB > > /kpackage/autotests/data/testfallbackpackage/testfallbackpackage.appdata.xml > > /kpackage/autotests/testfallbackpackage.appdata.xml > > shows that the latter has many more translations, and uses en_GB while the > > former uses en-GB. > > http://www.davidfaure.fr/2016/testfallbackpackage.appdata.diff.txt > > > > To compare XML files, what I did in kdsoap is to put them both into > > QDomDocument and then use toString(), and then compare. It even allows > > showing the actual line of the first difference (while the technique used > > here only shows "files differ"). You can reuse that code, it's LGPL: > > xmlBufferCompare() at > > https://github.com/KDAB/KDSoap/blob/master/testtools/httpserver_p.cpp > > This would help with any sort of formatting issue (indentation, casing of > > "utf-8" etc), but obviously not with the different amount of translations, > > you'd need to remove the translations from the DOM tree first. For reference, this was referring to a different patch (in KPackage). This change had not been submitted yet. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128533/#review98152 --- On Aug. 4, 2016, 1:03 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128533/ > --- > > (Updated Aug. 4, 2016, 1:03 p.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, > Matthias Klumpp, Scarlett Clark, and Harald Sitter. > > > Repository: extra-cmake-modules > > > Description > --- > > At the moment, we're validating it in build.kde.org, but I feel it will be > easier for developers to test if we do so locally. > This patch does it by seeing which `*.appdata.xml` files are being installed > and validating them. This way we can keep it generic for all KDE projects. > > > Diffs > - > > kde-modules/KDECMakeSettings.cmake dd37e7f > kde-modules/appstreamtest.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128533/diff/ > > > Testing > --- > > Tested on some projects, locally. > > > Thanks, > > Aleix Pol Gonzalez > >
Re: Review Request 128740: uncompress archives in subfolders
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128740/#review98579
---
Ship it!
Tested and confirmed working. Thanks, Marco!
- Sebastian Kügler
On Aug. 23, 2016, 2:43 p.m., Marco Martin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128740/
> ---
>
> (Updated Aug. 23, 2016, 2:43 p.m.)
>
>
> Review request for KDE Frameworks, Sebastian Kügler and Jeremy Whiting.
>
>
> Repository: knewstuff
>
>
> Description
> ---
>
> if the archive downloaded by ghns has more than a file inside (either single
> file or a folder at the root), uncompress it in a folder called the same as
> the file name (without path or extension)
>
> this fixes downloading and installing plasma wallpaper packages (those that
> provide multiple resolutions).
> I don't know if this behavior would in turn break other applications, but i
> don't think so as it seems the behavior changed between kde4 and kf5.
> if needed i can make it do this only in the case of wallpapers (if
> (standardResourceDirectory == QLatin1String("wallpaper"))) but i think this
> should be the correct behavior
>
>
> Diffs
> -
>
> src/core/installation.cpp a027418
>
> Diff: https://git.reviewboard.kde.org/r/128740/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Marco Martin
>
>
Re: Review Request 128740: uncompress archives in subfolders
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128740/#review98570
---
Ship it!
Ship It!
- Jeremy Whiting
On Aug. 23, 2016, 8:43 a.m., Marco Martin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128740/
> ---
>
> (Updated Aug. 23, 2016, 8:43 a.m.)
>
>
> Review request for KDE Frameworks, Sebastian Kügler and Jeremy Whiting.
>
>
> Repository: knewstuff
>
>
> Description
> ---
>
> if the archive downloaded by ghns has more than a file inside (either single
> file or a folder at the root), uncompress it in a folder called the same as
> the file name (without path or extension)
>
> this fixes downloading and installing plasma wallpaper packages (those that
> provide multiple resolutions).
> I don't know if this behavior would in turn break other applications, but i
> don't think so as it seems the behavior changed between kde4 and kf5.
> if needed i can make it do this only in the case of wallpapers (if
> (standardResourceDirectory == QLatin1String("wallpaper"))) but i think this
> should be the correct behavior
>
>
> Diffs
> -
>
> src/core/installation.cpp a027418
>
> Diff: https://git.reviewboard.kde.org/r/128740/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Marco Martin
>
>
Re: Review Request 128739: Fix build with Qt < 5.6
> On Aug. 23, 2016, 1:27 nachm., Heiko Becker wrote: > > ?[12:11] ?? commit it if someone can test with the appropriate > > Qt versions > > ... > > ?[12:13] ?? hmm, I have the right Qt versions. I can download the > > pat- > > ... > > ?[12:31] ?? heirecka: I ended up applying to patch manually..., and > > it compiles fine now :) > > Burkhard Lück wrote: > Your patch breaks build with Qt 5.6.1 for me > > I need this patch on to of yours to get it build: > index 4607966..abc50af 100644 > --- a/src/core/guesslanguage.cpp > +++ b/src/core/guesslanguage.cpp > @@ -489,7 +489,7 @@ GuessLanguagePrivate::GuessLanguagePrivate() > case QChar::Script_WarangCiti: > names = getNames(QLocale::VarangKshitiScript); > break; > -#if QT_VERSION >= QT_VERSION_CHECK(5, 6, 0) > +#if QT_VERSION > QT_VERSION_CHECK(5, 6, 1) > case QChar::Script_Ahom: > names = getNames(QLocale::AhomScript); > break; Yeah, sorry about that. I misread git's output, when determining in which qt version it had landed. Fixed with: https://quickgit.kde.org/?p=sonnet.git=commit=3d7d09fb7bae81ab5d277c1862b85955df96f1f5 - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128739/#review98566 --- On Aug. 23, 2016, 1:28 nachm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128739/ > --- > > (Updated Aug. 23, 2016, 1:28 nachm.) > > > Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. > > > Repository: sonnet > > > Description > --- > > Also correct the other #ifdef because like QChar::Script_SignWriting > 0e1f3aab11a4310595d8651c02ce5f9d60c93252 in qtbase.git introduced the > other enums as well. That commit was first released with Qt 5.6 > > BUG: 366789 > CCMAIL: martin.sandsm...@kde.org > > > Diffs > - > > src/core/guesslanguage.cpp 5c5239fbe99c9a3ea95bd07dc4d0ec6582897379 > > Diff: https://git.reviewboard.kde.org/r/128739/diff/ > > > Testing > --- > > Haven't an old Qt around, tested building with 5.7. though. > > > Thanks, > > Heiko Becker > >
Review Request 128740: uncompress archives in subfolders
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128740/
---
Review request for KDE Frameworks, Sebastian Kügler and Jeremy Whiting.
Repository: knewstuff
Description
---
if the archive downloaded by ghns has more than a file inside (either single
file or a folder at the root), uncompress it in a folder called the same as the
file name (without path or extension)
this fixes downloading and installing plasma wallpaper packages (those that
provide multiple resolutions).
I don't know if this behavior would in turn break other applications, but i
don't think so as it seems the behavior changed between kde4 and kf5.
if needed i can make it do this only in the case of wallpapers (if
(standardResourceDirectory == QLatin1String("wallpaper"))) but i think this
should be the correct behavior
Diffs
-
src/core/installation.cpp a027418
Diff: https://git.reviewboard.kde.org/r/128740/diff/
Testing
---
Thanks,
Marco Martin
Jenkins-kde-ci: sonnet master stable-kf5-qt5 » Linux,gcc - Build # 58 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/sonnet%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 23 Aug 2016 12:27:52 + Build duration: 2 min 52 sec CHANGE SET Revision 3d7d09fb7bae81ab5d277c1862b85955df96f1f5 by Heiko Becker: (Fix my previous commit) change: edit src/core/guesslanguage.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 4/4 (100%)FILES 24/27 (89%)CLASSES 24/27 (89%)LINE 853/1668 (51%)CONDITIONAL 305/978 (31%) By packages autotests FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 335/338 (99%)CONDITIONAL 101/180 (56%) data FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 23/23 (100%)CONDITIONAL 12/14 (86%) src.core FILES 12/15 (80%)CLASSES 12/15 (80%)LINE 433/1204 (36%)CONDITIONAL 167/718 (23%) src.plugins.hunspell FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 62/103 (60%)CONDITIONAL 25/66 (38%)
Jenkins-kde-ci: sonnet master stable-kf5-qt5 » Linux,gcc - Build # 58 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/sonnet%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 23 Aug 2016 12:27:52 + Build duration: 2 min 52 sec CHANGE SET Revision 3d7d09fb7bae81ab5d277c1862b85955df96f1f5 by Heiko Becker: (Fix my previous commit) change: edit src/core/guesslanguage.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 4/4 (100%)FILES 24/27 (89%)CLASSES 24/27 (89%)LINE 853/1668 (51%)CONDITIONAL 305/978 (31%) By packages autotests FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 335/338 (99%)CONDITIONAL 101/180 (56%) data FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 23/23 (100%)CONDITIONAL 12/14 (86%) src.core FILES 12/15 (80%)CLASSES 12/15 (80%)LINE 433/1204 (36%)CONDITIONAL 167/718 (23%) src.plugins.hunspell FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 62/103 (60%)CONDITIONAL 25/66 (38%)
Re: Review Request 128739: Fix build with Qt < 5.6
> On Aug. 23, 2016, 11:27 vorm., Heiko Becker wrote: > > ?[12:11] ?? commit it if someone can test with the appropriate > > Qt versions > > ... > > ?[12:13] ?? hmm, I have the right Qt versions. I can download the > > pat- > > ... > > ?[12:31] ?? heirecka: I ended up applying to patch manually..., and > > it compiles fine now :) Your patch breaks build with Qt 5.6.1 for me I need this patch on to of yours to get it build: index 4607966..abc50af 100644 --- a/src/core/guesslanguage.cpp +++ b/src/core/guesslanguage.cpp @@ -489,7 +489,7 @@ GuessLanguagePrivate::GuessLanguagePrivate() case QChar::Script_WarangCiti: names = getNames(QLocale::VarangKshitiScript); break; -#if QT_VERSION >= QT_VERSION_CHECK(5, 6, 0) +#if QT_VERSION > QT_VERSION_CHECK(5, 6, 1) case QChar::Script_Ahom: names = getNames(QLocale::AhomScript); break; - Burkhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128739/#review98566 --- On Aug. 23, 2016, 11:28 vorm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128739/ > --- > > (Updated Aug. 23, 2016, 11:28 vorm.) > > > Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. > > > Repository: sonnet > > > Description > --- > > Also correct the other #ifdef because like QChar::Script_SignWriting > 0e1f3aab11a4310595d8651c02ce5f9d60c93252 in qtbase.git introduced the > other enums as well. That commit was first released with Qt 5.6 > > BUG: 366789 > CCMAIL: martin.sandsm...@kde.org > > > Diffs > - > > src/core/guesslanguage.cpp 5c5239fbe99c9a3ea95bd07dc4d0ec6582897379 > > Diff: https://git.reviewboard.kde.org/r/128739/diff/ > > > Testing > --- > > Haven't an old Qt around, tested building with 5.7. though. > > > Thanks, > > Heiko Becker > >
Jenkins-kde-ci: sonnet master stable-kf5-qt5 » Linux,gcc - Build # 57 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/sonnet%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 23 Aug 2016 11:29:05 + Build duration: 2 min 27 sec CHANGE SET Revision b241c854c42931280ee5366439af40144f1268af by Heiko Becker: (Fix build with Qt lt; 5.6) change: edit src/core/guesslanguage.cpp
Re: Review Request 128739: Fix build with Qt < 5.6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128739/ --- (Updated Aug. 23, 2016, 11:28 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit b241c854c42931280ee5366439af40144f1268af by Heiko Becker to branch master. Repository: sonnet Description --- Also correct the other #ifdef because like QChar::Script_SignWriting 0e1f3aab11a4310595d8651c02ce5f9d60c93252 in qtbase.git introduced the other enums as well. That commit was first released with Qt 5.6 BUG: 366789 CCMAIL: martin.sandsm...@kde.org Diffs - src/core/guesslanguage.cpp 5c5239fbe99c9a3ea95bd07dc4d0ec6582897379 Diff: https://git.reviewboard.kde.org/r/128739/diff/ Testing --- Haven't an old Qt around, tested building with 5.7. though. Thanks, Heiko Becker
Review Request 128739: Fix build with Qt < 5.6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128739/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: sonnet Description --- Also correct the other #ifdef because like QChar::Script_SignWriting 0e1f3aab11a4310595d8651c02ce5f9d60c93252 in qtbase.git introduced the other enums as well. That commit was first released with Qt 5.6 BUG: 366789 CCMAIL: martin.sandsm...@kde.org Diffs - src/core/guesslanguage.cpp 5c5239fbe99c9a3ea95bd07dc4d0ec6582897379 Diff: https://git.reviewboard.kde.org/r/128739/diff/ Testing --- Haven't an old Qt around, tested building with 5.7. though. Thanks, Heiko Becker
[Differential] [Updated, 19 lines] D2545: Cleanup KSharedUiServerProxy before qApp exists
kfunk updated this revision to Diff 6175. kfunk added a comment. Fix typo in commit msg CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2545?vs=6173=6175 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2545 AFFECTED FILES src/kuiserverjobtracker.cpp src/kuiserverjobtracker_p.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth Cc: #frameworks
[Differential] [Updated] D2546: Cleanup DBus-related resources before qApp exits
kfunk updated the test plan for this revision. kfunk added reviewers: dfaure, vonreth. kfunk added a subscriber: Frameworks. REVISION DETAIL https://phabricator.kde.org/D2546 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth Cc: #frameworks
[Differential] [Updated] D2545: Cleanup KSharedUiServerProxy before qApp exists
kfunk added reviewers: dfaure, vonreth. kfunk added a subscriber: Frameworks. REVISION DETAIL https://phabricator.kde.org/D2545 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth Cc: #frameworks
