D5788: Add syntax highlighting for YANG data modeling language
nalvarez added a comment. I knew the text of RFCs was under a somewhat-restrictive license. I didn't know code snippets were explicitly excluded and BSD'd instead. We can work with that then :) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5788 To: nalvarez, #kate, jkt, dhaumann Cc: dhaumann, jkt, #frameworks
D5788: Add syntax highlighting for YANG data modeling language
jkt added a comment. Re "extracting bits from the RFC", RFC 6020 says (among other things) that //"Code Components extracted from this document must include Simplified BSD License text as described in Section 4.e of the Trust Legal Provisions and are provided without warranty as described in the Simplified BSD License."// That sounds like a reasonable license, doesn't it? REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5788 To: nalvarez, #kate, jkt, dhaumann Cc: dhaumann, jkt, #frameworks
D5788: Add syntax highlighting for YANG data modeling language
jkt accepted this revision. jkt added a comment. Oops, sorry, I forgot to comment here. I appreciate your conversion, it works really nicely! Compared to the vim version, my QtCreator theme is not highlighting the `true` and `false` keywords in statements such as `mandatory true;`. That's because the `dsVariable` appears to be mapped to "Local" in QtC, and that thing is not being decorated in any manner in my theme. Perhaps mapping it to "something else" ,ight be a good idea? I have to admit that I have no clue about a best fit here; it's probably not a keyword. Thanks again for implementing this! REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5788 To: nalvarez, #kate, jkt, dhaumann Cc: dhaumann, jkt, #frameworks
D5788: Add syntax highlighting for YANG data modeling language
nalvarez added a comment. Sorry, I don't know enough about the language to provide a meaningful test. I made these highlighting rules on request by @jkt, partly translating the .vim file and partly reading the RFC, without even understanding what the language is for. I was hoping he could provide a test file, but he didn't reply to my highlight here or to my email... Should I commit anyway, without the test? REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5788 To: nalvarez, #kate, jkt, dhaumann Cc: dhaumann, jkt, #frameworks
D6253: Use FindInotify.cmake to decide wheter inotify is available.
tcberner updated this revision to Diff 15532. tcberner added a comment. Fix identation. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6253?vs=15531=15532 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6253 AFFECTED FILES CMakeLists.txt src/lib/CMakeLists.txt src/lib/io/kdirwatch.cpp To: tcberner, #freebsd, dfaure Cc: #frameworks
D6253: Use FindInotify.cmake to decide wheter inotify is available.
tcberner edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D6253 To: tcberner, #freebsd, dfaure Cc: #frameworks
D6253: Use FindInotify.cmake to decide wheter inotify is available.
tcberner created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY FreeBSD also as sys/inotify.h available, but it is a library. We added FindInotify.cmake to ecm a while a go for this, but never got around to upstream the rest of the patches. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D6253 AFFECTED FILES CMakeLists.txt src/lib/CMakeLists.txt src/lib/io/kdirwatch.cpp To: tcberner, #freebsd, dfaure Cc: #frameworks
D5715: Fix tier-indicator.
adridg abandoned this revision. adridg added a comment. https://phabricator.kde.org/R159:b5e20a709fbef7015874e9536cc06e5aa22aa5c0 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D5715 To: adridg, ivan Cc: apol, #frameworks
KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.7 - Build # 24 - Fixed!
BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.7/24/ Project: Frameworks knewstuff kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 17 Jun 2017 18:47:16 + Build duration: 2 min 4 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s) build.log Description: Binary data
D6049: Extend unittests to test stable sort.
This revision was automatically updated to reflect the committed changes. Closed by commit R304:28833ae05d00: Extend unittests to test stable sort. (authored by adridg). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6049?vs=15016=15530 REVISION DETAIL https://phabricator.kde.org/D6049 AFFECTED FILES autotests/kmoretools/kmoretoolstest.cpp src/kmoretools/kmoretools_p.h To: adridg, whiting, #frameworks, leinir Cc: leinir, #frameworks
D6197: Add basic KAuth support to file ioslave
aacid added inline comments. INLINE COMMENTS > elvisangelaccio wrote in file.cpp:1382 > Can't this go in file_unix.cpp, without ifdefs? Why is there an ifdef anyway? KAuth has at least a mac backend (no idea how much it works) but adding an ifdef at this level seems the wrong thing to do. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks Cc: aacid
D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights
dhaumann added a comment. I am not yet convinced this is a good idea: We changed the foreground color of highlighted text just recently: https://git.reviewboard.kde.org/r/127554/diff/2/ The idea is to have just one color for search results that need to match. This currently is the foreground color of normal text. We would need to really make sure all color schemes still work properly. As I understand, this is the case? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5802 To: intelfx, #kdevelop, #ktexteditor, #kate Cc: dhaumann, mwolff, kwrite-devel, #frameworks
D5799: Rebase Less syntax highlighting on SCSS one
dhaumann added a comment. @gszymaszek Could you also add a unit test to autotest/input/highlight.less ? This way, we can guarantee to not break the highlighting with future changes, which is very hard otherwise. The reference data is created by calling autotest/update-reference-data.sh in the build directory. It would be very helpful, if you update the patch again. Besides that, in general this patch looks ok to me, although it is very hard to review (I don't know the language, and the diff is very big). REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5799 To: gszymaszek, #framework_syntax_hightlighting Cc: dhaumann, #frameworks, cullmann, vkrause
D5788: Add syntax highlighting for YANG data modeling language
dhaumann added a comment. @nalvarez Ping? Essentially, you're good to go. It would help, if you could add a unit test for this (autotest/input/) along with the reference data (use the script autotest/update-reference-data.sh in your build folder to update this into the src folder). REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5788 To: nalvarez, #kate, jkt, dhaumann Cc: dhaumann, jkt, #frameworks
D5034: Add support for x-gvfs style options in fstab
dhaumann added a comment. @broulik Ping. Is there anything that keeps you from submitting this? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D5034 To: broulik, #plasma, dhaumann, dfaure Cc: bruns, dhaumann, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5338: Add syntax highlighting file for Doxyfile
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Any news on this? Also, do we have a unit test on this? Please decide on one version and make a review request again to get this done. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, dhaumann, kwrite-devel, vkrause Cc: turbov, emaurer, #frameworks
D6180: Makefile: Remove invalid keyword entries in makefile.xml
dhaumann added a comment. Please everyone: If you make changes to .xml files, please ALWAYS (!!!) increase the version numbers. Otherwise the files will not get picked up by Kate's download dialog and other scripts that run in the background on http://kate-editor.org. This is important. Also: When you commit changes, please ALWAYS CLOSE the review requests. This again is important for maintainability. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6180 To: orgads, #framework_syntax_hightlighting, arichardson Cc: dhaumann, #frameworks
D6180: Makefile: Remove invalid keyword entries in makefile.xml
This revision was automatically updated to reflect the committed changes. Closed by commit R216:c81a3cad: Makefile: increase version number (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6180?vs=15341=15524#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6180?vs=15341=15524 REVISION DETAIL https://phabricator.kde.org/D6180 AFFECTED FILES data/syntax/makefile.xml To: orgads, #framework_syntax_hightlighting, arichardson Cc: #frameworks
D4716: Add some more directives to MIPS assembler highlighting
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. ping? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D4716 To: arichardson, dhaumann, vkrause Cc: #frameworks
D6234: KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys
dfaure added a comment. I don't use wayland, I use X11. I bet I'm not the only one. As long as that's the case, fixing bugs in the X11 implementation makes a lot of sense. Man it's demotivating to contribute to KDE. Users say all sorts of bad things about KDE, and then future-ex-maintainers reject your contribution. Great. INLINE COMMENTS > graesslin wrote in kglobalaccel_x11.cpp:278-287 > The shift handling code has shown regressions whenever it was touched. Also > on Wayland I needed several tries to get it right. I would prefer if it were > not touched any more. > > This is not as simple as it looks. There are besties out there like > Alt+Shift+Backtab as a global shortcut and a generic implementation breaks > quickly there. It is quite likely that this change would break > Alt+(Shift)+Tab in KWin. I did not change one inch of that logic, I just moved it to KKeyServer::xcbKeyPressEventToQt. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D6234 To: dfaure, graesslin Cc: #frameworks
D6087: Haskell: Add all language pragmas as keywords.
dhaumann added a comment. @arrowdodger Isn't there a line missing: + + + <-- This line ? + Also, is the lineEndContext #pop or should it rather be #stay? Please clarify/confirm. Also: could you provide us with a small demo code so that we can extend our unit test? REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D6087 To: arrowdodger, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, #frameworks
D6233: KKeyServer: fix handling of KeypadModifier.
dfaure updated this revision to Diff 15522. dfaure added a comment. Adjustments suggested by Martin Graesslin REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6233?vs=15487=15522 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6233 AFFECTED FILES autotests/CMakeLists.txt autotests/kkeyserver_x11_unittest.cpp src/platforms/xcb/kkeyserver.cpp src/platforms/xcb/kkeyserver_x11.h To: dfaure, graesslin Cc: graesslin, #frameworks
D6233: KKeyServer: fix handling of KeypadModifier.
dfaure added inline comments. INLINE COMMENTS > graesslin wrote in kkeyserver.cpp:160-180 > This looks very unrelated to the described change. Maybe an own commit? Well those are the XK_KP_* codes, i.e. Num Keypad keys, so it's related. But yeah, it would probably work without this change, it just seems best to update the full list from Qt. Do you insist on a separate commit? > graesslin wrote in kkeyserver.cpp:765 > xcb_is_keypad_key is not part of any xcb component KWindowSystem looks for. Oh. OK, then I'll go back to >= and <=, it's just as simple anyway. > graesslin wrote in kkeyserver.cpp:783 > why are you calling a deprecated method from a new method? it was simpler, but ok, I'll refactor ;) > graesslin wrote in kkeyserver_x11.h:150 > if it's getting deprecated it must be wrapped in ifdef, shouldn't it? now that it's not called by the new method, it's possible indeed ;) Done. > graesslin wrote in kkeyserver_x11.h:159 > for new code I would find it better to use the proper types of either > uint32_t or quint32. Not very symmetrical with keyQtToSymX, but whatever makes you happy. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D6233 To: dfaure, graesslin Cc: graesslin, #frameworks
D6087: Haskell: Add all language pragmas as keywords.
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I will change the patch slightly and commit: Instead of StringDetect, we better use WordDetect. Also, we need to increase the version="" number. Besides that, the patch looks good. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D6087 To: arrowdodger, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, #frameworks
D6199: Allow deleting from write-protected location in dolphin
dfaure added inline comments.
INLINE COMMENTS
> dolphinview.cpp:667
> const QList list = simplifiedSelectedUrls();
> +KFileItemList itemList;
> +foreach(QUrl u , list) {
itemList.reserve(list.count());
> dolphinview.cpp:668
> +KFileItemList itemList;
> +foreach(QUrl u , list) {
> +KFileItem i(u);
for (const QUrl : list) {
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D6199
To: chinmoyr, elvisangelaccio, #frameworks, #dolphin
Cc: dfaure, #konqueror
Re: Review Request 130146: Add angle brackets to matching brackets highlighting
> On June 5, 2017, 12:53 p.m., Aleix Pol Gonzalez wrote: > > I can see how this could be useful, but then it can be weird when '<' is > > used as less-than. Indeed, this patch is problematic, since < and > is very often not balanced. As Aleix noted, this is the case for less than and greater than operations comparisons in programming languages, or the << and >> shift operators. The result in these cases would be more distracting than useful... The proper fix would be add a KTextEditor interface with API to do this animation, then KDevelop or Kile could use this API and trigger these animations correctly. That said, I'm not in favor of this patch, but thanks anyways! If you have other ideas how to solve this problem, please shoot :-) - Dominik --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130146/#review103284 --- On June 5, 2017, 12:42 p.m., Jakub Gargul wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130146/ > --- > > (Updated June 5, 2017, 12:42 p.m.) > > > Review request for Kate and KDE Frameworks. > > > Repository: ktexteditor > > > Description > --- > > Highlighting matching angle brackets is useful, especially when multiple of > them are nested (take c++ templates for example). The only quirk is that > inequality signs most of the time aren't used as brackets and irrelevant > portions of texts can be highlighted. > > > Diffs > - > > src/document/katedocument.cpp 395a2cab > > Diff: https://git.reviewboard.kde.org/r/130146/diff/ > > > Testing > --- > > Compiled, turned animation and bracket range highlighting on and off, checked > on file with lots of nested brackets. > > > Thanks, > > Jakub Gargul > >
D6250: Expand documentation of Persistence attribute
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Add a note that the 'session' and 'always' values are meaningless with the polkit-1 backend, and explain what they actually do. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D6250 AFFECTED FILES src/kauthactionreply.h To: elvisangelaccio, #frameworks
D6199: Allow deleting from write-protected location in dolphin
chinmoyr updated this revision to Diff 15518. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6199?vs=15390=15518 REVISION DETAIL https://phabricator.kde.org/D6199 AFFECTED FILES src/dolphinmainwindow.cpp src/views/dolphinview.cpp To: chinmoyr, elvisangelaccio, #frameworks, #dolphin Cc: #konqueror
D6198: Add KAuth support to delete operation
chinmoyr updated this revision to Diff 15517. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6198?vs=15516=15517 REVISION DETAIL https://phabricator.kde.org/D6198 AFFECTED FILES src/ioslaves/file/file.cpp src/ioslaves/file/file_unix.cpp src/ioslaves/file/kauth/file.actions src/ioslaves/file/kauth/helper.cpp src/ioslaves/file/kauth/helper.h To: chinmoyr, elvisangelaccio, #frameworks
D6198: Add KAuth support to delete operation
chinmoyr updated this revision to Diff 15516. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6198?vs=15388=15516 REVISION DETAIL https://phabricator.kde.org/D6198 AFFECTED FILES src/ioslaves/file/file.cpp src/ioslaves/file/file_unix.cpp src/ioslaves/file/kauth/file.actions src/ioslaves/file/kauth/helper.cpp src/ioslaves/file/kauth/helper.h To: chinmoyr, elvisangelaccio, #frameworks
D6197: Add basic KAuth support to file ioslave
chinmoyr updated this revision to Diff 15515. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6197?vs=15385=15515 REVISION DETAIL https://phabricator.kde.org/D6197 AFFECTED FILES autotests/kiotesthelper.h src/core/jobuidelegateextension.h src/ioslaves/file/CMakeLists.txt src/ioslaves/file/file.cpp src/ioslaves/file/file.h src/ioslaves/file/file_unix.cpp src/ioslaves/file/kauth/CMakeLists.txt src/ioslaves/file/kauth/file.actions src/ioslaves/file/kauth/helper.cpp src/ioslaves/file/kauth/helper.h src/widgets/jobuidelegate.cpp src/widgets/jobuidelegate.h To: chinmoyr, elvisangelaccio, #frameworks
D6249: FindQHelpGenerator: avoid picking up Qt4 version
palimaka updated this revision to Diff 15514. palimaka added a comment. Fix indentation. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6249?vs=15512=15514 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6249 AFFECTED FILES find-modules/FindQHelpGenerator.cmake To: palimaka, #frameworks, kossebau Cc: asturmlechner, #build_system
D6249: FindQHelpGenerator: avoid picking up Qt4 version
palimaka added a reviewer: kossebau. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6249 To: palimaka, #frameworks, kossebau Cc: asturmlechner, #build_system
D6249: FindQHelpGenerator: avoid picking up Qt4 version
palimaka created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY Passing NO_DEFAULT_PATH ignores $PATH and ensures that we use the previously-detected Qt5 binary path. TEST PLAN qhelpgenerator is now picked up from the same location as Qt5::qmake. Before, anything in $PATH was preferred even if it was the Qt 4 version. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D6249 AFFECTED FILES find-modules/FindQHelpGenerator.cmake To: palimaka, #frameworks Cc: #build_system
D6198: Add KAuth support to delete operation
elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > file.actions:3 > +Name=Remove items as a privileged user. > +Description=Remove items as a privileged user. > +Policy=auth_admin Let's improve this description, we should at least warn the the operation cannot be reverted. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6198 To: chinmoyr, elvisangelaccio, #frameworks
D6197: Add basic KAuth support to file ioslave
elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.
If I don't enter the authentication password, after ~20 seconds I get the
"Access denied to " error. Is this some timeout in the ioslave?
INLINE COMMENTS
> file.cpp:1382
> +{
> +#ifdef Q_OS_UNIX
> +QVariantMap argv;
Can't this go in file_unix.cpp, without ifdefs?
> file.cpp:1387
> +
> +KAuth::Action execAction(QStringLiteral("org.kde.kio.file.") + action);
> +execAction.setHelperId(QStringLiteral("org.kde.kio.file"));
Prefer `QLatin1String` if you want to concatenate. Or you could use
`QStringLiteral("org.kde.kio.file.%1").arg(action)`.
> file.cpp:1443
> +{
> +int status = messageBox(WarningContinueCancel, warningMessage(warnId),
> QStringLiteral("Warning!"), QStringLiteral("Continue"),
> QStringLiteral("Cancel"));
> +return status != 2;
I didn't get this messagebox after deleting something when I was already
authenticated. What did I do wrong?
> file.h:108
> +bool execWithRoot(const QString , const QString , const
> QVariant , PriviledgeWarning warning);
> +void endPriviledgeOp();
> +QString warningMessage(PriviledgeWarning warnId) const;
`endProvidiledgeOperation()` is more descriptive, no?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6197
To: chinmoyr, elvisangelaccio, #frameworks
D6246: Don't rely on QQuickWindow delivering QEvent::Ungrab as mouseUngrabEvent (as it no longer does in Qt 5.8+)
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D6246 To: hein, #plasma, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6234: KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys
graesslin added a comment. > I need to point out that this creates a functional difference to Wayland and according to the latest rules of Plasma such changes are no longer allowed unless the implementation is done first for Wayland. After reading through KWin code together with your KWindowSystem change this might be a no issue and just work. So only needs testing. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D6234 To: dfaure, graesslin Cc: #frameworks
