KDE CI: Frameworks kemoticons kf5-qt5 XenialQt5.7 - Build # 24 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/24/ Project: Frameworks kemoticons kf5-qt5 XenialQt5.7 Date of build: Tue, 17 Oct 2017 05:53:41 + Build duration: 4 min 45 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kemoticons-kemoticontestFailed: TestSuite.kemoticons-ktexttohtmlplugintest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (3/3)83% (10/12)83% (10/12)36% (226/621)26% (122/477)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (3/3)100% (3/3)95% (146/153)66% (102/154)src.core71% (5/7)71% (5/7)15% (71/459)4% (13/313)src.integrationplugin100% (2/2)100% (2/2)100% (9/9)70% (7/10)
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 130 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/130/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 17 Oct 2017 03:06:41 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 13 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.coronatestFailed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-framesvgtestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-pluginloadertestFailed: TestSuite.plasma-sortfiltermodeltestFailed: TestSuite.plasma-storagetestFailed: TestSuite.plasma-themetest
KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 126 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/126/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Tue, 17 Oct 2017 03:06:41 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report86% (6/7)62% (57/92)62% (57/92)38% (3499/9230)26% (1859/7156)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (22/22)100% (22/22)76% (605/795)38% (390/1028)src.declarativeimports.core57% (4/7)57% (4/7)28% (246/883)14% (86/620)src.plasma62% (13/21)62% (13/21)40% (1420/3581)29% (773/2697)src.plasma.private46% (11/24)46% (11/24)39% (649/1649)28% (302/1080)src.plasma.scripting0% (0/3)0% (0/3)0% (0/190)0% (0/126)src.plasmaquick50% (6/12)50% (6/12)27% (548/2019)19% (302/1583)src.plasmaquick.private33% (1/3)33% (1/3)27% (31/113)27% (6/22)
D7130: KMoreTools: Update and fix desktopfiles
ngraham added a comment. I can confirm that this fixes https://bugs.kde.org/show_bug.cgi?id=384682. Updating that accordingly. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: cfeck, mak, ngraham, ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
cfeck added a comment. This probably also fixes bug 384682. Can someone confirm? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: cfeck, mak, ngraham, ltoscano, #frameworks
D8332: Added baloo urls into places model
renatoo updated this revision to Diff 20879. renatoo added a comment. Does not load baloo urls if file index is disabled REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=20873=20879 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesview.cpp To: renatoo, #frameworks, #dolphin, #kde_applications Cc: ngraham, #frameworks
D8332: Added baloo urls into places model
ngraham added reviewers: Frameworks, Dolphin, KDE Applications. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications Cc: ngraham, #frameworks
D8333: fix some indenters from randomly invoking indent
cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the fix! Just one thing: could we in addition have an addition indentation test that uses the trigger chars? Its amazing we seem to have none for this as otherwise this problem would have been fixed during the port. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, cullmann, sars, dhaumann
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 84 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/84/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 16 Oct 2017 19:35:40 + Build duration: 8 min 15 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.commands_testFailed: TestSuite.kateindenttest_testCstyleFailed: TestSuite.scripting_test
D8333: fix some indenters from randomly invoking indent
This revision was automatically updated to reflect the committed changes. Closed by commit R39:aeebeadb5f59: fix some indenters from indenting on random characters (authored by brauch). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8333?vs=20861=20874 REVISION DETAIL https://phabricator.kde.org/D8333 AFFECTED FILES src/script/kateindentscript.cpp To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, cullmann, sars, dhaumann
D8333: fix some indenters from randomly invoking indent
brauch marked 2 inline comments as done. brauch added a comment. Yes, at least the ones I'm aware of. Thanks for the review, I'll push it in a moment. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, cullmann, sars, dhaumann
D8336: Improve apidox of KJobTrackerInterface
apol added inline comments. INLINE COMMENTS > kjobtrackerinterface.h:73 > * Unregister a job from this tracker. > + * You need to manually call this method only if you re-implemented > + * registerJob() without connecting KJob::finished to this slot. Then it should be protected? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8336 To: elvisangelaccio, kossebau, dfaure Cc: apol, #frameworks
D8332: Added baloo urls into places model
renatoo updated this revision to Diff 20873. renatoo added a comment. Removed baloo dependency REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=20859=20873 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesview.cpp To: renatoo Cc: ngraham, #frameworks
D8332: Added baloo urls into places model
renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo Cc: ngraham, #frameworks
D8333: fix some indenters from randomly invoking indent
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. That makes a lot of sense. Please commit. Does that fix the indentation problems reported about Python? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, cullmann, sars, dhaumann
D8334: Fix display name of Generator property
This revision was automatically updated to reflect the committed changes. Closed by commit R286:16751d8e232d: Fix display name of Generator property (authored by elvisangelaccio). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8334?vs=20865=20871 REVISION DETAIL https://phabricator.kde.org/D8334 AFFECTED FILES src/propertyinfo.cpp To: elvisangelaccio, mgallien Cc: #frameworks
D8336: Improve apidox of KJobTrackerInterface
elvisangelaccio created this revision. elvisangelaccio added reviewers: kossebau, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY As discussed in https://phabricator.kde.org/D3977, document when unregisterJob() is actually supposed to be manually called. For example, it is not necessary with the KIO jobtracker. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D8336 AFFECTED FILES src/lib/jobs/kjobtrackerinterface.h To: elvisangelaccio, kossebau, dfaure Cc: #frameworks
D8334: Fix display name of Generator property
mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D8334 To: elvisangelaccio, mgallien Cc: #frameworks
D8333: fix some indenters from randomly invoking indent
brauch marked an inline comment as done. brauch added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kateindentscript.cpp:47 > But if triggerCharacters are undefined this variable should be false, no? No, that's still fine, this variable just caches reading the value from the script object. If the script doesn't define it, it is read as empty, and then doesn't look again (because that won't change in the future). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, cullmann, sars, dhaumann
D8333: fix some indenters from randomly invoking indent
anthonyfieroni added inline comments. INLINE COMMENTS > kateindentscript.cpp:47 > > m_triggerCharactersSet = true; > But if triggerCharacters are undefined this variable should be false, no? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, #frameworks, kevinapavew, cullmann, sars, dhaumann
D8334: Fix display name of Generator property
elvisangelaccio created this revision. elvisangelaccio added a reviewer: mgallien. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Use a shorter sentence (since space is limited) with Title Capitalization (since we are using it for every other property). REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D8334 AFFECTED FILES src/propertyinfo.cpp To: elvisangelaccio, mgallien Cc: #frameworks
D7130: KMoreTools: Update and fix desktopfiles
ngraham added a comment. My pleasure. It's always nice to get bugs fixed. :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: mak, ngraham, ltoscano, #frameworks
D8333: fix some indenters from randomly invoking indent
brauch created this revision. brauch added reviewers: KTextEditor, cullmann, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY If triggerCharacters was not set, toString() would return "undefined", making indenters trigger on u, n, d, e, f, i and n. TEST PLAN Trigger chars are still set correctly for e.g. cmake. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 AFFECTED FILES src/script/kateindentscript.cpp To: brauch, #ktexteditor, cullmann, dhaumann Cc: #frameworks, kevinapavew, cullmann, sars, dhaumann
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment. Thanks for committing, Nate. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: mak, ngraham, ltoscano, #frameworks
D8332: Added baloo urls into places model
renatoo planned changes to this revision. renatoo added a comment. Remove baloon dependency using KConfig API to query if it is enable, and hard-code search url with a fixed string. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo Cc: #frameworks
D8330: Open files in TagLib extractor readonly
mgallien added a comment. Thanks, I tested it and it works. I am not sure about the qWarning. I would prefer another opinion on that. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8330 To: davidk, #frameworks Cc: mgallien, ngraham, #frameworks
D8330: Open files in TagLib extractor readonly
mgallien added a reviewer: Frameworks. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8330 To: davidk, #frameworks Cc: ngraham, #frameworks
Python bindings using cppyy (was: An update on Python bindings)
As promised, here is an interim update on the investigation into the use of cppyy-based bindings for KF5 (and more...) instead of SIP-based bindings. The first thing is that the underlying technology of cppyy, cling/ROOT, has been under development at CERN for quite a while. It directly reads regular C++ files (there is no intermediate format like SIP). The bindings it generates from Python to C++ seem far more complete and automatic than SIP. For example: - Template instantiation is done on the fly as needed. - Since it uses C++ directly, there is none the effort required to decollide SIP's notion of forward and duplicate declarations. - Function overloads are cleanly handled, as are most (all?) operators. The net result is that so far, there is about 3 days work and approximately [1] no "customisation" required in order to get to roughly where the SIP based bindings were after 18 months. Without the need for customisations on a mass scale, I suspect that we might get away without anything like the tooling I had to create to SIP, and just integrate with CMake (https://root.cern.ch/how/integrate-root-my-project-cmake). This all sounds pretty amazing, right? Well, there are a few caveats... - The packaging is pretty new, and is evolving pretty rapidly. We are/will be an early adopter (https://bitbucket.org/wlav/cppyy/ and https://bitbucket.org/wlav/cppyy-backend). Packaging is via PyPI and pip/pip3. - There is a lot of documentation around for the system overall, but frankly, it has been/still is a struggle to understand how the different parts relate to each other as some parts are obsolete, and other parts have yet to be built out to their intended end-state. - There are bugs [1], [2]. The upstream dev has been very responsive, and the overall quality approach looks sound. IIUC, the vast bulk of the code seems to be in daily use at CERN (and is based on LLVM). - Need to look into the exact usage of Qt-specifics: signals/slots and interoperability with SIP-based PyQt (https://root.cern.ch/root/htmldoc/guides/users-guide/PythonRuby.html#glue-ing-applications, https://root.cern.ch/doc/v606_ORIG/guide/ROOTandQt.html) - Need to figure out how any customisations which *are* required should be handled. These seem like perfectly tractable issues, and so I conclude that using cppyy is definitely the way to go. With luck and a bit of effort, I am hopeful that we can get to some REALLY easy-to-develop-and-maintain bindings. [1] There is a bug with the binding producing stuff for private definitions. [2] There is a bug with missing globals. On 7 September 2017 at 10:23, Shaheed Haquewrote: > [ Copying in kde-frameworks-devel as suggested ] > > On 5 September 2017 at 22:12, Shaheed Haque wrote: >> A lot of progress has been made in the last 18 months or so: >> >> THE TOOLING >> === >> >> We have: >> >> - A pretty powerful KDE-independent automatic binding generation capability. >> >> - Supplemented by a powerful/fine-grained manual override "rule" capability. >> >> - Comprehensive (rule-based) support for the main Qt templates (QList, >> QVector, QHash, QSet and QFlags), some selected std:: and boost:: >> templates support, multi-dimensional arrays and lots more. >> >> - CMake-based portability (the frontend is solid enough to "read" KDE, >> only the final C++ compilation remains to be moved to either CMake or >> a Python-centric packaging form [2]). >> >> The code can be seen here: >> >> https://github.com/ShaheedHaque/extra-cmake-modules/tree/shaheed_master/find-modules/module_generation >> >> The KDE framework bindings >> = >> >> For 120 out of 167 KDE 5 frameworks (I'm using the term loosely, see >> [6]), I have created all the manual override "rules" to get the >> bindings through the SIP intermediate tooling and the g++ compiler. >> >> These rules mentioned are in the PyKF5 subdirectory, and it should be >> made clear that they are in proof-of-concept form, and some hopefully >> modest work would be needed (per framework, for some frameworks) to >> get actual useful bindings. >> >> Also, note that the bindings have not actually been run [1] because >> the focus till now has been to ensure the feasibility of the approach. >> The whole point of automation is of course that any fixes needed to >> get them going would be easy to apply (think any fixes needed for >> templates, arrays, unions, exceptions, threading etc etc). >> >> THE GOOD NEWS >> == >> >> The good news is that the approach appears to have lived up to my hope >> in that the amount of rule code for PyKF5 needed appears to be >> minimal: >> >> - A *LOT* of the bindings are completely automatically generated. >> >> - Very few rules are anything more than 1-2 lines of code. >> >> - A *LOT* of the rules are merely invocations of a small set of >> pre-provided rule helpers. There is a HOWTO/FAQ that should provide >> most of the needed idiomatic knowledge
D8330: Open files in TagLib extractor readonly
davidk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is useful if the extractor runs sandboxed, and read-write file access is denied. TagLib would retry it readonly, but this saves one syscall. TEST PLAN - Autotests run fine - Tags are still indexed, tested with "baloosearch artist=..." and "baloosearch genre=..." REPOSITORY R286 KFileMetaData BRANCH readOnly REVISION DETAIL https://phabricator.kde.org/D8330 AFFECTED FILES src/extractors/taglibextractor.cpp To: davidk Cc: #frameworks
KDE CI: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.7 - Build # 30 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.7/30/ Project: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 16 Oct 2017 11:28:02 + Build duration: 5 min 16 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.fullmodelaccesstestFailed: TestSuite.quickviewsharedengine
KDE CI: Frameworks kemoticons kf5-qt5 XenialQt5.7 - Build # 23 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/23/ Project: Frameworks kemoticons kf5-qt5 XenialQt5.7 Date of build: Mon, 16 Oct 2017 11:30:22 + Build duration: 2 min 23 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kemoticons-kemoticontestFailed: TestSuite.kemoticons-ktexttohtmlplugintest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (3/3)83% (10/12)83% (10/12)36% (226/620)26% (122/477)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (3/3)100% (3/3)95% (146/153)66% (102/154)src.core71% (5/7)71% (5/7)16% (71/458)4% (13/313)src.integrationplugin100% (2/2)100% (2/2)100% (9/9)70% (7/10)
KDE CI: Frameworks kcodecs kf5-qt5 AndroidQt5.9 - Build # 2 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20AndroidQt5.9/2/ Project: Frameworks kcodecs kf5-qt5 AndroidQt5.9 Date of build: Mon, 16 Oct 2017 11:27:17 + Build duration: 1 min 9 sec and counting CONSOLE OUTPUT [...truncated 13.87 KB...] > git config core.sparsecheckout # timeout=10 > git checkout -f 7fa33fe6e2b758272095106a8b9d77522b66cdd8Commit message: "Update path for Krita"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks kcodecs kf5-qt5 AndroidQt5.9/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision a968655c86985dfbfacc44542045a98fec45574e (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f a968655c86985dfbfacc44542045a98fec45574eCommit message: "Update the location here as well"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks kcodecs kf5-qt5 AndroidQt5.9/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision a693b69c3823088b27120dd3815f90ab5bead666 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f a693b69c3823088b27120dd3815f90ab5bead666Commit message: "Add missing deps for qqc2-desktop-style"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks kcodecs kf5-qt5 AndroidQt5.9] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kcodecs --branchGroup kf5-qt5 --environment production --platform AndroidQt5.9 --installTo /home/user/install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[Frameworks kcodecs kf5-qt5 AndroidQt5.9] Running shell script+ python3 -u ci-tooling/helpers/configure-build.py --product Frameworks --project kcodecs --branchGroup kf5-qt5 --platform AndroidQt5.9 --installTo /home/user/install-prefix/cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DBUILD_COVERAGE=ON -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix/;/opt/Qt/5.9.1/android_armv7;/opt/kdeandroid-deps" "/home/user/workspace/Frameworks kcodecs kf5-qt5 AndroidQt5.9"-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET=-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET=-- The C compiler identification is GNU 4.9.0-- The CXX compiler identification is GNU 4.9.0-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 129 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/129/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 16 Oct 2017 09:39:12 + Build duration: 18 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest
KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 125 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/125/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Mon, 16 Oct 2017 09:39:12 + Build duration: 8 min 0 sec and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report86% (6/7)62% (57/92)62% (57/92)38% (3501/9230)26% (1860/7156)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (22/22)100% (22/22)76% (607/795)38% (390/1028)src.declarativeimports.core57% (4/7)57% (4/7)28% (246/883)14% (86/620)src.plasma62% (13/21)62% (13/21)40% (1420/3581)29% (773/2697)src.plasma.private46% (11/24)46% (11/24)39% (649/1649)28% (303/1080)src.plasma.scripting0% (0/3)0% (0/3)0% (0/190)0% (0/126)src.plasmaquick50% (6/12)50% (6/12)27% (548/2019)19% (302/1583)src.plasmaquick.private33% (1/3)33% (1/3)27% (31/113)27% (6/22)
D8135: [FrameSvg] Optimize updateSizes
This revision was automatically updated to reflect the committed changes. Closed by commit R242:dea8a1ed5f2f: [FrameSvg] Optimize updateSizes (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8135?vs=20332=20851 REVISION DETAIL https://phabricator.kde.org/D8135 AFFECTED FILES src/plasma/framesvg.cpp To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Re: Adding build info attribute to KAboutData to improve bug report data?
On Monday, 16 October 2017 07:10:29 CEST Luca Beltrame wrote: > Il giorno Sun, 08 Oct 2017 19:45:00 +0200 > > Kevin Funkha scritto: > > Heya, > > > > The KDevelop team is currently discussing a patch which adds > > > > git-describe like information to the version string in KAboutData: > > https://phabricator.kde.org/D8158 > > (don't bother reading through the comments...) > > Is it added at compile time? I didn't read through the diff yet, but > how would you define a "development" build? > This is to make sure that no such things are put in released versions, > which would cause problems with reproducible builds. See: https://phabricator.kde.org/D8158 We'd like to add version information such as: "5.1.80-24-g6e3cfe2421" If Git's HEAD is checked out at a tag (i.e. v5.1.2), then I wouldn't set that attribute at all. Though even "5.1.80-24-g6e3cfe2421" should be fine when striving for reproducible builds. The Git SHA1 doesn't change after all, if you haven't modified the Git history. I wouldn't put the 'build time' or similar things there, to begin with (which would cause problems with reproducible builds, obviously). tl;dr: It's up to the individual project how to set that build information attribute. Probably makes sense to add little hints about reproducible builds to that attribute's API documentation. Regards, Kevin -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.
D7164: KSqueezedTextLabel: Respect indent, margin and frame width
rkflx added a comment. In https://phabricator.kde.org/D7164#156062, @dfaure wrote: > Looks like the CI issue is gone? Thanks for caring, David. Maybe I could have made this more clear, but work regarding the CI failure is tracked in https://phabricator.kde.org/T6982, were I solved the problem and marked it as done. (It has some minor additional action items though, so it does not show up as closed yet.) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7164 To: rkflx, #frameworks, cfeck, dhaumann Cc: dfaure, cfeck, dhaumann
D7164: KSqueezedTextLabel: Respect indent, margin and frame width
dfaure added a comment. Looks like the CI issue is gone? https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/ looks green to me (well, blue, the jenkins people got daltonism issues lately). REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7164 To: rkflx, #frameworks, cfeck, dhaumann Cc: dfaure, cfeck, dhaumann
ECM test failure on FreeBSD
On samedi 9 septembre 2017 14:15:53 CEST no-re...@kde.org wrote: > URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20 > FreeBSDQt5.7/54/ Project: Frameworks extra-cmake-modules kf5-qt5 > FreeBSDQt5.7 > Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), > Total: 50 test(s) Failed: TestSuite.KDEInstallDirsTest.relative_or_absolute Any idea why ctest -R KDEInstallDirsTest.relative_or_absolute passes on Linux and fails on FreeBSD with this error? "Installing in the same prefix as Qt, adopting their path scheme. CMake Error at /usr/home/jenkins/workspace/Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7/tests/test_helpers.cmake:52 (message): KDE_INSTALL_PLUGINDIR (/usr/local/lib/qt5/plugins) should be a relative path, but is absolute. Call Stack (most recent call first): CMakeLists.txt:21 (assert_var_relative_path) " On Linux the attached patch shows (on my system) KDE_INSTALL_QTPLUGINDIR=lib64/plugins when doing $ cd /tests/KDEInstallDirsTest/relative_or_absolute $ cmake . Can anyone debug this on FreeBSD ? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 diff --git i/tests/KDEInstallDirsTest/relative_or_absolute/CMakeLists.txt w/tests/KDEInstallDirsTest/relative_or_absolute/CMakeLists.txt index 1a7a7e7..5348f23 100644 --- i/tests/KDEInstallDirsTest/relative_or_absolute/CMakeLists.txt +++ w/tests/KDEInstallDirsTest/relative_or_absolute/CMakeLists.txt @@ -15,6 +15,7 @@ if(APPLE) endif() foreach(suffix ${var_suffixes}) +message("KDE_INSTALL_${suffix}=" ${KDE_INSTALL_${suffix}}) if(${suffix}_should_be_absolute) assert_var_absolute_path(KDE_INSTALL_${suffix}) else()
D6665: Make kssl compile against OpenSSL 1.1.0
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Now is the right time ;) REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D6665 To: dvratil, #frameworks, dfaure Cc: aacid, arojas, fvogt, ltoscano, rdieter, #frameworks
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 83 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/83/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 16 Oct 2017 06:33:36 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.commands_testFailed: TestSuite.kateindenttest_testCstyleFailed: TestSuite.scripting_test
D8314: Fix deprecation warning
This revision was automatically updated to reflect the committed changes. Closed by commit R39:68d42865076e: Fix deprecation warning (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8314?vs=20813=20841 REVISION DETAIL https://phabricator.kde.org/D8314 AFFECTED FILES src/dialogs/katedialogs.cpp To: kfunk, apol Cc: #frameworks, kevinapavew, cullmann, sars, dhaumann
D8315: CMake cleanup: Don't hardcode -std=c++0x
This revision was automatically updated to reflect the committed changes. Closed by commit R279:265b9f9f3120: CMake cleanup: Dont hardcode -std=c++0x (authored by kfunk). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8315?vs=20814=20840 REVISION DETAIL https://phabricator.kde.org/D8315 AFFECTED FILES CMakeLists.txt benchmarks/CMakeLists.txt examples/CMakeLists.txt To: kfunk, apol Cc: #frameworks