D13442: Implemented displaying of total lines in kate

[Sven Brauch]

brauch added a comment.


  I was also thinking about the context menu, yes. That is also where a lot of 
users would first look for it I think, even before the config dialog.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  The "of " is mere couple of alphabets, does this takes space on the bar and 
annoys, I dont think so, in my view 
  it should be by default,what u say cullmann?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  But then the question is: some want it, some not, and it is always visible, 
what to do?
  Perhaps the choice to have a config dialog entry is already bad and we should 
just have a context menu for the statusbar that allows to configure the 
appearance like other editors do?
  Then we wouldn't clutter the config dialog at all.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Sven Brauch]

brauch added a comment.


  I don't like this being user-controllable. We spend so much effort in keeping 
our option set clearly arranged and limited to useful choices, to me this seems 
like a very bad opportunity to break that rule.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 293 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/293/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 13 Jun 2018 03:36:53 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31905/60032)38%
(18946/49400)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8833/9263)50%
(5584/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8386/14487)50%
(4892/9788)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3918/7918)33%
(1656/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(526/1015)42%
(421/1012)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1381/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)52%
(723/13

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 142 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/142/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 13 Jun 2018 03:36:53 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31937/60033)38%
(18948/49396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8833/9263)50%
(5581/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8441/14488)50%
(4910/9792)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(526/1015)42%
(421/1012)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1381/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)51%
(702/1378

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/49/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 13 Jun 2018 03:36:53 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 65 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/65/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 13 Jun 2018 03:37:23 +
 Build duration:
4 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)21%
(458/2194)21%
(270/1301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)93%
(144/155)59%
(111/188)src100%
(8/8)100%
(8/8)69%
(226/326)48%
(123/256)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/32)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 41 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/41/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 13 Jun 2018 03:37:23 +
 Build duration:
4 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)22%
(481/2194)23%
(294/1301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)93%
(144/155)59%
(111/188)src100%
(8/8)100%
(8/8)76%
(249/326)57%
(147/256)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/32)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
   

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  How can the self toggling be done based on the space available?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Nathaniel Graham]

ngraham added a comment.


  Now the option is disabled by default, so nobody will ever find it, kind of 
defeating the point. If we absolutely have to make this a user-controllable 
option, I recommend having it on by default, because most of the time you're 
not space constrained. However I still think a far more user-friendly approach 
is to have no user-visible option and for it to simply turn itself off 
automatically when there's limited space in the status bar.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/55/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 12 Jun 2018 20:27:11 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)89%
(223/251)89%
(223/251)81%
(23113/28698)49%
(11248/22732)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client95%
(39/41)95%
(39/41)92%
(10629/11505)47%
(7332/15599)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client96%
(68/71)96%
(68/71)80%
(5372/6719)59%
(1627/2752)src.server97%
(111/115)97%
(111/115)85%
(6753/7944)64%
(2069/3256)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1262)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/27/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 12 Jun 2018 20:27:11 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24102/28745)52%
(11792/22732)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11225/11508)49%
(7708/15599)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5688/6743)65%
(1783/2752)src.server97%
(111/115)97%
(111/115)86%
(6830/7964)64%
(2081/3256)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1262)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/17/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 12 Jun 2018 20:27:11 +
 Build duration:
8 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 15 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testIdleFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testXdgShellV5

D13501: Fix 'unused parameter' warnings

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:1028770d48e5: Fix 'unused parameter' warnings 
(authored by zzag).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13501?vs=36069&id=36075

REVISION DETAIL
  https://phabricator.kde.org/D13501

AFFECTED FILES
  src/server/xdgforeign_v2_interface.cpp
  src/server/xdgoutput_interface.cpp

To: zzag, #kwin, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

[Dominik Haumann]

dhaumann added a subscriber: cullmann.
dhaumann added a comment.


  To be honest, I cannot claim I can follow all changes, since this is a big 
update. But in general the usage of the rules look good.
  
  The autotest output (html highlighting) looks good to me, it contains nice 
improvements for C++14 and C++17.
  
  @cullmann Since this is a big one, can you test this as well? Would be nice 
to have some days of testing for this.

INLINE COMMENTS

> gcc.xml:576-577
> + lineEndContext="#stay">
> +   String="gnu::" />
> +   String="clang::" />
> +

These can be WordDetect as well, right?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13394

To: jpoelen, dhaumann
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D13502: Fix compiler warning about hidden virtual overloads

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  TextInput has 4 virtual operators for casting. Each of the two
  subclasses override a different 2. It all works perfectly but results in
  this compiler warning.
  
  In file included from
  client/textinput_v2.cpp:20:
  client/textinput_p.h:95:13: warning: ‘virtual
  KWayland::Client::TextInputManager::Private::operator
  wl_text_input_manager*() const’ was hidden [-Woverloaded-virtual]
  
virtual operator wl_text_input_manager*() const {
^~~~
  
  This is the compiler telling us that we're overriding some overloads, but
  not all overloads which it thinks is wrong, even though it makes perfect
  sense in this particular case.
  
  Adding a "using" keyword silences the warning.

TEST PLAN
  Compiles with no warnings \o/

REPOSITORY
  R127 KWayland

BRANCH
  xdg_squash

REVISION DETAIL
  https://phabricator.kde.org/D13502

AFFECTED FILES
  src/client/textinput_v0.cpp
  src/client/textinput_v2.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:601f93780573: Rust: Add keywords & bytes, fix 
identifiers, and other improvements/fixes (authored by nibags, committed by 
dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13498?vs=36063&id=36072

REVISION DETAIL
  https://phabricator.kde.org/D13498

AFFECTED FILES
  autotests/folding/test.rs.fold
  autotests/html/test.rs.html
  autotests/input/test.rs
  autotests/reference/test.rs.ref
  data/syntax/rust.xml

To: nibags, dhaumann, cullmann
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Nice update, will integrate. And thanks for the unit test!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-rust (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13498

To: nibags, dhaumann, cullmann
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Milian Wolff]

mwolff added a comment.


  @shubham looks like you are a victim of 
https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/
 right? :D

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: mwolff, cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, sars, dhaumann

D13501: Fix 'unused parameter' warnings

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  fix-warnings

REVISION DETAIL
  https://phabricator.kde.org/D13501

To: zzag, #kwin, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13501: Fix 'unused parameter' warnings

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: KWin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The warnings:
  

/home/vlad/KDE/src/frameworks/kwayland/src/server/xdgforeign_v2_interface.cpp: 
In static member function ‘static void

KWayland::Server::XdgExporterUnstableV2Interface::Private::destroyCallback(wl_client*,
 wl_resource*)’:

/home/vlad/KDE/src/frameworks/kwayland/src/server/xdgforeign_v2_interface.cpp:95:95:
 warning: unused parameter ‘resource’
[-Wunused-parameter]
 void XdgExporterUnstableV2Interface::Private::destroyCallback(wl_client 
*client, wl_resource *resource)

  ~^~~~

/home/vlad/KDE/src/frameworks/kwayland/src/server/xdgforeign_v2_interface.cpp: 
In static member function ‘static void

KWayland::Server::XdgImporterUnstableV2Interface::Private::destroyCallback(wl_client*,
 wl_resource*)’:

/home/vlad/KDE/src/frameworks/kwayland/src/server/xdgforeign_v2_interface.cpp:237:95:
 warning: unused parameter ‘resource’
[-Wunused-parameter]
 void XdgImporterUnstableV2Interface::Private::destroyCallback(wl_client 
*client, wl_resource *resource)

  ~^~~~

/home/vlad/KDE/src/frameworks/kwayland/src/server/xdgforeign_v2_interface.cpp: 
In static member function ‘static void

KWayland::Server::XdgImportedUnstableV2Interface::Private::setParentOfCallback(wl_client*,
 wl_resource*, wl_resource*)’:

/home/vlad/KDE/src/frameworks/kwayland/src/server/xdgforeign_v2_interface.cpp:439:78:
 warning: unused parameter ‘client’
[-Wunused-parameter]
 void 
XdgImportedUnstableV2Interface::Private::setParentOfCallback(wl_client *client, 
wl_resource *resource, wl_resource *
surface)
   
~~~^~

/home/vlad/KDE/src/frameworks/kwayland/src/server/xdgoutput_interface.cpp: 
In constructor

‘KWayland::Server::XdgOutputManagerInterface::XdgOutputManagerInterface(KWayland::Server::Display*,
 QObject*)’:

/home/vlad/KDE/src/frameworks/kwayland/src/server/xdgoutput_interface.cpp:88:81:
 warning: unused parameter ‘parent’
[-Wunused-parameter]
 XdgOutputManagerInterface::XdgOutputManagerInterface(Display *display, 
QObject *parent)

~^~

TEST PLAN
  No more 'unused parameter' warnings.

REPOSITORY
  R127 KWayland

BRANCH
  fix-warnings

REVISION DETAIL
  https://phabricator.kde.org/D13501

AFFECTED FILES
  src/server/xdgforeign_v2_interface.cpp
  src/server/xdgoutput_interface.cpp

To: zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13500: Honor BUILD_TESTING

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: KWin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Don't build tests if BUILD_TESTING is OFF.

TEST PLAN
  - Passed BUILD_TESTING=OFF to cmake, no tests have been built;
  - Didn't pass BUILD_TESTING to cmake, all tests have been built.

REPOSITORY
  R127 KWayland

BRANCH
  honor-build-testing

REVISION DETAIL
  https://phabricator.kde.org/D13500

AFFECTED FILES
  CMakeLists.txt

To: zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13498

To: nibags, dhaumann, cullmann
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13498

To: nibags, dhaumann, cullmann
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: dhaumann, cullmann.
nibags added a project: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13498

To: nibags, dhaumann, cullmann
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes

[Nibaldo González]

nibags created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nibags requested review of this revision.

REVISION SUMMARY
  **Changes:**
  
  - Add missing keywords.
  - Remove obsolete types `int` & `uint` (these were depreciated by 
isize/usize): 
https://github.com/nox/rust-rfcs/blob/master/text/0544-rename-int-uint.md
  - Remove type `float`, because it isn't a valid data type: 
https://doc.rust-lang.org/std/index.html#primitives
  - Fix identifiers (entity `rustIdent`, marked with FIXME). The Rust 
identifier highlighting also detects Non-ASCII characters (in the Rust parser, 
an identifier is: `[a-zA-Z\x80-\xff_][a-zA-Z0-9\x80-\xff_]*`).
  
  **NOTE:** The POSIX character class `[[::ascii::]]` is used. I don't know 
from which version of KTextEditor (or Qt) the use of POSIX character class is 
available, or if the use of this is a correct way. It works well, but if it 
isn't the correct way to do it, I can change it without any problem.
  
  - Improved and fixes in the highlighting of numbers:
- Add missing integer suffixes (`i128`, `u128`, `isize`, `usize`).
- Add word border (`\b`) in numbers (Hex, Octal, Binary, Float, Decimal).
- Improves float detection; floats with suffix 'f' are not allowed (only 
'f32' & 'f64').
- Highlight as 'Error' invalid numbers (Hexadecimal, Octal, Binary).
  - Fix Raw Hashed Strings (`r##"text"##`). Before, only a maximum of 2 hashes 
are detected (this is mentioned in a comment). Now any number of #'s are 
allowed.
  - Add byte characters & byte strings (`b'X'`, `b"XX"`, `br"XX"`, `br#"XX"#`).
  - Improves character detection and escape characters:
- Highlight as 'Error' invalid characters.
- Fixes unicode escapes: only the `\u{NN}` type is allowed (Not 
`\u` or `\U`).
  
  **NOTES:**
  
  - Binaries don't allow unicode escapes, so a difference is made between 
common and unicode escapes. The RegExpr rules used to detect escape characters 
are placed in the entities `&commonEscape`; and `&unicodeEscape;`.
  - Escapes supported in: 
https://doc.rust-lang.org/std/primitive.char.html#method.escape_default
  
  - The style of the itemData 'Scope' is changed from 'dsNormal' to 
'dsProcessador', since the detection of identifiers was corrected.
  
  I also added a test file. Any inconvenience or if I need to correct 
something, do not hesitate to notify!
  
  Sources:
  
  - Rust documentation: https://doc.rust-lang.org/
  - Rust Playground: https://play.rust-lang.org/
  - Rust in Vim: 
https://github.com/rust-lang/rust.vim/blob/master/syntax/rust.vim
  - Rust in VSCode: 
https://github.com/Microsoft/vscode/blob/master/extensions/rust/syntaxes/rust.tmLanguage.json
  - Rust in gedit: 
https://github.com/GNOME/gtksourceview/blob/master/data/language-specs/rust.lang
  - Rust in ACE: 
https://github.com/ajaxorg/ace/blob/master/lib/ace/mode/rust_highlight_rules.js
  - https://github.com/rust-lang/kate-config

TEST PLAN
  I checked the modifications with the documentation and the compiler of Rust 
to avoid regressions.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-rust (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13498

AFFECTED FILES
  autotests/folding/test.rs.fold
  autotests/html/test.rs.html
  autotests/input/test.rs
  autotests/reference/test.rs.ref
  data/syntax/rust.xml

To: nibags
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13496: FrameSvg: Update mask frame if image path has been changed

[Vlad Zagorodniy]

zzag updated this revision to Diff 36057.
zzag added a comment.


  Compare against frame->imagePath.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13496?vs=36053&id=36057

BRANCH
  dont-wreck-shared-mask-frames

REVISION DETAIL
  https://phabricator.kde.org/D13496

AFFECTED FILES
  src/plasma/framesvg.cpp

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag updated this revision to Diff 36056.
zzag added a comment.


  Use `frame`'s imagePath.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13384?vs=35806&id=36056

REVISION DETAIL
  https://phabricator.kde.org/D13384

AFFECTED FILES
  src/plasma/framesvg.cpp
  src/plasma/private/framesvg_p.h

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[Fabian Vogt]

fvogt added a comment.


  In D9070#277428 , @bkchr wrote:
  
  > Hi,
  >  this patch is still no applied, would someone do it? :)
  >  Because it already missed 5.13.
  
  
  I pushed it now.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: bkchr, ahmadsamir, rdieter, abetts, anthonyfieroni, ngraham, cfeck, fvogt, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:2e971be576d2: KDE platform plugin: don't force 
default stylename on user-specified fonts (authored by rjvbb, committed by 
fvogt).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9070?vs=23175&id=36055

REVISION DETAIL
  https://phabricator.kde.org/D9070

AFFECTED FILES
  src/platformtheme/kfontsettingsdata.cpp

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: bkchr, ahmadsamir, rdieter, abetts, anthonyfieroni, ngraham, cfeck, fvogt, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[Bastian Köcher]

bkchr added a comment.


  Hi,
  this patch is still no applied, would someone do it? :)
  Because it already missed 5.13.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: bkchr, ahmadsamir, rdieter, abetts, anthonyfieroni, ngraham, cfeck, fvogt, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D13496: FrameSvg: Update mask frame if image path has been changed

[Vlad Zagorodniy]

zzag created this revision.
zzag added reviewers: Plasma, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  A FrameSvg can have wrong mask frame if image path has been changed after
  the mask frame was generated. Take image path into account when deciding
  whether the mask frame should be updated to address that problem.
  
  Depends on D13384 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dont-wreck-shared-mask-frames

REVISION DETAIL
  https://phabricator.kde.org/D13496

AFFECTED FILES
  src/plasma/framesvg.cpp

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag added a dependent revision: D13496: FrameSvg: Update mask frame if image 
path has been changed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13384

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

[Marco Martin]

mart updated this revision to Diff 36052.
mart added a comment.


  - remove neighbours, only order
  - store data in a single structure
  - auto activate a new desktop

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12820?vs=34871&id=36052

BRANCH
  mart/plasmavirtualdesktop

REVISION DETAIL
  https://phabricator.kde.org/D12820

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_plasma_virtual_desktop.cpp
  src/client/CMakeLists.txt
  src/client/plasmavirtualdesktop.cpp
  src/client/plasmavirtualdesktop.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-virtual-desktop.xml
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/client/registry.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/plasmavirtualdesktop_interface.cpp
  src/server/plasmavirtualdesktop_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  src/tools/mapping.txt

To: mart, #kwin, #plasma, graesslin, hein
Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, 
ngraham, bruns

D13495: Fix XDGV6 popup test

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  We had a data funciton...then didn't use it, effectively skpping half of
  the point of the test.

TEST PLAN
  Ran the test

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13495

AFFECTED FILES
  autotests/client/test_xdg_shell_v6.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13494: Fix stupid copy paste bug in XDGShellV6 Client

[David Edmundson]

davidedmundson updated this revision to Diff 36050.
davidedmundson added a comment.


  fix

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13494?vs=36049&id=36050

BRANCH
  xdg_squash

REVISION DETAIL
  https://phabricator.kde.org/D13494

AFFECTED FILES
  src/client/xdgshell_v6.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13494: Fix stupid copy paste bug in XDGShellV6 Client

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Wasn't spotted because of the bug in the test which is pretty much the
  sole use of this class.

TEST PLAN
  Fixed test now passes

REPOSITORY
  R127 KWayland

BRANCH
  xdg_squash

REVISION DETAIL
  https://phabricator.kde.org/D13494

AFFECTED FILES
  src/client/xdgshell_stable.cpp
  src/client/xdgshell_v6.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10937: Retouching of Screen Layout Selection OSD Icons

[Nathaniel Graham]

ngraham added a comment.


  @pstefan, any update? It would be a shame to let this amazing work languish!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, 
michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/26/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 12 Jun 2018 11:43:19 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24104/28746)52%
(11791/22732)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11227/11509)49%
(7708/15599)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5688/6743)65%
(1782/2752)src.server97%
(111/115)97%
(111/115)86%
(6830/7964)64%
(2081/3256)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1262)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/54/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 12 Jun 2018 11:43:19 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 41 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24042/28746)52%
(11741/22732)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)97%
(11169/11509)49%
(7666/15599)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5688/6743)65%
(1784/2752)src.server97%
(111/115)97%
(111/115)86%
(6826/7964)64%
(2071/3256)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1262)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/16/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 12 Jun 2018 11:43:19 +
 Build duration:
7 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 15 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testXdgShellV5Failed: TestSuite.kwayland-testXdgShellV6

D13211: Enable comparing KFileItems by url

[Jaime Torres Amate]

jtamate updated this revision to Diff 36037.
jtamate marked an inline comment as done.
jtamate edited the summary of this revision.
jtamate added a comment.


  Change @since to 5.48

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13211?vs=35303&id=36037

REVISION DETAIL
  https://phabricator.kde.org/D13211

AFFECTED FILES
  autotests/kfileitemtest.cpp
  autotests/kfileitemtest.h
  src/core/kfileitem.cpp
  src/core/kfileitem.h

To: jtamate, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks modemmanager-qt kf5-qt5 SUSEQt5.10 - Build # 26 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20modemmanager-qt%20kf5-qt5%20SUSEQt5.10/26/
 Project:
Frameworks modemmanager-qt kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 12 Jun 2018 08:18:58 +
 Build duration:
5 min 57 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘SUSEQt5.10’Ready to run at Tue Jun 12 08:24:51 UTC 2018Resuming build at Tue Jun 12 08:24:51 UTC 2018 after Jenkins restartRunning on Docker Swarm-fc2c2bd9e4a6 in /home/jenkins/workspace/Frameworks modemmanager-qt kf5-qt5 SUSEQt5.10[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[Pipeline] }[Pipeline] // stage[Pipeline] }java.lang.Exception: Resume after a restart not supported for non-blocking synchronous steps	at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution.onResume(AbstractSynchronousNonBlockingStepExecution.java:70)	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:185)	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:180)	at com.google.common.util.concurrent.Futures$6.run(Futures.java:975)	at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:253)	at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:149)	at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:134)	at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:170)	at com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53)	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:999)	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:977)	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$4$1.run(CpsFlowExecution.java:906)	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)	at java.lang.Thread.run(Thread.java:748)[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks modemmanager-qt kf5-qt5 SUSEQt5.9 - Build # 15 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20modemmanager-qt%20kf5-qt5%20SUSEQt5.9/15/
 Project:
Frameworks modemmanager-qt kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 12 Jun 2018 08:18:58 +
 Build duration:
5 min 57 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘SUSEQt5.9’Ready to run at Tue Jun 12 08:24:51 UTC 2018Resuming build at Tue Jun 12 08:24:51 UTC 2018 after Jenkins restartRunning on Docker Swarm-29ec2a14299d in /home/jenkins/workspace/Frameworks modemmanager-qt kf5-qt5 SUSEQt5.9[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[Pipeline] }[Pipeline] // stage[Pipeline] }java.lang.Exception: Resume after a restart not supported for non-blocking synchronous steps	at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution.onResume(AbstractSynchronousNonBlockingStepExecution.java:70)	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:185)	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:180)	at com.google.common.util.concurrent.Futures$6.run(Futures.java:975)	at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:253)	at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:149)	at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:134)	at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:170)	at com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53)	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:999)	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:977)	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$4$1.run(CpsFlowExecution.java:906)	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)	at java.lang.Thread.run(Thread.java:748)[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D13117: Don't set custom domain filter rules

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R281:54cc344aa659: Don't set custom domain filter rules 
(authored by aleksanderm, committed by jgrulich).

REPOSITORY
  R281 ModemManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13117?vs=34870&id=36036

REVISION DETAIL
  https://phabricator.kde.org/D13117

AFFECTED FILES
  src/manager.cpp

To: aleksanderm, jgrulich, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

[Jaime Torres Amate]

jtamate abandoned this revision.
jtamate added a comment.


  More numbers:
  The patch reserves 67 buckets in the QHash table vs. 37 by default.
  In my test, pasing the content of 
https://www.boe.es/legislacion/documentos/ConstitucionCASTELLANO.pdf from 
Okular,
  the number of items in the cache is a maximum of 24 members when inserting.
  But the first undo uses up to 2300 members (4099 buckets), and later undoes 
only use a maximum of 43 members.
  
  The performance problem is in the first undo. What could be the difference 
between the first undo and subsequent undoes?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12897

To: jtamate, #kate, #frameworks
Cc: cullmann, dhaumann, mwolff, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars