D26671: Cleanup and add 22px media repeat icons

[Alexander Stippich]

astippich updated this revision to Diff 73592.
astippich added a comment.


  - remove color

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26671?vs=73567&id=73592

BRANCH
  repeatIcons

REVISION DETAIL
  https://phabricator.kde.org/D26671

AFFECTED FILES
  icons-dark/actions/22/media-playlist-repeat.svg
  icons-dark/actions/22/media-repeat-all.svg
  icons-dark/actions/22/media-repeat-none.svg
  icons/actions/22/media-playlist-repeat.svg
  icons/actions/22/media-repeat-all.svg
  icons/actions/22/media-repeat-none.svg

To: astippich, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26671: Cleanup and add 22px media repeat icons

[Alexander Stippich]

astippich added a comment.


  here you go:
  
  F7883937: media-repet.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26671

To: astippich, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26671: Cleanup and add 22px media repeat icons

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:936f84707708: Cleanup and add 22px media repeat icons 
(authored by astippich).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26671?vs=73592&id=73823

REVISION DETAIL
  https://phabricator.kde.org/D26671

AFFECTED FILES
  icons-dark/actions/22/media-playlist-repeat.svg
  icons-dark/actions/22/media-repeat-all.svg
  icons-dark/actions/22/media-repeat-none.svg
  icons/actions/22/media-playlist-repeat.svg
  icons/actions/22/media-repeat-all.svg
  icons/actions/22/media-repeat-none.svg

To: astippich, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich added a comment.


  friendly ping for the series

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich updated this revision to Diff 75306.
astippich added a comment.


  - udpate since tag

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25517?vs=73097&id=75306

BRANCH
  binaryData

REVISION DETAIL
  https://phabricator.kde.org/D25517

AFFECTED FILES
  src/extractionresult.h
  src/properties.h
  src/propertyinfo.cpp

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich added a comment.


  Where are we with this? @bruns are you accepting the proposed solution or do 
you reject it completely?
  I think it is at least way better than the current solution and maintains 
current API.
  A larger refactoring could be done for KF6

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich added a comment.


  Ping! At least a reply would be nice

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> modifiedfileindexer.cpp:74
> +bool cTimeChanged;
> +bool isKnownFile = tr.hasDocument(fileId);
> +if (isKnownFile) {

const?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27766

To: bruns, #baloo, ngraham, astippich
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham, astippich
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

[Alexander Stippich]

astippich added a comment.


  I would like to request a clear answer for https://phabricator.kde.org/D25517 
once again

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham, astippich
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich added a comment.


  ping @bruns
  this has now been open and unanswered for month!
  Same for the dependent patches

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich updated this revision to Diff 77954.
astippich added a comment.


  - fix label comment
  - tweaks
  - rename flag to ImageData
  - adress review comments
  - udpate since tag
  - update since tag

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25517?vs=75306&id=77954

BRANCH
  binaryData

REVISION DETAIL
  https://phabricator.kde.org/D25517

AFFECTED FILES
  src/extractionresult.h
  src/properties.h
  src/propertyinfo.cpp

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich added a comment.


  Since I got one accept and no other response, I will merge on the weekend

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25518: Extract front cover in the taglib extractor

[Alexander Stippich]

astippich updated this revision to Diff 77956.
astippich added a comment.


  - adapt to changes

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25518?vs=73098&id=77956

BRANCH
  taglibBinaryExtraction

REVISION DETAIL
  https://phabricator.kde.org/D25518

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25679: Implement writing of front cover in taglibwriter

[Alexander Stippich]

astippich updated this revision to Diff 77959.
astippich added a comment.


  - adapt to changes
  - use QMimeDatabase

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25679?vs=73099&id=77959

BRANCH
  tagLibBinaryWrite

REVISION DETAIL
  https://phabricator.kde.org/D25679

AFFECTED FILES
  autotests/taglibwritertest.cpp
  src/writers/taglibwriter.cpp

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich added a comment.


  Due to the recent circumstances I will probably not implement the support in 
Elisa, so I won't land this unless @bruns explicitly is okay with it (I still 
think this is an improvement over the status quo).

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28682: export done signal in filecontentindexer

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: Baloo, bruns.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Applications can subsribe for new files being indexed by baloo
  via the dbus interface of fileindexer. However, currently only
  the start and finishedIndexing signals are exported.
  The latter does only indicate that the file has been indexed,
  but not yet committed to the database.  
  Export the done signal so that it is possible to know
  when the transaction has been committed and thus is safe to
  query the database for metadata.

REPOSITORY
  R293 Baloo

BRANCH
  exportSignal

REVISION DETAIL
  https://phabricator.kde.org/D28682

AFFECTED FILES
  src/file/filecontentindexer.h

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28682: export done signal in filecontentindexer

[Alexander Stippich]

astippich added a comment.


  > Quoted Text
  > 
  >> ! In D28682#644412 , @mgallien 
wrote:
  > 
  > This is the reason why it is so slow in Elisa?
  
  Do you mean slow for picking up changes in files? Then yes. This happens when 
a track is modified when Elisa is running and listens for finishedIndexingFile 
signal. It then immediately queries baloo database, which still has the old 
values.
  Only after the done signal the transaction to baloo's database is complete.
  
  In D28682#644414 , @bruns wrote:
  
  > In general fine for me.
  >
  > How will Elisa deal with the indexer maybe crashing inbetween? Do we also 
need a signal for a batch start?
  
  
  From my (limited) understanding, the finishedIndexingFile will no be emitted 
when an indexers crashes, does it? Then I think it is fine without an 
additional signal as long as the done() signal is still emitted as it is 
possible to reset the applications' internal list. Or will it retry some files 
of the current batch?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28682: export done signal in filecontentindexer

[Alexander Stippich]

astippich added a comment.


  Then it's fine from my application point of view. I can add a corresponding 
start signal for convenience, though. Your call.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28682: export done signal in filecontentindexer

[Alexander Stippich]

astippich added a comment.


  How about committedBatch so that it's clear that they have been committed to 
the database?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28682: export done signal in filecontentindexer

[Alexander Stippich]

astippich updated this revision to Diff 79751.
astippich added a comment.


  - rename signal

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28682?vs=79657&id=79751

BRANCH
  exportSignal

REVISION DETAIL
  https://phabricator.kde.org/D28682

AFFECTED FILES
  src/file/filecontentindexer.cpp
  src/file/filecontentindexer.h
  src/file/fileindexscheduler.cpp

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28682: rename and export done signal in filecontentindexer

[Alexander Stippich]

astippich retitled this revision from "export done signal in 
filecontentindexer" to "rename and export done signal in filecontentindexer".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28682: rename and export done signal in filecontentindexer

[Alexander Stippich]

astippich marked 2 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28682: rename and export done signal in filecontentindexer

[Alexander Stippich]

astippich updated this revision to Diff 79904.
astippich added a comment.


  - implement feedback

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28682?vs=79751&id=79904

BRANCH
  exportSignal

REVISION DETAIL
  https://phabricator.kde.org/D28682

AFFECTED FILES
  src/file/filecontentindexer.cpp
  src/file/filecontentindexer.h
  src/file/fileindexscheduler.cpp

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28682: rename and export newBatchTime signal in filecontentindexer

[Alexander Stippich]

astippich added a comment.


  Thanks

REPOSITORY
  R293 Baloo

BRANCH
  exportSignal

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28682: rename and export newBatchTime signal in filecontentindexer

[Alexander Stippich]

astippich retitled this revision from "rename and export done signal in 
filecontentindexer" to "rename and export newBatchTime signal in 
filecontentindexer".
astippich edited the summary of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  exportSignal

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28682: rename and export newBatchTime signal in filecontentindexer

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:19e71b3e4a5f: rename and export newBatchTime signal in 
filecontentindexer (authored by astippich).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28682?vs=79904&id=79905

REVISION DETAIL
  https://phabricator.kde.org/D28682

AFFECTED FILES
  src/file/filecontentindexer.cpp
  src/file/filecontentindexer.h
  src/file/fileindexscheduler.cpp

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich abandoned this revision.
astippich added a comment.


  Okay, since there seems to be no interest at all as even a short reply is not 
given, I am done here

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D25518: Extract front cover in the taglib extractor

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25518

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D25679: Implement writing of front cover in taglibwriter

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25679

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D25515: Only extract lyrics when the plain text flag is set

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25515

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28980: Revert "add Baloo DBus signals for moved or removed files"

[Alexander Stippich]

astippich removed a reviewer: astippich.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28980

To: bruns, #baloo, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams