D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

2018-02-18 Thread Nathaniel Graham 
ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10616

To: ngraham, #frameworks, #dolphin, elvisangelaccio, markg
Cc: markg, michaelh

D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

2018-02-17 Thread Nathaniel Graham 
ngraham added a comment.


  The file dialog uses two different methods of setting shortcuts. Most are set 
in `kdiroperator.cpp`, but only few are set in `kfilewidget.cpp` I suspect 
legacy code, and it seems sensible to use the more standard, consistent style 
whenever possible.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10616

To: ngraham, #frameworks, #dolphin, elvisangelaccio, markg
Cc: markg, michaelh

D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

2018-02-17 Thread Mark Gaiser 
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.


  Fine by me.
  I do wonder why it used to be in an if statement though. It would have added 
a nullptr if the "if (showHidden)" check failed (which would fail when it's a 
nullptr).

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10616

To: ngraham, #frameworks, #dolphin, elvisangelaccio, markg
Cc: markg, michaelh

D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

2018-02-17 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin, elvisangelaccio.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  CCBUG: 390527
  
  Like D10558: Also use standard keyboard shortcut for "show/hide hidden files" 
, but for the file dialogs too, to maintain 
consistency.

TEST PLAN
  Tested with Open and Save dialogs in Kate. New and old shortcuts all worked 
and correctly triggered showing and hiding hidden files

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10616

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: michaelh