D17630: Don't re-mark words added/ignored to the dictionary as misspelled

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:332935735994: Don't re-mark words added/ignored to 
the dictionary as misspelled (authored by ahmadsamir, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17630?vs=47684&id=48357

REVISION DETAIL
  https://phabricator.kde.org/D17630

AFFECTED FILES
  src/spellcheck/ontheflycheck.cpp
  src/spellcheck/ontheflycheck.h
  src/spellcheck/spellcheck.cpp
  src/spellcheck/spellcheck.h

To: ahmadsamir, cullmann, davidedmundson
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17630: Don't re-mark words added/ignored to the dictionary as misspelled

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Makes sense, will push that after you fix the documentation for the other 
patch, thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-ontheflycheck-backgroundchecker

REVISION DETAIL
  https://phabricator.kde.org/D17630

To: ahmadsamir, cullmann, davidedmundson
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17630: Don't re-mark words added/ignored to the dictionary as misspelled

[Ahmad Samir]

ahmadsamir added reviewers: cullmann, davidedmundson.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17630

To: ahmadsamir, cullmann, davidedmundson
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17630: Don't re-mark words added/ignored to the dictionary as misspelled

[Ahmad Samir]

ahmadsamir created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  When a word is added to the dictionary or ignored via the spellingMenu,
  the BackgroundChecker instance in ontheflycheck should be updated to
  reflect the changes, otherwise words already added to the dictionary
  (or ignored) are re-highlited as misspelled when the view changes.
  
  Depends on D17629 .
  
  BUG: 387729

TEST PLAN
  - Open a file with misspelled words in kate and enable automatic spellchecking
  - Using the context menu:
- add a misspelled word to the dictionary
- Ignore another word B misspelling highlighting is removed, as expected
  - Scroll up/down so that those particular words are out of view then scroll 
and show them again; notice that those words re-highlighted as misspelled
  - After applying the pacth, words added/ingored to the dictionary aren't 
going to be re-highlighted as misspelled when the view changes

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-ontheflycheck-backgroundchecker

REVISION DETAIL
  https://phabricator.kde.org/D17630

AFFECTED FILES
  src/spellcheck/ontheflycheck.cpp
  src/spellcheck/ontheflycheck.h
  src/spellcheck/spellcheck.cpp
  src/spellcheck/spellcheck.h

To: ahmadsamir
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann