D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:04e756751ceb: Add a Plasma Theme Preferences Icon 
(authored by trickyricky26, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18433?vs=50006&id=50021

REVISION DETAIL
  https://phabricator.kde.org/D18433

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-plasma-theme.svg
  icons/preferences/32/preferences-desktop-plasma-theme.svg

To: trickyricky26, #vdg, ndavis, GB_2, ngraham
Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Nathaniel Graham 
ngraham added a comment.


  After some discussion, we decided to keep this name to ensure a proper 
fallback path for themes without this icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg, ndavis, GB_2, ngraham
Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-plasma-theme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg, ndavis, GB_2, ngraham
Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Björn Feber 
GB_2 added a comment.


  It should fall back to `preferences-desktop-plasma-theme`, because it fits 
better than `preferences-desktop-theme` and it is also what we use now.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg, ndavis, GB_2, ngraham
Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Please change the name to `preferences-desktop-theme-plasma`, and then I'll 
land it!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg, ndavis, GB_2, ngraham
Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Noah Davis 
ndavis added a comment.


  In D18433#397602 , @ngraham wrote:
  
  > We have `preferences-desktop-theme-global`; shouldn't this be 
`preferences-desktop-theme-plasma`?
  
  
  Good point

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-plasma-theme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg, ndavis, GB_2, ngraham
Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Nathaniel Graham 
ngraham added a comment.


  We have `preferences-desktop-theme-global`; shouldn't this be 
`preferences-desktop-theme-plasma`?

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-plasma-theme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg, ndavis, GB_2, ngraham
Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Nathaniel Graham 
ngraham accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-plasma-theme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg, ndavis, GB_2, ngraham
Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Björn Feber 
GB_2 accepted this revision.
GB_2 added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-plasma-theme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg, ndavis, GB_2
Cc: GB_2, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Noah Davis 
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Looks good to me!

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-plasma-theme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 50006.
trickyricky26 added a comment.


  - Make the Plasma Logo the same size as the Plasma Preferences Icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18433?vs=50005&id=50006

BRANCH
  add-plasma-theme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18433

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-plasma-theme.svg
  icons/preferences/32/preferences-desktop-plasma-theme.svg

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread TrickyRicky 
trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  I will make the Plasma logo the same size as the one in 
`preferences-desktop-plasma`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread TrickyRicky 
trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18433

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread TrickyRicky 
trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-plasma-theme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18433

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-plasma-theme.svg
  icons/preferences/32/preferences-desktop-plasma-theme.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns