D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:9aec0d9cc43f: Add icons for Touch Screen and Screen Edge 
KCMs (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18483?vs=50156=50157

REVISION DETAIL
  https://phabricator.kde.org/D18483

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons-dark/preferences/32/preferences-desktop-gestures-touch.svg
  icons/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons/preferences/32/preferences-desktop-gestures-touch.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis 
ndavis updated this revision to Diff 50156.
ndavis added a comment.


  Add change to breeze dark

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18483?vs=50154=50156

BRANCH
  preferences-gestures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18483

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons-dark/preferences/32/preferences-desktop-gestures-touch.svg
  icons/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons/preferences/32/preferences-desktop-gestures-touch.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Love it. Shipit!

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-gestures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18483

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18483

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis 
ndavis updated this revision to Diff 50154.
ndavis added a comment.


  Change style of screen edges icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18483?vs=50139=50154

BRANCH
  preferences-gestures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18483

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons-dark/preferences/32/preferences-desktop-gestures-touch.svg
  icons/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons/preferences/32/preferences-desktop-gestures-touch.svg

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Nathaniel Graham 
ngraham added a comment.


  Cool. I think the issue here is that the hotcorner bit is simultaneously too 
small to be easily noticeable, but visible enough to subtly unbalance the icon. 
I might recommend experimenting with making the hotcorner highlight more 
visually prominent and then adding a screen edge highlight on the right side to 
balance it out.
  
  Or here's an idea: do those things and then remove the cursor icon from it 
entirely.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18483

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis 
ndavis added a comment.


  In D18483#398753 , @ngraham wrote:
  
  > Maybe `preferences-desktop-gestures-screenedges` should have the cursor 
near to the hot corner to reinforce the concept? Otherwise it kind of feels 
like an icon for the cursors KCM.
  
  
  The issue with that is that it would be the only one with an uncentered 
symbol. I can make an icon for the Cursors KCM with no desktop background, so 
it shouldn't be that bad.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18483

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Nathaniel Graham 
ngraham added a comment.


  Maybe `preferences-desktop-gestures-screenedges` should have the cursor near 
to the hot corner to reinforce the concept? Otherwise it kind of feels like an 
icon for the cursors KCM.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18483

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18483

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis 
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-gestures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18483

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons-dark/preferences/32/preferences-desktop-gestures-touch.svg
  icons/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons/preferences/32/preferences-desktop-gestures-touch.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns