D18834: Change glowbar.svgz to smoother style

2019-02-08 Thread Vlad Zagorodniy 
zzag added a comment.


  Also, it's worth to mention glowbar from Oxygen theme 
(plasma-framework/src/desktoptheme/oxygen/widgets/glowbar.svgz).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: zzag, rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-08 Thread Vlad Zagorodniy 
zzag added a comment.


  In D18834#407533 , @ndavis wrote:
  
  > I had a look through the Screen Edge effect code and while I'm no expert, I 
didn't see anything that would obviously make the corners large.
  
  
  The screen edge effect scales corner tiles and I don't think this will be 
changed.
  
  If slightly bigger corner glows is really such a big issue, then as a 
potential solution, the gradients could be "scaled" down a little bit.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: zzag, rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-08 Thread Noah Davis 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:054b494bb3f2: Change glowbar.svgz to smoother style 
(authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18834?vs=51144&id=51154

REVISION DETAIL
  https://phabricator.kde.org/D18834

AFFECTED FILES
  src/desktoptheme/breeze/widgets/glowbar.svgz

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-08 Thread Noah Davis 
ndavis added a comment.


  Well, there's nothing wrong within the patch itself, so I'll land it.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis 
ndavis added a comment.


  In D18834#407534 , @rooty wrote:
  
  > You could make it smaller? It looks fine to me at the corners, it's the 
actual sidebar that's a little thick.
  >
  > I still like this diff though, I think that the master's too 
stippled/dotted.
  
  
  I don't think I can change anything about the size in this patch. I think the 
sizes are determined elsewhere. Here's the real thickness of the portion of the 
image that is used for the top screen edge: F6599583: 
Screenshot_20190207_214454.png 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Krešimir Čohar 
rooty added a comment.


  You could make it smaller? It looks fine to me at the corners, it's the 
actual sidebar that's a little thick.
  
  I still like this diff though, I think that the master's too stippled/dotted.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis 
ndavis added a comment.


  I suppose it's this, but it's somehow even worse with this patch: 
https://bugs.kde.org/show_bug.cgi?id=337712
  
  I had a look through the Screen Edge effect code and while I'm no expert, I 
didn't see anything that would obviously make the corners large.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Krešimir Čohar 
rooty added a comment.


  In D18834#407529 , @ndavis wrote:
  
  > For some reason, this version looks much larger in the corners. Was there a 
change to how the screen edge effect works? I didn't change the size of the 
corners in the SVGZ.
  
  
  F6599457: image.png  This is the old 
version (kind of strange)
  F6599459: image.png  and this is yours, 
much better in my opinion...

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis 
ndavis added a comment.


  For some reason, this version looks much larger in the corners. Was there a 
change to how the screen edge effect works? I didn't change the size of the 
corners in the SVGZ.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Krešimir Čohar 
rooty added a comment.


  Sure thing. This seems straightforward enough to me though

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis 
ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis 
ndavis added a comment.


  In D18834#407524 , @rooty wrote:
  
  > Wait I can do that? I didn't know I could do that :D
  
  
  Yes, but I should have said make sure you've given patches you want to 
approve a good look first. Use `arc patch D` so you can look 
at it on your own hard drive unless you're confident that no mistakes were made 
by looking at the code on Phabricator.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Krešimir Čohar 
rooty accepted this revision.
rooty added a comment.
This revision is now accepted and ready to land.


  Wait I can do that? I didn't know I could do that :D

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis 
ndavis added a comment.


  If you like it, don't be afraid to hit "Approve" ;)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis 
ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Krešimir Čohar 
rooty added a comment.


  In D18834#407518 , @rapiteanu 
wrote:
  
  > This looks really good!
  >  With this the bug 391343 will be fixed.
  
  
  I like it too, +1.
  Can you also CC the BUG so it gets closed?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Viorel-Cătălin Răpițeanu 
rapiteanu added a comment.


  This looks really good!
  With this the bug 391343 will be fixed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis 
ndavis added a comment.


  JFYI, the whole embedded stylesheet thing doesn't work on gradients, so it 
doesn't matter if colors are hardcoded.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis 
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The old style was weird. When the screen edge feature was enabled for the 
sides of screens, it looked like a bunch of dots smooshed together. Now it's 
one smooth bar.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

AFFECTED FILES
  src/desktoptheme/breeze/widgets/glowbar.svgz

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns