ngraham created this revision.
ngraham added reviewers: ndavis, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
The problem with using the highlight color is that the emblem becomes
invisible when
applied to a UI element that's selectable and (correctly) uses the default
selection
color. Making it use the text color instead fixes the bug in all cases.
TEST PLAN
Stars in various UIs (Discover, Dolphin) are now black rather than blue, and
the icon
can now be used on buttons without becoming invisible.
REPOSITORY
R266 Breeze Icons
BRANCH
monochrome-rating-emblem (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24612
AFFECTED FILES
icons/emblems/16/rating.svg
icons/emblems/22/rating.svg
icons/emblems/8/rating.svg
To: ngraham, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns