D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-18 Thread Vlad Zahorodnii 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:deb476e47d47: [server] Introduce 
SurfaceInterface::boundingRect() (authored by zzag).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27828?vs=76922=77918

REVISION DETAIL
  https://phabricator.kde.org/D27828

AFFECTED FILES
  src/server/surface_interface.cpp
  src/server/surface_interface.h

To: zzag, #kwin, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-05 Thread Vlad Zahorodnii 
zzag added a dependent revision: D27859: [server] Expose SurfaceRole class.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27828

To: zzag, #kwin, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread Vlad Zahorodnii 
zzag added a comment.


  I'll merge this patch after 5.68 is tagged.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27828

To: zzag, #kwin, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27828

To: zzag, #kwin, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread Vlad Zahorodnii 
zzag added a comment.


  In D27828#621821 , @apol wrote:
  
  > Maybe producing the patch that is meant to consume this will help see 
what's the use for this patch.
  
  
  D27831 

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27828

To: zzag, #kwin
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread Aleix Pol Gonzalez 
apol added a comment.


  Maybe producing the patch that is meant to consume this will help see what's 
the use for this patch.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27828

To: zzag, #kwin
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread Vlad Zahorodnii 
zzag updated this revision to Diff 76922.
zzag added a comment.


  Add missing @since

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27828?vs=76921=76922

REVISION DETAIL
  https://phabricator.kde.org/D27828

AFFECTED FILES
  src/server/surface_interface.cpp
  src/server/surface_interface.h

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread Vlad Zahorodnii 
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The new method provides a convenient way for determining the rectangle
  that bounds the given surface and all of its sub-surfaces. This can be
  very handy when determining the effective window geometry.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27828

AFFECTED FILES
  src/server/surface_interface.cpp
  src/server/surface_interface.h

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns