D29027: Move document corner fold to top right in two icons
ngraham added a comment. Shipit! REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29027: Move document corner fold to top right in two icons
davidhurka added a comment. Is it possible to land this without arc? I can’t get arc running on my current system. :( If you want this in the next release, you too may land it for me. Otherwise I will land it when I have my own system back, i. e. in a few weeks. I will change the other gnumeric icons to use Highlight instead of a fixed color later. REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29027: Move document corner fold to top right in two icons
ngraham added a comment. You can do a regular old git push if you cherry-pick the commit onto master. I'll land it for you though. REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29027: Move document corner fold to top right in two icons
This revision was automatically updated to reflect the committed changes. Closed by commit R266:db3ec8680b35: Move document corner fold to top right in two icons (authored by davidhurka, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29027?vs=80707&id=81512 REVISION DETAIL https://phabricator.kde.org/D29027 AFFECTED FILES icons-dark/actions/16/document-close.svg icons-dark/actions/16/gnumeric-link-internal.svg icons-dark/actions/22/document-close.svg icons-dark/actions/22/gnumeric-link-internal.svg icons/actions/16/document-close.svg icons/actions/16/gnumeric-link-internal.svg icons/actions/22/document-close.svg icons/actions/22/gnumeric-link-internal.svg To: davidhurka, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29027: Move document corner fold to top right in two icons
davidhurka retitled this revision from "Move document corner fold to top right in two icons This updates document-close in the sizes below 32px and gnumeric-link-internal to the new style. I forgot them in D28203. gnumeric-link-internal uses ButtonFocus." to "Move document corner fold to top right in two icons". davidhurka edited the summary of this revision. davidhurka edited the test plan for this revision. davidhurka added a reviewer: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29027: Move document corner fold to top right in two icons
davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29027: Move document corner fold to top right in two icons
davidhurka updated this revision to Diff 80707. davidhurka added a comment. - Use Highlight instead of ButtonFocus, Noah already decided that somewhere else REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29027?vs=80702&id=80707 BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 AFFECTED FILES icons-dark/actions/16/document-close.svg icons-dark/actions/16/gnumeric-link-internal.svg icons-dark/actions/22/document-close.svg icons-dark/actions/22/gnumeric-link-internal.svg icons/actions/16/document-close.svg icons/actions/16/gnumeric-link-internal.svg icons/actions/22/document-close.svg icons/actions/22/gnumeric-link-internal.svg To: davidhurka, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29027: Move document corner fold to top right in two icons
davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29027: Move document corner fold to top right in two icons
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29027: Move document corner fold to top right in two icons
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29027: Move document corner fold to top right in two icons
davidhurka added a comment. I looked at the other gnumeric icons. Those which are not a symlink use fixed colors, while the linked icons use Highlight. I don’t see the point to use fixed colors. REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns