D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage
dfaure abandoned this revision. dfaure added a comment. This has been done meanwhile. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29371 To: dfaure, #frameworks, davidedmundson, dvratil Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage
dfaure commandeered this revision. dfaure edited reviewers, added: dvratil; removed: dfaure. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D29371 To: dfaure, #frameworks, davidedmundson, dvratil Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage
dfaure added a comment. `src/kmainwindow_p.h:59:QEventLoopLocker locker;` so the refcounting effect is the same as documented, just with a different "backend". REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29371 To: dvratil, dfaure, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Please don't remove this, but port it to QEventLoopLocker. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29371 To: dvratil, dfaure, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D29371 To: dvratil, dfaure, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage
dvratil added a reviewer: Frameworks. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29371 To: dvratil, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage
dvratil created this revision. dvratil added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY There's no sign of KGlobal (obviously, it's been moved to kdelibs4support) or any other similar code in KMainWindow, so remove the outdated paragraph from the documentation. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D29371 AFFECTED FILES src/kmainwindow.h To: dvratil, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns