D6685: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event
This revision was automatically updated to reflect the committed changes. Closed by commit R241:f9eb528acffc: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6685?vs=16663=17292 REVISION DETAIL https://phabricator.kde.org/D6685 AFFECTED FILES src/filewidgets/kurlnavigator.cpp src/filewidgets/kurlnavigator.h To: elvisangelaccio, #frameworks, dfaure
D6685: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D6685 To: elvisangelaccio, #frameworks, dfaure
D6685: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event
elvisangelaccio added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6685 To: elvisangelaccio, #frameworks, dfaure
D6685: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event
elvisangelaccio added a dependent revision: D6684: Fix drop menu position with urlnavigator drops. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6685 To: elvisangelaccio, #frameworks, dfaure
D6685: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Commit https://phabricator.kde.org/R241:1e251d2f6a428fc5cc27a766c2a6d7b5e8fb2594 does not work with KUrlNavigator drops because the drop event is processed at the KUrlNavigatorButton level. This means that passing a KUrlNavigator to KJobWidgets::setWindow() results in a wrong position for KIO::drop() menus (both on Wayland and X11). To fix this issue, the DropJob needs to be associated to the KUrlNavigatorButton that received the drop event. This class is not exported, so we add a getter to KUrlNavigator that exposes the relevant KUrlNavigatorButton as QWidget (which is enough because the DropJob just needs to call mapToGlobal() on it). TEST PLAN Use case in https://phabricator.kde.org/D6684 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D6685 AFFECTED FILES src/filewidgets/kurlnavigator.cpp src/filewidgets/kurlnavigator.h To: elvisangelaccio, #frameworks, dfaure