Re: Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114980/#review47942 --- Welp, since no-one seems to care, I'm gonna commit it. - Alex Merry On Jan. 12, 2014, 12:58 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114980/ > --- > > (Updated Jan. 12, 2014, 12:58 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kdesignerplugin > > > Description > --- > > Do not explicity find or use Qt5WebKit(Widgets) > > The kdewebkit designer plugin does not directly use anything from > Qt5WebKitWidgets, only KWebView from KF5WebKit. Qt5WebKitWidgets is > found as a dependency of KF5WebKit. So we do not need to find it > ourselves, or explicitly link against it. > > > Diffs > - > > CMakeLists.txt d13d071f935306df2d052b58a6a03ea92bba36f3 > src/CMakeLists.txt 55ac819d4c2cbaac483cec9617402e18fbe22d2b > > Diff: https://git.reviewboard.kde.org/r/114980/diff/ > > > Testing > --- > > Still configures, builds and installs. > > > Thanks, > > Alex Merry > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114980/ --- (Updated Jan. 21, 2014, 10:42 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: kdesignerplugin Description --- Do not explicity find or use Qt5WebKit(Widgets) The kdewebkit designer plugin does not directly use anything from Qt5WebKitWidgets, only KWebView from KF5WebKit. Qt5WebKitWidgets is found as a dependency of KF5WebKit. So we do not need to find it ourselves, or explicitly link against it. Diffs - CMakeLists.txt d13d071f935306df2d052b58a6a03ea92bba36f3 src/CMakeLists.txt 55ac819d4c2cbaac483cec9617402e18fbe22d2b Diff: https://git.reviewboard.kde.org/r/114980/diff/ Testing --- Still configures, builds and installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114980/#review47943 --- This review has been submitted with commit 749336963bbcddea2e547020202e049937536275 by Alex Merry to branch master. - Commit Hook On Jan. 12, 2014, 12:58 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114980/ > --- > > (Updated Jan. 12, 2014, 12:58 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kdesignerplugin > > > Description > --- > > Do not explicity find or use Qt5WebKit(Widgets) > > The kdewebkit designer plugin does not directly use anything from > Qt5WebKitWidgets, only KWebView from KF5WebKit. Qt5WebKitWidgets is > found as a dependency of KF5WebKit. So we do not need to find it > ourselves, or explicitly link against it. > > > Diffs > - > > CMakeLists.txt d13d071f935306df2d052b58a6a03ea92bba36f3 > src/CMakeLists.txt 55ac819d4c2cbaac483cec9617402e18fbe22d2b > > Diff: https://git.reviewboard.kde.org/r/114980/diff/ > > > Testing > --- > > Still configures, builds and installs. > > > Thanks, > > Alex Merry > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
