Re: Review Request 113170: Document KInit dependencies
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113170/ --- (Updated Oct. 11, 2013, 3:38 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Documents KInit dependencies, updates to the newer executable names and adds a comment regarding things to be looked into. Diffs - staging/kinit/src/wrapper.cpp c9d40cc staging/kinit/src/start_kdeinit/CMakeLists.txt d2eae19 staging/kinit/src/kwrapper/kwrapper_win.cpp 881920e staging/kinit/src/klauncher/klauncher_main.cpp e0d46c9 staging/kinit/src/klauncher/CMakeLists.txt 1b173be staging/kinit/src/kdeinit/kinit.cpp c4a0908 staging/kinit/src/kdeinit/CMakeLists.txt d5e1070 staging/kinit/src/CMakeLists.txt 9fc6736 Diff: http://git.reviewboard.kde.org/r/113170/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113170: Document KInit dependencies
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113170/#review41563 --- Ship it! Looks good ! - Àlex Fiestas On Oct. 11, 2013, 2 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113170/ > --- > > (Updated Oct. 11, 2013, 2 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Documents KInit dependencies, updates to the newer executable names and adds > a comment regarding things to be looked into. > > > Diffs > - > > staging/kinit/src/wrapper.cpp c9d40cc > staging/kinit/src/start_kdeinit/CMakeLists.txt d2eae19 > staging/kinit/src/kwrapper/kwrapper_win.cpp 881920e > staging/kinit/src/klauncher/klauncher_main.cpp e0d46c9 > staging/kinit/src/klauncher/CMakeLists.txt 1b173be > staging/kinit/src/kdeinit/kinit.cpp c4a0908 > staging/kinit/src/kdeinit/CMakeLists.txt d5e1070 > staging/kinit/src/CMakeLists.txt 9fc6736 > > Diff: http://git.reviewboard.kde.org/r/113170/diff/ > > > Testing > --- > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113170: Document KInit dependencies
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113170/ --- (Updated Oct. 11, 2013, 2 p.m.) Review request for KDE Frameworks. Changes --- Small love addition to the patch Repository: kdelibs Description --- Documents KInit dependencies, updates to the newer executable names and adds a comment regarding things to be looked into. Diffs (updated) - staging/kinit/src/wrapper.cpp c9d40cc staging/kinit/src/start_kdeinit/CMakeLists.txt d2eae19 staging/kinit/src/kwrapper/kwrapper_win.cpp 881920e staging/kinit/src/klauncher/klauncher_main.cpp e0d46c9 staging/kinit/src/klauncher/CMakeLists.txt 1b173be staging/kinit/src/kdeinit/kinit.cpp c4a0908 staging/kinit/src/kdeinit/CMakeLists.txt d5e1070 staging/kinit/src/CMakeLists.txt 9fc6736 Diff: http://git.reviewboard.kde.org/r/113170/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113170: Document KInit dependencies
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113170/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Documents KInit dependencies, updates to the newer executable names and adds a comment regarding things to be looked into. Diffs - staging/kinit/src/kdeinit/CMakeLists.txt d5e1070 staging/kinit/src/kdeinit/kinit.cpp c4a0908 staging/kinit/src/klauncher/CMakeLists.txt 1b173be staging/kinit/src/kwrapper/kwrapper_win.cpp 881920e staging/kinit/src/start_kdeinit/CMakeLists.txt d2eae19 staging/kinit/src/wrapper.cpp c9d40cc Diff: http://git.reviewboard.kde.org/r/113170/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
