Re: Review Request 124307: Remove Theme tree debug entry

2015-07-15 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124307/
---

(Updated July 15, 2015, 3:14 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Antonio Larrosa Jimenez and Christoph Feck.


Changes
---

Submitted with commit 15c76a72eee8dd8530cadcd8d5713ca08aaf7858 by Aleix Pol to 
branch master.


Repository: kiconthemes


Description
---

Every time we launch a KDE Application, we see this warning: `kf5.kiconthemes: 
"Theme tree: (Breeze)"`

This patch removes it, we're not outputting this for each plugin we have loaded 
(styles, qpt, etc.) and it doesn't seem very useful to me, so I'd just drop it.


Diffs
-

  src/kiconloader.cpp c725115 

Diff: https://git.reviewboard.kde.org/r/124307/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124307: Remove Theme tree debug entry

2015-07-15 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124307/#review82542
---

Ship it!


Ship It!

- David Edmundson


On July 9, 2015, 2:55 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124307/
> ---
> 
> (Updated July 9, 2015, 2:55 p.m.)
> 
> 
> Review request for KDE Frameworks, Antonio Larrosa Jimenez and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> Every time we launch a KDE Application, we see this warning: 
> `kf5.kiconthemes: "Theme tree: (Breeze)"`
> 
> This patch removes it, we're not outputting this for each plugin we have 
> loaded (styles, qpt, etc.) and it doesn't seem very useful to me, so I'd just 
> drop it.
> 
> 
> Diffs
> -
> 
>   src/kiconloader.cpp c725115 
> 
> Diff: https://git.reviewboard.kde.org/r/124307/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124307: Remove Theme tree debug entry

2015-07-09 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124307/#review82273
---


+1

- Kai Uwe Broulik


On Juli 9, 2015, 2:55 nachm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124307/
> ---
> 
> (Updated Juli 9, 2015, 2:55 nachm.)
> 
> 
> Review request for KDE Frameworks, Antonio Larrosa Jimenez and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> Every time we launch a KDE Application, we see this warning: 
> `kf5.kiconthemes: "Theme tree: (Breeze)"`
> 
> This patch removes it, we're not outputting this for each plugin we have 
> loaded (styles, qpt, etc.) and it doesn't seem very useful to me, so I'd just 
> drop it.
> 
> 
> Diffs
> -
> 
>   src/kiconloader.cpp c725115 
> 
> Diff: https://git.reviewboard.kde.org/r/124307/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 124307: Remove Theme tree debug entry

2015-07-09 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124307/
---

Review request for KDE Frameworks, Antonio Larrosa Jimenez and Christoph Feck.


Repository: kiconthemes


Description
---

Every time we launch a KDE Application, we see this warning: `kf5.kiconthemes: 
"Theme tree: (Breeze)"`

This patch removes it, we're not outputting this for each plugin we have loaded 
(styles, qpt, etc.) and it doesn't seem very useful to me, so I'd just drop it.


Diffs
-

  src/kiconloader.cpp c725115 

Diff: https://git.reviewboard.kde.org/r/124307/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel