Re: Review Request 126949: Remove Air and Oxygen themes

2016-03-23 Thread Martin Klapetek

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/
---

(Updated March 23, 2016, 12:15 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Plasma.


Bugs: 358533
http://bugs.kde.org/show_bug.cgi?id=358533


Repository: plasma-framework


Description
---

They are untested, unmaintained and most importantly, broken.

Let's remove them from our releases and move them to kde-look.org for grabs.


Diffs
-

  src/desktoptheme/air/CMakeLists.txt 40ea382 
  src/desktoptheme/air/colors 5c4e53d 
  src/desktoptheme/air/dialogs/background.svgz 81ef460 
  src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
  src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
  src/desktoptheme/air/icons/amarok.svgz e3c157e 
  src/desktoptheme/air/icons/audio.svgz 540cc77 
  src/desktoptheme/air/icons/battery.svgz 88f864e 
  src/desktoptheme/air/icons/configure.svgz a433b3c 
  src/desktoptheme/air/icons/device.svgz 23df094 
  src/desktoptheme/air/icons/document.svgz 6e89dd8 
  src/desktoptheme/air/icons/edit.svgz d0e1ca4 
  src/desktoptheme/air/icons/go.svgz ad3a4b2 
  src/desktoptheme/air/icons/kget.svgz 1f1702f 
  src/desktoptheme/air/icons/klipper.svgz 4afd33c 
  src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
  src/desktoptheme/air/icons/konversation.svgz 376211a 
  src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
  src/desktoptheme/air/icons/korgac.svgz 8c8f700 
  src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
  src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
  src/desktoptheme/air/icons/list.svgz 0a25bb0 
  src/desktoptheme/air/icons/media.svgz 23653bd 
  src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
  src/desktoptheme/air/icons/network.svgz a8e8b16 
  src/desktoptheme/air/icons/notification.svgz db12260 
  src/desktoptheme/air/icons/preferences.svgz 12e6588 
  src/desktoptheme/air/icons/printer.svgz 199ab95 
  src/desktoptheme/air/icons/quassel.svgz b004749 
  src/desktoptheme/air/icons/slc.svgz 9fd376b 
  src/desktoptheme/air/icons/wallet.svgz 4ad3691 
  src/desktoptheme/air/icons/window.svgz eecc37f 
  src/desktoptheme/air/icons/zoom.svgz c159491 
  src/desktoptheme/air/metadata.desktop 0be4bd5 
  src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
  src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
  src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
  src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
  src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
  src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
  src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
  src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
  src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
  src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
  src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
  src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
  src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
  src/desktoptheme/air/widgets/arrows.svgz b987b32 
  src/desktoptheme/air/widgets/background.svgz 174a8fc 
  src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
  src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
  src/desktoptheme/air/widgets/branding.svgz c6316fb 
  src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
  src/desktoptheme/air/widgets/button.svgz 2c529bf 
  src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
  src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
  src/desktoptheme/air/widgets/clock.svgz 3839dac 
  src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
  src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
  src/desktoptheme/air/widgets/dragger.svgz 3629591 
  src/desktoptheme/air/widgets/extender-background.svgz 4003079 
  src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
  src/desktoptheme/air/widgets/frame.svgz 327c284 
  src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
  src/desktoptheme/air/widgets/identiconshapes.svgz 67fe725 
  src/desktoptheme/air/widgets/identicontheme.svgz ad881cd 
  src/desktoptheme/air/widgets/labeltexture.svgz f52a78d 
  src/desktoptheme/air/widgets/line.svgz 70efca4 
  src/desktoptheme/air/widgets/lineedit.svgz 22347db 
  src/desktoptheme/air/widgets/listitem.svgz ec7e89a 
  src/desktoptheme/air/widgets/media-delegate.svgz e28b313 
  src/desktoptheme/air/widgets/monitor.svgz 13a22fd 
  src/desktoptheme/air/widgets/pager.svgz 2dcbbcd 
  src/desktoptheme/air/widgets/panel-background.svgz 080a65d 
  src/desktoptheme/air/widgets/picker.svgz c15eb0e 
  src/desktoptheme/air/widgets/plot-background.svgz f4c7957 
  src/desktoptheme/air/widgets/scrollbar.svgz c0ea8f5 
  src/desktoptheme/air/widgets/scrollwidget.svgz 3281ad6 
  

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek


> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.
> 
> Marco Martin wrote:
> I am willing to work on both of them, to fix the few objective bugs, but 
> most important to fix everything around it to have the behavior as identic as 
> possible.
> 
> Marco Martin wrote:
> > Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> I know, it's how is supposed to be, as the giant shadow.
> 
> there are only two actual bugs i can hee here or in the screenshot: that 
> panel margins and the sliders grooves (tabbar indicators may also have a bit 
> of extra side margins that shouldn't be there).
> the rest you can say you don't like it, but it's how is supposed to look
> 
> Marco Martin wrote:
> so i would:
> 
> * fix the panel "decrease margins until icons are big enough" behavior 
> that was implemented but broken
> 
> * do a couple of fixes in air of actual problems (already on my hard 
> drive)
> 
> * remove custom icons in both themes
> 
> * fix 

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin


> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.
> 
> Marco Martin wrote:
> I am willing to work on both of them, to fix the few objective bugs, but 
> most important to fix everything around it to have the behavior as identic as 
> possible.
> 
> Marco Martin wrote:
> > Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> I know, it's how is supposed to be, as the giant shadow.
> 
> there are only two actual bugs i can hee here or in the screenshot: that 
> panel margins and the sliders grooves (tabbar indicators may also have a bit 
> of extra side margins that shouldn't be there).
> the rest you can say you don't like it, but it's how is supposed to look
> 
> Marco Martin wrote:
> so i would:
> 
> * fix the panel "decrease margins until icons are big enough" behavior 
> that was implemented but broken
> 
> * do a couple of fixes in air of actual problems (already on my hard 
> drive)
> 
> * remove custom icons in both themes
> 
> * fix another 

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek


> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.
> 
> Marco Martin wrote:
> I am willing to work on both of them, to fix the few objective bugs, but 
> most important to fix everything around it to have the behavior as identic as 
> possible.
> 
> Marco Martin wrote:
> > Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> I know, it's how is supposed to be, as the giant shadow.
> 
> there are only two actual bugs i can hee here or in the screenshot: that 
> panel margins and the sliders grooves (tabbar indicators may also have a bit 
> of extra side margins that shouldn't be there).
> the rest you can say you don't like it, but it's how is supposed to look
> 
> Marco Martin wrote:
> so i would:
> 
> * fix the panel "decrease margins until icons are big enough" behavior 
> that was implemented but broken
> 
> * do a couple of fixes in air of actual problems (already on my hard 
> drive)
> 
> * remove custom icons in both themes
> 
> * fix 

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin


> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.
> 
> Marco Martin wrote:
> I am willing to work on both of them, to fix the few objective bugs, but 
> most important to fix everything around it to have the behavior as identic as 
> possible.
> 
> Marco Martin wrote:
> > Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> I know, it's how is supposed to be, as the giant shadow.
> 
> there are only two actual bugs i can hee here or in the screenshot: that 
> panel margins and the sliders grooves (tabbar indicators may also have a bit 
> of extra side margins that shouldn't be there).
> the rest you can say you don't like it, but it's how is supposed to look
> 
> Marco Martin wrote:
> so i would:
> 
> * fix the panel "decrease margins until icons are big enough" behavior 
> that was implemented but broken
> 
> * do a couple of fixes in air of actual problems (already on my hard 
> drive)
> 
> * remove custom icons in both themes
> 
> * fix another 

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Kai Uwe Broulik


> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo

Yes, Hugo is doing a fine job of maintaining Oxygen stuff and cherry-picking 
fixes from Breeze. :) It's really just the Plasma theme that is utterly broken 
and unmaintained.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz 

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Thomas Pfeiffer


> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo
> 
> Kai Uwe Broulik wrote:
> Yes, Hugo is doing a fine job of maintaining Oxygen stuff and 
> cherry-picking fixes from Breeze. :) It's really just the Plasma theme that 
> is utterly broken and unmaintained.
> 
> andreas kainz wrote:
> I'v never done a plasma theme but I saw how the breeze theme get broken 
> and how it was fixed again. As Hugo maintaine oxygen stuff and I maintain 
> oxygen icon stuff, it would be good to have the plasma theme also available. 
> I can offer to maintain the oxygen plasma theme (one of them).
> 
> Marco Martin wrote:
> oxygen icon or oxygen style repository? for me both would be good.
> 
> note that if you chose the oxygen look and feel it sets the oxygen widget 
> style and the Air plasma theme, that should be still the case.

I'd say we need one theme to go with the Oxygen Look & Feel package. If Air is 
still maintainted and used in the L, then killing Oxygen from our repos 
should be fine.
I'm against putting it on kde-look, however, because we don't want unmaintained 
and broken stuff on there, either. kde-look currently is used kind of as a 
junkyard by some, but this has to change if we want to showcase it more.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Thomas Pfeiffer


> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo
> 
> Kai Uwe Broulik wrote:
> Yes, Hugo is doing a fine job of maintaining Oxygen stuff and 
> cherry-picking fixes from Breeze. :) It's really just the Plasma theme that 
> is utterly broken and unmaintained.
> 
> andreas kainz wrote:
> I'v never done a plasma theme but I saw how the breeze theme get broken 
> and how it was fixed again. As Hugo maintaine oxygen stuff and I maintain 
> oxygen icon stuff, it would be good to have the plasma theme also available. 
> I can offer to maintain the oxygen plasma theme (one of them).
> 
> Marco Martin wrote:
> oxygen icon or oxygen style repository? for me both would be good.
> 
> note that if you chose the oxygen look and feel it sets the oxygen widget 
> style and the Air plasma theme, that should be still the case.
> 
> Thomas Pfeiffer wrote:
> I'd say we need one theme to go with the Oxygen Look & Feel package. If 
> Air is still maintainted and used in the L, then killing Oxygen from our 
> repos should be fine.
> I'm against putting it on kde-look, however, because we don't want 
> unmaintained and broken stuff on there, either. kde-look currently is used 
> kind of as a junkyard by some, but this has to change if we want to showcase 
> it more.
> 
> Boudhayan Gupta wrote:
> I'm still of the opinion that it makes more sense to put everything 
> Oxygen in one package; given that Oxygen is not the default theme for Plasma 
> anymore we shouldn't ship it with the default look-n-feel package at all.

Having everything needed for a complete Oxygen L theme package which then 
becomes an optional dependency for Plasma sounds sensible to me. That way, 
distros can decide whether they want to ship only Breeze and Breeze Dark L 
or Oxygen as well.
While of course it's possible for users to mix and match Breeze and Oxygen, I 
assume that most users will want either all Oxygen or all Breeze, so shipping 
anything Oxygen only makes sense if users can selecta  complete Oxygen L with 
all components working.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Boudhayan Gupta


> On Feb. 2, 2016, 1:42 a.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo
> 
> Kai Uwe Broulik wrote:
> Yes, Hugo is doing a fine job of maintaining Oxygen stuff and 
> cherry-picking fixes from Breeze. :) It's really just the Plasma theme that 
> is utterly broken and unmaintained.
> 
> andreas kainz wrote:
> I'v never done a plasma theme but I saw how the breeze theme get broken 
> and how it was fixed again. As Hugo maintaine oxygen stuff and I maintain 
> oxygen icon stuff, it would be good to have the plasma theme also available. 
> I can offer to maintain the oxygen plasma theme (one of them).
> 
> Marco Martin wrote:
> oxygen icon or oxygen style repository? for me both would be good.
> 
> note that if you chose the oxygen look and feel it sets the oxygen widget 
> style and the Air plasma theme, that should be still the case.
> 
> Thomas Pfeiffer wrote:
> I'd say we need one theme to go with the Oxygen Look & Feel package. If 
> Air is still maintainted and used in the L, then killing Oxygen from our 
> repos should be fine.
> I'm against putting it on kde-look, however, because we don't want 
> unmaintained and broken stuff on there, either. kde-look currently is used 
> kind of as a junkyard by some, but this has to change if we want to showcase 
> it more.

I'm still of the opinion that it makes more sense to put everything Oxygen in 
one package; given that Oxygen is not the default theme for Plasma anymore we 
shouldn't ship it with the default look-n-feel package at all.


- Boudhayan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 2, 2016, 1 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 2, 2016, 1 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek


> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme

Then we got some fixing to do as this is how Air looks like here: 
http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
the controls)

I can file all these as bugs if you want.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   src/desktoptheme/air/widgets/dragger.svgz 3629591 
>   src/desktoptheme/air/widgets/extender-background.svgz 4003079 
>   src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
>   src/desktoptheme/air/widgets/frame.svgz 327c284 
>   src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---



maybe not oxygen, but i want to point out that i *do* maintain the Air theme

- Marco Martin


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   src/desktoptheme/air/widgets/dragger.svgz 3629591 
>   src/desktoptheme/air/widgets/extender-background.svgz 4003079 
>   src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
>   src/desktoptheme/air/widgets/frame.svgz 327c284 
>   src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
>   src/desktoptheme/air/widgets/identiconshapes.svgz 67fe725 
>   src/desktoptheme/air/widgets/identicontheme.svgz ad881cd 
>   src/desktoptheme/air/widgets/labeltexture.svgz f52a78d 
>   src/desktoptheme/air/widgets/line.svgz 70efca4 
>   src/desktoptheme/air/widgets/lineedit.svgz 22347db 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin


> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo
> 
> Kai Uwe Broulik wrote:
> Yes, Hugo is doing a fine job of maintaining Oxygen stuff and 
> cherry-picking fixes from Breeze. :) It's really just the Plasma theme that 
> is utterly broken and unmaintained.
> 
> andreas kainz wrote:
> I'v never done a plasma theme but I saw how the breeze theme get broken 
> and how it was fixed again. As Hugo maintaine oxygen stuff and I maintain 
> oxygen icon stuff, it would be good to have the plasma theme also available. 
> I can offer to maintain the oxygen plasma theme (one of them).

oxygen icon or oxygen style repository? for me both would be good.

note that if you chose the oxygen look and feel it sets the oxygen widget style 
and the Air plasma theme, that should be still the case.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread andreas kainz


> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo
> 
> Kai Uwe Broulik wrote:
> Yes, Hugo is doing a fine job of maintaining Oxygen stuff and 
> cherry-picking fixes from Breeze. :) It's really just the Plasma theme that 
> is utterly broken and unmaintained.

I'v never done a plasma theme but I saw how the breeze theme get broken and how 
it was fixed again. As Hugo maintaine oxygen stuff and I maintain oxygen icon 
stuff, it would be good to have the plasma theme also available. I can offer to 
maintain the oxygen plasma theme (one of them).


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek


> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?

@andreas - This is only about the Plasma theme, using different icons or window 
decoration has zero impact on the theme itself.

The Plasma theme has many broken things, here's a list of what I've noticed in 
just couple minutes:
* task manager buttons have too big margins; the icons are tiny and text is gone
* all button-based controls have strangely stretched bottom frame
* kicker has artifacts in the submenu corners that touch the parent menus
* the selection box in listviews is smaller than the items, making the icons in 
systray popup be painted outside of the selection rectangle
* placeholder text has no inner left padding on text inputs
* the blinking cursor in text inputs can be painted partially outside the input 
field
* sliders have artifacts in corners
* network manager has no selection painted on hover, it's missing quite a few 
graphical things it seems
* everything has a hge shadow (although that may be a feature)

...it's not just about setting the theme and looking at the default desktop and 
making a screenshot. You have to use it for a while.

These are all fixable, but given the last useful commit in air/ was June 2014, 
I had considered this as unmaintained.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin


> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.

one regression over Plasma4 for instance is that it used to remove panel border 
paddings even to 0 if needed if the panel size went less that allowing for a 
smallmedium icon to be displayed. Breeze just happens to have tiny margins but 
it's just a peculiarity of that theme. that should be restored.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin


> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.
> 
> Marco Martin wrote:
> I am willing to work on both of them, to fix the few objective bugs, but 
> most important to fix everything around it to have the behavior as identic as 
> possible.

> Look at the button or the checkbox in my screenshot, their bottom frame looks 
> huge.
I know, it's how is supposed to be, as the giant shadow.

there are only two actual bugs i can hee here or in the screenshot: that panel 
margins and the sliders grooves (tabbar indicators may also have a bit of extra 
side margins that shouldn't be there).
the rest you can say you don't like it, but it's how is supposed to look


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an 

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek


> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.

> what do you mean with the bottom frame of the controls?

Look at the button or the checkbox in my screenshot, their bottom frame looks 
huge.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin


> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.

many of those bugs are actually a symptom of bad compatibility with older 
themes (tough made worse by high dpi).
and this is actually a problem of plasma, as the compatibility of themes was, 
and still is a promise (and I had already had to modify things around in 
controls or plasmoids specifically to fix the look is some random old theme)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin


> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.

I am willing to work on both of them, to fix the few objective bugs, but most 
important to fix everything around it to have the behavior as identic as 
possible.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's 

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin


> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png

it's fine they are missing in the plasma themes, those themes were designed to 
have systray icons explicitly different (to change that, all of their icons can 
just be deleted and they will fallback)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek


> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)

Yeah, I figured hidpi probably makes these details much more exposed. Another 
thing to consider is the number of bug reports with old themes. I remember a 
single one, I don't think there were that many more. Which either means that 
nobody uses old themes or that all good themes were updated to Plasma 5 already 
(or that Breeze is just perfect).

Maybe Air and Oxygen should then just be updated to not be "old" anymore? I 
imagine that when theme creators tested the old themes against Plasma 5(.0/.1), 
it looked broken and so they went ahead and fixed it on their side.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz 

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread andreas kainz


> On Feb. 2, 2016, 9:17 vorm., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.

There are missing icons from the oxygen plasma theme and in the future also in 
oxygen-icons. I will work on this but without this the theme is not that broken 
as you show in the screenshot when you use everything from oxygen (plasma 
theme, icons, window decoration, ...) 
https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin


> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)

what do you mean with the bottom frame of the controls?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin


> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.
> 
> Marco Martin wrote:
> I am willing to work on both of them, to fix the few objective bugs, but 
> most important to fix everything around it to have the behavior as identic as 
> possible.
> 
> Marco Martin wrote:
> > Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> I know, it's how is supposed to be, as the giant shadow.
> 
> there are only two actual bugs i can hee here or in the screenshot: that 
> panel margins and the sliders grooves (tabbar indicators may also have a bit 
> of extra side margins that shouldn't be there).
> the rest you can say you don't like it, but it's how is supposed to look

so i would:

* fix the panel "decrease margins until icons are big enough" behavior that was 
implemented but broken

* do a couple of fixes in air of actual problems (already on my hard drive)

* remove custom icons in both themes

* fix another problem i found in push buttons because this is using the button 
shadow element, 

Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Martin Klapetek

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/
---

Review request for KDE Frameworks and Plasma.


Bugs: 358533
http://bugs.kde.org/show_bug.cgi?id=358533


Repository: plasma-framework


Description
---

They are untested, unmaintained and most importantly, broken.

Let's remove them from our releases and move them to kde-look.org for grabs.


Diffs
-

  src/desktoptheme/air/CMakeLists.txt 40ea382 
  src/desktoptheme/air/colors 5c4e53d 
  src/desktoptheme/air/dialogs/background.svgz 81ef460 
  src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
  src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
  src/desktoptheme/air/icons/amarok.svgz e3c157e 
  src/desktoptheme/air/icons/audio.svgz 540cc77 
  src/desktoptheme/air/icons/battery.svgz 88f864e 
  src/desktoptheme/air/icons/configure.svgz a433b3c 
  src/desktoptheme/air/icons/device.svgz 23df094 
  src/desktoptheme/air/icons/document.svgz 6e89dd8 
  src/desktoptheme/air/icons/edit.svgz d0e1ca4 
  src/desktoptheme/air/icons/go.svgz ad3a4b2 
  src/desktoptheme/air/icons/kget.svgz 1f1702f 
  src/desktoptheme/air/icons/klipper.svgz 4afd33c 
  src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
  src/desktoptheme/air/icons/konversation.svgz 376211a 
  src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
  src/desktoptheme/air/icons/korgac.svgz 8c8f700 
  src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
  src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
  src/desktoptheme/air/icons/list.svgz 0a25bb0 
  src/desktoptheme/air/icons/media.svgz 23653bd 
  src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
  src/desktoptheme/air/icons/network.svgz a8e8b16 
  src/desktoptheme/air/icons/notification.svgz db12260 
  src/desktoptheme/air/icons/preferences.svgz 12e6588 
  src/desktoptheme/air/icons/printer.svgz 199ab95 
  src/desktoptheme/air/icons/quassel.svgz b004749 
  src/desktoptheme/air/icons/slc.svgz 9fd376b 
  src/desktoptheme/air/icons/wallet.svgz 4ad3691 
  src/desktoptheme/air/icons/window.svgz eecc37f 
  src/desktoptheme/air/icons/zoom.svgz c159491 
  src/desktoptheme/air/metadata.desktop 0be4bd5 
  src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
  src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
  src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
  src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
  src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
  src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
  src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
  src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
  src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
  src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
  src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
  src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
  src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
  src/desktoptheme/air/widgets/arrows.svgz b987b32 
  src/desktoptheme/air/widgets/background.svgz 174a8fc 
  src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
  src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
  src/desktoptheme/air/widgets/branding.svgz c6316fb 
  src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
  src/desktoptheme/air/widgets/button.svgz 2c529bf 
  src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
  src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
  src/desktoptheme/air/widgets/clock.svgz 3839dac 
  src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
  src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
  src/desktoptheme/air/widgets/dragger.svgz 3629591 
  src/desktoptheme/air/widgets/extender-background.svgz 4003079 
  src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
  src/desktoptheme/air/widgets/frame.svgz 327c284 
  src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
  src/desktoptheme/air/widgets/identiconshapes.svgz 67fe725 
  src/desktoptheme/air/widgets/identicontheme.svgz ad881cd 
  src/desktoptheme/air/widgets/labeltexture.svgz f52a78d 
  src/desktoptheme/air/widgets/line.svgz 70efca4 
  src/desktoptheme/air/widgets/lineedit.svgz 22347db 
  src/desktoptheme/air/widgets/listitem.svgz ec7e89a 
  src/desktoptheme/air/widgets/media-delegate.svgz e28b313 
  src/desktoptheme/air/widgets/monitor.svgz 13a22fd 
  src/desktoptheme/air/widgets/pager.svgz 2dcbbcd 
  src/desktoptheme/air/widgets/panel-background.svgz 080a65d 
  src/desktoptheme/air/widgets/picker.svgz c15eb0e 
  src/desktoptheme/air/widgets/plot-background.svgz f4c7957 
  src/desktoptheme/air/widgets/scrollbar.svgz c0ea8f5 
  src/desktoptheme/air/widgets/scrollwidget.svgz 3281ad6 
  src/desktoptheme/air/widgets/slider.svgz 107e627 
  src/desktoptheme/air/widgets/systemtray.svgz 6e15351 
  

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91878
---


Ship it!




Ship It!

- David Edmundson


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   src/desktoptheme/air/widgets/dragger.svgz 3629591 
>   src/desktoptheme/air/widgets/extender-background.svgz 4003079 
>   src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
>   src/desktoptheme/air/widgets/frame.svgz 327c284 
>   src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
>   src/desktoptheme/air/widgets/identiconshapes.svgz 67fe725 
>   src/desktoptheme/air/widgets/identicontheme.svgz ad881cd 
>   src/desktoptheme/air/widgets/labeltexture.svgz f52a78d 
>   src/desktoptheme/air/widgets/line.svgz 70efca4 
>   src/desktoptheme/air/widgets/lineedit.svgz 22347db 
>   src/desktoptheme/air/widgets/listitem.svgz ec7e89a 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Martin Klapetek


> On Feb. 1, 2016, 9:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai

> in addition a lot of dev's make screenshots with oxygen so there is an user 
> group for oxygen.

Really? Got any examples?

> There'a an oxygen repository where the widget style and everything resides, 
> I'd say the Plasma theme would fit in there as well.


Ok, I'll put it there then.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread andreas kainz


> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.

can we add ALL oxygen stuff in one "unmaintained" area?


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread andreas kainz


> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.

in addition a lot of dev's make screenshots with oxygen so there is an user 
group for oxygen.


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Martin Klapetek


> On Feb. 1, 2016, 8:39 p.m., Boudhayan Gupta wrote:
> > +1
> > 
> > Ideally the default look-n-feel package should include only two themes - 
> > the default one and a high-contrast counterpart. In fact all other themes 
> > should reside elsewhere.
> > 
> > If we still want to "officially" provide Air and Oxygen, maybe we should 
> > move them to an extra-themes package instead instead of kde-look?

I have no preference as to where it gets moved. Maybe somewhere in git would be 
better in the end as it would preserve the history.

Imo if we still want to "officially" ship these two, they need to get some 
upgrade, cause at least on my hidpi they are kinda broken.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91874
---


On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91876
---



+1

- Kai Uwe Broulik


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   src/desktoptheme/air/widgets/dragger.svgz 3629591 
>   src/desktoptheme/air/widgets/extender-background.svgz 4003079 
>   src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
>   src/desktoptheme/air/widgets/frame.svgz 327c284 
>   src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
>   src/desktoptheme/air/widgets/identiconshapes.svgz 67fe725 
>   src/desktoptheme/air/widgets/identicontheme.svgz ad881cd 
>   src/desktoptheme/air/widgets/labeltexture.svgz f52a78d 
>   src/desktoptheme/air/widgets/line.svgz 70efca4 
>   src/desktoptheme/air/widgets/lineedit.svgz 22347db 
>   src/desktoptheme/air/widgets/listitem.svgz ec7e89a 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Kai Uwe Broulik


> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.

There'a an oxygen repository where the widget style and everything resides, I'd 
say the Plasma theme would fit in there as well.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Boudhayan Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91874
---



+1

Ideally the default look-n-feel package should include only two themes - the 
default one and a high-contrast counterpart. In fact all other themes should 
reside elsewhere.

If we still want to "officially" provide Air and Oxygen, maybe we should move 
them to an extra-themes package instead instead of kde-look?

- Boudhayan Gupta


On Feb. 2, 2016, 1 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 2, 2016, 1 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   src/desktoptheme/air/widgets/dragger.svgz 3629591 
>   src/desktoptheme/air/widgets/extender-background.svgz 4003079 
>   src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
>   src/desktoptheme/air/widgets/frame.svgz 327c284 
>   src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
>   src/desktoptheme/air/widgets/identiconshapes.svgz 67fe725 

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread andreas kainz

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---



Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
time I need the plasma oxygen theme too to give the user the one single click 
feature (look & feel package). Is there an space where you can move 
"unmaintained" stuff and the distros can choose what they want to ship. now all 
distros ship oxygen.

I love breeze but oxygen is also really sexy in addition a lot of uers work 
with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 LTS. It 
would be bad to support oxygen for an additional LTS cycle, but for the switch 
it would be nice to give the user the posibility for an soft switch.

- andreas kainz


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread andreas kainz


> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.

ok. that would fit for me. since now we have not that much look and feel 
packages most distros use it for there look and feel stuff and than breeze and 
breeze-dark for people how don't like monochrome (there are a lot) is oxygen. 
it would be nice to have more packages there available so move the oxygen stuff 
in an spacific area is fine for me but don't move them to kde-look cause than 
oxygen is more broken than now and no one can fix it any more.

thanks Kai


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Kai Uwe Broulik


> On Feb. 1, 2016, 7:39 nachm., Boudhayan Gupta wrote:
> > +1
> > 
> > Ideally the default look-n-feel package should include only two themes - 
> > the default one and a high-contrast counterpart. In fact all other themes 
> > should reside elsewhere.
> > 
> > If we still want to "officially" provide Air and Oxygen, maybe we should 
> > move them to an extra-themes package instead instead of kde-look?
> 
> Martin Klapetek wrote:
> I have no preference as to where it gets moved. Maybe somewhere in git 
> would be better in the end as it would preserve the history.
> 
> Imo if we still want to "officially" ship these two, they need to get 
> some upgrade, cause at least on my hidpi they are kinda broken.

I'd say Light, Dark, and high-contrast which we don't have.

Imho we should turn Air/Oxygen back into their 4.x form since at the moment 
they have quite ugly looking tray icons and Kickoff tabs that were used as a 
testing ground for auto-coloring icons, also Task Manager looks rather borked


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91874
---


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Hugo Pereira Da Costa


> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?

Wait wait, neither oxygen widget style nor window decoration are unmaintained. 
(nor broken as far as I know)
They are in "maintenance" mode on the contrary. Meaning: they are "done", there 
won't be any new feature, but bugs get fixed when reported. 
Please 
- dont move them anywhere else,
- dont move broken, nor truely unmaintained things in there.
This is not a trash can :)

Thx,

Hugo


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread David Edmundson


> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.

Andreas, note the oxygen widget style and plasma theme are different things. 
The Oxygen plasma style is this theme: 
https://www.kde.org/announcements/4.0/screenshots/desktop.jpg

the widget style isn't being touched.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>