Re: Review Request 127469: Use QQuickWidget for QML KCMs

[David Rosca]

> On July 2, 2016, 8:26 a.m., David Faure wrote:
> > src/kcmoduleqml.cpp, line 112
> > 
> >
> > This line breaks compilation with Qt 5.4 (quickWindow() doesn't exist).
> > 
> > 
> > http://ci-logs.kde.flaska.net/d4/d42402a0b5581707d019bb9db0b074b1775083a1/rebuilddep/rebuilddep-kf5-qt54-gcc-el7/b301f2c/shell_output.log

https://git.reviewboard.kde.org/r/128340/


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127469/#review97002
---


On May 20, 2016, 1:33 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127469/
> ---
> 
> (Updated May 20, 2016, 1:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 359124
> https://bugs.kde.org/show_bug.cgi?id=359124
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> Fix position of QtQuickControls popups.
> 
> BUG: 359124
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 60cf4bb 
>   src/CMakeLists.txt 58352f6 
>   src/kcmoduleqml.cpp c52769b 
> 
> Diff: https://git.reviewboard.kde.org/r/127469/diff/
> 
> 
> Testing
> ---
> 
> Popups are now in correct position in systemsettings and kcmshell
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127469: Use QQuickWidget for QML KCMs

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127469/#review97002
---




src/kcmoduleqml.cpp (line 112)


This line breaks compilation with Qt 5.4 (quickWindow() doesn't exist).


http://ci-logs.kde.flaska.net/d4/d42402a0b5581707d019bb9db0b074b1775083a1/rebuilddep/rebuilddep-kf5-qt54-gcc-el7/b301f2c/shell_output.log


- David Faure


On May 20, 2016, 1:33 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127469/
> ---
> 
> (Updated May 20, 2016, 1:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 359124
> https://bugs.kde.org/show_bug.cgi?id=359124
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> Fix position of QtQuickControls popups.
> 
> BUG: 359124
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 60cf4bb 
>   src/CMakeLists.txt 58352f6 
>   src/kcmoduleqml.cpp c52769b 
> 
> Diff: https://git.reviewboard.kde.org/r/127469/diff/
> 
> 
> Testing
> ---
> 
> Popups are now in correct position in systemsettings and kcmshell
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127469: Use QQuickWidget for QML KCMs

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127469/
---

(Updated May 20, 2016, 3:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 23b6468fc2486516711ba4ce50f3492fd231d50e by David Rosca 
to branch master.


Bugs: 359124
https://bugs.kde.org/show_bug.cgi?id=359124


Repository: kcmutils


Description
---

Fix position of QtQuickControls popups.

BUG: 359124


Diffs
-

  CMakeLists.txt 60cf4bb 
  src/CMakeLists.txt 58352f6 
  src/kcmoduleqml.cpp c52769b 

Diff: https://git.reviewboard.kde.org/r/127469/diff/


Testing
---

Popups are now in correct position in systemsettings and kcmshell


Thanks,

David Rosca

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127469: Use QQuickWidget for QML KCMs

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127469/#review95608
---


Ship it!




I suggest we try it, then see if there are any reports of problems

- Marco Martin


On March 23, 2016, 10:29 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127469/
> ---
> 
> (Updated March 23, 2016, 10:29 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 359124
> https://bugs.kde.org/show_bug.cgi?id=359124
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> Fix position of QtQuickControls popups.
> 
> BUG: 359124
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 60cf4bb 
>   src/CMakeLists.txt 58352f6 
>   src/kcmoduleqml.cpp c52769b 
> 
> Diff: https://git.reviewboard.kde.org/r/127469/diff/
> 
> 
> Testing
> ---
> 
> Popups are now in correct position in systemsettings and kcmshell
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127469: Use QQuickWidget for QML KCMs

[David Rosca]

> On March 23, 2016, 12:07 p.m., Marco Martin wrote:
> > In theory using QQuickWidget is the correct way, but...
> > That widget is really not reliable, it has a structural (and probably 
> > unfixable at least on x11) problem in which anybody calling winId() 
> > anywhere on any window on the application will turn all QQuickWidgets in 
> > black rectangles for the whole application lifecycle.
> > 
> > since systemsettings loads a lot of random c++ code from plugins, we can't 
> > ensure this will not happen.
> 
> Aleix Pol Gonzalez wrote:
> Maybe QQuickWidget can be fixed? If it works here, there must be a way to 
> get QQuickWidget to work.

It only turns black when calling winId() on the QQuickWidget, calling it on any 
other widgets is not an issue (in this case 
Qt::AA_DontCreateNativeWidgetSiblings probably helps, but it seems to work fine 
even without it).
We can't ensure it won't happen, but it is highly unlikely as this QQuickWidget 
is not a window.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127469/#review93895
---


On March 23, 2016, 10:29 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127469/
> ---
> 
> (Updated March 23, 2016, 10:29 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 359124
> https://bugs.kde.org/show_bug.cgi?id=359124
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> Fix position of QtQuickControls popups.
> 
> BUG: 359124
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 60cf4bb 
>   src/CMakeLists.txt 58352f6 
>   src/kcmoduleqml.cpp c52769b 
> 
> Diff: https://git.reviewboard.kde.org/r/127469/diff/
> 
> 
> Testing
> ---
> 
> Popups are now in correct position in systemsettings and kcmshell
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127469: Use QQuickWidget for QML KCMs

[Aleix Pol Gonzalez]

> On March 23, 2016, 1:07 p.m., Marco Martin wrote:
> > In theory using QQuickWidget is the correct way, but...
> > That widget is really not reliable, it has a structural (and probably 
> > unfixable at least on x11) problem in which anybody calling winId() 
> > anywhere on any window on the application will turn all QQuickWidgets in 
> > black rectangles for the whole application lifecycle.
> > 
> > since systemsettings loads a lot of random c++ code from plugins, we can't 
> > ensure this will not happen.

Maybe QQuickWidget can be fixed? If it works here, there must be a way to get 
QQuickWidget to work.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127469/#review93895
---


On March 23, 2016, 11:29 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127469/
> ---
> 
> (Updated March 23, 2016, 11:29 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 359124
> https://bugs.kde.org/show_bug.cgi?id=359124
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> Fix position of QtQuickControls popups.
> 
> BUG: 359124
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 60cf4bb 
>   src/CMakeLists.txt 58352f6 
>   src/kcmoduleqml.cpp c52769b 
> 
> Diff: https://git.reviewboard.kde.org/r/127469/diff/
> 
> 
> Testing
> ---
> 
> Popups are now in correct position in systemsettings and kcmshell
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127469: Use QQuickWidget for QML KCMs

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127469/#review93895
---



In theory using QQuickWidget is the correct way, but...
That widget is really not reliable, it has a structural (and probably unfixable 
at least on x11) problem in which anybody calling winId() anywhere on any 
window on the application will turn all QQuickWidgets in black rectangles for 
the whole application lifecycle.

since systemsettings loads a lot of random c++ code from plugins, we can't 
ensure this will not happen.

- Marco Martin


On March 23, 2016, 10:29 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127469/
> ---
> 
> (Updated March 23, 2016, 10:29 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 359124
> https://bugs.kde.org/show_bug.cgi?id=359124
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> Fix position of QtQuickControls popups.
> 
> BUG: 359124
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 60cf4bb 
>   src/CMakeLists.txt 58352f6 
>   src/kcmoduleqml.cpp c52769b 
> 
> Diff: https://git.reviewboard.kde.org/r/127469/diff/
> 
> 
> Testing
> ---
> 
> Popups are now in correct position in systemsettings and kcmshell
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127469: Use QQuickWidget for QML KCMs

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127469/
---

(Updated March 23, 2016, 10:29 a.m.)


Review request for KDE Frameworks.


Changes
---

Bring back the ifdef


Bugs: 359124
https://bugs.kde.org/show_bug.cgi?id=359124


Repository: kcmutils


Description (updated)
---

Fix position of QtQuickControls popups.

BUG: 359124


Diffs (updated)
-

  CMakeLists.txt 60cf4bb 
  src/CMakeLists.txt 58352f6 
  src/kcmoduleqml.cpp c52769b 

Diff: https://git.reviewboard.kde.org/r/127469/diff/


Testing
---

Popups are now in correct position in systemsettings and kcmshell


Thanks,

David Rosca

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127469: Use QQuickWidget for QML KCMs

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127469/
---

Review request for KDE Frameworks.


Bugs: 359124
https://bugs.kde.org/show_bug.cgi?id=359124


Repository: kcmutils


Description
---

Fix position of QtQuickControls popups.
Also remove ifdef for Qt 5.4

BUG: 359124


Diffs
-

  CMakeLists.txt 60cf4bb 
  src/CMakeLists.txt 58352f6 
  src/kcmoduleqml.cpp c52769b 

Diff: https://git.reviewboard.kde.org/r/127469/diff/


Testing
---

Popups are now in correct position in systemsettings and kcmshell


Thanks,

David Rosca

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel