Re: How do you find the git repository for a given differential?
Mark Gaiser ha scritto: > Hi, > > For instance, take this differential [1]. > Now i found the repository (plasma-integration in that specific case), > but i always [2] have trouble finding the repository. It doesn't seem > to be stated anywhere in a differential. It is, if the submitter use arcanist, or if the submitter remembers to specify it. Just please as I do and ask the submitter to specify the repository. Please remember to check if the data (name/email) of the submitter are in the patch that you are going to submit (which does not work automatically when arcanist is not used, so you need to do a git commit --author...). -- Luigi
D5656: Adds method to force the reloading of a document
cullmann added a comment. You can add the function as non-virtual one. Then call the right one of the d pointer, like we do for other new introduced view stuff: KTextEditor::Cursor View::maxScrollPosition() const { return d->maxScrollPositionInternal(); } Its bit ugly, as you have to do that manually but its BC. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5656 To: pedroarthurp, dfaure, brauch, dhaumann, cullmann Cc: nalvarez, kwrite-devel, #frameworks
How do you find the git repository for a given differential?
Hi, For instance, take this differential [1]. Now i found the repository (plasma-integration in that specific case), but i always [2] have trouble finding the repository. It doesn't seem to be stated anywhere in a differential. How do you folks find the right repository for a given differential? Cheers, Mark [1] https://phabricator.kde.org/D5538 [2] I usually do find it with some common sense. But often it required searching through some repositories before finding the right ones.
Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros
> On May 4, 2017, 12:40 p.m., Albert Astals Cid wrote: > > Lamarque, you broke the build. > > Lamarque Souza wrote: > Fixed. Thanks for the quick report about the broken build and sorry for > not adding all files to the commit. > > Ben Cooksley wrote: > This patch broke the MSVC build and will be reverted shortly. > Please see > https://build-sandbox.kde.org/job/Frameworks%20solid%20kf5-qt5%20WindowsQt5.7/2/consoleText > for the build log. Well, the simpler solution is removing all those #if, #include and #error clauses (lines 31 oto 39 of autotests/solidudisks2test.cpp), they are not required. I do not have a MSVC machine with frameworks installed to test that now. I will test that after next frameworks release. - Lamarque --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/#review103182 --- On May 4, 2017, 12:32 p.m., KJ Tsanaktsidis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130090/ > --- > > (Updated May 4, 2017, 12:32 p.m.) > > > Review request for KDE Frameworks. > > > Repository: solid > > > Description > --- > > Previously, udesksblock.cpp was attempting to find a definition for > major/minor on Linux in by checking Q_OS_LINUX before > importing the header. Q_OS_LINUX is however only set when > qsystemdetection.h is included, and the macro was being checked first. > > Even had this check worked, it would still be wrong. On a modern version > of the userspace linux-headers, includes definitions for > major and minor that assume each is limited to 8 bits and that dev_t is > 16 bits. This is no longer true anymore; on Linux, major numbers can be > up to 12 bits at present and minor numbers up to 20. Calling these > macros with dev_t values > 2^16 would give incorrect results. > > Because the Q_OS_LINUX check failed, a fallback version of the macros > were defined for use on all platforms. The code is allegedly copied from > kdev_t.h, except it is copied from the *kernel* version of the header, > not the userspace version. Linux internally uses a different > representation of dev_t than it exposes to userspace - the kernelspace > version is 20 bits of minor/12 bits of major contiguously, but the > userspace version packs the bits in a different order to maintain > compatability with old 16-bit device numbers. Thus, this code also does > not work for dev_t values > 2^16. > > To fix this, we add CMake rules to search for a system-provided > definition of the major/minor macros - on various systems, these can be > in a few different places. As a fallback, we assume old-style 16-bit > dev_t (although I suspect that is only used for Windows, where > major/minor numbers are pretty meaningless anyway). > > > Diffs > - > > autotests/CMakeLists.txt 54adeea62b954b9169b37f1eab8fa3e215fafafa > autotests/fakeUdisks2.h PRE-CREATION > autotests/fakeUdisks2.cpp PRE-CREATION > autotests/solidudisks2test.cpp PRE-CREATION > src/solid/devices/backends/udisks2/CMakeLists.txt > 34390064af29ace07cbb3470945be098cc606d04 > src/solid/devices/backends/udisks2/udisksblock.cpp > 0622ec77fcf670a2005d34b7a6c31ca8b53a18d8 > > Diff: https://git.reviewboard.kde.org/r/130090/diff/ > > > Testing > --- > > I've written a little snippet to iterate through block devices, print their > major/minor number, and their device properties. It was previously > incorrectly labeling all my disks with major 0 and minor == device_number > (since it was using the first 20 bits for the minor). It now correctly > identifies their major/minor number. > > > Thanks, > > KJ Tsanaktsidis > >
D5747: add pid to plasma window management protocol
hein added a dependent revision: D5756: Set pid on the ClientConnection backing the PlasmaWindow surface.. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma, hein, graesslin Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
Re: How do you find the git repository for a given differential?
On Sun, May 7, 2017 at 2:56 PM, Luigi Toscanowrote: > Mark Gaiser ha scritto: >> Hi, >> >> For instance, take this differential [1]. >> Now i found the repository (plasma-integration in that specific case), >> but i always [2] have trouble finding the repository. It doesn't seem >> to be stated anywhere in a differential. > > It is, if the submitter use arcanist, or if the submitter remembers to specify > it. Just please as I do and ask the submitter to specify the repository. > Great, thank you. > > Please remember to check if the data (name/email) of the submitter are in the > patch that you are going to submit (which does not work automatically when > arcanist is not used, so you need to do a git commit --author...). That's neat! Didn't knew that either. I would've added these lines: CCMAIL: Differential Revision: https://phabricator.kde.org/D5538 But I will commit with --author now that i know about it.
D5741: Fix test when compiling from a tarball
apol created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY Otherwise it doesn't work when falling back to the project name. TEST PLAN Ran the test locally with and without .git directory REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5741 AFFECTED FILES tests/KDEFetchTranslations/CMakeLists.txt To: apol, #frameworks, joselema Cc: #build_system
D5741: Fix test when compiling from a tarball
apol added a reviewer: sitter. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5741 To: apol, #frameworks, joselema, sitter Cc: #build_system
D5638: Use a single QNAM (and a disk cache) for HTTP jobs
leinir marked 4 inline comments as done. leinir added inline comments. INLINE COMMENTS > dfaure wrote in httpworker.cpp:41 > 0.1% of the partition size is a rather arbitrary value, no? It could go from > something very tiny to something really big... > > On my 470GB partition this would lead to a 470MB cache for knewstuff, that's > maybe a bit much, given the average size for knewstuff stuff? Maybe a qMin() > call with a maximum value would be useful? Good point yes, it's supposed to be helpful, not take over the system. I'll set a max of 50 megs, should be fine for most uses. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5638 To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks
D5639: Internal cache for provider data on initialisation
leinir updated this revision to Diff 14243. leinir added a comment. Static var naming change, for consistency and whatnot REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5639?vs=14236=14243 REVISION DETAIL https://phabricator.kde.org/D5639 AFFECTED FILES src/core/engine.cpp src/core/jobs/httpjob.cpp To: leinir, whiting, apol Cc: dfaure, #frameworks
D5639: Internal cache for provider data on initialisation
leinir added inline comments. INLINE COMMENTS > dfaure wrote in engine.cpp:58 > The uppercase first letter on variable name is unusual. > > I personally use a s_ prefix for static vars. Hmm. Right, there is no established way of naming them in KNS already, so while i am not personally so keen on underscores in my variable names, static vars are already sort of ugly, and so going with the "ugly things should look a bit ugly" that stoustrup suggests for c++ things, i kind of like that :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5639 To: leinir, whiting, apol Cc: dfaure, #frameworks
D5638: Use a single QNAM (and a disk cache) for HTTP jobs
leinir updated this revision to Diff 14244. leinir added a comment. Work some numbers a bit REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5638?vs=14242=14244 REVISION DETAIL https://phabricator.kde.org/D5638 AFFECTED FILES src/core/jobs/httpworker.cpp src/core/jobs/httpworker.h To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks
Jenkins-kde-ci: kcompletion master kf5-qt5 » Linux,gcc - Build # 239 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcompletion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/239/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 07 May 2017 18:36:36 + Build duration: 5 min 56 sec CHANGE SET No changes
Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 272 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/272/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 07 May 2017 18:46:47 + Build duration: 3 min 20 sec CHANGE SET No changes
Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 273 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/273/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 07 May 2017 21:29:33 + Build duration: 53 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 439/570 (77%)CONDITIONAL 128/247 (52%) By packages autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 114/114 (100%)CONDITIONAL 41/78 (53%) src FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 325/456 (71%)CONDITIONAL 87/169 (51%)
Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 273 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/273/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 07 May 2017 21:29:33 + Build duration: 53 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 439/570 (77%)CONDITIONAL 128/247 (52%) By packages autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 114/114 (100%)CONDITIONAL 41/78 (53%) src FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 325/456 (71%)CONDITIONAL 87/169 (51%)
Jenkins-kde-ci: kcompletion master kf5-qt5 » Linux,gcc - Build # 240 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcompletion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/240/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 07 May 2017 21:25:21 + Build duration: 3 min 38 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 21/24 (88%)CLASSES 21/24 (88%)LINE 1982/3232 (61%)CONDITIONAL 982/2367 (41%) By packages autotests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 528/528 (100%)CONDITIONAL 297/590 (50%) src FILES 16/19 (84%)CLASSES 16/19 (84%)LINE 1454/2704 (54%)CONDITIONAL 685/1777 (39%)
Jenkins-kde-ci: kcompletion master kf5-qt5 » Linux,gcc - Build # 240 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcompletion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/240/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 07 May 2017 21:25:21 + Build duration: 3 min 38 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 21/24 (88%)CLASSES 21/24 (88%)LINE 1982/3232 (61%)CONDITIONAL 982/2367 (41%) By packages autotests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 528/528 (100%)CONDITIONAL 297/590 (50%) src FILES 16/19 (84%)CLASSES 16/19 (84%)LINE 1454/2704 (54%)CONDITIONAL 685/1777 (39%)
Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros
> On May 4, 2017, 12:40 p.m., Albert Astals Cid wrote: > > Lamarque, you broke the build. > > Lamarque Souza wrote: > Fixed. Thanks for the quick report about the broken build and sorry for > not adding all files to the commit. > > Ben Cooksley wrote: > This patch broke the MSVC build and will be reverted shortly. > Please see > https://build-sandbox.kde.org/job/Frameworks%20solid%20kf5-qt5%20WindowsQt5.7/2/consoleText > for the build log. > > Lamarque Souza wrote: > Well, the simpler solution is removing all those #if, #include and #error > clauses (lines 31 oto 39 of autotests/solidudisks2test.cpp), they are not > required. I do not have a MSVC machine with frameworks installed to test that > now. I will test that after next frameworks release. They're needed to actually find the right header file to include for these macros on the various BSD's I think. Actually I think we should just disable this test for windows, this feature is totally meaningless on windows. Another hacky option is to code in the fallback macros (including makedev) in solidudisks2test.cpp in the same way they are defined in udisksblock.cpp, which will probably make that test compile and "work". It wouldn't really be testing anything on windows though. The original reason I put the #error case in that test was to make sure we found out if there was some platform that was supposed to be supported that didn't have these macros in any of the places I looked for them. I guess we found out. - KJ --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/#review103182 --- On May 4, 2017, 12:32 p.m., KJ Tsanaktsidis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130090/ > --- > > (Updated May 4, 2017, 12:32 p.m.) > > > Review request for KDE Frameworks. > > > Repository: solid > > > Description > --- > > Previously, udesksblock.cpp was attempting to find a definition for > major/minor on Linux in by checking Q_OS_LINUX before > importing the header. Q_OS_LINUX is however only set when > qsystemdetection.h is included, and the macro was being checked first. > > Even had this check worked, it would still be wrong. On a modern version > of the userspace linux-headers, includes definitions for > major and minor that assume each is limited to 8 bits and that dev_t is > 16 bits. This is no longer true anymore; on Linux, major numbers can be > up to 12 bits at present and minor numbers up to 20. Calling these > macros with dev_t values > 2^16 would give incorrect results. > > Because the Q_OS_LINUX check failed, a fallback version of the macros > were defined for use on all platforms. The code is allegedly copied from > kdev_t.h, except it is copied from the *kernel* version of the header, > not the userspace version. Linux internally uses a different > representation of dev_t than it exposes to userspace - the kernelspace > version is 20 bits of minor/12 bits of major contiguously, but the > userspace version packs the bits in a different order to maintain > compatability with old 16-bit device numbers. Thus, this code also does > not work for dev_t values > 2^16. > > To fix this, we add CMake rules to search for a system-provided > definition of the major/minor macros - on various systems, these can be > in a few different places. As a fallback, we assume old-style 16-bit > dev_t (although I suspect that is only used for Windows, where > major/minor numbers are pretty meaningless anyway). > > > Diffs > - > > autotests/CMakeLists.txt 54adeea62b954b9169b37f1eab8fa3e215fafafa > autotests/fakeUdisks2.h PRE-CREATION > autotests/fakeUdisks2.cpp PRE-CREATION > autotests/solidudisks2test.cpp PRE-CREATION > src/solid/devices/backends/udisks2/CMakeLists.txt > 34390064af29ace07cbb3470945be098cc606d04 > src/solid/devices/backends/udisks2/udisksblock.cpp > 0622ec77fcf670a2005d34b7a6c31ca8b53a18d8 > > Diff: https://git.reviewboard.kde.org/r/130090/diff/ > > > Testing > --- > > I've written a little snippet to iterate through block devices, print their > major/minor number, and their device properties. It was previously > incorrectly labeling all my disks with major 0 and minor == device_number > (since it was using the first 20 bits for the minor). It now correctly > identifies their major/minor number. > > > Thanks, > > KJ Tsanaktsidis > >
D5638: Use a single QNAM (and a disk cache) for HTTP jobs
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5638 To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks
D5745: recreate plasmashellsurf on exposed, destoy on hidden
mart updated this revision to Diff 14247. mart added a comment. - don't return false REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5745?vs=14246=14247 BRANCH phab/recreateshell REVISION DETAIL https://phabricator.kde.org/D5745 AFFECTED FILES src/declarativeimports/core/tooltipdialog.cpp src/plasmaquick/dialog.cpp To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5747: add pid to plasma window management protocol
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please also extend the autotests/client/test_wayland_windowmanagement.cpp INLINE COMMENTS > plasmawindowmanagement.h:385 > + * @returns The process id this window belongs to. > + * @see virtualDesktopChangeableChanged > + * @since 5.35 copy and paste error > plasmawindowmanagement.h:481 > + * @see pid > + **/ > +void pidChanged(); "@since" missing REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma, hein, graesslin Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
D5638: Use a single QNAM (and a disk cache) for HTTP jobs
leinir marked 2 inline comments as done. leinir added inline comments. INLINE COMMENTS > dfaure wrote in httpworker.cpp:41 > 50 bytes? isn't that a bit small? :) Yes, yes it is ;) > dfaure wrote in httpworker.cpp:57 > the uppercase first letter is weird, for a variable. Good point, yes. Not very Qt REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5638 To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks
D5745: recreate plasmashellsurf on exposed, destoy on hidden
davidedmundson added inline comments. INLINE COMMENTS > dialog.cpp:1123 > if (event->type() == QEvent::Expose) { > -// FIXME TODO: We can remove this once we depend on Qt 5.6.1+. > -// See: https://bugreports.qt.io/browse/QTBUG-26978 > -KWindowSystem::setState(winId(), NET::SkipTaskbar | NET::SkipPager); > +if (!d->shellSurface) { > +KWindowSystem::setState(winId(), NET::SkipTaskbar | > NET::SkipPager); we also get an expose on hide, but with a null region. Can you add: auto ee = static_cast(event); +if (ee->region().isNull()) { +return false; +} REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5745 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5741: Fix test when compiling from a tarball
This revision was automatically updated to reflect the committed changes. Closed by commit R240:94056e2e4629: Fix test when compiling from a tarball (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5741?vs=14229=14248 REVISION DETAIL https://phabricator.kde.org/D5741 AFFECTED FILES tests/KDEFetchTranslations/CMakeLists.txt To: apol, #frameworks, joselema, sitter Cc: #build_system
D5747: add pid to plasma window management protocol
sebas created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This patch adds a pid event to the plasma window management protocol. It allows the compositor to tell allow a mapping between windows and processes. Bumps the version number of the interface to 8 to indicate this. TEST PLAN autotest added, passed REPOSITORY R127 KWayland BRANCH sebas/processid REVISION DETAIL https://phabricator.kde.org/D5747 AFFECTED FILES autotests/client/test_plasma_window_model.cpp src/client/plasmawindowmanagement.cpp src/client/plasmawindowmanagement.h src/client/plasmawindowmodel.cpp src/client/plasmawindowmodel.h src/client/protocols/plasma-window-management.xml src/server/plasmawindowmanagement_interface.cpp src/server/plasmawindowmanagement_interface.h To: sebas, #plasma, hein, graesslin Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
D5747: add pid to plasma window management protocol
davidedmundson added inline comments. INLINE COMMENTS > plasma-window-management.xml:267 > + > + > + uint is a native type: https://wayland.freedesktop.org/docs/html/ch04.html#sect-Protocol-Wire-Format you don't need to do an implicit cast REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma, hein, graesslin Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
D5741: Fix test when compiling from a tarball
sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5741 To: apol, #frameworks, joselema, sitter Cc: #build_system
D5739: Improve some error messages
This revision was automatically updated to reflect the committed changes. Closed by commit R304:f72a417aecd0: Improve some error messages (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5739?vs=14226=14230 REVISION DETAIL https://phabricator.kde.org/D5739 AFFECTED FILES src/attica/atticaprovider.cpp src/core/engine.cpp To: apol, #frameworks, whiting, leinir
D5639: Internal cache for provider data on initialisation
leinir marked 3 inline comments as done. leinir added inline comments. INLINE COMMENTS > dfaure wrote in engine.cpp:206 > This connect (and the following) could be done outside of the if/else, so > avoid being repeated, no? > Or is there a risk that load() will emit those signals immediately? Normally yes, it would potentially return immediately... However, it makes sense for the get job to be postponed just slightly (it's logically an async thing anyway), so that is what HTTPJob now does, and we can simplify this code muchly. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5639 To: leinir, whiting, apol Cc: dfaure, #frameworks
D5638: Use a single QNAM (and a disk cache) for HTTP jobs
leinir updated this revision to Diff 14235. leinir marked an inline comment as done. leinir added a comment. Some style fixes, and set a reasonable maximum size for the cache REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5638?vs=14146=14235 REVISION DETAIL https://phabricator.kde.org/D5638 AFFECTED FILES src/core/jobs/httpworker.cpp src/core/jobs/httpworker.h To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks
D5745: recreate plasmashellsurf on exposed, destoy on hidden
mart updated this revision to Diff 14246. mart added a comment. - check null region REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5745?vs=14241=14246 BRANCH phab/recreateshell REVISION DETAIL https://phabricator.kde.org/D5745 AFFECTED FILES src/declarativeimports/core/tooltipdialog.cpp src/plasmaquick/dialog.cpp To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5639: Internal cache for provider data on initialisation
leinir updated this revision to Diff 14236. leinir marked an inline comment as done. leinir added a comment. Simplify the xmlloader cache logic a touch REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5639?vs=14080=14236 REVISION DETAIL https://phabricator.kde.org/D5639 AFFECTED FILES src/core/engine.cpp src/core/jobs/httpjob.cpp To: leinir, whiting, apol Cc: dfaure, #frameworks
D5745: recreate plasmashellsurf on exposed, destoy on hidden
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY every time the window gets shown the wayland surfaces get created, when hidden, they get destroyed showevent is too early for it as they aren't there yet, use :Exposed instead, but only the first time when the surface isn't there yet TEST PLAN popup applets always have correct blur in a wayland session REPOSITORY R242 Plasma Framework (Library) BRANCH phab/recreateshell REVISION DETAIL https://phabricator.kde.org/D5745 AFFECTED FILES src/declarativeimports/core/tooltipdialog.cpp src/plasmaquick/dialog.cpp To: mart, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5638: Use a single QNAM (and a disk cache) for HTTP jobs
dfaure added a comment. 5 is 50kB. You wrote 50 megs which would be 5000 or 50*1024*1024. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5638 To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks
D5638: Use a single QNAM (and a disk cache) for HTTP jobs
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > httpworker.cpp:41 > +QStorageInfo storageInfo(cacheLocation); > +cache.setMaximumCacheSize(qMin(50, (int)(storageInfo.bytesTotal() / > 1000))); > +nam.setCache(); 50 bytes? isn't that a bit small? :) > httpworker.cpp:57 > + > +Q_GLOBAL_STATIC(HTTPWorkerNAM, NetworkManager) > the uppercase first letter is weird, for a variable. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5638 To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks
D5739: Improve some error messages
apol created this revision. Restricted Application added a project: Frameworks. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D5739 AFFECTED FILES src/attica/atticaprovider.cpp src/core/engine.cpp To: apol, #frameworks, whiting, leinir
D5739: Improve some error messages
leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D5739 To: apol, #frameworks, whiting, leinir
D5639: Internal cache for provider data on initialisation
dfaure added a comment. Looks simpler indeed. INLINE COMMENTS > engine.cpp:58 > +typedef QHashEngineProviderLoaderHash; > +Q_GLOBAL_STATIC(QThreadStorage, > EngineProviderLoaders) > + The uppercase first letter on variable name is unusual. I personally use a s_ prefix for static vars. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5639 To: leinir, whiting, apol Cc: dfaure, #frameworks
D5639: Internal cache for provider data on initialisation
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5639 To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks
D5638: Use a single QNAM (and a disk cache) for HTTP jobs
leinir added a comment. In https://phabricator.kde.org/D5638#107645, @dfaure wrote: > 5 is 50kB. > You wrote 50 megs which would be 5000 or 50*1024*1024. Yes, i certainly did. I should remember to drink less caffeine sometimes. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5638 To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks
D5747: add pid to plasma window management protocol
hein added a dependent revision: D5755: Expose PlasmaWindow::pid through WaylandTasksModel.. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma, hein, graesslin Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 552 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/552/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 08 May 2017 02:14:07 + Build duration: 20 min CHANGE SET Revision 1740cf4febb7ed719081b8845b3c58a4fdb8a945 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit src/kioexec/kioexecd.json JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiocore-threadtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 22/22 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29970/51989 (58%)CONDITIONAL 16422/39055 (42%) By packages autotests FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7934/8253 (96%)CONDITIONAL 4431/8672 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8124/14183 (57%)CONDITIONAL 4450/9267 (48%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3465/7562 (46%)CONDITIONAL 1293/4381 (30%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 330/749 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3781 (47%)CONDITIONAL 1266/3462 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.remote FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 14/200 (7%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 (63%)CONDITIONAL 420/851 (49%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 461/970 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 146/256 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3673/11070 (33%)CONDITIONAL 1765/7138 (25%)
Jenkins-kde-ci: kactivities-stats master kf5-qt5 » Linux,gcc - Build # 572 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kactivities-stats%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/572/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 08 May 2017 02:53:02 + Build duration: 4.4 sec CHANGE SET No changes
Jenkins-kde-ci: kactivities-stats master stable-kf5-qt5 » Linux,gcc - Build # 566 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kactivities-stats%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/566/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 08 May 2017 03:06:54 + Build duration: 4.9 sec CHANGE SET No changes