D28033: Create ExpandableListItem

[Niccolò Venerandi]

niccolove added a comment.


  Strongly agree on having a single component. By the way, all these lists have 
the issue that the button only appearing on hover is very touch-unfriendly. 
This does not have to be addressed in this patch, but it having it implemented 
in only one place makes it much easier to fix.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77588.
niccolove added a comment.


  Fixed inset

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=77482&id=77588

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir

To: niccolove, mart, ngraham
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove added a comment.


  Works for me!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart, ngraham
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27444: Added plasmoid heading svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77622.
niccolove added a comment.


  - Merge branch 'master' into top_area

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=77407&id=77622

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/qmldir
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added plasmoid heading svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77623.
niccolove added a comment.


  Merge with master pt2

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=77622&id=77623

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added plasmoid heading svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77624.
niccolove added a comment.


  Made opacity consistent

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=77623&id=77624

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added plasmoid heading svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77625.
niccolove added a comment.


  Polish

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=77624&id=77625

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7d80f01c3162: WIP: Create a new TopArea element using 
widgets/toparea svg (authored by niccolove).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=77588&id=77627

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir

To: niccolove, mart, ngraham
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27444: Added plasmoid heading svg

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f55f1044479a: Added plasmoid heading svg (authored by 
niccolove).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=77625&id=77626

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28033: Create ExpandableListItem

[Niccolò Venerandi]

niccolove added a comment.


  AFAIK, there should be a easy way to add animations to the highlight effect. 
An example is the print one, where clicking on it will animate the highlight. 
It should also be possible to make the highlight effect fly over elements 
instead of always being on the hovered element. Not a must for this patch, but 
it could be nice to have.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove added a comment.


  I'll make this patch again, as much has change since then, there are things 
I'd do differently, and I'm not a fan of rebasing svg files. I will post the 
progress I did there.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: trmdi, cblack, ndavis, filipf, ngraham, davidedmundson, 
kde-frameworks-devel, dmenig, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, 
michaelh, crozbo, ZrenBot, firef, bruns, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  (gimme a sec to edit with screenshots)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

AFFECTED FILES
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> metadata.desktop.cmake:99
> -contrast=0.2
> -#intensity is disabled, in order to auto adjust to the chosen theme color
> -#intensity=2.0

I changed this because: simply put, it doesn't work. I opened a bug about it 
https://bugs.kde.org/show_bug.cgi?id=416699. It results in weird colors that 
have nothing to do with the background. If I understood it correctly, it's 
supposed to tweak the value based on the background darkness in order to make 
the background more light in those cases and preserving readability, but that 
does not seem to work either as there are some places in the 'before' 
screenshots that look way too dark, and are instead much more readable with 
this patch.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove updated this revision to Diff 78675.
niccolove added a comment.


  Fix breeze dark values

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28353?vs=78668&id=78675

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

AFFECTED FILES
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove abandoned this revision.
niccolove added a comment.


  in favor of https://phabricator.kde.org/D28353

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: trmdi, cblack, ndavis, filipf, ngraham, davidedmundson, 
kde-frameworks-devel, dmenig, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, 
michaelh, crozbo, ZrenBot, firef, bruns, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  In D28353#636164 , @cblack wrote:
  
  > Looks visually appealing to me, with one question: How does this look on 
low-end hardware where there's compositing but no blur?
  
  
  Before:
  F8201840: Screenshot_20200327_180214.png 

  After:
  F8201842: Screenshot_20200327_180258.png 

  
  It is more grayish, but that will no longer be as soon as D28317 
 lands

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  Bug! It should look like this: 
  F8201997: Screenshot_20200327_191850.png 

  Let me check again.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.
niccolove added a dependency: D28317: Adjust default color scheme and titlebar 
appearance for Tools Area.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  Cannot reproduce, it looks like what's in the screenshots to me. Just for 
sure, I also added the dep on Nate's patch as that improves legibility. I 
totally agree on your points seen what you got, that'd be extreme. With what 
I'm actually trying to propose (I don't know if the problem is on my or your 
side), the change looks like the screenshot I added. I also added screenshots 
with fullscreen windows, as that's important as well. E.g., with the default 
wallpaper, left panel and maximized white window it looks like this, which is 
good enough IMO since master is not perfect either: 
  F8202189: Screenshot_20200327_221948.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28372: Added a merged look to the plasmoidheading

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Added a merged look (without a separator) so that multiple plasmoidheadings 
can be visually merged (e.g.: in system tray).

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  merged-plasmoidheading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28372

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading

[Niccolò Venerandi]

niccolove planned changes to this revision.
niccolove added a comment.


  The rounding in the svgs is not necessary.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading

[Niccolò Venerandi]

niccolove updated this revision to Diff 78721.
niccolove added a comment.


  Removed rounded borders and thus the enabledBorders check

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28372?vs=78719&id=78721

BRANCH
  merged-plasmoidheading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28372

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Niccolò Venerandi]

niccolove added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Niccolò Venerandi]

niccolove retitled this revision from "Added a merged look to the 
plasmoidheading" to "Added a merged look to the plasmoidheading and remove 
roundedborders".
niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Niccolò Venerandi]

niccolove updated this revision to Diff 78742.
niccolove added a comment.


  Specified false by default

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28372?vs=78721&id=78742

BRANCH
  merged-plasmoidheading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28372

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Niccolò Venerandi]

niccolove marked an inline comment as done.
niccolove added inline comments.

INLINE COMMENTS

> davidedmundson wrote in PlasmoidHeading.qml:77
> What should happen if this is set to merged and someone uses a theme that 
> doesn't have a merged- prefix?
> 
> The old SVG or no SVG at all?

I'd go with no SVG, to make sure that the theme creators will see that it's 
broken and add a merged- look. Keep in mind that the plasmoidheading svg was 
added barely one month ago, and no big Plasma release had it yet, so I find it 
very hard to believe that any third party theme already has it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  In D28353#636931 , @ngraham wrote:
  
  > It would be helpful to remind people of those details in the Test Plan 
section in the future. :)
  
  
  I will! Sorry. It applied to me without cache clearing, so I assumed it 
didn't need it, but I guess I had some previous transparent theme in the cache.
  
  > However as you can see from that screenshot, the background color of the 
pop-up still differs from the color of the panel.
  
  It is, but near the panel it gets whiter because of the bug that I'm solving 
in D27439 . I didn't put it as a dependency 
as the bug also affects current Breeze, but I could add it if you think it's 
necessary for this patch.
  
  > And the panel transparency effect is still a bit too pronounced for my 
tastes when a visually striking wallpaper is being covered by windows and only 
the panel is still visible. It results in a significant difference between the 
background colors of the panel and plasma pop-ups that appear on top of 
windows: F8203294: Screenshot_20200328_122908.png 

  
  Heh, you're right here. And I think that...
  
  > I might have proposed this before, but I think an improvement would be to 
dynamically change the transparency of the panel and pop-ups from widgets 
living in it based on the proximity of windows
  
  ...I will implement this :-)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Niccolò Venerandi]

niccolove added a subscriber: manueljlin.
niccolove added a comment.


  Generally speaking, I'd still like for all applets to have a row of 
plasmoidheading on the bottom of system tray's own because having just system 
tray plasmoidheading, especially with the new small font, does not feel 
"enough" to me; if you look at every @manueljlin mockups, you'll see they have 
two rows of heading. I think it's because there's a visual minimum 
(plasmoidheading area / normal background area) ratio to look pretty. To 
clarify, I think this is not ideal:
  F8207914: image.png 
  While I think this looks much better:
  F8207917: image.png 
  YMMV. What do you think?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: manueljlin, ahiemstra, ndavis, ngraham, mart, davidedmundson, 
kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28466: Added Page element

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Page element was missing. I added it.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28466

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Page.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28466: Added Page element

[Niccolò Venerandi]

niccolove added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28466

To: niccolove, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28466: Added Page element

[Niccolò Venerandi]

niccolove added a dependent revision: D28467: Converted to Page with a 
PlasmodHeading in the heading.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28466

To: niccolove, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28466: Added Page element

[Niccolò Venerandi]

niccolove marked 2 inline comments as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28466

To: niccolove, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28466: Added Page element

[Niccolò Venerandi]

niccolove updated this revision to Diff 79004.
niccolove added a comment.


  Used correct year and implicitWidth/Height code

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28466?vs=78994&id=79004

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28466

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Page.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: niccolove, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28466: Added Page element

[Niccolò Venerandi]

niccolove added a comment.


  In D28466#639011 , @ngraham wrote:
  
  > Could you add some explanation regarding what this is for? Ideally, both in 
the phab patch and also inline, as API docs.
  >
  > Also shouldn't this be in PlasmaExtras?
  
  
  I'll explain here first to make sure it's correct: from what I was able to 
understand talking to Marco, plasmacomponents3 are QtQuick components with 
plasma style. In this case there is not a svg for a page in the desktoptheme, 
so this effectively just behaves like a normal Page component.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28466

To: niccolove, #plasma
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28466: Added Page element

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8b5e09314162: Added Page element (authored by niccolove).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28466?vs=79004&id=79227

REVISION DETAIL
  https://phabricator.kde.org/D28466

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Page.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: niccolove, #plasma, ngraham, mart
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.
niccolove added a dependency: D27439: Replaced isDock check with !hasDecoration.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28372: Remove rounded borders to plasmoidHeading

[Niccolò Venerandi]

niccolove retitled this revision from "Added a merged look to the 
plasmoidheading and remove roundedborders" to "Remove rounded borders to 
plasmoidHeading".
niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: manueljlin, ahiemstra, ndavis, ngraham, mart, davidedmundson, 
kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Niccolò Venerandi]

niccolove updated this revision to Diff 79740.
niccolove added a comment.


  Removed merged look, no longer needed, but kept rounded corners change

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28372?vs=78742&id=79740

BRANCH
  merged-plasmoidheading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28372

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #plasma
Cc: manueljlin, ahiemstra, ndavis, ngraham, mart, davidedmundson, 
kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28372: Remove rounded borders to plasmoidHeading

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0f9abc2d403d: Remove rounded borders to plasmoidHeading 
(authored by niccolove).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28372?vs=79740&id=79888

REVISION DETAIL
  https://phabricator.kde.org/D28372

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #plasma, ngraham
Cc: manueljlin, ahiemstra, ndavis, ngraham, mart, davidedmundson, 
kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Niccolò Venerandi]

niccolove added a reviewer: niccolove.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28808

To: ngraham, #plasma, apol, #vdg, niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Niccolò Venerandi]

niccolove added a comment.


  This generically works, except for: would it be possible to make it so that 
clicking on an empty point will drop the list and button hover status? 
otherwise, you kind of get stuck to this situation:
  F8242311: Screenshot_20200416_224831.png 

  
  (ps yay, first time I actually manage to try a patch and review it. I'm 
getting better!)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28808

To: ngraham, #plasma, apol, #vdg, niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove updated this revision to Diff 80625.
niccolove added a comment.


  Toned down transparency

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28353?vs=78675&id=80625

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

AFFECTED FILES
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  F8248684: Screenshot_20200420_111621.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove abandoned this revision.
niccolove added a comment.


  I've tweaked it so many times that I eventually ended up with something that 
looks almost identical to default without even noticing. I still think there is 
margin for improvement over the default, but I need to take some more time to 
tweak the values again until I get to something I'm again really confident 
proposing.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove planned changes to this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove reclaimed this revision.
niccolove added a comment.


  This should've been "Changes planned", not "Abandoned". I'm really feeling 
sorry for all of the emails.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.
niccolove added a dependency: D28627: Adaptive panel opacity.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  In D28353#655226 , @ngraham wrote:
  
  > It's okay. :)
  >
  > This is gonna seem like a really dumb question, but which images are the 
befores and which are the afters?
  
  
  Not a dumb question! They are all before-after, but keep in mind that they 
have the colorscheme change patch applied, so they both look different from 
default. First one is default + your colorscheme patch, second one is defult + 
colorscheme patch + this patch.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  In D28353#655680 , @ngraham wrote:
  
  > To be honest, I kinda prefer the befores since the afters are significantly 
darker. Is there a way to preserve the desired level of translucency without 
causing the background to darken like that?
  
  
  Yeah, but it results in very altered colors in wallpapers like Volna. I added 
a second variant to show that. Feedback very welcome!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  Same. I will try some half-way that works everywhere more consistenly.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  What do you think of this one? It's slightly less bright than before, but not 
as much as the first proposal.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

[Niccolò Venerandi]

niccolove accepted this revision as: niccolove.
niccolove added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  heading-only-if-svg-exists (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29352

To: filipf, #vdg, #plasma, niccolove
Cc: niccolove, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29479: Fix rounded borders

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This makes borders of elements using plasmoidHeading rounded again

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29479

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29479: Fix rounded borders

[Niccolò Venerandi]

niccolove edited the test plan for this revision.
niccolove added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29479

To: niccolove, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29479: Fix rounded borders

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29479

To: niccolove, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29479: Fix rounded borders

[Niccolò Venerandi]

niccolove updated this revision to Diff 82131.
niccolove added a comment.


  Address some feedback

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29479?vs=82078&id=82131

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29479

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29479: Fix rounded borders

[Niccolò Venerandi]

niccolove marked 2 inline comments as done.
niccolove added a comment.


  In D29479#664767 , @broulik wrote:
  
  > Notifications don't use `PlasmoidHeading`
  
  
  Heh, it was actually an unrelated mistake: D29490 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29479

To: niccolove, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29479: Fix rounded borders

[Niccolò Venerandi]

niccolove updated this revision to Diff 82133.
niccolove added a comment.


  Round things up again

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29479?vs=82131&id=82133

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29479

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29479: Fix rounded borders

[Niccolò Venerandi]

niccolove marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29479

To: niccolove, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29479: Fix rounded borders

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> broulik wrote in PlasmoidHeading.qml:74
> Where is `plasmoid` defined?

It's not necessary to define it, when you use this in a plasmoid it takes it 
from the context

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29479

To: niccolove, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29479: Fix rounded borders

[Niccolò Venerandi]

niccolove marked 2 inline comments as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29479

To: niccolove, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29479: Fix rounded borders

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1bc004e5c65f: Fix rounded borders (authored by niccolove).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29479?vs=82133&id=82147#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29479?vs=82133&id=82147

REVISION DETAIL
  https://phabricator.kde.org/D29479

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a comment.


  Uhm, I probably got Scour wrong. Sorry.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove updated this revision to Diff 67790.
niccolove added a comment.


  Used scour on svg files

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67789&id=67790

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a comment.


  I'm sorry, when I use scour on svg files, it looks like git does not 
recognize that the file has changed. How can I fix that?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove updated this revision to Diff 67852.
niccolove added a comment.


  Re-done the dialogs/background.svg

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67790&id=67852

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove updated this revision to Diff 67853.
niccolove added a comment.


  Re-done the widgets/panel-background.svg

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67852&id=67853

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a comment.


  In D24593#546309 , @ngraham wrote:
  
  > In D24593#546042 , @niccolove 
wrote:
  >
  > > I'm sorry, when I use scour on svg files, it looks like git does not 
recognize that the file has changed. How can I fix that?
  >
  >
  > That means that the files actually haven't changed compared to the prior 
version. It looks like the diff is messed up and is using the scoured version 
as the base rather than the latest git master.
  
  
  It now shows me a diff, is relatively to master or to my previous svg? in 
that case, I can do another diff  without messing up 
(hopefully)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a comment.


  In D24593#546586 , @filipf wrote:
  
  > > b) radial gradients instead of linear on the four sides to make the 
center darker than the angles.
  >
  > Other than this, they look great to me. I think they should be uniformly 
dispersed.
  >
  > One of the things with shadows is that the user shouldn't really notice 
them. With the radial style I can't help but notice there's shadows missing in 
the corners.
  
  
  What do you think?
  F7601293: Screenshot_20191015_190157.png 

  
  In D24593#546731 , @Luwx wrote:
  
  > Making good looking pure svg box shadows is a bit tricky.
  >
  > A while back I tried to create one:
  >
  > F7590931: shadow.png 
  >
  > The left one uses blur (like breeze decoration does) and the right uses 
gradients with quite a few stops to emulate the blurred square (I don't know if 
this has any effect on performance), radial gradients were used only in the 
corners.
  >
  > It this is of any help, here is the svg: F7590940: shadow.svg 

  
  
  Thanks, that's interesting. May I ask why did you use multiple linear 
gradients instead of a big linear one?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove updated this revision to Diff 68626.
niccolove added a comment.


  Made missing shadow on corners less noticeable on widgets shadows

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67853&id=68626

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a comment.


  In D24593#551591 , @ngraham wrote:
  
  > Is this ready for formal review now or are you still tweaking and/or 
soliciting comments?
  
  
  Ready for review :-)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove updated this revision to Diff 68788.
niccolove added a comment.


  Rebase on master - test

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=68626&id=68788

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a comment.


  In D24593#552915 , @ngraham wrote:
  
  > Needs a rebase on master. It doesn't apply for me.
  
  
  Does it apply now? If not, I messed up something and I will just reset to 
master and add the svgs again.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns