Re: [Kicad-developers] The library tables wizard
Ok, I see you have fixed it in rev 5371. But I still see two semicolons in github/github_getliblist.cpp I don't see why there are two. 2015-01-15 22:57 GMT+01:00 Nick Østergaard oe.n...@gmail.com: Ahh, I just found the place. I have attached a patch that removed the extra slash and the extra semicolon. This interface looks much nicer to choose from instead of the browser window. :) Also, on the same dialog/form as the Github Libs List the button called Add FP Library entry does nothing. 2015-01-15 22:50 GMT+01:00 Nick Østergaard oe.n...@gmail.com: Hi Jean-Pierre To me it seems like you have a double semicolor on pcbnew/github/github_getliblist.cpp 104wxString urlPrefix = wxT( https://; ) + repo.GetServer() + wxT( / );; Aslo I geth the following error when trying to fetch. The problem is the two slashes before repos. I could not figure out where those two slashes come from, therefore I have not attached a patch. https GET command failed Cannot get/download json data from: 'https://api.github.com/orgs/KiCad//repos?per_page=99page=1' Reason: 'Not found' 2015-01-15 21:26 GMT+01:00 Miguel Ángel Ajo majop...@redhat.com: As I said on the other email, awesome :-) I’m glad my advice made any sense. And I like your idea of being able to make a local copy via the KiCad plugin, that’s very nice. Miguel Ángel Ajo On Thursday, 15 de January de 2015 at 21:10, jp charras wrote: Le 07/01/2015 23:38, Miguel Ángel Ajo a écrit : Hi Jean Pierre, just an idea for your wizard work: https://api.github.com/orgs/KiCad/repos You could save the need to work with the HTML viewer and pagination problems using the above API endpoint, all the KiCad project repositories are listed into it in json format. Best regards, Miguel Ángel Ajo Your advices are always golden. I added some enhancements to the fp lib table wizard: a button to import and display the full list of these .pretty libs on github (using this URL). * if the current select plugin is the github plugin, one can select some of these libraries and add them to the current table. * if the current select plugin is the kicad plugin, one can select some of these libraries and download them to make a local copy (which is the usual way of work) in corresponding .pretty folders. They can added later to the table after they are downloaded. Testers are welcome -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] The library tables wizard
Le 07/01/2015 23:38, Miguel Ángel Ajo a écrit : Hi Jean Pierre, just an idea for your wizard work: https://api.github.com/orgs/KiCad/repos You could save the need to work with the HTML viewer and pagination problems using the above API endpoint, all the KiCad project repositories are listed into it in json format. Best regards, Miguel Ángel Ajo Your advices are always golden. I added some enhancements to the fp lib table wizard: a button to import and display the full list of these .pretty libs on github (using this URL). * if the current select plugin is the github plugin, one can select some of these libraries and add them to the current table. * if the current select plugin is the kicad plugin, one can select some of these libraries and download them to make a local copy (which is the usual way of work) in corresponding .pretty folders. They can added later to the table after they are downloaded. Testers are welcome -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] The library tables wizard
Hi Jean-Pierre To me it seems like you have a double semicolor on pcbnew/github/github_getliblist.cpp 104wxString urlPrefix = wxT( https://; ) + repo.GetServer() + wxT( / );; Aslo I geth the following error when trying to fetch. The problem is the two slashes before repos. I could not figure out where those two slashes come from, therefore I have not attached a patch. https GET command failed Cannot get/download json data from: 'https://api.github.com/orgs/KiCad//repos?per_page=99page=1' Reason: 'Not found' 2015-01-15 21:26 GMT+01:00 Miguel Ángel Ajo majop...@redhat.com: As I said on the other email, awesome :-) I’m glad my advice made any sense. And I like your idea of being able to make a local copy via the KiCad plugin, that’s very nice. Miguel Ángel Ajo On Thursday, 15 de January de 2015 at 21:10, jp charras wrote: Le 07/01/2015 23:38, Miguel Ángel Ajo a écrit : Hi Jean Pierre, just an idea for your wizard work: https://api.github.com/orgs/KiCad/repos You could save the need to work with the HTML viewer and pagination problems using the above API endpoint, all the KiCad project repositories are listed into it in json format. Best regards, Miguel Ángel Ajo Your advices are always golden. I added some enhancements to the fp lib table wizard: a button to import and display the full list of these .pretty libs on github (using this URL). * if the current select plugin is the github plugin, one can select some of these libraries and add them to the current table. * if the current select plugin is the kicad plugin, one can select some of these libraries and download them to make a local copy (which is the usual way of work) in corresponding .pretty folders. They can added later to the table after they are downloaded. Testers are welcome -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] The library tables wizard
Ahh, I just found the place. I have attached a patch that removed the extra slash and the extra semicolon. This interface looks much nicer to choose from instead of the browser window. :) Also, on the same dialog/form as the Github Libs List the button called Add FP Library entry does nothing. 2015-01-15 22:50 GMT+01:00 Nick Østergaard oe.n...@gmail.com: Hi Jean-Pierre To me it seems like you have a double semicolor on pcbnew/github/github_getliblist.cpp 104wxString urlPrefix = wxT( https://; ) + repo.GetServer() + wxT( / );; Aslo I geth the following error when trying to fetch. The problem is the two slashes before repos. I could not figure out where those two slashes come from, therefore I have not attached a patch. https GET command failed Cannot get/download json data from: 'https://api.github.com/orgs/KiCad//repos?per_page=99page=1' Reason: 'Not found' 2015-01-15 21:26 GMT+01:00 Miguel Ángel Ajo majop...@redhat.com: As I said on the other email, awesome :-) I’m glad my advice made any sense. And I like your idea of being able to make a local copy via the KiCad plugin, that’s very nice. Miguel Ángel Ajo On Thursday, 15 de January de 2015 at 21:10, jp charras wrote: Le 07/01/2015 23:38, Miguel Ángel Ajo a écrit : Hi Jean Pierre, just an idea for your wizard work: https://api.github.com/orgs/KiCad/repos You could save the need to work with the HTML viewer and pagination problems using the above API endpoint, all the KiCad project repositories are listed into it in json format. Best regards, Miguel Ángel Ajo Your advices are always golden. I added some enhancements to the fp lib table wizard: a button to import and display the full list of these .pretty libs on github (using this URL). * if the current select plugin is the github plugin, one can select some of these libraries and add them to the current table. * if the current select plugin is the kicad plugin, one can select some of these libraries and download them to make a local copy (which is the usual way of work) in corresponding .pretty folders. They can added later to the table after they are downloaded. Testers are welcome -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp fp-tab-wiz-slash.patch Description: plain/text ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] The library tables wizard
Le 07/01/2015 23:38, Miguel Ángel Ajo a écrit : Hi Jean Pierre, just an idea for your wizard work: https://api.github.com/orgs/KiCad/repos You could save the need to work with the HTML viewer and pagination problems using the above API endpoint, all the KiCad project repositories are listed into it in json format. Best regards, Miguel Ángel Ajo Thanks, Miguel. I have a very poor knowledge of github ( and of python, by the way) (near zilch). So, your advices are always welcome. I'll work on it soon. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] The library tables wizard
John, talking of visualizing pull requests to modules, we could setup a hook to your site from the github KiCad org if you want: https://developer.github.com/webhooks/ Miguel Ángel Ajo On Thursday, 8 de January de 2015 at 08:33, Miguel Ángel Ajo wrote: Nice John, very interesting job, It could be very cool if you could visualize pull requests, etc.. Very good point about the unregistered API limit. The unregistered API limit is 60 req/hour. That should be enough for a normal user (used for listing the repos) If that’s found to be exceeded we could cache that response into downloads.kicad-pcb.org (http://downloads.kicad-pcb.org) with a cron script + OAuth key if necessary. Miguel Ángel Ajo On Thursday, 8 de January de 2015 at 01:19, John Beard wrote: On Wed, 2015-01-07 at 23:38 +0100, Miguel Ángel Ajo wrote: Hi Jean Pierre, just an idea for your wizard work: https://api.github.com/orgs/KiCad/repos You could save the need to work with the HTML viewer and pagination problems using the above API endpoint, all the KiCad project repositories are listed into it in json format. The GitHub API is pretty comprehensive, as I found when writing my web footprint viewer [1]. Full GH API access would allow us to be rather more flexible with what we can do, for example: * Only load footprints one at a time, rather than having to download and unzip the whole repo (note that the transfer can still be compressed!) * View and use footprint history (although this can't easily be done in the case that a footprint has moved pretty repo, e.g. from Sockets.pretty to Sockets_Samtec.pretty) * See changes made in all repos (currently quite hard to do, as you have dozens of separate repos to consider) * Contribute new footprints back to the GH repo in the form of a pull request, without leaving KiCad. Similar use could be made of any Git repo locally too (but not the pull request aspect). Additionally, any remote git repo could also be cloned and used from within KiCad. This does not require the GH API, just a Git library, of which there are many (or shell out, even, bleh!) just querying the URL Miguel provided would only count as a single API access, and would not need an API token, unless the user kept on refreshing the list somehow! But you would still get a complete list of repos. However, the API limits are pretty low when you don't have an API token. The web viewer uses a private clientId and secret and then the user gets their own API token via OAuth. This does require that the user has a Github account. We wouldn't be able to distribute the client secret for a KiCad GitHub interface (it could be stolen and used fraudulently for other purposes). We could: * Make the user get their own access token (fairly easy via GitHub's settings page * Have an OAuth server somewhere which can arbitrate this process (user still needs to log into GitHub via Kicad to get the access token, however. This would also allow to dispense with the webviewer WX requirement, which adds another step to the arduous KiCad build process. [1] http://libree.org/tool/kicad_viewer ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net (mailto:kicad-developers@lists.launchpad.net) Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net (mailto:kicad-developers@lists.launchpad.net) Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] The library tables wizard
Nice John, very interesting job, It could be very cool if you could visualize pull requests, etc.. Very good point about the unregistered API limit. The unregistered API limit is 60 req/hour. That should be enough for a normal user (used for listing the repos) If that’s found to be exceeded we could cache that response into downloads.kicad-pcb.org with a cron script + OAuth key if necessary. Miguel Ángel Ajo On Thursday, 8 de January de 2015 at 01:19, John Beard wrote: On Wed, 2015-01-07 at 23:38 +0100, Miguel Ángel Ajo wrote: Hi Jean Pierre, just an idea for your wizard work: https://api.github.com/orgs/KiCad/repos You could save the need to work with the HTML viewer and pagination problems using the above API endpoint, all the KiCad project repositories are listed into it in json format. The GitHub API is pretty comprehensive, as I found when writing my web footprint viewer [1]. Full GH API access would allow us to be rather more flexible with what we can do, for example: * Only load footprints one at a time, rather than having to download and unzip the whole repo (note that the transfer can still be compressed!) * View and use footprint history (although this can't easily be done in the case that a footprint has moved pretty repo, e.g. from Sockets.pretty to Sockets_Samtec.pretty) * See changes made in all repos (currently quite hard to do, as you have dozens of separate repos to consider) * Contribute new footprints back to the GH repo in the form of a pull request, without leaving KiCad. Similar use could be made of any Git repo locally too (but not the pull request aspect). Additionally, any remote git repo could also be cloned and used from within KiCad. This does not require the GH API, just a Git library, of which there are many (or shell out, even, bleh!) just querying the URL Miguel provided would only count as a single API access, and would not need an API token, unless the user kept on refreshing the list somehow! But you would still get a complete list of repos. However, the API limits are pretty low when you don't have an API token. The web viewer uses a private clientId and secret and then the user gets their own API token via OAuth. This does require that the user has a Github account. We wouldn't be able to distribute the client secret for a KiCad GitHub interface (it could be stolen and used fraudulently for other purposes). We could: * Make the user get their own access token (fairly easy via GitHub's settings page * Have an OAuth server somewhere which can arbitrate this process (user still needs to log into GitHub via Kicad to get the access token, however. This would also allow to dispense with the webviewer WX requirement, which adds another step to the arduous KiCad build process. [1] http://libree.org/tool/kicad_viewer ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net (mailto:kicad-developers@lists.launchpad.net) Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] The library tables wizard
On Wed, 2015-01-07 at 23:38 +0100, Miguel Ángel Ajo wrote: Hi Jean Pierre, just an idea for your wizard work: https://api.github.com/orgs/KiCad/repos You could save the need to work with the HTML viewer and pagination problems using the above API endpoint, all the KiCad project repositories are listed into it in json format. The GitHub API is pretty comprehensive, as I found when writing my web footprint viewer [1]. Full GH API access would allow us to be rather more flexible with what we can do, for example: * Only load footprints one at a time, rather than having to download and unzip the whole repo (note that the transfer can still be compressed!) * View and use footprint history (although this can't easily be done in the case that a footprint has moved pretty repo, e.g. from Sockets.pretty to Sockets_Samtec.pretty) * See changes made in all repos (currently quite hard to do, as you have dozens of separate repos to consider) * Contribute new footprints back to the GH repo in the form of a pull request, without leaving KiCad. Similar use could be made of any Git repo locally too (but not the pull request aspect). Additionally, any remote git repo could also be cloned and used from within KiCad. This does not require the GH API, just a Git library, of which there are many (or shell out, even, bleh!) just querying the URL Miguel provided would only count as a single API access, and would not need an API token, unless the user kept on refreshing the list somehow! But you would still get a complete list of repos. However, the API limits are pretty low when you don't have an API token. The web viewer uses a private clientId and secret and then the user gets their own API token via OAuth. This does require that the user has a Github account. We wouldn't be able to distribute the client secret for a KiCad GitHub interface (it could be stolen and used fraudulently for other purposes). We could: * Make the user get their own access token (fairly easy via GitHub's settings page * Have an OAuth server somewhere which can arbitrate this process (user still needs to log into GitHub via Kicad to get the access token, however. This would also allow to dispense with the webviewer WX requirement, which adds another step to the arduous KiCad build process. [1] http://libree.org/tool/kicad_viewer ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp