[Koha-bugs] [Bug 9552] BIB1 Relation "Greater Than" Attribute Not Mapped Properly in CCL.Properties

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9552

Galen Charlton  changed:

   What|Removed |Added

  Attachment #15082|0   |1
is obsolete||

--- Comment #2 from Galen Charlton  ---
Created attachment 15086
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15086&action=edit
Bug 9552 - BIB1 Relation "Greater Than" Attribute Not Mapped Properly in
CCL.Properties

Currently, you can use "lt,le,eq,ge" in your CCL query to handle
"lesser than, lesser or equal to, equal to, greater than or equal
to" relationships.

The only one missing is "gt" (Bib1 2=5).

The mappings are also off "ne, phonetic, stem", but those are Bib1
attributes that Zebra doesn't support, so that's not really relevant.

To test:

[1] Before applying the patch, try the following query in the OPAC:

pubdate,gt:2006

You should get "no results found".

[2] After applying the patch (and note that ccl.properties will usually
need to be installed in the run-time Zebra configuration directory), try
the same search.  This time, you could get back the titles whose publication
date is after 2006.

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9552] BIB1 Relation "Greater Than" Attribute Not Mapped Properly in CCL.Properties

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9552

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9450] Use DataTables in cataloging Z39.50 search results

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450

Galen Charlton  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #5 from Galen Charlton  ---
I've signed off on the patch after testing.

I was able to reproduce the title sorting issue that Jonathan saw (connecting
to z3950.bnf.fr/TOUT, character encoding ISO 5426), but that problem also
existed with the old tablesorter plugin and, in fact, has nothing to do with
either jQuery plugin -- the sorting is thrown off by embedded NSB/NSE
characters in the title.  That's worth opening a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9450] Use DataTables in cataloging Z39.50 search results

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450

Galen Charlton  changed:

   What|Removed |Added

  Attachment #14761|0   |1
is obsolete||

--- Comment #4 from Galen Charlton  ---
Created attachment 15085
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15085&action=edit
Bug 9450 - Use DataTables in cataloging Z39.50 search results

Replace the tablesorter plugin with the DataTables plugin in cataloging
Z39.50 search results.

Structural changes were made to the table markup to deal with a
DataTables bug which prevents it from properly parsing a  with a
colspan.

To test, go to cataloging and perform a Z39.50 search. Confirm that
table sorting works correctly. In this configuration there
should be no pager and no results filtering.

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9450] Use DataTables in cataloging Z39.50 search results

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9459] Use DataTables on hold ratios report page

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459

Galen Charlton  changed:

   What|Removed |Added

  Attachment #14788|0   |1
is obsolete||

--- Comment #2 from Galen Charlton  ---
Created attachment 15084
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15084&action=edit
Bug 9459 - Use DataTables on hold ratios report page

Replace the tablesorter plugin with the DataTables plugin on the
hold ratios report page.

To test, open the hold ratios report (Circulation -> Hold ratios).
Confirm that table sorting works correctly.

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9459] Use DataTables on hold ratios report page

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9476] Use Datatables on Koha news page

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||gmcha...@gmail.com

--- Comment #2 from Galen Charlton  ---
Patch doesn't apply to master -- please rebase and resubmit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9424] Move JavaScript out of header include

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||gmcha...@gmail.com

--- Comment #2 from Galen Charlton  ---
Patch doesn't apply to master -- please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9417] Allow number of results per page to be selectable for guided reports

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9417

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9417] Allow number of results per page to be selectable for guided reports

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9417

--- Comment #2 from Galen Charlton  ---
Created attachment 15083
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15083&action=edit
screenshot of incorrectly constructed select list

The feature works as advertised, but the drop-down for selecting the number of
rows to display isn't being constructed correctly.  As you can see in the
screenshot I've attached, if you change the number of rows and re-run the
report, the currently selected number of rows is duplicated at the top of the
option list.  Idiomatic HTML would wouldn't duplicate the value but would
simply select the corresponding entry on the option list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9552] BIB1 Relation "Greater Than" Attribute Not Mapped Properly in CCL.Properties

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9552

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
Created attachment 15082
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15082&action=edit
Bug 9552 - BIB1 Relation "Greater Than" Attribute Not Mapped Properly in
CCL.Properties

Currently, you can use "lt,le,eq,ge" in your CCL query to handle "lesser than,
lesser or equal to, equal to, greater than or equal to" relationships.

The only one missing is "gt" (Bib1 2=5).

The mappings are also off "ne, phonetic, stem", but those are Bib1 attributes
that Zebra doesn't support, so that's not really relevant.

---

To test:

Before applying patch...

1) On the OPAC or Intranet search bar, type in the following:

pqf=@attr 1=32 @attr 2=5 "2009"

(feel free to substitute any other number in for 2009 or any other phrase
Use attribute you like which contains a number that can be compared - for
instance, 31, which is pubdate)

2) Now, type in the following:

acqdate,gt:2009

or

ccl=acqdate,gt:2009

3) You'll notice that you get "No results found!", even though it should be
the exact same query!

4) Apply patch
5) Re-try steps 1 and 2
6) Notice that your results will be identical for both the pqf and ccl
queries.

(Another note: This test will only work if you have items in your database
that have dateaccessioned information that has been mapped to the 952$d field.
If the test fails, try @attr 1=31 in step 1 and pubdate,gt in step 2)




This is a very simple patch that adds a correct mapping for "greater than"
relationships. 

As far as I can tell, using the actual <, <=, >, >= signs don't actually work
in search queries, so we should probably include the reference to "lt,le,gt,ge"
in the Koha documentation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9552] New: BIB1 Relation "Greater Than" Attribute Not Mapped Properly in CCL.Properties

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9552

Bug ID: 9552
   Summary: BIB1 Relation "Greater Than" Attribute Not Mapped
Properly in CCL.Properties
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: dc...@prosentient.com.au

Currently, you can use "lt,le,eq,ge" in your CCL query to handle "lesser than,
lesser or equal to, equal to, greater than or equal to" relationships. 

The only one missing is "gt" (Bib1 2=5). 

The mappings are also off "ne, phonetic, stem", but those are Bib1 attributes
that Zebra doesn't support, so that's not really relevant.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9516] Item Availability/Data missing from OPAC tag search

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9516

--- Comment #8 from David Cook  ---
I agree. I'm still not sure how it could've worked for you. 

When I connect to Zebra using yaz, I notice that the 952 field has been
appended to the record, which is to be expected. When I look at the marc blob
in the database, I don't see any 952 field, which is also to be expected. Since
the GetBiblioData sub doesn't embed item data, I don't see how your your opac
tag search results could possibly be getting item data :S. When you do the
test, is your query string something along the lines of: ?tag=KEYWORD&q=KEYWORD

Alas, I cannot test anything search related on my git dev install, as Zebra
doesn't work on it. Wish I knew why...

But when I try it on my actual trial install (3.8.0), it doesn't get any item
data. I've looked at the code for master, and it looks like the same as 3.8.0
in this regard :S.


(In reply to comment #7)
> I think it may be a good idea to get at least a couple more people to test
> the preconditions for this bug.
> 
> (In reply to comment #6)
> > (In reply to comment #4)
> > > Neither I nor Owen have been able to reproduce this bug.
> > 
> > Hmmm, intriguing!
> > 
> > The more I look at the getRecords and searchResults subs, the more confused
> > I get by the marc/marcxml/items synchronization. 
> > 
> > If it's working for you guys, it must mean that my sync is off, because
> > using getRecords seems to return raw marc with embedded item data, while
> > just querying the marc blob in the database returns raw marc without item
> > data. 
> > 
> > :S
> > 
> > I thought that the marcxml and marc weren't supposed to store item-level
> > data anymore, but I don't see in these subs where it is being added. In
> > fact, in searchResults (around line 1729: "Pull out the items fields"), it
> > seems that the incoming marcRecord param passed into searchResults should
> > have that embedded item data :S.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9383] Bad logic, missing params, and irregular labeling for Members scripts

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9383

--- Comment #3 from David Cook  ---
(In reply to comment #2)
> (In reply to comment #1)
> 
> > Personally, I don't see why Professionals should be separated from the rest
> > of patrons (other than Organizations). In fact, I don't know if there is
> > even a point separating Organizations! I think Primary/Secondary/Mobile are
> > fine clear across the board.
> 
> Professional type patrons can be created with links to specific
> Organizations. I don't know much about how this works in practice but it's
> obviously a feature which was created with specific intent.

I agree, Owen, but I was referring to the separation of phone/email labels
rather than the actual patron types. I don't know why an organisation would
need "organisation phone" rather than "primary phone" or why a professional
would have different labels for the same fields as any other individual patron. 

I think there might be some disagreement about which labels I've chosen to
apply in this patch (like using Mobile Phone for mobilephone, as I think some
people prefer to use Other phone as mobilephone might actually be the Primary
Phone). However, the current templates don't actually work to differentiate
them anyways at the moment, because the categorycode param isn't passed to the
template from the perl. 

Besides that, the labels appear to be inconsistent between the patron entry
page and the patron detail page. I imagine it would be disconcerting to put
your work phone as your primary phone and then have your home phone show up as
your primary phone on your page. (Mind you, that's awfully detail-oriented, so
maybe most people wouldn't notice.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9551] New: OPACMobileUserCSS being overriden by OPACUserCSS

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551

Bug ID: 9551
   Summary: OPACMobileUserCSS being overriden by OPACUserCSS
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: 3.10
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ed.v...@bywatersolutions.com

I have been playing with the OPACMobileUserCSS sys pref. I am trying to have
separate information in the opaccredits sys pref for the mobile and the desktop
views. I am doing this by giving the content unique id's and then using the
appropriate css sys pref to hide or display the appropriate information. 

However, when I do this whatever is the OpacUserCSS overrides what is in the
OPACMobileUserCSS. 

Ed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9546] MANIFEST.SKIP breaking regexp when running make manifest tardist

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9546

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #15047|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 15081
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15081&action=edit
[SIGNED-OFF] Bug 9546 : Updating make manifest tardist

To test
perl Makefile.PL
make manifest tardist

Before the patch you will get an error, after the patch it will create
the tarball

Signed-off-by: Mason James 
Signed-off-by: Katrin Fischer 
make manifest tardist and make manifest zipdist work
perfectly after patch was applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9546] MANIFEST.SKIP breaking regexp when running make manifest tardist

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9546

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9480] Set barcode width and height configurable with system preferences in patron card creator

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9480

--- Comment #3 from Vitor Fernandes  ---
Hi Owen,

They are in a system preference because they are fixed in the code and can't be
changed in the layout. So I created tão system preferences for the barcode
height and width scale.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9213] Implement analytics for NORMARC XSLT

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9213

--- Comment #4 from Mirko Tietgen  ---
Sorry, ignore my last comment, it is there :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9213] Implement analytics for NORMARC XSLT

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9213

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #3 from Mirko Tietgen  ---
I think the beginning of the test plan lack an explanation of your analytics
settings. I don't think I have seen something that looks like »In the "Normal"
view, do New > New child record and create another record«. Is that
EasyAnalytics or what settings does one have to use to follow the plan?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9432] acqui/addorderiso2409.pl is not Plack-friendly

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9432

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9432] acqui/addorderiso2409.pl is not Plack-friendly

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9432

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #14722|0   |1
is obsolete||

--- Comment #2 from Mirko Tietgen  ---
Created attachment 15080
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15080&action=edit
Bug 9432: Plack changes for acqui/addorderiso2409.pl

Without this patch, after selecting the file I want to add acquisitions
from, Plack explodes. With this patch, it works.

To test without Plack:
1) Apply patch.
2) Try adding an order item from a staged file.
3) If it works, there are no regressions from the patch.

To test with Plack:
1) Try adding an order item from a staged file. It will fail.
2) Apply patch.
3) Try adding an order item from a staged file.
3) If it works, the patch is successful.

Signed-off-by: Mirko Tietgen 
Fixes Plack, does not break Apache. Works as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #14 from Kyle M Hall  ---
I changed the prototype for CountItemsIssued, so I had to update all calls to
it. Still, it wouldn't hurt to test in multiple ways.

Kyle

(In reply to comment #13)
> (In reply to comment #12)
> > 4) Attempt to place a hold on the item, you should now be able to do so
> 
> I see that this patch affects several scripts. Should one test placing a
> hold from multiple pages or in multiple ways?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9421] tools/picture-upload.pl not Plack-compatible

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9421] tools/picture-upload.pl not Plack-compatible

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #14692|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #13 from Owen Leonard  ---
(In reply to comment #12)
> 4) Attempt to place a hold on the item, you should now be able to do so

I see that this patch affects several scripts. Should one test placing a hold
from multiple pages or in multiple ways?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9421] tools/picture-upload.pl not Plack-compatible

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421

--- Comment #2 from Mirko Tietgen  ---
Created attachment 15079
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15079&action=edit
Bug 9421: tools/picture-upload.pl not Plack-compatible

This patch avoids using file-level private variables in subroutines
by passing the needed variables as parameters to the subroutines.

To test (under Plack):
1) Try uploading a patron image without applying the patch. Notice
   it fails.
2) Apply patch.
3) Try uploading a patron image again, noticing this time it succeeds.

To test (under Apache):
1) Apply patch.
2) Try uploading a patron image, confirm that it works.

Signed-off-by: Mirko Tietgen 
Fixes Plack, does not break Apache. Works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9511] DOM indexing problem

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9511

--- Comment #6 from Jorge de Cardenas  ---
Our production Koha is 3.10 but I reproduced the problem and took index data
from a test server on master (3.11.00.014).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9499] --itemscontent= option is undocumented in advanced-notice.pl cronjob + default date should be date_due, not issuedate

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499

Owen Leonard  changed:

   What|Removed |Added

  Attachment #14877|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 15078
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15078&action=edit
[SIGNED-OFF] Bug 9499 - --itemscontent= option is undocumented in
advanced-notice.pl cronjob + default date should be date_due, not issuedate

To Test:

Set up a borrower to receive due and/or predue notices.
Define your predue and/or due notice to use <>
Give your borrower an issue that will trigger a notice to be sent
(Example: Henry Acevedo has checked out a book that will be coming due
tomorrow,
he wants to receive predue notices 1 day in advance)

On the command line, run (your paths may vary, these are mine):
sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml
PERL5LIB=/usr/share/koha/lib perl advance_notices.pl -c -n

Note that the date listed is the due date, not the issue date.

Then run:
sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml
PERL5LIB=/usr/share/koha/lib perl advance_notices.pl -c -n
--itemscontent=issuedate,title,author,barcode

Note that the date listed is the issue date, not the date due.

Also run
sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml
PERL5LIB=/usr/share/koha/lib perl advance_notices.pl --help

Should show the help.

sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml
PERL5LIB=/usr/share/koha/lib perl advance_notices.pl --man

Should show the man page version of the help.

sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml
PERL5LIB=/usr/share/koha/lib perl advance_notices.pl

Should show the help. This script requires confirmation before running (-c or
nothing is done).

Note that the documentation refers to the --itemscontent= option and now allows
--man as well as --help. Also it is a proper POD.

Signed-off-by: Owen Leonard 

Works as advertised according to the fine test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9499] --itemscontent= option is undocumented in advanced-notice.pl cronjob + default date should be date_due, not issuedate

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #14451|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall  ---
Created attachment 15077
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15077&action=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9499] --itemscontent= option is undocumented in advanced-notice.pl cronjob + default date should be date_due, not issuedate

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |l...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9480] Set barcode width and height configurable with system preferences in patron card creator

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9480

--- Comment #2 from Owen Leonard  ---
I don't know much about the patron card creator, but is there a reason why
these values belong in a system preference rather than as part of a layout?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9440] update Koha's LICENSE file from GPL2 to GPL3

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9440

Owen Leonard  changed:

   What|Removed |Added

  Attachment #14740|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 15076
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15076&action=edit
[SIGNED-OFF] Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3

http://bugs.koha-community.org/show_bug.cgi?id=9440

Signed-off-by: Owen Leonard 

I'm not sure what the correct test plan for this is, but a diff
of LICENSE in Koha after applying the patch and the file at
http://www.gnu.org/licenses/gpl-3.0.txt shows no differences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9440] update Koha's LICENSE file from GPL2 to GPL3

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9440

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #15074|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall  ---
Created attachment 15075
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15075&action=edit
Bug 8735 - Expire holds waiting only on days the library is open

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #13365|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 15074
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15074&action=edit
Bug 8735 - Expire holds waiting only on days the library is open

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7718] Remove itemnumber column from serials table

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #10 from Bernardo Gonzalez Kriegel  ---
(In reply to comment #8)
> The test plan needs to provide enough information for the tester to confirm
> that the removal of the column does not break anything.

I did a check. Can't found any SELECT, DELETE or INSERT that
references itemnumber column from serial table.
But I may be wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9511] DOM indexing problem

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9511

--- Comment #5 from Jared Camins-Esakov  ---
What version of Koha are you using, Jorge?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #11 from Owen Leonard  ---
Needs a test plan.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9511] DOM indexing problem

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9511

--- Comment #4 from Jorge de Cardenas  ---
I hope this might help: This record has been deleted. It still shows up on
searches and when you click on it, you get

"The record you requested does not exist (81828)."

I found this using yaz-client (not easy).

Z> show
Sent presentRequest (20+1).
Records: 1
[biblios]Record type: USmarc
01187nam a2200313Ia 4500
001 ocm56473895
003 OSt
005 20111031143426.0
008 040909s2004nyua   j  000 0 eng d
020$a 0439455243  $c $3.50
040$a OCO $c OCO $d STD $d OSt $d OhAtLVL
049$a STDN
100 1  $a McCann, Jesse Leon. $9 1001550701
245 10 $a Scooby-doo and the werewolf / $c by Jesse Leon McCann.
246 3  $a Scooby-doo & the werewolf
260$a New York : $b Scholastic, $c c2004.
300$a 24 p. : $b ill. ; $c 22 cm.
440 00 $a Scooby-Doo! $9 3000254601
500$a At head of title: Cartoon Network.
521$a Level M (red) ; $b Scholastic Leveled Reading.
526$a Accelerated reader ; $c 2.7 ; $d 0.5 ;
650  0 $a Scooby-Doo (Fictitious character) $v Juvenile fiction $9 2001577542
650  0 $a Leveled reader $9 100098602612
650  0 $a Accelerated Reader $9 100098597294
710 2  $a Cartoon Network (Television network) $9 1001407241
910$a 267343
942$c GE $k Scooby- Doo  $2 ddc
999$c 81828 $d 81828
952$w 2007-02-25 $p 33529002654449 $v 3.50 $r 2012-12-01 $4 0 $0 0 $6
SCOOBY__DOO $9 95084 $b MAIN $m 12 $1 0 $o Scooby- Doo $d 2004-09-14 $7 0 $c JE
$y GE $s 2012-11-10 $l 124 $a MAIN

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9546] MANIFEST.SKIP breaking regexp when running make manifest tardist

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9546

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Assignee|gmcha...@gmail.com  |ch...@bigballofwax.co.nz
 QA Contact||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7718] Remove itemnumber column from serials table

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #15071|0   |1
is obsolete||

--- Comment #9 from Bernardo Gonzalez Kriegel  ---
Created attachment 15073
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15073&action=edit
[SIGNED-OFF] Bug 7718 - Remove itemnumber column from serials table

Remove the column 'itemnumber' from the table 'serial'. This is
a 1 to many relationship, and this reference does not make sense.
The 'serialitems' table handles the relationship between the 'items'
table and the 'serial' table.

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Verify serial.itemnumber has been removed from the database

Signed-off-by: Bernardo Gonzalez Kriegel 

Column removed. No errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9521] Move common jQuery assets to koha-tmpl/intranet-tmpl/lib

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9521

Owen Leonard  changed:

   What|Removed |Added

  Attachment #15005|0   |1
is obsolete||

--- Comment #6 from Owen Leonard  ---
Created attachment 15072
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15072&action=edit
Bug 9521 [Revised] Move common jQuery assets to koha-tmpl/intranet-tmpl/lib

Assets which are not theme-specific can now be placed in
koha-tmpl/intranet-tmpl/lib. This patch moves jQuery assets referenced
by doc-head-close.inc to this location and corrects the path in the
include.

To test, load any page in the staff client which uses jQuery and confirm
that there are no JavaScript errors. Test keyboard shortcuts (Alt-r,
Alt-u, Alt-q), Search to hold functionality, and search term
highlighting to confirm that jQuery plugins are working correctly.

Revision corrects some additional instances in help-top.inc and removes
a redundant call to the highlight script in preferences.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9521] Move common jQuery assets to koha-tmpl/intranet-tmpl/lib

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9521

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7718] Remove itemnumber column from serials table

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Jared Camins-Esakov  ---
The test plan needs to provide enough information for the tester to confirm
that the removal of the column does not break anything.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7718] Remove itemnumber column from serials table

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7718] Remove itemnumber column from serials table

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #15031|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 15071
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15071&action=edit
Bug 7718 - Remove itemnumber column from serials table

Remove the column 'itemnumber' from the table 'serial'. This is
a 1 to many relationship, and this reference does not make sense.
The 'serialitems' table handles the relationship between the 'items'
table and the 'serial' table.

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Verify serial.itemnumber has been removed from the database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438

--- Comment #14 from Bernardo Gonzalez Kriegel  ---
Created attachment 15070
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15070&action=edit
Follow-up Bug 9438 - Biblio notes displayed when ordering

This patch re-enables displying Notes when select
Modify order from basket view.

To Test:
1) After applying first patch, Notes are empty when select Modify order
2) Apply patch
3) Now Notes are visible again, unless the order is new.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9521] Move common jQuery assets to koha-tmpl/intranet-tmpl/lib

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9521

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9550] Replace PazPar2 with MetaProxy

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9550

Elliott Davis  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |elli...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9550] Replace PazPar2 with MetaProxy

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9550

Elliott Davis  changed:

   What|Removed |Added

   Patch complexity|--- |Large patch
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9550] New: Replace PazPar2 with MetaProxy

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9550

Bug ID: 9550
   Summary: Replace PazPar2 with MetaProxy
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: elli...@bywatersolutions.com

Currently PazPar2 is not working in Koha.  To get it working requires a
complete overhaul of its implementation.  I would like to replace the existing
PazPar2 Code with MetaProxy as it is a better fit for Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #13 from Katrin Fischer  ---
Hi Bernardo, I think your test sounds logical - I woudl like to see this
resolved. Adrien - could you take a look please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9549] New: Local Cover are not displayed in the Shelf Browser.

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9549

Bug ID: 9549
   Summary: Local Cover are not displayed in the Shelf Browser.
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: anthony.laque...@ccsr.qc.ca

Created attachment 15069
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15069&action=edit
LocalCoverMissing in shelfbrowser.

Example on current master : 
Look at the picture attached.

This document dont have a valid amazon image but do have localcover upload and
tie to it.
I think we should have the ability to display the localcover in the shelf
browser.
Usually, our user use the localcover when the cover is not available on Amazon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438

--- Comment #12 from Bernardo Gonzalez Kriegel  ---
Perhaps I'm wrong, but I found the following behavior:

1) Follow test plan after patch applied
2) In a new basket the Notes field in Accounting Details is empty 
(was the place filled with 300a/500a), patch is working!
3) Add a note and save 
4) When viewing the basket, press Modify order... and the Notes is empty!!
(the data is saved, in doubt do "select notes from aqorders")

That was the meaning of my previous comment.
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
is used to add AND modify a order in a basket. If you remove [% notes %] from
it then will never see your Accounting Details Notes again.

I got the expected behavior using:
in .../neworderempty.tt
[% IF ( notes ) %][% notes %][% END %]

and in .../neworderempty.pl
$template->param ( notes => $data->{'notes'} ) unless ( $ordernumber eq '' );


Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9293] action_logs not tracking payments

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9293

--- Comment #7 from Kyle M Hall  ---
I think this new version will be more to your liking.

Kyle

(In reply to comment #3)
> This patch certainly works, but I think the output in the log needs to be
> clearer. 
> 
> Where money is involved, you do not want *any* ambiguity as to what
> happened, and you average librarian is going to look at that and probably
> have trouble understanding what happened.
> 
> I know that the same output appears in other logs, but the other logs don't
> involve money and financial "paper trail."
> 
> Please make the output a bit easier to understand, something like "borrower:
>  Action:  Amount: 
> 
> It doesn't have to be exactly like that, but it should have those elements.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9293] action_logs not tracking payments

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9293

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9293] action_logs not tracking payments

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9293

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #15067|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 15068
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15068&action=edit
Bug 9293 - action_logs not tracking payments

Add all fine actions to action_logs via FinesLog syspref

Test Plan:
1) Enable FinesLog
2) Apply patch
3) Try all the various fine related actions possible
4) Verify that each action creates an action_logs entry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9293] action_logs not tracking payments

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9293

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #15066|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 15067
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15067&action=edit
Bug 9293 - action_logs not tracking payments

Add all fine actions to action_logs via FinesLog syspref

Test Plan:
1) Enable FinesLog
2) Apply patch
3) Try all the various fine related actions possible
4) Verify that each action creates an action_logs entry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9293] action_logs not tracking payments

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9293

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #14667|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 15066
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15066&action=edit
Bug 9293 - action_logs not tracking payments

Add all fine actions to action_logs via FinesLog syspref

Test Plan:
1) Enable FinesLog
2) Apply patch
3) Try all the various fine related actions possible
4) Verify that each action creates an action_logs entry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9425] Template plugins are missing utf8 encoding

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425

--- Comment #2 from Owen Leonard  ---
Thank you for the detailed test plan. However, I cannot produce the problem. I
see correct characters before and after the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Owen Leonard  ---
Can you please add a test plan for this? acq.js is modified in several places,
so I assume several different functions are being affected. A test plan will
ensure that we test all the changes properly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #6 from Chris Cormack  ---
Probably doesn't matter whether it's an enhancement or bug unless a patch to
change it actually exists. But it is working as designed, adding the ability
for it to wipe fines is therefore an enhancement. But yeah without a patch its
moot anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9399] Accessibility - Search box options aren't buttons

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9399

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Owen Leonard  ---
I'm marking this "failed QA" because it's not clear whether this patch is
really ready for signoff ("The patch will need to be worked on"). I would like
to understand better why the changes are being made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm)

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
Can you please add a test plan for this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7253] fast cataloging not always checking out

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #9 from Jared Camins-Esakov  ---
The follow-up will need a signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7718] Remove itemnumber column from serials table

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Owen Leonard  ---
This patch recycles the database upgrade description from another update ("Add
IDreamBooks enhanced content") and lacks a test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886

Owen Leonard  changed:

   What|Removed |Added

  Attachment #14434|0   |1
is obsolete||

--- Comment #17 from Owen Leonard  ---
Created attachment 15065
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15065&action=edit
[SIGNED-OFF] Bug 6886 - Single branch mode should disable showing the branch
name in front of all callnumbers

Followup - Copies available for reference

Test plan: Enable singleBranchMode and  OPACXSLTResultsDisplay. Perform
a search in the OPAC which returns results containing not-for-loan
items. Before the patch these items will show their library in search
results loan items. After the patch there will be not be a library
listed, matching other items in results.

Signed-off-by: Owen Leonard 

Works according to the test plan I invented.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438

Owen Leonard  changed:

   What|Removed |Added

  Attachment #14732|0   |1
is obsolete||

--- Comment #11 from Owen Leonard  ---
Created attachment 15064
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15064&action=edit
[SIGNED-OFF] Bug 9438: biblio notes displayed when adding order

The biblio notes should not appear in the "Notes" textarea
of the "New order" page, in Acquisitions.

TEST PLAN
1) Find a biblio with a note (for example 300$a in UNIMARC, 500$a
in USMARC), or add a note to a biblio.

2) In a basket, create a new order for that title. Before the patch,
the "Notes" textarea contains the note from the biblio. After the patch
the textarea is empty.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Colin Campbell  changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com

--- Comment #5 from Colin Campbell  ---
There does seem to be a common expectation amongst users that dropbox mode
clears fines in some way. And subsequently they find it to be behaving
inconsistently. The behaviour does need documenting as it seems to be adding
confusion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range for fields 1xx)

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

mathieu saby  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

--- Comment #16 from Owen Leonard  ---
Looking at this again, the other thing I worry about is the name of the
preference and its description. The preference is tied directly to suggestions
isn't it? But the name, "SupportsAuthorizedValues," doesn't imply a connection.
The description, "(itemtype|ccode|loc) represents document physical support."
doesn't make sense to me.

Maybe something like, "SuggestionsUseValues," "Suggestions can be submitted
using the following authorized values: (itemtype|ccode|loc)"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9395] Problem with callnumber and standard number search in OPAC and Staff Client

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9395

Owen Leonard  changed:

   What|Removed |Added

  Attachment #14606|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 15063
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15063&action=edit
[SIGNED-OFF] Bug 9395: Problem with callnumber and standard number searches

This problem happens because there isn't a operator "phr" in the values
of callnumber and standard number search. So many results aren't the
corrects ones.

Test plan:

- Apply the patch
- In the dropbox search menu of OPAC main page header, the callnum
  should have only callnum
- In OPAC advanced search the callnumber and standard number options
  shouldn't have "phr"
- In staff client advanced search the callnumber and standard number
  options shouldn't have "phr"
- Change OPACNumbersPreferPhrase and IntranetNumbersPreferPhrase to "use"
- The options listed before should use now the operator "phr"
- This will resolve the problems with the searches of callnumbers and
  standard numbers in OPAC and staff client (spaces problems, no
  results, inconsistent results, etc...)

Sponsored-by: KEEP SOLUTIONS
Signed-off-by: Owen Leonard 

I don't know how to reproduce the searching problems described in the
bug, but I can confirm that the patch works correctly to enable/disable
the use of 'phr' in the searches described in the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9395] Problem with callnumber and standard number search in OPAC and Staff Client

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9395

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322

--- Comment #10 from Kyle M Hall  ---
There are now two mutually exclusive patches to resolve this issue. One deletes
previous open transfers from the database, the other marks them as arrived with
an arrival date of '-00-00 00:00:00'.

Please pick the one you feel is the better implementation and deprecate the
alternative when you sign off on the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #15059|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 15062
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15062&action=edit
Bug 9322 - Delete previous open transfer when adding a new transfer for a given
item

This patch prevents multiple unresolved item transfers for
a given item to exist at the same time.

Test Plan:
 1) Get an item's barcode
 2) Go to circulation -> transfers
 3) Select a branch to transfer to
 4) Put in your barcode
 5) Submit the transfer
 6) Examine the branchtransfers table, note that
there is now one open transfer for the item
 7) Select a different branch to transfer to
 8) Put your same barcode in again
 9) Submit the transfer
10) Reexamine the branchtransfers table, note that
the previous open transfer has been deleted and
the new open transfer has replaced it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #15060|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 15061
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15061&action=edit
Bug 9322 - 'Resolve' previous open transfer when adding a new transfer for a
given item

This patch prevents multiple unresolved item transfers for
a given item to exist at the same time. If an item has an
open transfer and is subject to a second open transfer, the
previous open transfer will be given a datearrived time of
'-00-00 00:00:00' to indicate the transfer was resolved
but never completed.

Test Plan:
 1) Get an item's barcode
 2) Go to circulation -> transfers
 3) Select a branch to transfer to
 4) Put in your barcode
 5) Submit the transfer
 6) Examine the branchtransfers table, note that
there is now one open transfer for the item
 7) Select a different branch to transfer to
 8) Put your same barcode in again
 9) Submit the transfer
10) Reexamine the branchtransfers table, note that
the previous open transfer now has a datearrived
value of '-00-00 00:00:00' and the new transfer
is the only transfer for this item with a datearrived
value of NULL

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322

--- Comment #7 from Kyle M Hall  ---
Created attachment 15060
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15060&action=edit
Bug 9322 - 'Resolve' previous open transfer when adding a new transfer for a
given item

This patch prevents multiple unresolved item transfers for
a given item to exist at the same time. If an item has an
open transfer and is subject to a second open transfer, the
previous open transfer will be given a datearrived time of
'-00-00 00:00:00' to indicate the transfer was resolved
but never completed.

Test Plan:
 1) Get an item's barcode
 2) Go to circulation -> transfers
 3) Select a branch to transfer to
 4) Put in your barcode
 5) Submit the transfer
 6) Examine the branchtransfers table, note that
there is now one open transfer for the item
 7) Select a different branch to transfer to
 8) Put your same barcode in again
 9) Submit the transfer
10) Reexamine the branchtransfers table, note that
the previous open transfer has been removed and
the new open transfer has replaced it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322

--- Comment #6 from Kyle M Hall  ---
This patch deletes the unresolved but 'overwritten' transfers. It may be a good
idea to keep them around for historical data purposes, and set the date to
'-00-00 00:00:00' to mark them as resolved but never completed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322

--- Comment #5 from Kyle M Hall  ---
Created attachment 15059
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15059&action=edit
Bug 9322 - If multiple transfers exist (from circ/branchtransfers.pl),
completing one completes them all

This patch prevents multiple unresolved item transfers for
a given item to exist at the same time.

Test Plan:
 1) Get an item's barcode
 2) Go to circulation -> transfers
 3) Select a branch to transfer to
 4) Put in your barcode
 5) Submit the transfer
 6) Examine the branchtransfers table, note that
there is now one open transfer for the item
 7) Select a different branch to transfer to
 8) Put your same barcode in again
 9) Submit the transfer
10) Reexamine the branchtransfers table, note that
the previous open transfer has been removed and
the new open transfer has replaced it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

Owen Leonard  changed:

   What|Removed |Added

  Attachment #15021|0   |1
is obsolete||

--- Comment #38 from Owen Leonard  ---
Created attachment 15058
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15058&action=edit
[SIGNED-OFF] Bug 8942 : Adding a test to make sure we don't use single quotes
for js

Signed-off-by: Owen Leonard 

Tested by adding single quotes to a translation-escaped string.
Test correctly failed it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9383] Bad logic, missing params, and irregular labeling for Members scripts

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9383

--- Comment #2 from Owen Leonard  ---
(In reply to comment #1)

> Personally, I don't see why Professionals should be separated from the rest
> of patrons (other than Organizations). In fact, I don't know if there is
> even a point separating Organizations! I think Primary/Secondary/Mobile are
> fine clear across the board.

Professional type patrons can be created with links to specific Organizations.
I don't know much about how this works in practice but it's obviously a feature
which was created with specific intent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9542] link to regular site from ccsr mobile

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9542

--- Comment #3 from Nicole C. Engard  ---
What I mean is the site you would see if you went to the site in your browser. 
I mention this because in training we found that the mobile view didn't seem to
have the cart or lists - and so the trainees asked for a way to get those.  

Owen thanks for the info - I did think of that, but figured I'd ask.

I was thinking of sites like Amtrak and Delta when I visit them in the browser
on my phone I always click 'full html site' to get out of the mobile view and
see all of the menus that the mobile is missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
I tend to agree with Nicole, I had always assumed that dropbox mode was
backdating the return date to yesterday so that fines would be generated as if
it had been returned the day before.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #3 from Nicole C. Engard  ---
What's the point of changing the day ... except to get rid of the fines?  That
at least is the point here in the US.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8913] Improve acquisitions navigation

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8913] Improve acquisitions navigation

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #15036|0   |1
is obsolete||

--- Comment #21 from Nicole C. Engard  ---
Created attachment 15057
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15057&action=edit
[SIGNED-OFF] Bug 8913 [Revised] Improve acquisitions navigation

This patch adds a new menu for vendor-related pages in which
vendor related "views" can be linked to: baskets, basket groups,
contracts, invoices, uncertain prices.

The acquisitions toolbar is pared down to vendor-related actions:
New basket, contract, or vendor; edit vendor, delete vendor,
receive shipment.

Other small improvements have been made to other pages: corrections
to breadcrumbs and title tags, adding useful links betweeen pages.

Vendor menu and toolbar are added to booksellers.pl
when there is only one "search result" (i.e. a vendor id is passed).

- Menu appears when booksellerid variable is present
- Redundant heading removed
- Additional variables added to enable proper display of the toolbar

Revision corrects broken links pointed out by QA.

TODO: Add coverage of Basket groups page.

To test, navigate Acquisitions pages and test as many links and buttons
as you can, confirming that nothing is broken on vendor pages, invoice
pages, contract pages, uncertain price pages, etc.

Signed-off-by: Nicole C. Engard 

All tests pass - I like this very much!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5609] Holds Rewrite

2013-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5609

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #9 from Kyle M Hall  ---
Are you referring to view_holdsqueue.pl, or to pendingreserves.pl?

(In reply to comment #8)
> Currently, when a Suspended HOLD is un-suspended, it does not show up in the
> Holds to Pull report. 
> 
> Is this part of the Holds re-write development? 
> 
> If not, can it be?
> 
> It's kind of an important feature. 
> 
> Thanks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >