[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #87 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Galen Charlton changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||gmcha...@gmail.com --- Comment #79 from Galen Charlton --- Patch no longer applies; merge conflict is not straightforward to resolve. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Galen Charlton changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #22 from Galen Charlton --- This patch no longer applies. This is more than just a merge conflict; the change in the restriction introduced for bug 2720 should be taken into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #50 from Galen Charlton --- Pushed to master. Thanks Julian! I also pushed a follow-up that adds the toolbar menu items back. From the commit message: My rationale: the question of the best UI for selecting items for batch operations is not yet settled. Adding the ability to select items from the bib details page is indeed useful, but as currently implemented, it can hide the availability of the batch edit/deletion operations if no item is yet selected. Although having both the toolbar items and the links that display when an item is selected is a bit redundant, for now I think we can live with that until we get more eyes on the UI. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 Galen Charlton changed: What|Removed |Added Status|Passed QA |Failed QA CC||gmcha...@gmail.com --- Comment #51 from Galen Charlton --- Marking as failed QA, sorry. This patch series (after fixing merge) conflicts, blows up every nearly every DB-dependent serials unit test that calls GetSubscription() with an error similar to this: Can't use an undefined value as a HASH reference at /home/gmc/koha/C4/Serials.pm line 2808, line 558. This, ultimately, is because the patch series makes it *required* that there is a valid userenv, which was not the case before. can_edit_subscription() should be revised so that it doesn't crash if there's no userenv. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Galen Charlton changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||gmcha...@gmail.com --- Comment #83 from Galen Charlton --- Patch doesn't apply on account of the renaming of the serial claims export script -- tossing back for the patch submitter to rebase. Feel free to set back to passed QA afterwards so that I can try to make this in before the string freeze window closes. General note for the future -- it would have been better if the patch for renaming the existing script had stayed separate; in fact, that kind of refactoring should have been a separate bug since the name of the serials claim export script has no direct bearing on the functionality of the feature proposed here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #48 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11167] Remove memcached config from koha-conf-site.xml.in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Robin Sheat changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11167] Remove memcached config from koha-conf-site.xml.in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Robin Sheat changed: What|Removed |Added Attachment #22576|0 |1 is obsolete|| --- Comment #2 from Robin Sheat --- Created attachment 22614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22614&action=edit Bug 11167 - Remove memcached config from koha-conf-site.xml.in Memcached-configuration is now done with environment variables or SetEnv in the Apache configs. Having remnants of the now obsolete configuration in koha-conf.xml might cause confusion as to where memcached is actually configured. This patch removes the two lines related to memcached from koha-conf-site.xml.in To test, the hard way: - Apply the patch - Build packages - Install package - Create instances and enable memcached - Check that memcached is used, even without the settings in koha-conf.xml To test, the easy way: - On an installation running off the packages, verify that memcached is actually configured through environment variables/SetEnv in the Apache configs, and not through koha-conf.xml Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11167] Remove memcached config from koha-conf-site.xml.in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Robin Sheat changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11173] Carriage returns are missing in email notification when content type is html
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 --- Comment #3 from Katrin Fischer --- Hm that last sentence didn't make sense: make line breaks for an easier readable template, but don't want them to appear in my notice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11173] Carriage returns are missing in email notification when content type is html
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hm, not sure, but would we not be using and HTML block elements to create line breaks in HTML overdues? If I am using HTML I might make line breaks for better and easier readable display and wouldn't want those interpreted as new lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11174] Wrong paramter 'valuec' in opac-authoritiessearchresultlist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174 --- Comment #2 from Zeno Tajoli --- Test plan: 1)Insert an authority record with a 5xx field (on MARC21 or UNIMARC) 2)Index the record 3)Seek the record 4)Clik one of the link build from the 5xx field, the link doesn't work 5)Apply the patch 6)Close the browser 7)Open the opac and select the english interface 8)Redo the search 9)Now the link works 10)To use the patch in others languages you need to regenerate the templates. After test the 'prog' templates you need to test it with to 'bootstrap' templates but it is not clear for me how to do, ask on koha-dev mailing list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11174] Wrong paramter 'valuec' in opac-authoritiessearchresultlist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174 Zeno Tajoli changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11174] Wrong paramter 'valuec' in opac-authoritiessearchresultlist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174 --- Comment #1 from Zeno Tajoli --- Created attachment 22613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22613&action=edit Changes for opac-authoritiessearchresultlist templates Patch for prog and bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent records child records (aka. component parts) in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 22612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22612&action=edit Bug 11175 - Show the parent records child records (aka. component parts) in the detailed views. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent records child records (aka. component parts) in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti changed: What|Removed |Added Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored --- Comment #1 from Olli-Antti Kivilahti --- Sponsored by the Joensuu Regional Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] New: Show the parent records child records (aka. component parts) in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Bug ID: 11175 Summary: Show the parent records child records (aka. component parts) in the detailed views. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: olli-antti.kivila...@jns.fi QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl TERMINOLOGY: "Child record" or "Component part": A Bibliographic record connected to it's host record via $773w -> 001 or via other Record-control-number-index relation. "Host record": A bibliographic record which contains child records. Host record doesn't have a link to the child record. USEFUL: For music cataloguers whose jobs depend on these. For browsing the contents of a musical record. Provides the basis for a high quality music library service. Because Koha has the building blocks to create these child records out of box, it is odd that they can't be displayed out of box. This patch adds a system preference AddChildRecordsToDetailedViews. This controls if child records data is appended after the bibliographic data for XSLT parsing. Also makes sure that child records are not pulled needlessly for non-detailed views as this would cripple performance. Modifies the default XSLT templates: MARC21slim2intranetDetail.xsl and MARC21slim2OPACDetail.xsl to display the child record data as HTML. Modifies .css files as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788
--- Comment #38 from M. Tompsett ---
I did not run any code that would trigger all the change points in the
"Followup removing the alldates parameter" patch. I did, however, do a file
comparison between master and the modified code to confirm that the code was
identical. That would mean the last four diffs are fully accounted for, because
the left side of the diffs are due to another part of the four patches attached
to this bug.
Since I also ran the prove on the attached test, I know the SQL function is
working, and hence the first portion of this specific patch ("Followup removing
the alldates parameter") is functional.
It seems that initially, the code was NOT called with a parameter passed for
$alldates, and so the unless statement was always run. This is why it was moved
up into the SQL, which is working. I suppose ordering by priority is considered
part of the improvements too. And with the addition of the waitingdate into the
SQL statement there is an improvement by including a confirmed future hold.
Though, this is the part that makes me feel uncomfortable signing this off,
even though it probably is okay.
This series of patches have removed the alldates parameter and just put the
date restriction into the function. The perldoc has been appropriately updated
as well.
mtompset@ubuntu:~/kohaclone$ git reset --hard origin/master
HEAD is now at 5d7aa7e Bug 10725: Add filters on the pending orders table
mtompset@ubuntu:~/kohaclone$ grep -n GetReservesFromItemnumber `find . -name
"*.p[lm]" | grep -v blib` `find . -name "*.t"`
./C4/Reserves.pm:98:&GetReservesFromItemnumber
./C4/Reserves.pm:351:=head2 GetReservesFromItemnumber
./C4/Reserves.pm:353: ( $reservedate, $borrowernumber, $branchcode, $reserve_id
) = GetReservesFromItemnumber($itemnumber);
./C4/Reserves.pm:359:sub GetReservesFromItemnumber {
./circ/transferstoreceive.pl:102:my @checkreserv =
GetReservesFromItemnumber($num->{'itemnumber'} );
./opac/opac-reserve.pl:434:my ($reservedate,$reservedfor,$expectedAt) =
GetReservesFromItemnumber($itemNum);
./reserve/request.pl:331:my
($reservedate,$reservedfor,$expectedAt,$reserve_id) =
GetReservesFromItemnumber($itemnumber);
./catalogue/detail.pl:223:my ($reservedate,$reservedfor,$expectedAt) =
GetReservesFromItemnumber($item->{itemnumber});
./t/db_dependent/Holds.t:79:my ( $reservedate, $borrowernumber, $branchcode,
$reserve_id ) = GetReservesFromItemnumber($itemnumber);
./t/db_dependent/Holds.t:80:ok($reserve_id, "Test
GetReservesFromItemnumber()");
./t/db_dependent/Holds.t:95:( $reservedate, $borrowernumber, $branchcode,
$reserve_id ) = GetReservesFromItemnumber($itemnumber);
mtompset@ubuntu:~/kohaclone$ git bz apply 9788
Bug 9788 - Improvements for calling GetReservesFromItemnumber
19943 - [SIGNED_OFF] Bug 9788: Improvements when calling
GetReservesFromItemnumber
21479 - Bug 9788: Followup removing the alldates parameter
22309 - [SIGNED_OFF] Bug 9788: Followup for expirationdate in Letter.pm
22610 - [SIGNED OFF] Bug 9788: Unit tests for changed routine
GetReservesFromItemnumber
Apply? [(y)es, (n)o, (i)nteractive] i
Applying: Bug 9788: Improvements when calling GetReservesFromItemnumber
Applying: Bug 9788: Followup for expirationdate in Letter.pm
Applying: Bug 9788: Unit tests for changed routine GetReservesFromItemnumber
Applying: Bug 9788: Followup removing the alldates parameter
mtompset@ubuntu:~/kohaclone$ grep -n GetReservesFromItemnumber `find . -name
"*.p[lm]" | grep -v blib` `find . -name "*.t"`
./C4/Reserves.pm:98:&GetReservesFromItemnumber
./C4/Reserves.pm:351:=head2 GetReservesFromItemnumber
./C4/Reserves.pm:353: ( $reservedate, $borrowernumber, $branchcode,
$reserve_id, $waitingdate ) = GetReservesFromItemnumber($itemnumber);
./C4/Reserves.pm:361:sub GetReservesFromItemnumber {
./circ/transferstoreceive.pl:102:my @checkreserv =
GetReservesFromItemnumber($num->{'itemnumber'});
./opac/opac-reserve.pl:434:my
($reservedate,$reservedfor,$expectedAt,undef,$wait) =
GetReservesFromItemnumber($itemNum);
./reserve/request.pl:331:my
($reservedate,$reservedfor,$expectedAt,$reserve_id,$wait) =
GetReservesFromItemnumber($itemnumber);
./catalogue/detail.pl:223:my
($reservedate,$reservedfor,$expectedAt,undef,$wait) =
GetReservesFromItemnumber($item->{itemnumber});
./t/db_dependent/Reserves.t:269:# Tests for bug 9788: Does
GetReservesFromItemnumber return a future wait?
./t/db_dependent/Reserves.t:270:# 9788a: GetReservesFromItemnumber does not
return future next available hold
./t/db_dependent/Reserves.t:280:my @results=
GetReservesFromItemnumber($itemnumber);
./t/db_dependent/Reserves.t:281:is(defined $results[3]?1:0, 0,
'GetReservesFromItemnumber does not return a future next available hold');
./t/db_dependent/Reserves.t:282:# 9788b: GetReservesFromItemnumber does not
return future item level hold
./t/db_dependent/Reserves.t:287:my @results=
GetRese
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. Tompsett changed: What|Removed |Added Attachment #21750|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. Tompsett changed: What|Removed |Added Attachment #22610|0 |1 is obsolete|| --- Comment #37 from M. Tompsett --- Comment on attachment 22610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22610 [SIGNED OFF] Bug 9788: Unit tests for changed routine GetReservesFromItemnumber FAIL t/db_dependent/Reserves.t OK pod OK forbidden patterns FAIL valid "my" variable @results masks earlier declaration in same scope OK critic Oops! Caught this while looking at the other patch, not signed off patch. I really should run this all the time. Sorry, I should not have signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11174] Wrong paramter 'valuec' in opac-authoritiessearchresultlist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174 Zeno Tajoli changed: What|Removed |Added Assignee|oleon...@myacpl.org |z.taj...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11174] Wrong paramter 'valuec' in opac-authoritiessearchresultlist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174 Zeno Tajoli changed: What|Removed |Added Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11174] New: Wrong paramter 'valuec' in opac-authoritiessearchresultlist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174 Bug ID: 11174 Summary: Wrong paramter 'valuec' in opac-authoritiessearchresultlist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: z.taj...@cineca.it QA Contact: testo...@bugs.koha-community.org In the template opac-authoritiessearchresultlist are dinamic written link with 5xx heading. But in the link is used a wrong 'valuec' parameter instead of 'value'. It is present in prog and in / bootstrap template opac-authoritiessearchresultlist.tt In prog it is at line 62 In bootstrap it is at line 88 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11173] Carriage returns are missing in email notification when content type is html
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 --- Comment #1 from Sophie MEYNIEUX --- Created attachment 22611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22611&action=edit Bug 11173 : Notifications by email lacks carriage returns if content type is HTML Test plan : - Define one letter template for overdues for example - Check "HTML Message" - Define some overdue rules that are using this letter - Find one borrower that has overdues triggering this notification. - Run misc/cronjobs/overdue_notices.pl to generate the message and change to_address to give your email Without patch : - run misc/cronjobs/process_messsage_queue.pl => email content is all on one line With the patch : - change message status to 'pending' so that it could be sent once again - run misc/cronjobs/process_message_queue.pl => email content is displaid correctly with carriage returns as defined in template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11173] Carriage returns are missing in email notification when content type is html
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 Sophie MEYNIEUX changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |sophie.meyni...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11173] New: Carriage returns are missing in email notification when content type is html
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 Bug ID: 11173 Summary: Carriage returns are missing in email notification when content type is html Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meyni...@biblibre.com QA Contact: testo...@bugs.koha-community.org Notifications by email lacks carriage returns if content type is HTML Test plan : - Define one letter template for overdues for example - Check "HTML Message" - Define some overdue rules that are using this letter - Find one borrower that has overdues triggering this notification. - Run misc/cronjobs/overdue_notices.pl to generate the message and change to_address to give your email Without patch : - run misc/cronjobs/process_messsage_queue.pl => email content is all on one line With the patch : - change message status to 'pending' so that it could be sent once again - run misc/cronjobs/process_message_queue.pl => email content is displaid correctly with carriage returns as defined in template -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. Tompsett changed: What|Removed |Added Attachment #21750|0 |1 is obsolete|| CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #36 from M. Tompsett --- Created attachment 22610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22610&action=edit [SIGNED OFF] Bug 9788: Unit tests for changed routine GetReservesFromItemnumber Adds three tests to Reserves.t for GetReservesFromItemnumber. We test if this routine does not return a future next available hold, a future item level hold. And if it does return a future wait (that is: a confirmed future hold, using ConfirmFutureHolds). Note that Holds.t does also contains some basic tests for this routine, but the additional tests seem to better located in the direct context of tests for bug 9761 for ConfirmFutureHolds. Test plan: Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t. Verify if both tests do not fail. Holds.t required adding CPL branch to function. Reserves.t does not fail for the three tests in question. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #43 from Paola Rossi --- Thanks, Jonathan. Applying the patch is OK. I get this error message during step 3 of web installation: The following error occurred while importing the database structure: ERROR 1064 (42000) at line 3320: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '| CREATE TABLE `additional_field_values` ( `id` int(11) NOT NULL AUTO_IN' In installer/data/mysql/updatedatabase.pl, there a 'q' instead of 'qq' in two lines, and in kohastructure.sql the ending char of two lines is wrong [v. ENGINE=InnoDB DEFAULT CHARSET=utf8 |]. So I pass the patch to "failed QA" status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11172] New: Reports need a clear filter button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11172 Bug ID: 11172 Summary: Reports need a clear filter button Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcha...@gmail.com Reporter: david.robe...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Once a report filter has been applied, it doesn't seem possible to clear the filter without logging out of Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 Tomás Cohen Arazi changed: What|Removed |Added Attachment #20743|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi --- Created attachment 22609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22609&action=edit Bug 10003: bash-completion for koha-list and some other script This is an initial commit submitted for peer review. It implements bash-completion for the following commands: - koha-list - koha-enable - koha-disable - koha-email-enable - koha-email-disable - koha-enable-sip - koha-start-sip - koha-restart-sip - koha-stop-sip - koha-start-zebra - koha-stop-zebra - koha-restart-zebra It is implemented in a way that it removes already used or mutually exclusive parameters (instance names, option switches). I already have written completion for other (more complex) commands, But I belive a simpler patch is better to start with. IMPORTANT: this patch relies on having the koha-list command available in the path. Also 10622 is needed for the SIP-related option switches. To test: - Make sure you have bash-completion installed and enabled (IRC might help us if you encounter problems). - Apply the patch. Option 1: - Pick the debian/koha-common.bash-completion file and do $ cp debian/koha-common.bash-completion /etc/bash_completion.d/koha-common - Open a new bash shell (I do it opening a new terminal on my Ubuntu box). - Type one of the listed commands... And repeatedly press . - Enjoy, and signoff if you belive it is usable. Otherwise report back. Option 2: - run: $ . debian/koha-common.bash-completion - Type one of the listed commands... And repeatedly press . - Enjoy, and signoff if you belive it is usable. Otherwise report back. Tests: - Some koha-list option switches are mutually exclusive, -h should be available in any context - koha-enable should only autocomplete disabled instances - koha-disable should only autocomplete enabled instances - koha-email-enable should only autocomplete email-disabled instances - koha-email-disable should only autocomplete email-enabled instances - koha-*-zebra scripts should only autocomplete enabled instances. - koha-*-sip scripts should only autocomplete sip-enabled instances. Regards To+ Note: writing bash-completion routines is a bit hacky, I tried to make it the simplest way I could. Your comments are welcome. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10501] Can't order more than 1 when importing all from staged file (AcqCreateItem = on order)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10501 marjorie barry-vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #39 from Jonathan Druart --- Created attachment 22605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22605&action=edit Bug 10855: Search subscriptions by additional fields Now you will abble to search subscriptions by additional fields. The additional field values will be displayed in the table results. Test plan: - go on the subscriptions advanced search page (serials/serials-search.pl). - verify all searchable additional fields are displayed on the form. - combine 1 or more values and verify results are consistent. - verify the values are displayed in new columns of the table. - for field linked to an authorised value category, the description is displayed (not the code). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #42 from Jonathan Druart --- Created attachment 22608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22608&action=edit Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #40 from Jonathan Druart --- Created attachment 22606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22606&action=edit Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #41 from Jonathan Druart --- Created attachment 22607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22607&action=edit Bug 10855: FIX: Add additional fields for closed subscriptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #37 from Jonathan Druart --- Created attachment 22603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22603&action=edit Bug 10855: interface configuration for adding new fields to subscriptions This patch adds an interface configuration for adding fields to subscriptions. Test plan: - go to serials/serials-home.pl - click on the "Add subscription fields" link on the left of the screen - try to add/update/delete new fields You are not abble to add a field with an authorised value category and a marcfield. Columns are sortable - for the rest, you should have, at least: * a new field named af1, sortable, linked to a category * a new field named af2, sortable, linked to a marcfield * a new field named af3, not sortable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #38 from Jonathan Druart --- Created attachment 22604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22604&action=edit Bug 10855: New fields on adding/updating a subscription This patch adds the ability to add values for additional fields when adding/updating a subscription. Test plan (test the following on adding a new subscription and on editing an existent one): - add/edit a subscription. - verify all additional fields appears into the "Additional fields" block. - fill a value for af1 and af3. - fill others values if you are adding a new subscription. - save. - verify values appears on the detail of the subscription page. - verify the af2 field is automatically filled with the specified marc field of the notice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #36 from Jonathan Druart --- Created attachment 22602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22602&action=edit Bug 10855: Add unit tests for the new package Koha::AdditionalField Test plan: - prove t/db_dependent/AdditionalField.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #35 from Jonathan Druart --- Created attachment 22601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22601&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What|Removed |Added Attachment #22049|0 |1 is obsolete|| Attachment #22050|0 |1 is obsolete|| Attachment #22051|0 |1 is obsolete|| Attachment #22052|0 |1 is obsolete|| Attachment #22053|0 |1 is obsolete|| Attachment #22054|0 |1 is obsolete|| Attachment #22055|0 |1 is obsolete|| Attachment #22359|0 |1 is obsolete|| Attachment #22360|0 |1 is obsolete|| --- Comment #34 from Jonathan Druart --- Created attachment 22600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22600&action=edit Bug 10855: Add the new package Koha::AdditionalField -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What|Removed |Added Attachment #22309|Bug 9788: Followup for |[SIGNED_OFF] Bug 9788: description|expirationdate in Letter.pm |Followup for expirationdate ||in Letter.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What|Removed |Added Attachment #19943|Bug 9788: Improvements when |[SIGNED_OFF] Bug 9788: description|calling |Improvements when calling |GetReservesFromItemnumber |GetReservesFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #35 from M. de Rooy --- This report still needs some help! There are four patches (two have a signoff). Two patches need a signoff: the unit test and the alldates followup. For testing you need to run two unit tests (see commit message). And follow the test plan in the alldates followup. You should be able to complete them in well 10 minutes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #33 from Paola Rossi --- against master 3.13.00.034: Applying: Bug 10855: New fields on adding/updating a subscription Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging serials/subscription-detail.pl Auto-merging serials/subscription-add.pl CONFLICT (content): Merge conflict in serials/subscription-add.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging C4/Serials.pm CONFLICT (content): Merge conflict in C4/Serials.pm Failed to merge in the changes. Patch failed at 0001 Bug 10855: New fields on adding/updating a subscription So I pass tha patch to "Failed QA" status. NB. Update database entry needs to be rebased too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #31 from Paul Poulain --- (In reply to Galen Charlton from comment #25) > Broader question: do we really need another field in the items table? Why > not just tweak AnonymiseIssueHistory() so that if StoreLastBorrower is set, > old_issue rows that are the most recent return for their items are not > anonymized? The more I think of it, the less I like this patch : it introduces a duplicate information in our database: the last patron is in old_issues and in items.last_borrower I agree that the old_issues information can be removed by anonymisation. But a better option, imho, would be to improve anonymization, to have something like: * anonymize * anonymize except the last patron * don't anonymize However, I'm not the RM, so Galen final cut. But I really think that, on the long term, this patch introduces some inconsistencies, and thus, pain. (Sorry not to have written this earlier) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9822] No alert appears on adding an order to a basket if the budget has exceeded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What|Removed |Added Assignee|colin.campbell@ptfs-europe. |matthias.meusburger@biblibr |com |e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939 Fridolyn SOMERS changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #7 from Fridolyn SOMERS --- Created attachment 22599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22599&action=edit Bug 10939 - ICU does not transliterate polish special characters Polish characters added to ICU config -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7627] Editing of invoice number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7627 marjorie barry-vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7255] Information on Holds Transfer Slips is Inconsistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255 --- Comment #9 from Heather Braum --- There was discussion on this bug more than a year ago--is it going to move anywhere? What will it take for that to happen? I see Chris' comment that there's a deeper issue going on. Just curious -- this issue is affecting our libraries, too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11171 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11171] The basket group is not displayed on the supplier list page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11171] The basket group is not displayed on the supplier list page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171 Jonathan Druart changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11171] The basket group is not displayed on the supplier list page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11171] The basket group is not displayed on the supplier list page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171 --- Comment #1 from Jonathan Druart --- Created attachment 22598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22598&action=edit Bug 11171: Display basket group name on the supplier list page Test plan: search supplier and verify the basket group column is filled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11171] New: The basket group is not displayed on the supplier list page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171 Bug ID: 11171 Summary: The basket group is not displayed on the supplier list page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Jonathan Druart changed: What|Removed |Added Depends on||5336 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart changed: What|Removed |Added Blocks||11170 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 --- Comment #1 from Jonathan Druart --- Created attachment 22597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22597&action=edit Bug 11170: The pending order list should only display orders to receive The order status ordered is set when the basket is closed. The parcel page should only display status "ordered" and "partial". Test plan: - create a basket. - create an order. - verify the order is not listed on the parcel page (i.e. you cannot receive it). - close the basket. - verify the order is listed on the parcel page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] New: The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Bug ID: 11170 Summary: The pending order list should only display orders to receive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org The parcel page should only display status "ordered" and "partial". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart changed: What|Removed |Added Blocks||11169 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED Depends on||5336 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996 Paola Rossi changed: What|Removed |Added Attachment #22586|0 |1 is obsolete|| --- Comment #14 from Paola Rossi --- Created attachment 22596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22596&action=edit Cannot exclude numeric subfields on export The deletes are being applied to all occurences. I sign off the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #2 from Jonathan Druart --- Created attachment 22595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22595&action=edit Bug 11169: [Bootstrap] Display acquition details at the OPAC Patch for the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #1 from Jonathan Druart --- Created attachment 22594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22594&action=edit Bug 11169: Display acquition details at the OPAC This patch adds a new tab 'Acquisition detail' on the OPAC detail page. A syspref (OPACAcquisitionDetails) permits to turn on this feature. Test plan: - switch on the OPACAcquisitionDetails pref. - set the AcqCreateItems pref to 'receiving'. - create some orders on 1 or more items. - go to the opac detail page and verify the "acquitision details" tab contains the right number of items which is in order. - receive the items. - verify the number of items has decreased. - set the AcqCreateItems pref to 'ordering'. - create some orders on 1 or more items. - go to the opac detail page and verify the "acquitision details" tab contains the list of items which is in order. - receive the items. - verify the received items don't appear anymore in the table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895
--- Comment #10 from M. Tompsett ---
Here is how I tested this.
mtompset@ubuntu:~/kohaclone$ git reset --hard origin/master
HEAD is now at 5d7aa7e Bug 10725: Add filters on the pending orders table
mtompset@ubuntu:~/kohaclone$ git bz apply 10900
Bug 10900 - Incorrect calling conventions accessing C4::Context
22585 - Bug 10900 - Incorrect calling conventions accessing C4::Context
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 10900 - Incorrect calling conventions accessing C4::Context
mtompset@ubuntu:~/kohaclone$ git bz apply 10589
Bug 10589 - Override OpacHiddenItems based on Patron Category
22587 - Bug 10589 - Override OpacHiddenItems based on Patron Category
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 10589 - Override OpacHiddenItems based on Patron Category
mtompset@ubuntu:~/kohaclone$ git bz apply 10895
Bug 10895 - Tests for C4::Items GetHiddenItems
21153 - Bug 10895 - Tests for C4::Items GetHiddenItems
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 10895 - Tests for C4::Items GetHiddenItems
mtompset@ubuntu:~/kohaclone$ prove -v
t/db_dependent/GetHiddenItems_PatronCategory.t
t/db_dependent/GetHiddenItems_PatronCategory.t ..
1..22
ok 1 - use C4::Items;
ok 2 - LIB1 Item linked to correct biblionumber.
ok 3 - LIB1 Item linked to correct biblioitemnumber.
ok 4 - LIB2 Item linked to correct biblionumber.
ok 5 - LIB2 Item linked to correct biblioitemnumber.
$VAR1 = {
'firstname' => 'Sample',
'userid' => 'Sample.Borrower',
'categorycode' => 'PT',
'phone' => '967-',
'zipcode' => 'H0H 0H0',
'surname' => 'Borrower',
'email' => 'sa...@northpole.com',
'city' => 'Bogusville',
'address' => '123 Bogus Street',
'branchcode' => 'LIB1'
};
# Sample Borrower added.
CHECK: 225
dtHtmrYqik
# 79273 - LIB1
# 79274 - LIB2
ok 6 - OpacHiddenItems hid everything correctly.
# 79273,79274
# Borrower number: 225
# Sample Borrower environment variables set up.
ok 7 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SPT
# PatronEveryBranch: SPT
#
ok 8 - OpacHiddenItems hid LIB2 correctly.
# PatronSingleBranch: SPT
# PatronEveryBranch: SS
# 79274
ok 9 - OpacHiddenItems hid LIB2 correctly.
# PatronSingleBranch: SPT
# PatronEveryBranch: ''
# 79274
ok 10 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SPT
# PatronEveryBranch: SS|SPT
#
ok 11 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: SPT
#
ok 12 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: SS
# 79273,79274
ok 13 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: ''
# 79273,79274
ok 14 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: SS|SPT
#
ok 15 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: SPT
#
ok 16 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: SS
# 79273,79274
ok 17 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: ''
# 79273,79274
ok 18 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: SS|SPT
#
ok 19 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SPT
#
ok 20 - OpacHiddenItems hid LIB2 correctly.
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SS
# 79274
ok 21 - OpacHiddenItems hid LIB2 correctly.
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: ''
# 79274
ok 22 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SS|SPT
#
ok
All tests successful.
Files=1, Tests=22, 1 wallclock secs ( 0.01 usr 0.01 sys + 0.42 cusr 0.01
csy
s = 0.45 CPU)
Result: PASS
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Fridolyn SOMERS changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m --- Comment #16 from Fridolyn SOMERS --- > the commit message states that 995... will be automatically filled. And this > is indeed hardcoded The subfield $h was also hardcoded. It has been corrected by Bug 9947. This patch should be corrected the same way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Component|OPAC|Acquisitions Assignee|oleon...@myacpl.org |jonathan.dru...@biblibre.co ||m Summary|Display an acquisition |OPAC: Display an |details tab |acquisition details tab -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] New: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Bug ID: 11169 Summary: Display an acquisition details tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10842] Allow for new type of LDAP authentication - Further Enhancement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10842 --- Comment #6 from Martin Renvoize --- I'm not actually sure if this is required anymore? If someone has a requirement for searching thier LDAP using a service account before doing a koha user bind, let me know and I'll rebase the patch. But I have a feeling that this is now null and void as Robin re-implemented direct binding in bug 10908 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #53 from Martin Renvoize --- Thanks Julian, Applies beautifully... now for some testing :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10851] Add missing statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851 Jonathan Druart changed: What|Removed |Added Attachment #22460|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 22593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22593&action=edit Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never received, sold out, damaged or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice changed: What|Removed |Added Attachment #22583|0 |1 is obsolete|| --- Comment #51 from Julian Maurice --- Created attachment 22591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22591&action=edit Bug 8993 [Follow-up] update and replicate options used at wrong place Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice changed: What|Removed |Added Attachment #22584|0 |1 is obsolete|| --- Comment #52 from Julian Maurice --- Created attachment 22592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22592&action=edit Bug 8993: Add branchcode and categorycode mappings for sample module Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice changed: What|Removed |Added Attachment #22582|0 |1 is obsolete|| --- Comment #50 from Julian Maurice --- Created attachment 22590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22590&action=edit Bug 8993 - my attempt to get this module working Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice changed: What|Removed |Added Attachment #22581|0 |1 is obsolete|| --- Comment #49 from Julian Maurice --- Created attachment 22589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22589&action=edit Bug 8993: Follow-up - LDAP authentication improvements Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #47 from Julian Maurice --- Hmm I forgot to fetch the git remote before rebasing... Rebased patches are coming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice changed: What|Removed |Added Attachment #22580|0 |1 is obsolete|| --- Comment #48 from Julian Maurice --- Created attachment 22588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22588&action=edit Bug 8993: LDAP authentication improvements Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895 M. Tompsett changed: What|Removed |Added Depends on||10589 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Blocks||10895 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #46 from Martin Renvoize --- Great fast response Julian.. unfortunately I still can't get it to apply :( Falling back to patching base and 3-way merge... Auto-merging C4/Auth_with_ldap.pm CONFLICT (content): Merge conflict in C4/Auth_with_ldap.pm Failed to merge in the changes. Patch failed at 0001 Bug 8993: LDAP authentication improvements Looking at the merge markers, it looks like the main routine 'checkpw_ldap' is the issue, but it's such an extensive re-write that I don't want to screw it up by trying to merge it myself. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Olli-Antti Kivilahti changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Attachment #21620|0 |1 is obsolete|| --- Comment #20 from M. Tompsett --- Created attachment 22587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22587&action=edit Bug 10589 - Override OpacHiddenItems based on Patron Category Two system preferences, PatronSingleBranch and PatronEveryBranch, have been added to facilitate some granularity on the override. If the home branch of the item and the patron match and the catgegory code of the patron matches one of the pipe delimited values in the PatronSingleBranch patron category code, then an item which would normally be hidden will be visible. If the patron category matches one of the pipe delimited values in the PatronEveryBranch patron category, then every item hidden by OpacHiddenItems will be visible. Since the patron category codes used by default for these two system preferences are not added, OpacHiddenItems will continue function as expected until individual patrons and system preferences are configured. There is no need to provide this functionality to staff, as they have access to the staff client. Rebased to current master (again). Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #21 from M. Tompsett --- Rebased again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996 Colin Campbell changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #13 from Colin Campbell --- Reset status to needs signoff. Would be grateful if folks could retest and confirm that deletes are being applied to all occurences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996 Colin Campbell changed: What|Removed |Added Attachment #22009|0 |1 is obsolete|| --- Comment #12 from Colin Campbell --- Created attachment 22586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22586&action=edit Amended patch Expanded the patch to ensure that all occurences of the tag are processed not just the first as previously was the case -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10421] Add cron script to delete deleted records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421 Kyle M Hall changed: What|Removed |Added Status|Failed QA |RESOLVED CC||k...@bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #16 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 11084 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Kyle M Hall changed: What|Removed |Added CC||kyle.m.h...@gmail.com --- Comment #8 from Kyle M Hall --- *** Bug 10421 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Kyle M Hall changed: What|Removed |Added Attachment #22038|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall --- Created attachment 22585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22585&action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep "::set_userenv" `find .` grep "\->set_userenv" `find .` The first grep demonstrated that the smaller change is from :: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use ->) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #45 from Julian Maurice --- I rebased all patches but not tested them. Hope it will works :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice changed: What|Removed |Added Attachment #21349|0 |1 is obsolete|| --- Comment #44 from Julian Maurice --- Created attachment 22584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22584&action=edit Bug 8993: Add branchcode and categorycode mappings for sample module Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
