[Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 --- Comment #38 from Bernardo Gonzalez Kriegel --- Now when adding to a basket "Publisher/Publication place/Collection title" shows up, good. [neworderempty.pl?booksellerid=MM&basketno=LL&suggestionid=OO] But when viewing a basket you press Modify (ej. to alter quantity), [neworderempty.pl?ordernumber=NN&booksellerid=MM&basketno=LL] that information does not shows. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
--- Comment #29 from M. Tompsett ---
Comment on attachment 27049
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27049
Bug 5010: Fix incomplete links in carts and lists sent from the staff client
Review of attachment 27049:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5010&attachment=27049)
-
::: opac/opac-sendshelf.pl
@@ +109,5 @@
>
> +if (C4::Context->preference('OPACBaseURL')){
> + $template2->param( OPACBaseURL =>
> C4::Context->preference('OPACBaseURL') );
> +}
> +
Nope. Triple check shows this is what it was before. Removing probably does
correct a problem, but it is unrelated to this bug (carts and lists in staff).
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
--- Comment #28 from M. Tompsett ---
Comment on attachment 27049
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27049
Bug 5010: Fix incomplete links in carts and lists sent from the staff client
Review of attachment 27049:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5010&attachment=27049)
-
::: basket/sendbasket.pl
@@ +102,5 @@
>
> +if (C4::Context->preference('OPACBaseURL')){
> +my $protocol = C4::Context->preference('OpacProtocol') // 'http://';
> +$template2->param( OPACBaseURL => $protocol .
> C4::Context->preference('OPACBaseURL') );
> +}
koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasketform.tt does not have
OPACBaseURL in it. However, doc-head-close.inc does. This is a short-term fix,
as the problem in doc-head-close.inc affects much more than just carts and
lists.
::: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt
@@ +35,4 @@
> LCCN: [% BIBLIO_RESULT.lccn %][% END %][% IF ( BIBLIO_RESULT.url ) %]
> URL : [% BIBLIO_RESULT.url %][% END %][% IF ( OPACBaseURL ) %]
> In the online catalog:
> +[% Koha.Preference( 'OPACProtocol' ) %][% OPACBaseURL
> %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% BIBLIO_RESULT.biblionumber
> |url %][% END %]
Took Kyle's second suggestion from comment #21.
::: opac/opac-sendshelf.pl
@@ +109,5 @@
>
> +if (C4::Context->preference('OPACBaseURL')){
> + $template2->param( OPACBaseURL =>
> C4::Context->preference('OPACBaseURL') );
> +}
> +
Oops. I think I let a bad piece in.
::: virtualshelves/sendshelf.pl
@@ +103,2 @@
>if (C4::Context->preference('OPACBaseURL')){
> +$template2->param( OPACBaseURL =>
> C4::Context->preference('OPACBaseURL') );
This represents changing it back to what it was initially.
@@ -104,2 @@
>if (C4::Context->preference('OPACBaseURL')){
> -$template2->param( OPACBaseURL => $protocol .
> C4::Context->preference('OPACBaseURL') );
The protocol logic is moved to the template now. Only need the OPACBaseURL,
which is not available by default for staff client pages.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #27 from M. Tompsett --- Created attachment 27049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27049&action=edit Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new OPAC system preference, OpacProtocol, in the Policy subsection. It defaults to "doesn't use" (http://), but can be changed to "uses" (https://). basket/sendbasket.pl was tweaked for OpacProtocol changes. opac/opac-sendshelf.pl was returned to previous state, because it affects doc-head-close.inc if OPACBaseURL is not passed. This should be fixed to use the OpacProtocol system preference in another bug fix. virtualshelves/sendshelf.pl was returned to previous state, because the OpacProtocol logic is now in the virtualshelves/sendshelf.tt template file. TEST PLAN - 1) Back up your database 2) Drop your koha database and recreate it empty 3) In the mysql client: > SOURCE .../installer/data/mysql/sysprefs.sql; -- It should run without error. > SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 4) Restore your database 5) $ ./installer/data/mysql/updatedatabase.pl -- It should run the upgrade to insert OpacProtocol. 6) In the mysql client: > SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 7) Log into the staff client 8) Click 'Koha administration' 9) Click 'Global system preferences' 10) Click the 'OPAC' tab on the left side. 11) Scroll down to the Policy section, and find the OpacProtocol preference. -- It should have a value of "doesn't use" in the drop down. 12) Fill your cart with something(s). 13) Make sure you have a list filled with something(s). 14) Click 'Cart' in the top menu bar area. 15) Click 'Send', and send it to yourself. 16) Click 'Close window' 17) Click 'Hide window' 18) Click 'More' and click 'Lists' 19) Choose a list and 'Send list' to yourself. 20) Check your email -- both emails should have OPAC URLs which start with http:// 21) Change the OPAC system preference OpacProtocol to 'uses' (https://), log out and log in (to force refresh of cached system preferences), and repeat steps 14 through 19. 22) Check your email -- the two new emails should have OPAC URLS which start with https:// NOTE: Other URLs may be broken as well, this bug only fixes carts and lists sent from staff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12078] New: z3950_search.pl parser error when viewing card
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12078 Bug ID: 12078 Summary: z3950_search.pl parser error when viewing card Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org Similar to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9668, we get an error in z3950_search.pl when we click on the card link in 3.12. It produces the following software error: :241: parser error : PCDATA invalid Char value 28 Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12077] New: Give superlibrarian ability to remove selected patron fine history.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12077 Bug ID: 12077 Summary: Give superlibrarian ability to remove selected patron fine history. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Would like to see a way for the superlibrarian to remove line items in patron fine history. Either through manual manipulation with checkboxes, or through a batch process. This would be particularly helpful in purging old data. But in particular, we need a better way to get rid of unwanted credit on a patron account. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #27014|0 |1 is obsolete|| --- Comment #36 from Bernardo Gonzalez Kriegel --- Created attachment 27048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27048&action=edit [SIGNED-OFF] Bug 766: Use a tt include instead of a method in the AV plugin Signed-off-by: Bernardo Gonzalez Kriegel This gives a koha-qa error, but on another user/env not. Really don't know -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #27013|0 |1 is obsolete|| --- Comment #35 from Bernardo Gonzalez Kriegel --- Created attachment 27047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27047&action=edit [SIGNED-OFF] Bug 766: Cleaning: buildCGISort is not in use anymore buildCGISort can be deleted. Test plan: git grep buildCGISort should return no result. Signed-off-by: Bernardo Gonzalez Kriegel No more buildCGISort -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #27010|0 |1 is obsolete|| --- Comment #32 from Bernardo Gonzalez Kriegel --- Created attachment 27044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27044&action=edit [SIGNED-OFF] Bug 766: Move GetAuthvalueDropbox to C4::Koha GetAuthvalueDropbox is in C4::Budgets, this does not make sense. Only acqui/fetch_sort_dropbox.pl call GetAuthvalueDropbox without using C4::Koha. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #27012|0 |1 is obsolete|| --- Comment #34 from Bernardo Gonzalez Kriegel --- Created attachment 27046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27046&action=edit [SIGNED-OFF] Bug 766: Use the method plugin to generate sort dropdown list - memberentry Now we can use the method plugin from the memberentry form. Test plan: 1/ Create a patron and verify sort1 and sort2 dropdown list are correctly generated. 2/ Select values. 3/ Save. 4/ Edit the patron and verify the selected values are displayed. Signed-off-by: Bernardo Gonzalez Kriegel Works as described. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #27011|0 |1 is obsolete|| --- Comment #33 from Bernardo Gonzalez Kriegel --- Created attachment 27045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27045&action=edit [SIGNED-OFF] Bug 766: Create a plugin routine to build dropdown list On this way, dropdown list could be generated from the templates. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #31 from Bernardo Gonzalez Kriegel --- (In reply to Owen Leonard from comment #30) > > I get this same error from the QA script, but everything seems to work. Is > it an inaccurate error? I think it is, but don't know why. With another user/repo/etc. gives no error, like Jonathan. For me it works -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12076] xt/tt_valid.t can miss an invalid construct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12076 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12076] xt/tt_valid.t can miss an invalid construct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12076 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #27041|0 |1 is obsolete|| --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 27043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27043&action=edit [SIGNED-OFF] Bug 12076: better detect an untranslatable template construct Per bug 6458, template constructs of the form [2] Run prove -v xt/tt_valid.t. Note that no error is reported. [3] Apply the patch, and rerun the tt_valid.t test. This time, an error should be reported. Signed-off-by: Galen Charlton Signed-off-by: Bernardo Gonzalez Kriegel Works well, detects the forbidden pattern No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Bernardo Gonzalez Kriegel --- (In reply to Owen Leonard from comment #2) > > This should be written: > > [%- IF ( loo.ohidden.default == 0 ) -%] > Show all > [%- ELSE -% > Show all > [%- END -%] Sorry for that, and thanks for testing and the reference :) Now is fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #26829|0 |1 is obsolete|| --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 27042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27042&action=edit Bug 11508 - Untranslatable pull-down in auth_subfields_structure.pl OMG!!, this file is full of tabs and CGI::scrolling_list !!! This patch fix the reported strings and also another one. It removes 2 occurrences of CGI::scrolling_list with untranslatable labels. Fixed capitalization. To test 1. Go to Administration > Authority types, click 'MARC structure' of any auth type, click 'subfields' for any Tag >= 010, clic 'Edit subfields' Check pulldowns 'Manged in tab' and 'Select to display or not' 2. Apply the patch 3. Reload and verify functionality of both pulldowns 4. Check that strings are not present on staff PO file egrep "^msgid \"(Show all|Hide all|ignore)" misc/translator/po/fi-FI-i-staff-t-prog-v-3006000.po 5. Update language file (cd misc/translator/; perl translate update fi-FI) 6. Check that strings are now present, repeat 4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
--- Comment #26 from M. Tompsett ---
Comment on attachment 25878
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25878
[SIGNED OFF] Bug 5010: Send list emails with complete links back into the
catalog
Review of attachment 25878:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5010&attachment=25878)
-
::: opac/opac-sendshelf.pl
@@ -109,5 @@
>
> -if (C4::Context->preference('OPACBaseURL')){
> - $template2->param( OPACBaseURL =>
> C4::Context->preference('OPACBaseURL') );
> -}
> -
Unfortunately, koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc is
affected by the removal:
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #21 from Owen Leonard --- A couple of comments: The system preference name "OpacBelowLoginBox" refers to where it goes rather than what it is. It would be a lot better to have something descriptive, like "OpacLoginHelp" or something like that. The change to the bootstrap theme modifies a different page than the change to the prog theme. I think the change to the prog theme is in the right place: On the full-page login screen where there is currently text about logging in, opac-auth.tt. (It might be good to link to this page directly from the bootstrap theme's login modal so that patrons can read the help text if they want to?) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #25 from M. Tompsett --- Actually, I've started on it, but it may take me another 9 hours before I finish, test, and post it up. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 Galen Charlton changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #4 from Galen Charlton --- (In reply to Katrin Fischer from comment #3) > What is the reason for the -? It's a valid TT construct to make sure it doesn't emit extra whitespace before the value to be put in, and is fine to use -- just not within a tag. See bug 12076 for a change to the test case to catch the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12076] xt/tt_valid.t can miss an invalid construct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12076 Galen Charlton changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12076] xt/tt_valid.t can miss an invalid construct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12076 --- Comment #3 from Galen Charlton --- Created attachment 27041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27041&action=edit Bug 12076: better detect an untranslatable template construct Per bug 6458, template constructs of the form [2] Run prove -v xt/tt_valid.t. Note that no error is reported. [3] Apply the patch, and rerun the tt_valid.t test. This time, an error should be reported. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12076] xt/tt_valid.t can miss an invalid construct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12076 --- Comment #2 from Galen Charlton --- (In reply to Galen Charlton from comment #0) > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12076] xt/tt_valid.t can miss an invalid construct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12076 --- Comment #1 from Galen Charlton --- (In reply to Galen Charlton from comment #0) > Per bug 6458, template constructs of the form > > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12076] New: xt/tt_valid.t can miss an invalid construct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12076 Bug ID: 12076 Summary: xt/tt_valid.t can miss an invalid construct Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: gmcha...@gmail.com QA Contact: testo...@bugs.koha-community.org Per bug 6458, template constructs of the form http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- What is the reason for the -? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 --- Comment #2 from Owen Leonard --- The change to the template includes improperly nested [% IF %]s inside HTML tags: Show all This should be written: [%- IF ( loo.ohidden.default == 0 ) -%] Show all [%- ELSE -% Show all [%- END -%] This is because of problems the translation script has with parsing template directives nested inside tags: http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML This should have been caught by the QA tool, but it looks like the "-" in "[%- IF" isn't an expected pattern. It would be nice if the QA test tool were updated to be aware of that construction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Chris Nighswonger changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #24 from Katrin Fischer --- Thx for the offer! I'd not be too unhappy if you took that item off my to do list :) Maybe leave a quick note here, when you get to it? So we don't try to fix it at the same time. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 Owen Leonard changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5052] Can't choose languages if all choices are sublanguages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5052 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5052] Can't choose languages if all choices are sublanguages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5052 Owen Leonard changed: What|Removed |Added Attachment #26805|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 27040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27040&action=edit [SIGNED-OFF] Bug 5052 - Can't choose languages if all choices are sublanguage This was tricky to catch. In current implementation, Bug 6755 introduced in C4/Templates.pm as condition to send the array of hashrefs of languages that (@$languages_loop<2), but with one language group that condition is false, there is only one element in that array. This patch changes that condition to have more than one language selected, grouped or not. Also send $bidi value always, that was only sent if there is more than one group language. To test: 1. Translate to en-GB and en-NZ, or simply do mkdirs on intranet-tmpl/prog and opac-tmpl/bootstrap 2. Go to Administration > System preferences > I18N enable those languages on staff/opac 3. Check that language chooser is nowhere to be found 4. Apply the patch 5. Reload staff/opac, now you can see language chooser NOTE: I made little changes on staff, but can't replicate bootstrap colors for selected/unselected language. Someone need to touch css files to make it happen. But that is current behavior. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #38 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall changed: What|Removed |Added Attachment #27038|0 |1 is obsolete|| --- Comment #31 from Kyle M Hall --- Created attachment 27039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27039&action=edit Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off Both OpacHiddenItems and hidelostitems work, and Dobrica's recent patch to remove the numbering if OpacHiddenItems is used is a swell idea (hidelostitems needs that, too!), but in either event, the hit count at the top of the result list is off. Test Plan: 1) Create 5 records with the titles "test 1" through "test 5" with one item each 2) enable hidelostitems 3) Mark one of the items as lost 4) Rebuild your zebra index 5) Search for "test" 6) Note the results count is off 7) Apply this patch 8) Re-run the search 9) Note the results count is now correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall changed: What|Removed |Added Attachment #12590|0 |1 is obsolete|| --- Comment #30 from Kyle M Hall --- Created attachment 27038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27038&action=edit Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off Both OpacHiddenItems and hidelostitems work, and Dobrica's recent patch to remove the numbering if OpacHiddenItems is used is a swell idea (hidelostitems needs that, too!), but in either event, the hit count at the top of the result list is off. Test Plan: 1) Create 5 records with the titles "test 1" through "test 5" with one item each 2) enable hidelostitems 3) Mark one of the items as lost 4) Rebuild your zebra index 5) Search for "test" 6) Note the results count is off 7) Apply this patch 8) Re-run the search 9) Note the results count is now correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall changed: What|Removed |Added Assignee|fridolyn.som...@biblibre.co |k...@bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #29 from Kyle M Hall --- Well that didn't work out ; ) Patch no longer solves the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #26 from M. de Rooy --- (In reply to Jonathan Druart from comment #25) > (In reply to M. de Rooy from comment #24) > > Just curious: The above call seems to be incorrect and is removed. But after > > removal you got the same error? Where is it raised in that situation? > > I get the error without the patch. OK. In that case I do not exactly understand what keeps you from passing QA on this patch? I saw that Kyle signed off on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- Looks like something has been left out of the patch? Undefined subroutine &C4::Review::GetIndependentGroupModificationRights called at C4/Review.pm line 141. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #28 from Kyle M Hall --- This patch has been in discussion for over a year now with no movement. I'm going to QA this and let the RM make the final decision. It looks like nobody is interested in developing an alternative solutions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12031] Task Scheduler not sending mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031
--- Comment #20 from M. Tompsett ---
Comment on attachment 26851
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26851
[SIGNED OFF] Bug 12031 - Task Scheduler not sending mail
Review of attachment 26851:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12031&attachment=26851)
-
::: tools/scheduler.pl
@@ +40,5 @@
> + $base = C4::Context->config('supportdir');
> +}
> +else {
> + $base= "/usr/share/koha/bin";
> +}
This block could be simplified:
my $base = C4::Context->config('supportdir') // "/usr/share/koha/bin";
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 M. de Rooy changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 M. de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||m.de.r...@rijksmuseum.nl Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 M. de Rooy changed: What|Removed |Added Attachment #25367|0 |1 is obsolete|| --- Comment #5 from M. de Rooy --- Created attachment 27037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27037&action=edit Bug 11433 - Remove attachbasket op value in basket.pl and rename it in basketgroup.pl This patch cleans code in basket.pl, basketgroup.pl and basketgroup.tt Not absolutely needed, but makes further improvements easier 'attachbasket' is used in basket.pl and basketgroup.pl as a value of $op In basket.pl, some code is supposed to be executed if $op eq 'attachbasket'. But it is never the case (grep attachbasket * -r), so this condition must be removed. In basketgroup.pl, the description of 'attachbasket' value in comments is wrong, and the name is misleading (this value of $op is ONLY used when someone clic on 'Save' button on a basketgroup page). So 'attachbasket' should be renamed. This patch - removes code related to 'attachbasket' in basket.pl - rename 'attachbasket' to 'save' in basketgroup.pl and basketgroup.tt - fixes some comments related to 'attachbasket' and 'mod_basket' in basketgroup.pl No functional change expected. Regression test only : Make a complete acquisition process, from the creation of a basket to the closure of a basketgroup, and check everything is OK On a basket page, try to change the basketgroup it belongs to, and check everything is OK On a basketgroup page, try to edit the content of a basketgroup (put a new basket in it, change the deliverybranch...), and check everything is OK On a basketgroup page, try to reopen a closed basketgroup, and close an open basketgroup, and check everything is OK Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 --- Comment #14 from Galen Charlton --- (In reply to M. de Rooy from comment #12) > I looked at the move of this code from one file to the other. And made a > quick compare between what you deleted and what you created in a git format > file. > Unfortunately this compare was not very helpful. Too much differences > (including spacing etc.) Makes it harder to verify what happens here.. Indeed. However, with some use of diff -bw to compare the old acq.js, the new acq.js, and basketgroup.js (and with testing of the acq pages, of course), I was able to convince myself that the patch implements a clean move of those functions. Plus, it has the benefit of sticking the last active use of YUI by the staff interface in one file. Signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Galen Charlton changed: What|Removed |Added Attachment #20292|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 --- Comment #13 from Galen Charlton --- Created attachment 27036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27036&action=edit Bug 10533: move JavaScript functions for basket groups to a separate file This patch moves JavaScript functions used for managing basket groups to a file. This has the effect of putting the last (active) use of the YUI JavaScript library by the staff interface in one file: koha-tmpl/intranet-tmpl/prog/en/js/basketgroup.js Test plan: - Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv). - Check that there is no regression on others acquisition pages: * acqui/neworderempty.tt * acqui/uncertainprice.tt * acqui/addorderiso2709.tt * acqui/basketheader.tt * admin/aqbudgets.tt * admin/aqcontract.tt * admin/aqbudgetperiods.tt * admin/aqplan.tt * suggestion/suggestion.tt Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Galen Charlton changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 Owen Leonard changed: What|Removed |Added Version|3.14|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 Owen Leonard changed: What|Removed |Added Attachment #26428|0 |1 is obsolete|| --- Comment #23 from Owen Leonard --- Created attachment 27035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27035&action=edit [SIGNED-OFF] Bug 11947 - renumber reserves when hold is confirmed Currently when a reserve is moved to "waiting" status because it's acknowledged on checkin, the reserve priorities aren't renumbered. This causes things to go a bit haywire in the UI, in particular, some reserves can unjustly end up with priority 1 when they shouldn't. It also seemed to mess with the logic of who should get it next, but I didn't look too closely at that. This patch forces a renumbering so that all the priorities remain copacetic. Test plan: * have a few borrowers, say 4. * have a biblio with a single item (you can scale this up, it should work just the same.) * issue the item to borrower A * have borrowers B, C, and D place a hold on the item * return the item, acknowledge that it'll be put aside for B. * view the holds on the item. Without the patch: * the hold priorities in the UI end up being "waiting, 2, 1" when they should be "waiting, 1, 2". * in the database "reserves" table, they're really "0, 2, 3" when they should be "0, 1, 2". With the patch: * the hold priorities in the UI end up being "waiting, 1, 2" * in the database, they're "0, 1, 2" Signed-off-by: Owen Leonard Test plan confirms that the problem exists and that the patch corrects it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12075] jQueryUI upgrade broke keyboard shortcuts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12075 --- Comment #1 from Owen Leonard --- Created attachment 27034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27034&action=edit Bug 12075 - jQueryUI upgrade broke keyboard shortcuts The recent jQueryUI upgrade broke keyboard shortcuts in the staff client because of changes to the jQueryUI API. This patch fixes the problem. To test, apply the patch and clear your browser cache if necessary. - View any page in the staff which includes header search tabs for check out, check in, or catalog search (staff client home page or circulation page for instance). - Test the keyboard shortcuts: Alt-q for catalog search, Alt-u for check out, Alt-r for check in. - Each keyboard shortcut should select the correct tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12075] jQueryUI upgrade broke keyboard shortcuts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12075 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12075] New: jQueryUI upgrade broke keyboard shortcuts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12075 Bug ID: 12075 Summary: jQueryUI upgrade broke keyboard shortcuts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff Client Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The latest jQueryUI upgrade removed the option to trigger a tab select based on its name. The only built-in option is to select a tab based on its index. Since the index of the keyboard-shortcutted tabs varies depending on which page you're on another solution is required. This is what worked for me: http://stackoverflow.com/questions/14859281/select-tab-by-name-in-jquery-ui-1-10-0/16550804#16550804 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11598] Add --text option to overdue_notices similar to --html option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11598 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com Severity|minor |enhancement --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11960] GetMemberDetails is unnecessarily called in CanBookBeRenewed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11960 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11441] Ability to globally remove authorities with no bibliographic record linked.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11441 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Juan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11995] Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7267] Display accountnumber in PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7267 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #19 from Galen Charlton --- Pushed to master. Thanks, Pasi! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Galen Charlton changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #29 from Galen Charlton --- The second patch is weird -- it doesn't just remove CancelReserveFromId, it has the effect of *changing* CancelReserve: - it adds a return that no callers actually check - more importantly, it removes the code to insert the old hold into old_reserves, which is a pretty clear regression. I'm marking failed QA on this basis. I strongly encourage starting the patch over from scratch; a patch that adds a routine that then gets immediately removed by its follow-up is confusing, at the very least, and risks whatever merge reconciliation failure happened here. In particular, I don't see that it is necessary to touch C4/Reserves.pm at all to implement this change; if there are concerns about CancelReserve's behavior, that should go into a separate bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 --- Comment #3 from Koha Team Lyon 3 --- Created attachment 27033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27033&action=edit test file 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 --- Comment #2 from Koha Team Lyon 3 --- Created attachment 27032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27032&action=edit test file 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 Koha Team Lyon 3 changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 Koha Team Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- Created attachment 27031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27031&action=edit Bug 12074 Filter duplicates when adding a batch from a staged file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12074] New: Filter duplicates when adding a full batch from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 Bug ID: 12074 Summary: Filter duplicates when adding a full batch from a staged file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@univ-lyon3.fr QA Contact: testo...@bugs.koha-community.org Until now, when you add order for a single record from a staged batch, duplicates are checked and if found you can choose 3 different treatments : adding a new order from existing record, adding a new record nevertheless or doing nothing. But when importing the batch all in once (Import all), there's no duplicate checking. This patch aims to solve this. When adding a batch of records to a basket, duplicates are skipped and an alert is displayed with a link to them so as they could be treated individually. In the case that all batch records match an existing record, you stay on the staged batch list, a warning is also visible to tell you that nothing had been imported. The "Import all" block is not any more displayed Test plan : You need the 2 test attached files TestFile1.mrc and TestFile2.elc (TestFile1 includes only the title "Amilec ou La graine d'hommes" that is also included in TestFile2) 1) go to “Stage MARC records for import” page, upload TestFile1 and stage it (select iso 5426 encoding). 2) Manage staged record and import the batch. 3) Make sure that the new record is indexed (depending to your indexing system and test platform). 4) Go back to go to “Stage MARC records for import” page upload TestFile2 and stage it (select iso 5426 encoding). 5) Go to acquisitions module and create a new basket. 6) From your basket, in the “Add order to basket block” choose 'From a staged file'. 7) Then click File2 (‘addorder button'). 8) Go down the "Import all" block and save. 9) You are redirected to the basket page : a warning is displayed to tell you that some duplicates have been found and skipped. There's a link on the warning throughout you can go back to the list of remaining records and treat them individually if necesary. 10) Click the link : you fall upon the title of TestFile1 (of course as it's a duplicate). 11) Check that the imported records have been indexed. 11) Go down the "Import all" block and save. 12) A warning is displayed saying that no records have been imported because they all match an existing record. The “Import all” block is not any more visible. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12073] OPAC detail page printing show links URL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12073 Owen Leonard changed: What|Removed |Added Attachment #27029|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 27030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27030&action=edit [SIGNED-OFF] Bug 12073 - OPAC detail page printing show links URL On OPAC Bootstrap detail page, by clicking Print link on the right the page is printed. But the printed page contains HTML anchors URL attribute. It's useless, and unreadable. It isn't the case with prog theme. This page hide all href attributes when printing any OPAC page. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12073] OPAC detail page printing show links URL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12073 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #12 from M. de Rooy --- I looked at the move of this code from one file to the other. And made a quick compare between what you deleted and what you created in a git format file. Unfortunately this compare was not very helpful. Too much differences (including spacing etc.) Makes it harder to verify what happens here.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10842] Allow for new type of LDAP authentication - Further Enhancement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10842 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |RESOLVED CC||mtomp...@hotmail.com Resolution|--- |DUPLICATE --- Comment #7 from M. Tompsett --- (In reply to Martin Renvoize from comment #6) > I have a feeling that this is now null and void as Robin re-implemented > direct binding in bug 10908 Just from eyeballing the code, I think your feeling is correct. I'm going to mark this as a resolved duplicate. *** This bug has been marked as a duplicate of bug 10908 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908 --- Comment #18 from M. Tompsett --- *** Bug 10842 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #5 from Owen Leonard --- (In reply to Kyle M Hall from comment #4) > I would expect it to remain on > the circulation screen and open a hold slip popup the same way the "print > and confirm" button does on returns.pl. I see no reason why it could not be > implemented that way. Part of the problem is that the button text isn't clear about what is going to happen, but I agree with Kyle that it could be handled better with regard to the checkout process. It would be great not to interrupt the checkout session. "Confirm hold and print slip" maybe, triggering the popup? And then circulation.pl returns to a state where it is ready to check out another item to that patron. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12073] OPAC detail page printing show links URL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12073 Frédéric Demians changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|oleon...@myacpl.org |frede...@tamil.fr --- Comment #1 from Frédéric Demians --- Created attachment 27029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27029&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12073] New: OPAC detail page printing show links URL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12073 Bug ID: 12073 Summary: OPAC detail page printing show links URL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: frede...@tamil.fr QA Contact: testo...@bugs.koha-community.org On OPAC Bootstrap detail page, by clicking Print link on the right the page is printed. But the printed page contains HTML anchors URL attribute. It's useless, and unreadable. It isn't the case with prog theme. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12071] javascript broken for a search with double quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071 --- Comment #2 from Owen Leonard --- I can't reproduce this bug in master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12071] javascript broken for a search with double quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #2 from Kyle M Hall --- FAIL authorities/authorities.pl FAIL critic # Subroutines::ProhibitSubroutinePrototypes: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #68 from Paola Rossi --- I apply the last "Fix encoding issue" patch. No bad chars are seen, But, if I use f.i. the "frequency" 1/day, in the "Advanced prediction pattern" shown table "null" is shown in some cells. In sandbox 17 no "null" is shown in these cells. IMO this could be a bug, and so I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #4 from Kyle M Hall --- (In reply to Jonathan Druart from comment #3) > The 'cancel hold' checkbox is not taken into account (but it is already the > case for the "No, don't check out" button). > The redirect to returns.pl is a little bit unexpected, in my opinion. > > I need other qa points of view for this one. I agree, the behavior of this patch is very odd. I don't think the redirect is a very good idea. It feels very much like a hack especially since the user is not told this is what will happen. I would expect it to remain on the circulation screen and open a hold slip popup the same way the "print and confirm" button does on returns.pl. I see no reason why it could not be implemented that way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5739] Check out waiting holds directly from "hold waiting" alerts on circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5739 Owen Leonard changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #6 from Owen Leonard --- (In reply to Kyle M Hall from comment #5) > Patch works and passes QA. However I have some additional thoughts: > 1) Making the barcode a link to moredetail.pl makes it much more difficult > to copy and paste. You can no longer just double click the barcode to > highlight it. Yeah I think the link to moredetail.pl eliminates the usefulness of outputting the barcode here. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12069] If you access members/mod_debarment.pl when logged out you are redirected to OPAC login
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 --- Comment #5 from M. Tompsett --- This also applies cleanly to 3.14.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #46 from M. Tompsett --- Bug 11746 has been pushed to master, which is good. However, this means that the links displayed in the catalogue/details.pl page are displaying Edit on items which the user should not have edit links for. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12069] If you access members/mod_debarment.pl when logged out you are redirected to OPAC login
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 M. Tompsett changed: What|Removed |Added Attachment #27022|0 |1 is obsolete|| --- Comment #4 from M. Tompsett --- Created attachment 27028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27028&action=edit [SIGNED OFF] Bug 12069 - If you access members/mod_debarment.pl when logged out you are redirected to OPAC login members/mod_debarment.pl's call to checkauth should pass 'intranet' so that if the user happens to be logged out they will be redirected to the staff client login form. To test, apply the patch and log in to the staff client: - Add a restriction to a patron's account. - View the restrictions tab on the patron's account. You should see the restriction and a "Remove" link for that restriction. - In another tab, log out of the staff client. - In the first tab, click the "Remove" link. You should be redirected to the staff client login page. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12069] If you access members/mod_debarment.pl when logged out you are redirected to OPAC login
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #30 from Owen Leonard --- (In reply to Bernardo Gonzalez Kriegel from comment #23) > koha-qa complains > > FAIL koha-tmpl/intranet-tmpl/prog/en/includes/av-build-dropbox.inc >OK forbidden patterns >OK tt_valid >FAIL valid_template > Undefined subroutine &C4::Koha::GetAuthvalueDropbox called > at /home/bgkriegel/kohaclone/Koha/Template/Plugin/AuthorisedValues.pm line > 49. I get this same error from the QA script, but everything seems to work. Is it an inaccurate error? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5739] Check out waiting holds directly from "hold waiting" alerts on circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5739 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #5 from Kyle M Hall --- Patch works and passes QA. However I have some additional thoughts: 1) Making the barcode a link to moredetail.pl makes it much more difficult to copy and paste. You can no longer just double click the barcode to highlight it. 2) I think the idea of making it a link that pastes the barcode into the checkout box automatically is a good one since it obviates the need to do these extra actions. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5739] Check out waiting holds directly from "hold waiting" alerts on circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5739 Kyle M Hall changed: What|Removed |Added Attachment #25775|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 27027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27027&action=edit Bug 5739 - Show the barcode of the waiting item on the circulation page To test: 1. place a hold for a borrower 2. mark the hold waiting for that borrower 3. view that borrower's circulation page 4. without the patch, no barcode will be displayed under "hold waiting for..." With it, the barcode will be linked to the item. Signed-off-by: Jonathan Druart Amended patch: fix qa issues (tabs and trailing spaces) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5739] Check out waiting holds directly from "hold waiting" alerts on circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5739 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11960] GetMemberDetails is unnecessarily called in CanBookBeRenewed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11960 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11960] GetMemberDetails is unnecessarily called in CanBookBeRenewed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11960 Kyle M Hall changed: What|Removed |Added Attachment #26479|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 27026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27026&action=edit Bug 11960: GetMemberDetails is unnecessarily called in CanBookBeRenewed C4::Circulation::CanBookBeRenewed calls C4::Members::GetMemberDetails to retrieve categorycode and branchcode. - categorycode is used to retrieve the issuing rule - the borrower information is passed to C4::Circulation::_GetCircControlBranch. Which only uses the branchcode parameter. GetMemberDetails does a lot of useless calls/queries (patronflags, account, etc.). This call could be replaced with a call to C4::Members::GetMember. Note: I presented this small optimisation during a quick introduction to NYTProf (hackfest 14 in Marseille). Test plan: - launch member unit tests - check the code Checking the code resulted in the following: CanBookBeRenewed builds a hash reference from the borrowernumber (2482). Note it is only used in this function and not passed in. _GetCircControlBranch (2485) requires that hashreference to have a branchcode key. As stated above. The following line (2486) requires it have a categorycode key. As such, C4::Members::GetMemberDetails is confirmed to be overkill, and C4::Members::GetMember is sufficient. Testing Done 0) Back up DB 1) Make sure MPL is in the list of libraries. 2) Apply the patch. 3) run the koha qa test tool 4) prove -v t/db_dependent/Circulation.t Patch applies cleanly. QA Test tool was all OK. All tests ran successfully. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11441] Ability to globally remove authorities with no bibliographic record linked.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11441 Kyle M Hall changed: What|Removed |Added Attachment #26326|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 27025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27025&action=edit Bug 11441 - Ability to globally remove authorities with no bibliographic record linked. To test it: Parse only PERSO_NAME authorities: misc/migration_tools/remove_unused_authorities.pl -aut PERSO_NAME Parse all authorities: misc/migration_tools/remove_unused_authorities.pl Signed-off-by: Nicolas Legrand Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11441] Ability to globally remove authorities with no bibliographic record linked.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11441 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Kyle M Hall changed: What|Removed |Added Attachment #26271|0 |1 is obsolete|| --- Comment #27 from Kyle M Hall --- Created attachment 27023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27023&action=edit Bug 8868: ILS-DI: CancelHold needs to take a reserve_id (follow-up) - Fix the text in the ilsdi.pl?service=Describe&verb=CancelHold page - Unit tests for CancelReservedFromId and GetReserve - Do not delete row in reserves table if insert in old_reserves fails Signed-off-by: Benjamin Rokseth Rebased. Hopefully it applies now. Fixed test t/db_dependant/Reserves.t and updated return reference in CancelReserveFromId. Tested via ILS-DI : placing hold (HoldItem) checking patron info (GetPatronInfo) cancelling hold (CancelHold) Verified that CancelHold parameter item_id takes reserve_id May need additional testing and sign-off Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
