[Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 --- Comment #16 from Galen Charlton gmcha...@gmail.com --- (In reply to M. Tompsett from comment #15) I think there is merit for a follow up if one wants truly nice code (i.e. not working by accident). To answer the question you posed in IRC, please open a new bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de --- There are lots of conflicts in Reserves.pm now - with the recent changes to Reserves.pm. Please fix and test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch --- Comment #8 from Marc Véron ve...@veron.ch --- I'm not sure how to test. Any test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #72 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27338 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27338action=edit Bug 11703 [QA Followup] - Change output_pref_due to output_pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #27338|0 |1 is obsolete|| --- Comment #73 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27339 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27339action=edit Bug 11703 [QA Followup] - Change output_pref_due to output_pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #74 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27340 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27340action=edit Bug 11703 [QA Followup] - Retain functionality of IssuesDefaultSortOrder system preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #27340|0 |1 is obsolete|| --- Comment #75 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27341 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27341action=edit Bug 11703 [QA Followup] - Retain functionality of IssuesDefaultSortOrder system preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #27341|0 |1 is obsolete|| --- Comment #76 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27342 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27342action=edit Bug 11703 [QA Followup] - Retain functionality of IssuesDefaultSortOrder system preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #24 from Iming Chan imingc...@yahoo.com.au --- Hi Galen, I don't believe a separate tab is really necessary. It should be provided like holds (reservations). I like your idea just to give acquisition information in the OPAC holdings tab ** AND ** display a date when X item(s) is/are on order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger cnighswon...@foundations.edu changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #62 from Chris Nighswonger cnighswon...@foundations.edu --- (In reply to Bernardo Gonzalez Kriegel from comment #61) (In reply to Chris Nighswonger from comment #59) Also, its not apparent how this fix interacts with the existing justification code, if at all, which makes it further desirable to rewrite/replace it. Although this patch may fix the immediately apparent problem, there may be unexpected hidden side effects because of this. If found a solution that use current code :) I think you may be misunderstanding me. Using your proposed fix will result in justification code in multiple places. This is bad a practice otherwise known as spaghetti code[1]. It also makes the fix inaccessible via the C4::Labels module by placing it at the script level. This is bad practice as no other scripts (existing or future) will have access to this fix. Unless this is corrected, I will (as the module maintainer) be forced to hold this bug in failed-QA status. Just to clarify: I have no issue with the proposed fix in principle. We just need to put it into the correct place in the code. [1]http://www.computerhope.com/jargon/s/spaghett.htm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #63 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to Chris Nighswonger from comment #62) I think you may be misunderstanding me. Using your proposed fix will result in justification code in multiple places. This is bad a practice otherwise known as spaghetti code[1]. It also makes the fix inaccessible via the C4::Labels module by placing it at the script level. This is bad practice as no other scripts (existing or future) will have access to this fix. Unless this is corrected, I will (as the module maintainer) be forced to hold this bug in failed-QA status. Just to clarify: I have no issue with the proposed fix in principle. We just need to put it into the correct place in the code. Chris, I changed completely the solution. Please, take a look (second patch) The fix IS in Label.pm, that was the meaning of 'using current code.' Your were right, I was bypassing current justification code, and that was wrong. I found the real problem (non-existent font code and bad parameter to StrWidth) and fixed that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27343 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27343action=edit Bug 11518 [QA Followup] - Make unit tests pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #27343|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27344 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27344action=edit Bug 11518 [QA Followup] - Make unit tests pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #25510|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27346 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27346action=edit [PASSED QA] Bug 11518 [Followup] - Change method name from 'itemtype' to 'effective_itemtype' for clarity Test runs without errors. Signed-off-by: Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #26987|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27348 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27348action=edit [PASSED QA] Bug 11518 [QA Followup] - Make unit tests pass Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27345 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27345action=edit [PASSED QA] Bug 11518 - Add new method to Koha::Schema::Result::Item that will always return the correct itemtype There are many disparate areas of Koha that deal with item level itemtypes vs record level itemtypes. We can take advantage of DBIx::Class to make smarter objects that automatically return the correct value depending on the system preference. Test Plan: 1) Apply this patch 2) Run t/db_dependent/Items.t Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #24121|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27347 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27347action=edit [PASSED QA] Bug 11518 [QA Followup] Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #27344|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #64 from Chris Nighswonger cnighswon...@foundations.edu --- (In reply to Bernardo Gonzalez Kriegel from comment #63) (In reply to Chris Nighswonger from comment #62) I think you may be misunderstanding me. I changed completely the solution. Please, take a look (second patch) The fix IS in Label.pm, that was the meaning of 'using current code.' Ouch! My bad. I apologize for my misunderstanding. I found the real problem (non-existent font code and bad parameter to StrWidth) and fixed that. I'll take a look at it now and sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #68 from Kyle M Hall k...@bywatersolutions.com --- - I think the note on the currency page is misplaced. It would be better using a diferent styling (similar to other hints) below the table. I agree with this. In addition, I think it should be worded more like: When importing MARC files via the staging tools, the tool will attempt to find and use the price of the currently active currency. - I am a bit torn about adding a new column for ISO code. The sample Koha currencies already have the ISO code as code and the overdue_notices.pl that prints the fine into the notices also assumes code to be the ISO code. Maybe we should just enforce the code to be the ISO code a bit more? I agree, the default data convention is for the Currency field to be the ISO code. However, that doesn't mean that everyone is currently following this convention. I *don't* think this is a blocker. I could easily see the Currency being Brazilian real while the ISO code would be BRL. Since not everyone memorizes ISO codes for currency, I think this may be an improvement anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #77 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27349 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27349action=edit Bug 11703 [QA Followup] - Use datatables.inc in circulation.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Not able to adjust size of barcode numbers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Binu Thomas binu.tho...@eclateng.com changed: What|Removed |Added CC||binu.tho...@eclateng.com --- Comment #1 from Binu Thomas binu.tho...@eclateng.com --- Hello, Is this issue confirmed as a bug. We are also facing this issue in Koha 3.14.05.? Any timeline of getting this resolved? Is anyone working on this? Regards, Binu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Not able to adjust size of barcode numbers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 --- Comment #2 from Binu Thomas binu.tho...@eclateng.com --- Hello, Is this issue confirmed as a bug. We are also facing this issue in Koha 3.14.05.? Any timeline of getting this resolved? Is anyone working on this? Regards, Binu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #78 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27350 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27350action=edit Bug 11703 [QA Followup] - Fix up holds table details -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051
Tomás Cohen Arazi tomasco...@gmail.com changed:
What|Removed |Added
CC||tomasco...@gmail.com
--- Comment #29 from Tomás Cohen Arazi tomasco...@gmail.com ---
(In reply to M. de Rooy from comment #28)
(In reply to Jonathan Druart from comment #27)
There are 2 reasons.
1/ I don't see the load difference following the test plan.
2/ There are some calls to
memoize_memcached('subroutine_name', memcached = C4::Context-memcached);
in the code.
If the call is wrong, we should fix it everywhere. If I am wrong, I am not
able to pass qa on it :)
I installed memcached (and ..) and ran the memoize_memcached call for
GetMarcStructure and called it in a for loop so many times.
My findings are:
1) As Jonathan pointed out, the call seems to be wrong. If I pass memcached
=1 as parameter, I also have: Invalid memcached argument (expected a hash).
If I pass memcached = {}, it seems to be okay.
I do not understand why we still find this error. Are other people using
another version for memcached, Cache::Memcached or Memoize::Memcached?
Memoize::Memcached v0.04 changed the use of isa() in favour of ref() to prevent
deprecation messages in Perl 5.12+. I think Debian's 0.03 package at some point
introduced a similar patch (the package was abandoned, I own it now because of
that).
The problem is (i think, have just arrived from a month without any Perl) that
isa('HASH') was true because it would match all inherited classes (not only the
latest blessed one).
I'll try to fix it (help is welcome), but I don't think i will be available in
Debian soon.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #65 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to Chris Nighswonger from comment #64) Ouch! My bad. I apologize for my misunderstanding. No problem :) I'll take a look at it now and sign off. Thinking about the patch, perhaps $fontCode/fontObject (or font_code/font_object) are better than $fontName, I can change that (or you, if you like) StrWidth was receiving 'TI' or 'HO' for example, not Ft1/Ft2 for embedded fonts, nor 'Times-Italic' or 'Helvetica-Oblique', in that way it use Helvetica, which is approximately good for latin scripts[1] [1] http://search.cpan.org/dist/PDF-Reuse/Reuse.pm#prStrWidth_-_calculate_the_string_width -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12115] New: Follow up fix for tools/inventory.pl's output_pref issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12115 Bug ID: 12115 Summary: Follow up fix for tools/inventory.pl's output_pref issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: mtomp...@hotmail.com QA Contact: testo...@bugs.koha-community.org In bug 11253, the second parameter was ignore, and caused issues for dd/mm/. However, two other lines later in the code were broken, but worked by accident. This is to patch those two lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12115] Follow up fix for tools/inventory.pl's output_pref issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12115 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11253 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12115 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #94 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Galen Charlton from comment #93) Pushed to master, along with my usual set of follow-ups. One follow-up deserving special mention is the last one, which restores the documented interpretation of the sharedate column. Thanks for the follow-ups. Retested the feature successfully in current master along with new parameter of cleanup-database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl --- But the the other point of the patch was to suppress attachbasket code from basket.pl, which was never executed. Do you agree with that? If so, I can make a followup to limit the patch to this 1st point. I signed off. So I agreed with the patch in its current state. The name of the operation does not seem so important that we should still put more effort in this dev (at least imo). I add Katrin to the CC list. Katrin: Could you decide if this can pass qa in its current form? Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #79 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, as promised, here my first test results: GENERAL - New jQuery plugin: jquery.dataTables.grouping.js Should we add a note to the about page about this? - Translation: +var HOLD_IS = _(Hold is); +var SUSPENDED = _(suspended); +var UNTIL = _(until); +var ITEM_IS = _(Item is); +var WAITING = _(waiting); +var AT = _(at); +var FROM = _(from); Would be much nicer as complete sentences with placeholders - this is really hard to translate grammatically correct. CHECKOUTS - Sorting table OK. Sorting the table was not possible before patch. Sorting will remove the Today's and Previous checkouts differentiation. Works ok. - Column price and charge Bug: columns price and charge are not sortable. - Column Due date Ok, only shows time now when it's an hourly loan. Nice! - Column Item type Shows the code instead of description, something for another day. - Column Checked out on Bug: Shows seconds, but those are always 00 so I guess we don't record the issue by second? Checking out - still to be tested - 'normal' check out OK - hourly check out (with specify due date) OK - with rental fee - notforloan item - too many items OK, override possible. - item on hold for someone else - item with material note Renewing items - Check out with an already checked out barcode again OK, item is renewed - renewal using checkboxes Concern: It's only possible to do one renewal at a time. After renewing once the checkbox is gone and then you will have to reload the page to bring the checkboxes back. - renewal override OK. If the item is on hold, the renewal will fail. I wonder if that's always been the case, but it's behaviour pre-patches. - too early renewal (bug 6779) Bug: Shows too_soon instead of a nice message for why the renewal is not yet allowed. Should show the date - compare to master. System preferences - UseTableSortForCirc Is removed, sorting will be always available Bug: Should be removed properly with updatedatabase.pl as well - [prefs for sorting by checkout date] - still to be tested RELATIVE's CHECKOUTS - releative's checkouts tab is only shown for the guarantee (child), but not for the parent - something seems messed up here? Bug: My patron has 2 children, one of them has an item checked out. It doesn't show up, the relative's checkouts tab is empty. HOLDS - Sorting table Sorting the holds table was not possible pre-patches. Concern: The sorting and page load seems a bit slow for 4 holds - Columns: Title, Hold date, expiration date, Delete OK - Barcode column Ok, now offers a link to the item - Delete column - Suspending and unsuspending holds OK - Cancelling holds OK, possible enhancement: Redirect back to the holds tab after cancelling a hold instead of sending user to the checkouts tab. Exists pre-patch. Concern: Performance testing / benchmarking - I would be really interested to see a comparison on how fast the complete page loads in comparison to before and similar. Is this possible? Concern: Accessibility - We currently have no feedback about accessibility issues this might cause in circulation. I want to note that there is no non-Javascript fallback here. In case the Ajax proves to be a problem, we'd have a regression as currenct circulation works nicely. I really like he idea of this, but I think I'd like it a bit better if it had been implemented as an alternative at first - but that sure is debatable :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #80 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Katrin Fischer from comment #79) Hi Kyle, as promised, here my first test results: GENERAL - New jQuery plugin: jquery.dataTables.grouping.js Should we add a note to the about page about this? Will do. - Translation: +var HOLD_IS = _(Hold is); +var SUSPENDED = _(suspended); +var UNTIL = _(until); +var ITEM_IS = _(Item is); +var WAITING = _(waiting); +var AT = _(at); +var FROM = _(from); Would be much nicer as complete sentences with placeholders - this is really hard to translate grammatically correct. I don't think this is possible with JavaScript, as it has no string interpolation. - renewal using checkboxes Concern: It's only possible to do one renewal at a time. After renewing once the checkbox is gone and then you will have to reload the page to bring the checkboxes back. This is by design. I think in those rare cases reloading the page would be a fair resolution for this. - renewal override OK. If the item is on hold, the renewal will fail. I wonder if that's always been the case, but it's behaviour pre-patches. Yes, that has always been the case. - too early renewal (bug 6779) Bug: Shows too_soon instead of a nice message for why the renewal is not yet allowed. Should show the date - compare to master. Will fix System preferences - UseTableSortForCirc Is removed, sorting will be always available Bug: Should be removed properly with updatedatabase.pl as well - [prefs for sorting by checkout date] - still to be tested Will fix RELATIVE's CHECKOUTS - releative's checkouts tab is only shown for the guarantee (child), but not for the parent - something seems messed up here? Bug: My patron has 2 children, one of them has an item checked out. It doesn't show up, the relative's checkouts tab is empty. I'll look into this HOLDS - Sorting table Sorting the holds table was not possible pre-patches. Concern: The sorting and page load seems a bit slow for 4 holds The sorting is done server side. We can either leave it as is, since there was no sorting to begin with, make the sorting client side ( which will break sorting on some columns possibly ), or just disable sorting altogether ( ie pre-patch behavior ) Concern: Performance testing / benchmarking - I would be really interested to see a comparison on how fast the complete page loads in comparison to before and similar. Is this possible? Not easily. The idea is to get the circulation screen to be as *responsive* as possible. The more checkouts and holds a patron has, the less responsive circulation.pl becomes. This patch obviates that issue be loading the page, and fetching that data afterward. Concern: Accessibility - We currently have no feedback about accessibility issues this might cause in circulation. I want to note that there is no non-Javascript fallback here. In case the Ajax proves to be a problem, we'd have a regression as currenct circulation works nicely. These tables should be just as accessible as any other datatable in Koha, some of which are also ajax based such as this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12094] jQueryUI upgrade broke default tab selection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12094] jQueryUI upgrade broke default tab selection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #27217|0 |1 is obsolete|| --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27351 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27351action=edit [SIGNED OFF] Bug 12094 - jQueryUI upgrade broke default tab selection The recent upgrade to jQueryUI didn't take into account the new method for forcing selection of a tab by adding a class to the tab markup. This patch corrects this by updating the class name. This patch also updates one instance where it was necessary to switch to the new function for selecting a tab by ID, introduced by Bug 12075. To test, view the following pages: - Perform a catalog search in the staff client. On the search results page the Search the catalog tab should be selected. - In Acquisitions, view the basket groups page for a vendor which has open and closed basket groups (/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=X). Append listclosed=1 to the URL. The Closed tab should be selected. - In Administration - Authorized values, modify an authorized value for which an icon has been selected. When the edit form loads the corresponding icon tab should be selected. - In Administration - Item types, modify an itemtype for which an icon has been selected. When the edit form loads the corresponding icon tab should be selected. - In Cataloging, open an existing record and select any tab besides the first one. Choose Save and continue editing from the Save menu. When the page reloads you should be returned to the tab you selected before. - In Suggestions, markup for selected the tab has been removed because it didn't appear to be performing any function. The first tab is selected by default. The template doesn't need to explicitly add a class to make it so. - In Tools - CSV profiles, choose an existing profile for editing. When the page loads the Edit existing profile tab should be selected. Signed-off-by: Mark Tompsett mtomp...@hotmail.com NOTE: Unable to duplicate Cataloging step issue, but there is no visible regression with the patch. The second part of the addbiblio.tt portion of the patch is clearly correct, because it is the same type of change as made in the other sections. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #81 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Kyle M Hall from comment #80) (In reply to Katrin Fischer from comment #79) Hi Kyle, as promised, here my first test results: GENERAL - New jQuery plugin: jquery.dataTables.grouping.js Should we add a note to the about page about this? Will do. On further review most of our datatables plugins are not listed on the about page. Only the star rating one is listed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12115] Follow up fix for tools/inventory.pl's output_pref issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12115 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12115] Follow up fix for tools/inventory.pl's output_pref issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12115 --- Comment #1 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27352 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27352action=edit Bug 12115 - Follow up fix for tools/inventory's output_pref issues This should correct issues with the output_prefs in the compareinv2bar logic section of tools/inventory.pl It is a follow up to bug 11253. TEST PLAN - NOTE: There should be no distinguishable difference before and after the patch. This corrects a works by accident bug. Back up DB. Create a small barcode file from books in a given branch. Set I18N/L10N system preference of dateformat to mm/dd/. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in mm/dd/ format. Set I18N/L10N system preference of dateformat to -mm-dd. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in -mm-dd format. Set I18N/L10N system preference of dateformat to dd/mm/. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in dd/mm/ format. Apply patch Restore DB (so results should be comparable to the first result) Repeat the three testing blocks above. There should be no visible difference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #69 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I wanted to note it - adding the column is ok with me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12116] New: Move fixFloat jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12116 Bug ID: 12116 Summary: Move fixFloat jQuery plugin outside of language-specific directory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The fixFloat jQuery plugin should be moved to intranet-tmpl/lib/jquery/plugins so that it doesn't have to be duplicated for each translation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #82 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I checked with Galen, please add to the about page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10807] OPAC: There is no authority search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #51 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Back on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #83 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27353 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27353action=edit Bug 11703 [QA Followup] * Add plugin to about * fix relatives' checkouts * add too_many string * remove dead syspref from db -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #84 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27354 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27354action=edit Bug 11703 [QA Followup] - Sort relatives' checkouts and holds tables client side -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12116] Move fixFloat jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12116 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 27355 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27355action=edit Bug 12116 - Move fixFloat jQuery plugin outside of language-specific directory This patch moves the fixFloat jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. This patch also includes a change to staff-global.css to override some style the floating toolbar inherited when we added Bootstrap widgets. To test, apply the patch and confirm that the toolbar sticks to the top of the screen when scrolling down on the following pages: - System preferences - Authorities editor (Authorities - New authority) - Cataloging editor (Cataloging - New record) - List contents view (Lists - View a list's contents) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12116] Move fixFloat jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12116 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12117] New: Remove unused image myshadow.png from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12117 Bug ID: 12117 Summary: Remove unused image myshadow.png from the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The image file /intranet-tmpl/prog/en/lib/jquery/plugins/myshadow.png was used by a jQuery plugin which was removed over six years ago. It's time to let it go. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #85 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27356 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27356action=edit Bug 11703 [QA Followup] - Provide context for translation of strings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12116] Move fixFloat jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12116 --- Comment #2 from Marc Véron ve...@veron.ch --- Created attachment 27357 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27357action=edit [Signed-off] Bug 12116 - Move fixFloat jQuery plugin outside of language-specific directory This patch moves the fixFloat jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. This patch also includes a change to staff-global.css to override some style the floating toolbar inherited when we added Bootstrap widgets. To test, apply the patch and confirm that the toolbar sticks to the top of the screen when scrolling down on the following pages: - System preferences - Authorities editor (Authorities - New authority) - Cataloging editor (Cataloging - New record) - List contents view (Lists - View a list's contents) Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12116] Move fixFloat jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12116 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #27355|0 |1 is obsolete|| CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12116] Move fixFloat jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12116 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12117] Remove unused image myshadow.png from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12117 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 27358 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27358action=edit Bug 12117 - Remove unused image myshadow.png from the staff client myshadow.png was used by a jQuery plugin which has long been removed. This patch removes it. To test, search the Koha source for references to myshadow.png. There should be none. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12117] Remove unused image myshadow.png from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12117 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12117] Remove unused image myshadow.png from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12117 --- Comment #2 from Marc Véron ve...@veron.ch --- Created attachment 27359 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27359action=edit [Signed-off] Bug 12117 - Remove unused image myshadow.png from the staff client myshadow.png was used by a jQuery plugin which has long been removed. This patch removes it. To test, search the Koha source for references to myshadow.png. There should be none. Followed test plan, patch removed file as expected. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12117] Remove unused image myshadow.png from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12117 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #27358|0 |1 is obsolete|| CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12117] Remove unused image myshadow.png from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12117 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12118] New: Unnecessary YUI assets included in offline circ manifest
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Bug ID: 12118 Summary: Unnecessary YUI assets included in offline circ manifest Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org These files are not used by any page other than basketgroup.tt. They can be safely removed from the offline circ manifest. [% themelang %]/lib/yui/button/button-min.js [% themelang %]/lib/yui/container/container_core-min.js [% themelang %]/lib/yui/menu/menu-min.js [% themelang %]/lib/yui/utilities/utilities.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #3 from Marc Véron ve...@veron.ch --- Created attachment 27360 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27360action=edit [Signed-off] Bug 12114: Fix encoding problem with reports JSON web service (opac) - catalog a record that includes umlauts äöü - write a report, that has the record in the result set - access the JSON output of the report OPAC BaseURL/cgi-bin/koha/svc/report?id=1 - verify the umlaut displays not correctly - switch the encoding in the browser to 'western'/latin1 - verify the umlaut now displays correctly - apply patch - verify umlaut now displays correctly from the beginning Based on paste from Galen Charlton. http://bugs.koha-community.org/show_bug.cgi?id=9915 Followed test plan. Result as expected. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #27333|0 |1 is obsolete|| CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #4 from Marc Véron ve...@veron.ch --- Created attachment 27361 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27361action=edit [Signed-off] Bug 12114: Fix encoding problem with reports JSON web service (staff) Repeat tests from first patch, but this time, access the report with your staff client base URL. Staff BaseURL/cgi-bin/koha/svc/report?id=reportid Based on paste from Galen Charlton. http://bugs.koha-community.org/show_bug.cgi?id=9915 Followed test plan. Result as expected. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #27334|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12065] Consistent use of encode_qp when sending basket/shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12065 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #26975|0 |1 is obsolete|| --- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 27362 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27362action=edit Bug 12065: Consistent use of encode_qp when sending basket/shelf QP-encode both mail header and mail body when sending baskets or shelves. There is no need to Encode qp-encoded strings. Note that this does not solve all possible encoding problems in the mail sent. This is related to decoding CGI parameters and use of TT. That problem is addressed in report 11944. Test plan: Verify if sending a basket from opac and staff still works. Check if sending a shelf (list) from opac and staff still functions as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #66 from Chris Nighswonger cnighswon...@foundations.edu --- Created attachment 27363 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27363action=edit Arabic records to test with -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12100] Messaging preferences did not save Days in Advance
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12100 --- Comment #2 from Marc Véron ve...@veron.ch --- Created attachment 27364 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27364action=edit [Signed-off] Bug 12100: Messaging preferences did not save Days in Advance If you have enhanced messaging preference, the Days in Advance combo value (in Patron Messaging Preferences) is saved in the database but not retrieved when you have not enabled the Email checkbox next to it. This patch does the following: [1] It replaces a JOIN by a LEFT JOIN that is the actual reason of the problem described. [2] Removes a FIXME by saving a hardcoded 30 into a constant. [3] Fixes a typo in the neighborhood. [4] Removes a superfluous comma in the map statement. [5] Simplifies code for the selected field of the days combo. It should just be a boolean. The text selected=selected is in the template. Test plan: [1] Enable enhanced messaging preferences. [2] Fill in Days in advance for Advance notice but uncheck Email. [3] Save the preferences. [4] The member home screen does not display the number of days (until you decide to apply this patch :) Followed test plan. Works as expected. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12100] Messaging preferences did not save Days in Advance
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12100 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #27234|0 |1 is obsolete|| CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12100] Messaging preferences did not save Days in Advance
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12100 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12112] C4::Breeding::ImportBreeding() is not used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12112 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12112] C4::Breeding::ImportBreeding() is not used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12112 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #27322|0 |1 is obsolete|| --- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 27365 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27365action=edit Bug 12112: remove disused routine C4::Breeding::ImportBreeding() This patch removes the ImportBreeding() routine, which lost its last caller as of the patch for bug 10462. To test: [1] Verify that prove -v t/Breeding.t passes. [2] Perform a Z39.50 search in the staff interface. [3] Perform a cataloguing reservoir search in the staff interface; verifying that cached records from the search done in step 2 are retrieved. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8560] renewing lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8560 Christopher Brannon cbran...@cdalibrary.org changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #1 from Christopher Brannon cbran...@cdalibrary.org --- We would like to see this addressed. This is pretty significant. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices slips
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #17 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Katrin Fischer from comment #16) I think this is a tricky one, it's hard to tell, what the expected behaviour is. We don't use the default rules much, even if there is only one librray we use the specific page for the rules - maybe a bad habit? Maybe there are just multiple ways? I can tell you that we always use only the default rules in the case of a single library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12103] Move ajaxfileupload jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12103 --- Comment #2 from Marc Véron ve...@veron.ch --- Created attachment 27366 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27366action=edit [Signed-off] Bug 12103 - Move ajaxfileupload jQuery plugin outside of language-specific directory This patch moves the ajaxfileupload jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. To test, apply the patch and test a page which requires the file upload plugin. For instance: Tools - Upload local cover image. The upload process should finish correctly. Tested with patron and local cover images. Works as expected. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12103] Move ajaxfileupload jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12103 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #27271|0 |1 is obsolete|| CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12103] Move ajaxfileupload jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12103 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12118] Unnecessary YUI assets included in offline circ manifest
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 27367 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27367action=edit Bug 12118 - Unnecessary YUI assets included in offline circ manifest The offline circulation asset manifest includes some YUI JavaScript files which are no longer used by any template in Koha except for acquisitions/basketgroup.tt. This patch removes them from the manifest. To test, apply the patch and test offline circulation. Everything should work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12118] Unnecessary YUI assets included in offline circ manifest
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12119] New: Move jeditable jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12119 Bug ID: 12119 Summary: Move jeditable jQuery plugin outside of language-specific directory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The jeditable jQuery plugin should be moved to intranet-tmpl/lib/jquery/plugins so that it doesn't have to be duplicated for each translation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12119] Move jeditable jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12119 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12119] Move jeditable jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12119 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 27368 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27368action=edit Bug 12119 - Move jeditable jQuery plugin outside of language-specific directory This patch moves the jeditable jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. To test, apply the patch and confirm that editing quotes works correctly in the Quote of the Day manager. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10807] OPAC: There is no authority search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #52 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 24221
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24221
Bug 10807: Add an authority search history for the OPAC
Review of attachment 24221:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10807attachment=24221)
-
::: C4/Auth.pm
@@ +251,5 @@
# If at least one search has already been performed
if ($sth-fetchrow_array 0) {
+# We show the link in opac
+$template-param( EnableOpacSearchHistory = 1 );
I am not sure renaming the variable was necessary.
Now it shows up in the templates like the system preference, although there is
another condition that it takes into account. Also tempting to replace it with
the TT plugin accidentally.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11916] Borrower Imports Refactor/Rewrite
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11916 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added CC||mag...@enger.priv.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12115] Follow up fix for tools/inventory.pl's output_pref issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12115 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11227] Staff po files contain some Javascript
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11227] Staff po files contain some Javascript
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #26793|0 |1 is obsolete|| --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Created attachment 27369 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27369action=edit [SIGNED-OFF] Bug 11227 - Staff po files contain some Javascript This patch rewrites authorities_js.inc so translate script process it correctly. To that I add script/script at the file To test: 1) Update po files for your preffered language 2) Check occurrence of mergeAuth on staff PO file or try egrep -n Merging with authority: |Cancel merge strings appear in a JS func 3) Apply the patch 4) Update translations again, chech again, old strings now begin with #~ (obsoleted) and there are new entries for the messages 5) Check functionality provided by script Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #26521|0 |1 is obsolete|| --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Created attachment 27370 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27370action=edit [SIGNED-OFF] Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders This patch MARC21 modifies value builders 006 and 008 to make confirm popup translatable To test: 1) Update po files for your preferred language, xx-YY cd misc/translator; perl translate update xx-YY 2) Check that confirm string is NOT present egrep -B3 Show values for|material type\? po/xx-YY*po 3) Apply the patch 4) Repeat 1) 5) Repeat 2), now the strings are present Also check that english or translated popup is right Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #26520|0 |1 is obsolete|| --- Comment #4 from Owen Leonard oleon...@myacpl.org --- Created attachment 27371 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27371action=edit [SIGNED-OFF] Bug 11639 - Untranslatable strings in 007 builder This patch modifies marc21_field_007.tt to make some missing strings translatable To test: 1) Using your preferred language, xx-YY, updatepo files cd misc/translator perl translate update xx-YY 2) Check that missing strings are NOT present egrep -i exact bit depth|pad with zero|use up to 6 po/xx-YY-i-staff-t-prog-v-3006000.po 3) Apply the patch 4) repeat 1) 5) Repeat 2), check that missing strings are present Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12105] Remove duplicated plugin jquery.dataTables.columnFilter.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- $ grep jquery.dataTables.columnFilter.js `find .` | cut -f1 -d':' Binary file ./.git/index matches ./koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.dataTables.columnFilter.js ./koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt ./koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.columnFilter.js ./koha-tmpl/intranet-tmpl/prog/fr-FR/modules/acqui/parcel.tt ./koha-tmpl/intranet-tmpl/prog/fr-FR/modules/tools/manage-marc-import.tt ./koha-tmpl/intranet-tmpl/prog/fr-FR/modules/catalogue/detail.tt ./koha-tmpl/intranet-tmpl/prog/fr-FR/lib/jquery/plugins/jquery.dataTables.columnFilter.js The fr-FR template files will be regenerated from en template files, so they can be ignored. There are two copies of the same file, and yes the non-language version should be used. ./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt uses the [% interface %] version, which is the correct one. ./koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt loads the javascript file, but does not use it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10807] OPAC: There is no authority search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #56 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27375 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27375action=edit [PASSED QA] Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10807] OPAC: There is no authority search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #58 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27377 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27377action=edit [PASSED QA] Bug 10807: Add an authority search history for the OPAC - bootstrap Patch for the bootstrap theme Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10807] OPAC: There is no authority search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #55 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27374 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27374action=edit [PASSED QA] Bug 10807: Change the GPL version to v3+ Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10807] OPAC: There is no authority search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #54 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27373 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27373action=edit [PASSED QA] Bug 10807 [Follow-up] OPAC: There is no authority search history This follow-up makes two changes: 1) Change biblio to catalog when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
