[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Katrin Fischer changed: What|Removed |Added Attachment #33181|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 33182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33182&action=edit [PASSED QA] Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details In the OPAC if you view the MARC details for a title (and have OPACXSLTDetailsDisplay enabled) there is a "view plain" link which displays the output of opac-showmarc.pl. This is broken in master: fixed by this patch. Test plan: (1) Set OPACXSLTDetailsDisplay to default (2) Do a search on OPAC, then display a specific biblio record (3) Click on MARC view tab. Then click on 'view plain' link. Nothing is displayed. (4) Apply the patch. And refresh the MARC detail page. (5) Click on 'view plain' link. Check that a plain text MARC record is displayed. Signed-off-by: Chris Note: This makes a small change to C4::Templates::themelanguage so that it works with .xsl files too (They live in the xslt dir) Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12851] order tags are not removed on claiming serials/orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12851 --- Comment #7 from Katrin Fischer --- It would be great if someone could test this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #6 from Katrin Fischer --- It would be great if someone could test this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #65 from Katrin Fischer --- We don't want any SQL code in the .pl files - so I'd say both. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Chris Cormack changed: What|Removed |Added Attachment #33180|0 |1 is obsolete|| --- Comment #13 from Chris Cormack --- Created attachment 33181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33181&action=edit Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details In the OPAC if you view the MARC details for a title (and have OPACXSLTDetailsDisplay enabled) there is a "view plain" link which displays the output of opac-showmarc.pl. This is broken in master: fixed by this patch. Test plan: (1) Set OPACXSLTDetailsDisplay to default (2) Do a search on OPAC, then display a specific biblio record (3) Click on MARC view tab. Then click on 'view plain' link. Nothing is displayed. (4) Apply the patch. And refresh the MARC detail page. (5) Click on 'view plain' link. Check that a plain text MARC record is displayed. Signed-off-by: Chris Note: This makes a small change to C4::Templates::themelanguage so that it works with .xsl files too (They live in the xslt dir) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9175] Shelving location search returns no results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9175 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #64 from M. Tompsett --- (In reply to M. de Rooy from comment #57) > Interesting! Just some thoughts: > The SQL code in the opac-recovery script will not make it pass QA. Please > move it to module level (in DBIx?). > Can you unit test SendPasswordRecoveryEmail? Though, I would make sure this comment didn't get missed in the midst of everyone discussing password logic. M. de Rooy, are you talking about just the SELECT? What about the DELETE? Could you clarify which bits you mean by commenting on a splinter review? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #12 from Chris Cormack --- Excellent this looks good, Ill do a proper test tomorrow (i might edit the commit message to remove mention of the sub we aren't using now). But from a code review it looks good. Just to do some regression testing now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Frédéric Demians changed: What|Removed |Added Attachment #33179|0 |1 is obsolete|| --- Comment #11 from Frédéric Demians --- Created attachment 33180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33180&action=edit Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details In the OPAC if you view the MARC details for a title (and have OPACXSLTDetailsDisplay enabled) there is a "view plain" link which displays the output of opac-showmarc.pl. This is broken in master: fixed by this patch. Note: Implemented with C4::XSLT::_get_best_default_xslt_filename() to keep code orthogonal. Test plan: (1) Set OPACXSLTDetailsDisplay to default (2) Do a search on OPAC, then display a specific biblio record (3) Click on MARC view tab. Then click on 'view plain' link. Nothing is displayed. (4) Apply the patch. And refresh the MARC detail page. (5) Click on 'view plain' link. Check that a plain text MARC record is displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12971] Printing member information lacks data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12971 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | Severity|normal |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #10 from Frédéric Demians --- > It should fall back to whateverr OPACFallback is set to. Currently thats > bootstrap, but we dont want to be in this same position when we change > default theme again sometime in the future of having hardcoded theme names. Sorry. I wasn't even aware of this syspref. > Something like that, a single place where we pick the theme and language > seems to be a lot less error prone and easier to maintain. Will try. Thanks. > Hmm nope, still not the same behaviour > > in themelanguage we do > > my $fallback_syspref = ($interface eq 'intranet') ? 'template' : > 'OPACFallback'; > C4::Context->preference( $fallback_syspref ) I couldn't agree with you more. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170
--- Comment #9 from Chris Cormack ---
Comment on attachment 33179
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33179
Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC
details
Review of attachment 33179:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13170&attachment=33179)
-
::: C4/XSLT.pm
@@ +145,4 @@
> my @candidates = (
> "$htdocs/$theme/$lang/xslt/${base_xslfile}", # exact match
> "$htdocs/$theme/en/xslt/${base_xslfile}",# if not, preferred
> theme in English
> +"$htdocs/bootstrap/$lang/xslt/${base_xslfile}", # if not,
> 'bootstrap' theme in preferred language
Hmm nope, still not the same behaviour
in themelanguage we do
my $fallback_syspref = ($interface eq 'intranet') ? 'template' :
'OPACFallback';
C4::Context->preference( $fallback_syspref )
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Frédéric Demians changed: What|Removed |Added Attachment #33129|0 |1 is obsolete|| --- Comment #8 from Frédéric Demians --- Created attachment 33179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33179&action=edit Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details In the OPAC if you view the MARC details for a title (and have OPACXSLTDetailsDisplay enabled) there is a "view plain" link which displays the output of opac-showmarc.pl. This is broken in master: fixed by this patch. Note: Implemented with C4::XSLT::_get_best_default_xslt_filename() to keep code orthogonal. Test plan: (1) Set OPACXSLTDetailsDisplay to default (2) Do a search on OPAC, then display a specific biblio record (3) Click on MARC view tab. Then click on 'view plain' link. Nothing is displayed. (4) Apply the patch. And refresh the MARC detail page. (5) Click on 'view plain' link. Check that a plain text MARC record is displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Frédéric Demians changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #7 from Chris Cormack --- (In reply to Frédéric Demians from comment #6) > (In reply to Chris Cormack from comment #5) > > > Why are we doing this? Instead of using C4::Template::themelanguage ? > > > > Now we still have different behaviour for xslt and for normal templates > > > > themelanguage will never fallback to prog for the opac. however > > _get_best_defautl_xslt_filename will. > > > > So if have a new theme chrisc theme. And I make all the stuff, but no new > > xslt file. It will now fall back to prog, instead of bootstrap. > > > > This is a problem as prog no longer exists in the OPAC. > > Ok. I see. I forgot to modify _get_best_default_xslt_filename to fall back > to 'bootstrap' theme rather than 'prog' for OPAC interface. It should fall back to whateverr OPACFallback is set to. Currently thats bootstrap, but we dont want to be in this same position when we change default theme again sometime in the future of having hardcoded theme names. > > There is a difference between C4::Template::themelanguage & > C4::XSLT::_get_best_default_xslt_filename. 'themelanguage' search tempalates > in subdirectories of directory named 'modules'. > '_get_best_default_xslt_filename' search XSL file in a subdirectory named > 'xslt'. > > Would you suggest to factorize both functions in one? Something like that, a single place where we pick the theme and language seems to be a lot less error prone and easier to maintain. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 --- Comment #11 from Katrin Fischer --- I think we can't leave that it is currently - we need local logins or we will break people's LDAP setups on update :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9342] zebra UNIMARC dom indexing does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9342 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- Is DOM indexing for UNIMARC still not functional at all, as the title of this bug suggests or is there a more specific problem? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #10 from Katrin Fischer --- Kyle, could you take another look at this? I think it's almost a blocker, as your items will not be reset to the correct state if the fields has been empty (which is kind of a data loss) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7997] Can't create a notice with the same code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Katrin Fischer changed: What|Removed |Added Summary|can create a notice with|Can't create a notice with |the same code |the same code --- Comment #15 from Katrin Fischer --- Updating the bug description a bit: The problem now is that we DON'T allow for duplicate letter codes and a check has been added in the template (bug 11742). But I think we forgot about the existence of the hardcoded letter codes - some of those are: - ACCTDETAULS - HOLD - Slip templates... So... I think we need to find a way to allow duplicates? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10827] List of holds does not update correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 Katrin Fischer changed: What|Removed |Added Severity|critical|normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 --- Comment #6 from Frédéric Demians --- (In reply to Chris Cormack from comment #5) > Why are we doing this? Instead of using C4::Template::themelanguage ? > > Now we still have different behaviour for xslt and for normal templates > > themelanguage will never fallback to prog for the opac. however > _get_best_defautl_xslt_filename will. > > So if have a new theme chrisc theme. And I make all the stuff, but no new > xslt file. It will now fall back to prog, instead of bootstrap. > > This is a problem as prog no longer exists in the OPAC. Ok. I see. I forgot to modify _get_best_default_xslt_filename to fall back to 'bootstrap' theme rather than 'prog' for OPAC interface. There is a difference between C4::Template::themelanguage & C4::XSLT::_get_best_default_xslt_filename. 'themelanguage' search tempalates in subdirectories of directory named 'modules'. '_get_best_default_xslt_filename' search XSL file in a subdirectory named 'xslt'. Would you suggest to factorize both functions in one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12008] hold notice can be deleted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12008 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Can't test this as it's currently not possible to add mulitple letters with the same code :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #17 from Katrin Fischer --- I feel like we made a mistake here. Now it's not possible to add notices that have a hardcoded notice code like 'HOLD' for multiple branches. Maybe I am wrong...? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6172] Non-French UNIMARC frameworks need to be updated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6172 Katrin Fischer changed: What|Removed |Added Severity|critical|normal --- Comment #7 from Katrin Fischer --- We have an updated English UNIMARC framework now with 11453. I am not sure it makes sense to continue here - maybe we should file more specific bugs for further improvements/fixes? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|3.14|master Severity|critical|normal --- Comment #2 from Katrin Fischer --- To test: - Create an authority for "Cement Concrete & Aggregates Australia" - Create a new bibliographic record, link to the authority - Click on the plugin again, the search string is not complete -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13170] Remove of prog theme broke the OPAC's "view plain" option for MARC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170
--- Comment #5 from Chris Cormack ---
Comment on attachment 33129
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33129
Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC
details
Review of attachment 33129:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13170&attachment=33129)
-
::: opac/opac-showmarc.pl
@@ +57,5 @@
> +C4::Context->config('opachtdocs'),
> +C4::Context->preference('opacthemes'),
> +C4::Languages::getlanguage($input),
> +$view eq 'card' ? 'compact.xsl' : 'plainMARC.xsl'
> +);
Why are we doing this? Instead of using C4::Template::themelanguage ?
Now we still have different behaviour for xslt and for normal templates
themelanguage will never fallback to prog for the opac. however
_get_best_defautl_xslt_filename will.
So if have a new theme chrisc theme. And I make all the stuff, but no new xslt
file. It will now fall back to prog, instead of bootstrap.
This is a problem as prog no longer exists in the OPAC.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7380] Can't filter patron search on detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Katrin Fischer --- Hm not sure what's wrong - I tried applying 11944 first, but got a couple of conficts. 7380 won't apply alone either. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12886] shelfbrowser script should write headers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12886] shelfbrowser script should write headers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Katrin Fischer changed: What|Removed |Added Attachment #33142|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 33178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33178&action=edit [PASSED QA] Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header= I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with "en" and translated templates) Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes tests and QA script, no regressions found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Mandatory fields are wrong in patron personal details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure if it's wrong - it seems like it might be intended behaviour. The library staff might have a different set of fields to fill out then the patron. I am not sure, but i think it earlier versions we didn't check for mandatory fields at all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #8 from Barton Chittenden --- (In reply to Frédéric Demians from comment #7) > (In reply to Chris Cormack from comment #6) > > > 28/10/2014 > 2014-10-28 .. so i think you need to make sure you have it set > > to mm/dd/ (american format) > > I already tested switching dateformat do dd/mm/. It doesn't help. Sorry. Frédéric: did you test dd/mm/ or mm/dd/? The latter is the one we're having trouble with. Your reply above suggests that you tested the former, but I can't tell if you mis-typed your answer or mis-tested. No big deal either way, I'm just looking for clarification. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #63 from Liz Rea --- Comment 57, 2nd paragraph - when someone doing QA suggests mailing a cleartext password might be ok, it seems right to emphatically tell them "no, that's a bad idea." I for one appreciate the fact that it was never part of this dev, thanks for doing it properly. :) Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #62 from Eric Bégin --- Juste wondering how this clear text password came in the discussion. That was never the case with this development. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #61 from Liz Rea --- Also, if you send the password in the clear, if it is intercepted once, and you are one of (more people than we'd like to admit) those people who uses the same password in multiple accounts, it's not only your library account that is now possibly hacked. We should not ever, ever, ever show a password in the clear. Ever. I am glad this works the way it does, it is the proper way. Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #60 from Eric Bégin --- The token sent to the user is valid only for 2 days or if the link is clicked. Most of the time, a use who requests a password will click the link in the following minutes (if not seconds). Of course, this doesn't prevent your email to be intercepted. As far as I know, this feature was implemented the way most of the « Forgot your password ? » links are implemented. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #28 from Robin Sheat --- Is it really coming from Koha::Cache? I haven't had a chance to look yet, but I don't really understand those messages, and without understanding they'll be hard to fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404
--- Comment #13 from Frédéric Demians ---
For me, there is a design error in you dev. You send to TT a representation of
MARC record which is not correct. You loose the field order in the record, and
subfields order inside each field. The fields object sent to TT is a hashref of
arrayref of hashref of array. The valid representation is an arrayref (1 per
tag) of arrayref (1 per subfield) of arrayref (1 per pair letter/value).
So for example (bad example), if you have:
245 ## - TITLE STATEMENT
a Title My first title
b Remainder of title My remainder
a Title My second title
With your represenation, you can't know anymore that the second $a comes after
$b. In MARC21, it's important since separators are in the subfield content
itself. Your 245 field will be represented like that:
245 => {
'a' => [
'My first title',
'My second title'
],
'b' => [
'My remainder'
]
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #59 from Katrin Fischer --- I agree with Chris, I think. Also we have a similar approach for the patron verification - sending a link to a page where you learn about your password. It seems a good way to do this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #58 from Chris Cormack --- (In reply to M. de Rooy from comment #57) > Interesting! Just some thoughts: > The SQL code in the opac-recovery script will not make it pass QA. Please > move it to module level (in DBIx?). > Can you unit test SendPasswordRecoveryEmail? > > I would not mind a mail with a library password; other info is more > sensitive. If you can read/intercept the password from the mail, you can > also read the unique userid for the reset password form. Same result: a > hacked account. This approach is fine with me, feels more safe but is not > per se safer imo. I disagree, a token should be time based, and will require the person to set a password. This password only they will know. It's true that if someone intercepts the token and uses it to set your password for you, that is still a problem. However when you go to use the token and find out it has been used you will know this. If they intercept your password, they could use it for a bunch of time without you ever knowing. Sending passwords in the clear is a bad idea. Please do not do it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #57 from M. de Rooy --- Interesting! Just some thoughts: The SQL code in the opac-recovery script will not make it pass QA. Please move it to module level (in DBIx?). Can you unit test SendPasswordRecoveryEmail? I would not mind a mail with a library password; other info is more sensitive. If you can read/intercept the password from the mail, you can also read the unique userid for the reset password form. Same result: a hacked account. This approach is fine with me, feels more safe but is not per se safer imo. Thinking out loud: if you do not include sensitive keywords as "password" in your mail (so rename your script?), would that be little more safe? Would not attract attention? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 --- Comment #6 from Frédéric Demians --- (In reply to Tiburce Euphrasie from comment #5) Aloha! > Aloha Frédéric Demians, > Adding 'return unless $isbn;' on line 1683 in Koha.pm means that the sub > NormalizeISBN will return nothing for the specific ISBN sample I've provided. > > This is not a proper way to fix this bug because that patch implies that all > those '979.*' ISBN simply don't exist. Your assumption is not correct. The function can't transform your ISBN-13 into ISBN-10, because it begins with '979'. Rather than returning undef to say that the conversion is not possible, the function was failing badly, stopping completely the Perl process. That's what is corrected by the patch. Have you tried the patch? Does it solve the bug reported here? Can you import your record? Is your ISBN field preserved? For both records? The Koha internal function NormalizeISBN is called from other part of the Koha code base (see bug 13158). When the action requested to the function could not be completed, the function is supposed to return undef (nothing). That's exactly what'is done with the patch. The import process call NormalizeISBN function for whatever reason. I can't say why, indeed. And for doing nothing with the result, since ISBN field is not modified during import. But this is another story, and can't be fixed here. > Bu the way, the initial summary for this bug was "Stage MARC for Import > hangs", a mistake was done when changing this summary to "Stage MARC for > Import hangs for biblio containing invalid ISBN-13", so I'll change it to > "Stage MARC for Import hangs for biblio containing valid 979* ISBN-13" after > redacting this comment. You're correct. That's a valid ISBN-13 which can't be converted into ISBN-10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13132] Confirm report delete?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Heather Braum changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #2 from Heather Braum --- Owen, We are on 3.16.4 (which I thought was the latest version of 3.16 when I reported this issue), and I am still not seeing a confirm delete message on Mac and PC versions of Firefox and Chrome... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11064] batch import ignoring framework choice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Tiburce Euphrasie changed: What|Removed |Added Summary|Stage MARC for Import hangs |Stage MARC for Import hangs |for biblio containing |for biblio containing valid |invalid ISBN-13 |979* ISBN-13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing invalid ISBN-13
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 --- Comment #5 from Tiburce Euphrasie --- (In reply to Frédéric Demians from comment #1) > Created attachment 33130 [details] [review] > Bug 13167 Stage MARC for Import hangs for biblio containing invalid ISBN-13 > > If the ISBN of a UNIMARC record begins with 979 then the 'Stage MARC for > import' hangs. If I use the same UNIMARC record and change 979 to 978 in the > ISBN, 'Stage MARC for import' works perfectly. > > The patch deals with the fact that converting an ISBN-13 to ISBN-10 with > Business::ISBN as_isbn10() method fails if the ISBN doesn't begin with 978. Aloha Frédéric Demians, Adding 'return unless $isbn;' on line 1683 in Koha.pm means that the sub NormalizeISBN will return nothing for the specific ISBN sample I've provided. This is not a proper way to fix this bug because that patch implies that all those '979.*' ISBN simply don't exist. Bu the way, the initial summary for this bug was "Stage MARC for Import hangs", a mistake was done when changing this summary to "Stage MARC for Import hangs for biblio containing invalid ISBN-13", so I'll change it to "Stage MARC for Import hangs for biblio containing valid 979* ISBN-13" after redacting this comment. This ISBN is valid : - there's a scan from the original book in the attachment file 32969 : http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32969 - There's some documentation available this kind of ISBN : http://www.afnil.org/ http://fr.wikipedia.org/wiki/International_Standard_Book_Number Aloha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing invalid ISBN-13
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 --- Comment #4 from Tiburce Euphrasie --- (In reply to Frédéric Demians from comment #2) > (In reply to Tiburce Euphrasie from comment #0) > > > I think I've also detected a small problem in > > Open a separate bug report. Aloha, Done. See bug 13192 : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13192 Aloha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11201] List pending in-house uses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #7 from Owen Leonard --- There a couple of things I would like to see added if possible: - Output of subtitles as defined in Keyword to MARC mapping - Overdue items highlighted in red as they are on the checkouts page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13193] Discussion: strategy for diagnosing memcache issues.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Barton Chittenden changed: What|Removed |Added Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13193] New: Discussion: strategy for diagnosing memcache issues.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Bug ID: 13193
Summary: Discussion: strategy for diagnosing memcache issues.
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: gmcha...@gmail.com
Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
In bug 13150, we came across the following error:
Can't use string ("") as a HASH ref while "strict refs" in use at
/usr/share/koha/lib/C4/Biblio.pm line 1635.
Ultimately, this was determined to be caused by a corrupted data structure
caused by memcache.
I would suggest creating an entry in a similar hash that contains a well known
string that could be checked upon entering any page. If the memcached copy
didn't match the well-known value, we would know that memcache is having
problems, and throw a warning of some sort, advising that memcache should be
re-started.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- If you do not have "Always show checkouts immediately" checked by default, the list of checkouts doesn't appear but the "export checkouts" form does. However, the "export checkouts" function doesn't work unless you have selected checkouts to export. I think the export form should be hidden by default along with the checkouts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Tomás Cohen Arazi changed: What|Removed |Added Attachment #31181|0 |1 is obsolete|| --- Comment #19 from Tomás Cohen Arazi --- Created attachment 33177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33177&action=edit Bug 6681: introduce XSLT scripts to remove items and links This patch adds the following sample files: - Del952.xsl - Del995.xsl - Del9LinksExcept952.xsl - Del9LinksExcept995.xsl Thay can be used on the new SRU/Z39.50 XSLT processing feature. At the same time they can be used to solve this bug. To test: - Have an SRU/Z39.50 target configured - Have a search that returns at least a record with the following properties: * It contains $9 links * It contains items (952 or 995 fields in MARC21/NORMARC and UNIMARC respectively). MARC21/NORMARC test: - Do a Z39.50/SRU cataloguing search that retrieves the desired record - Verify it includes $9 and 952 field(s) by clicking on the MARC link - Edit your Z39.50 target and add Del952.xsl to the "XSLT File(s) for transforming results:" field - Re-run the search => SUCCESS: the MARC view of the imported record doesn't contain the 952 field - Edit your Z39.50 target and add Del9LinksExcept952.xsl to the "XSLT File(s) for transforming results:" field - Re-run the search => SUCCESS: the MARC view contains the 952 field (including the $9 subfield), and all other $9 subfields have been removed - Edit your Z39.50 target and add Del952.xsl, Del9LinksExcept952.xsl to the "XSLT File(s) for transforming results:" field (both, comma separated) - Re-run the search => SUCCESS: the MARC view doesn't contain $9 subfields nor items. - Repeat for UNIMARC, replacing 952 for 995. - Sign off :-D Regards Tomas Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13192] New: Hard-coded value (ISBN Prefix '978') in cataloguing::value_builder::unimarc_field_010
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13192
Bug ID: 13192
Summary: Hard-coded value (ISBN Prefix '978') in
cataloguing::value_builder::unimarc_field_010
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: MARC Bibliographic data support
Assignee: gmcha...@gmail.com
Reporter: tiburce.euphra...@aupaysdescrevettes.org
QA Contact: testo...@bugs.koha-community.org
Aloha,
Frédéric Demians suggests me to open a new bug report for this case (please
read http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 for more
information):
...I think I've also detected a small problem in
cataloguing::value_builder::unimarc_field_010 :
[...] Line 94 to 96 :
if (length ($isbn) == 13){
$isbn = substr($isbn, 3, length($isbn)-3);
}
[...] Then, line 143 :
$sth->execute($seg2, "978$seg2");
This "978" on line 143 is hard-coded and there's no relation with the original
data inside $isbn (lost on line 95 via the substr function). I don't know if
this is a real problem but it might be better to keep the original data than
replacing it with "978".
Thanks to Frédéric Demians for resolving bug 13167.
Aloha.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #56 from simith.dolive...@inlibro.com --- Created attachment 33176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33176&action=edit Bug 8753 - Add forgot password link to OPAC - DBIx Schema Added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 simith.dolive...@inlibro.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||simith.dolive...@inlibro.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #55 from simith.dolive...@inlibro.com --- Created attachment 33175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33175&action=edit Bug 8753 - Add forgot password link to OPAC - Updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_3_18_candidate CC||tomasco...@gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13191] New: Null borrowernumber in reserves table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13191 Bug ID: 13191 Summary: Null borrowernumber in reserves table Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: hbr...@nekls.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Occasionally, we have reserves placed on our system without a linked borrowernumber. It displays as NULL in the reserves table of the database. I cannot recreate how this behavior is happening so far, except to say it appears to originate on the public side of the system. Some debugging code was added to C4::Reserves::AddReserve on our system, and the logs revealed it's a call to AddReserve where no borrowernumber is passed in -- on the OPAC side. Has anyone else seen this behavior? Know why it's happening? Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13096] Send account notice with login details in more situations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #13 from M. de Rooy --- Will still make some small adjustments before setting to Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Jonathan Druart --- Bug 10703 introduces a big regression, see bug 13190. Has to be apply before this patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What|Removed |Added Attachment #28769|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 33172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33172&action=edit Bug 12404: Allow TT tags for csv profiles This patch is the main patch. It contains the changes in C4::Record::marcrecord2csv. The goal of this development is to provide a better flexibility on creating a CSV profile. Currently it is not possible to: - Concatenate specific subfields into a csv column - Display a field/subfield using a condition - Extract a substring of a subfield value and a lot of other actions. This patch allows to write Template Toolkit code and to extract only data you want. See the help page for more information (in next patch). Test plan: Create some CSV profiles (MARC, not SQL) using some TT methods. Use the basket export and the export tool and verify the CSV file generated is what you expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What|Removed |Added Attachment #28771|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 33174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33174&action=edit Bug 12404: Add some documentation in the help page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What|Removed |Added Attachment #28770|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 33173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33173&action=edit Bug 12404: tools/export.pl allows CSV export -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What|Removed |Added Attachment #28767|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 33170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33170&action=edit Bug 12404: Add UT for marcrecord2csv Verify that these unit tests pass before any changes and after applying all patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What|Removed |Added Attachment #28768|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 33171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33171&action=edit Bug 12404: Add new unit tests These unit tests reflect the changes done in next patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What|Removed |Added Attachment #33167|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 33169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33169&action=edit Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13183] Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13183 --- Comment #2 from Owen Leonard --- Created attachment 33168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33168&action=edit Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on This patch addresses the case where OnSiteCheckoutsForce is enabled and the user is checking out to a patron who is blocked from checking out. Instead of showing the 'specify due date' form (which is disabled) this patch hides it and highlights the on-site checkout controls. This patch adds some CSS and consolidates some redundant CSS. To test, load a patron for checkout under the following conditions: 1. OnSiteCheckoutsForce is off and patron is not blocked from checkout 2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for being expired or restricted). 3. OnSiteCheckoutsForce is on and patron is not blocked from checkout 4. OnSiteCheckoutsForce is on and patron is blocked from checkout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13183] Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13183 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What|Removed |Added Blocks||12404 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What|Removed |Added Depends on||13190 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #3 from Jonathan Druart --- Created attachment 33167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33167&action=edit Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11201] List pending in-house uses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_3_18_candidate CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #2 from Jonathan Druart --- It does not work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What|Removed |Added Attachment #33166|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #188 from Jonathan Druart --- This feature introduces a bug: it's not possible to export the checkout list. See bug 13190 for a fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #1 from Jonathan Druart --- Created attachment 33166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33166&action=edit Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13179] Circulation page layout problem when OnSiteCheckoutsForce is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13179 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jonathan Druart changed: What|Removed |Added Blocks||13190 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||11703 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] New: Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Bug ID: 13190 Summary: Export checkout list does not work anymore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Bug 11703 breaks the export feature present on the checkout list. On circ/circulation.pl, the export column is there but not the export button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #88 from Tomás Cohen Arazi --- Patches pushed to master. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13184] Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsForce is on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13184 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Kyle M Hall changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Kyle M Hall changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13189] New: Patron card creator patron search browse by last name broken by extended attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Bug ID: 13189 Summary: Patron card creator patron search browse by last name broken by extended attributes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The browse by last name letters on the patron search for the patron card creator doesn't work quite right. If extended patron attributes are disabled, it works fine, but if they are enabled, they are searched even when using the browse last name. Thus, if a searchable attribute has a "D" in it, and one clicks the "D" link for the last name browser, that patron will show even if he or she has no "D" in his or her hame! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12969] VAT and price calculation should be done in a subroutine
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12969 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #87 from Tomás Cohen Arazi --- Created attachment 33165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33165&action=edit Bug 10860: (RM followup) checkout-related sysprefs belong to the checkouts section Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #31 from Jonathan Druart --- (In reply to M. de Rooy from comment #30) > If so, please merge them. > A squash of patches that edit the same lines multiple items would be helpful > too. I would not prefer. One is a bugfix (this one), the other is a new feature (11395). I could try to find what fix the problem, but I don't have enough time to do it soon and I don't think it is worth a try. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Mandatory fields are wrong in patron personal details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Fridolin SOMERS changed: What|Removed |Added Assignee|oleon...@myacpl.org |fridolyn.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
