[Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter and update master version number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013 Mirko Tietgen changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #3 from Mirko Tietgen --- *** Bug 16676 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16676] advance default version in build-git-snapshot
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16676 Mirko Tietgen changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Mirko Tietgen --- *** This bug has been marked as a duplicate of bug 17013 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16273] Prevent selfregistration from printing the borrower password and filling the logging form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16273 --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #6) > How is the user informed about his/her login credentials when this > preference is turned on? Since bug 15343, you can choose your password :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16985] Self registration verification e-mail is broken - no token at the end of the URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #2) > Jonathan, are you sure it's a duplicate? Not completely but it's about the same table (borrower_modifications, field verification_token). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #7 from Jiri Kozlovsky --- (In reply to Frédéric Demians from comment #6) > I've just tried this patch in order to test bug 17005 depending patch. For me > 4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this > error: > > Can't call method "borrowernumber" on unblessed reference at > Koha/REST/V1/Checkout.pm line 81 > > It may be due to my testing environment. Can someone confirm that tests are > still working on master? Oh, did you apply the bug 13895 first before testing? It is based on that bug, which is not in master yet. Dependency is set already -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #16 from M. Tompsett --- (In reply to Aleisha Amohia from comment #15) > (In reply to Jonathan Druart from comment #13) > > Aleisha, as Mark told you in comment 3 and comment 5, your patch conflict > > with bug 10589 and bug 16335. > > I see 10589 has been closed will this one goes ahead. Mark, should we wait > for you to finish your work with 16335 before finishing this one? Go ahead with this. 16335 is going to take a long time before I get it finished. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 Jonathan Druart changed: What|Removed |Added Attachment #53731|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 53873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53873&action=edit Bug 16622: some tests triggered by prove t fail for unset KOHA_CONF TEST PLAN - 1) unset KOHA_CONF 2) prove t -- 00-load.t dies miserably 3) prove t/Creators.t -- fails 4) apply patch 5) prove t -- noisy, but all tests successful 6) prove -v t/Creators.t -- 2 skipped tests 7) run koha qa test tools Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #99 from M. Tompsett --- (In reply to David Cook from comment #98) > (In reply to M. Tompsett from comment #97) > > PerlDependencies issue. > > Could you elaborate? > > I've added the Perl dependency. > > https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter. > html&bug=10662&attachment=53362 I'm going to guess off the top of my head without checking... But I usually state the file where the problem is. That's why it is marked as "Patch does not apply". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16955] Internal Server Error while populating new framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16955] Internal Server Error while populating new framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 Jonathan Druart changed: What|Removed |Added Assignee|ve...@veron.ch |jonathan.dru...@bugs.koha-c ||ommunity.org Severity|minor |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16955] Internal Server Error while populating new framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 Jonathan Druart changed: What|Removed |Added Attachment #53815|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 53874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53874&action=edit Bug 16955: Do not clear from cache when adding a new framework There are several issues with these lines: 1/ $cache is not defined correctly and it not visible inside duplicate_framework 2/ $frameworkcode is a wrong c/p, it should be $newframeworkcode 3/ these calls are not needed. As we are creating a new framework, the cache should be empty... This patch will simply remove these calls Test plan: Duplicate a framework and confirm that you do not get any error in your logs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17009] Duplicating frameworks is unnecessary slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17009 Jonathan Druart changed: What|Removed |Added Attachment #53835|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 53875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53875&action=edit Bug 17009: Speed up the framework duplication To duplicate frameworks, the code retrieve all the subfields, then execute 1 insert per subfield. It's unnecessary slow, we can use the DBMS to do it. Test plan: Create a new framework and duplicate the structure of another framework. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15247] mysql_auto_reconnect do not reconnect with UTF8 connection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15247 Jonathan Druart changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7441] Search results showing wrong branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #78 from Jonathan Druart --- (In reply to Kyle M Hall from comment #77) > > I am wondering if it would not be easier to use something like > > items.$pref_value instead of the xsl:choose blocks which copy/paste code. > > I'm not sure what you mean, but if you want to submit a followup to make > that change I'd be happy to test and sign off on it! Sorry but I really don't want to write xslt code. Waiting for a unimarc signoff! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Frédéric Demians changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #8 from Frédéric Demians --- (In reply to Jiri Kozlovsky from comment #7) > Oh, did you apply the bug 13895 first before testing? It is based on that > bug, which is not in master yet. Dependency is set already Indeed, my comment was for bug 13895! I've mixed up my browser tabs. I will recopy my comment on bug 13895 thread, and restore your patch status to 'Needs Signoff'. Thks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #22 from Frédéric Demians --- I've just tried this patch in order to test bug 17005 depending patch. For me 4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this error: Can't call method "borrowernumber" on unblessed reference at Koha/REST/V1/Checkout.pm line 81 It may be due to my testing environment. Can someone confirm that tests are still working on master? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #94 from Jonathan Druart --- What is the status of this? IMO we should wait for bug 16735 before pushing this one. It won't make sense to have 15707 without 16735. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15903] Remove use of recordpayment in paycollect.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15903 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Needs Signoff --- Comment #4 from Jonathan Druart --- signed-off-by line missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15895] Add Koha::Account module, use Koha::Account:: pay internally for recordpayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #16 from Jonathan Druart --- signed-off-by line missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 --- Comment #12 from Jonathan Druart --- Created attachment 53877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53877&action=edit Bug 16436 [QA Followup] - Use debug instead of info Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 Jonathan Druart changed: What|Removed |Added Attachment #51938|0 |1 is obsolete|| Attachment #53126|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 53876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53876&action=edit Bug 16436 - Allow action logs to be logged to the koha log file Test Plan: 1) Ensure that your Koha::Logger configuration is in good working order 2) Apply this patch 3) Modify the first line of your log4perl.conf file from: log4perl.logger.intranet = WARN, INTRANET to log4perl.logger.intranet = INFO, INTRANET 4) Change a system preference setting 5) Note the new line in your log file! Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16449] unimarc_field_4XX raises a warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449 Jonathan Druart changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Lari Taskula changed: What|Removed |Added Attachment #53817|0 |1 is obsolete|| --- Comment #23 from Lari Taskula --- Created attachment 53878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53878&action=edit Bug 13895: Fixed QA demands https://bugs.koha-community.org/show_bug.cgi?id=13895 Signed-off-by: Jiří Kozlovský Test plan still working Fixes Can't call method "borrowernumber" on unblessed reference at Koha/REST/V1/Checkout.pm line 81 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895
--- Comment #24 from Lari Taskula ---
(In reply to Frédéric Demians from comment #22)
> I've just tried this patch in order to test bug 17005 depending patch. For me
> 4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this
> error:
>
> Can't call method "borrowernumber" on unblessed reference at
> Koha/REST/V1/Checkout.pm line 81
>
> It may be due to my testing environment. Can someone confirm that tests are
> still working on master?
It was a small issue in the code. Calling $checkout->borrowernumber on
unblessed reference $checkout, probably meant $checkout->{borrowernumber}
instead, or even don't unbless $checkout(?).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16818] CAS redirect broken under Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16818] CAS redirect broken under Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818 Jonathan Druart changed: What|Removed |Added Attachment #53721|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 53879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53879&action=edit Bug 16818: External auth redirect broken under Plack Test plan: 0) Have either CAS or Shibboleth authentication enabled under Plack. 1) Hover over the authentication link on the staff client or OPAC, and notice that it has either '.../opac/...' or '.../intranet/...' instead of '.../cgi-bin/koha/...'. (This will be a complete dealbreaker for CAS authentication.) 2) Apply patch. 3) Check links again; they should now have the correct paths. Signed-off-by: Matthias Meusburger Signed-off-by: Jonathan Druart Did not test CAS or Shibboleth, but no regression found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #38 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #37) > The import tool does not work for me under plack (master), could you confirm? Did you test with plackup.sh ? There is an essential difference: When you test with koha-plack, the apache include file apache-shared-intranet-plack.conf comes into the picture. It includes a bunch of ProxyPass directives for some problematic scripts, and yes it includes stage-marc-import.pl. This means that the import tool most probably does not work with plackup.sh too without this patch. (Especially when you repeat the import?) So your problem here is not the scope of this report. I retested this patch by importing a marcxml twice with koha-plack enabled, and I confirm that it still works as expected. Btw I would like to work on resolving these issues making the ProxyPass unneeded, but yes on another report :) Thx for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 Jonathan Druart changed: What|Removed |Added Attachment #53729|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 53880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53880&action=edit Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t When the auth_header table has records which exclude 1xx and 2xx tags, the $bibfield doesn't match anything. This in turn sets it to undef, which triggers an error on the next line killing the test. This was completely refactored to provide the data necessary for the tests to pass, and to be more comprehensive (both MARC and UNIMARC are tested). The tests are then run. C4::Headings::authorities is mocked, so that this test is not dependent on a search engine. TEST PLAN - 1) back up DB 2) DELETE FROM auth_header; 3) SOURCE auth_header.sql; -- the provided file 4) prove t/db_dependent/Linker_FirstMatch.t -- should barf before running all the tests 5) apply all patches 6) prove t/db_dependent/Linker_FirstMatch.t -- should work happy 7) run koha qa test tools 8) restore your backup Followed test plan, behaves as expected. Signed-off-by: Marc Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16864] Silence warnings in t/db_dependent/ILSDI_Services.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16864] Silence warnings in t/db_dependent/ILSDI_Services.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Jonathan Druart changed: What|Removed |Added Attachment #53730|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 53881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53881&action=edit Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t prove t/db_dependent/ILSDI_Services.t generates noisy output as a result of the ambiguous context of two $cgi->param() calls. By storing into scalar variables, and then using the scalar variables, the code maintains readability and fixes the problem. TEST PLAN - 1) prove t/db_dependent/ILSDI_Services.t -- noisy. 2) apply patch 3) prove t/db_dependent/ILSDI_Services.t -- not noisy 4) run koha qa test tools Signed-off-by: Marc Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16864] Silence warnings in t/db_dependent/ILSDI_Services.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15809 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16864 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16585] Update Italian installer sample files for 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16585] Update Italian installer sample files for 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Jonathan Druart changed: What|Removed |Added Attachment #53725|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 53882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53882&action=edit Bug 16585: Update Italian installer sample files for 16.05 With this patch all sample/defintions .sql files are updated and translated into Italian (if you select italian during web installation). Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16585] Update Italian installer sample files for 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #9 from Jonathan Druart --- (In reply to Zeno Tajoli from comment #7) > Hi, > I answer the request of Jonathan (#6): > > >You should use \r\n to line breaks. > I insert "\r\n\r\n" because in Italy we want a empty line in the template. > It is a cosmetic request. > I used "\r\n\r\n" in older version of notices.sql No, look at: +Il prestito dei seguenti volumi sta per scadere: + +<> + +<>', 'email'), You did not use \r\n or whatever. Anyway, it's fine by me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall --- Pushed to master for 16.11! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15895] Add Koha::Account module, use Koha::Account:: pay internally for recordpayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15895] Add Koha::Account module, use Koha::Account:: pay internally for recordpayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895 Kyle M Hall changed: What|Removed |Added Attachment #52138|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 53883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53883&action=edit Bug 15895 - Add Koha::Account module, use Koha::Account::pay internally for recordpayment This is the first patch in a series to unify all payment functions into a single method. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay amount" button Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Jonathan Druart changed: What|Removed |Added Attachment #53856|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 53884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53884&action=edit Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates This patch removes the use of event attributes like "onclick" from the serial collection and serial edit templates. Events are now defined in JavaScript. Also changed: Converted "create routing list," "edit routing list," and "Renew" links to Bootstrap buttons. The "select all" and "clear all" links have Font Awesome icons added. To test, apply the patch and go to Serials - Locate or create a subscription for which an item record is NOT created when receiving. - On the serial collection page for this subscription, test that the "Multi receiving" button works correctly. - For any subscription, test that the "Generate next" button works correctly. - In each tab, test that the "select all" and "clear all" links work correctly. - On a subscription which has expired, test that the "Renew" button works correctly. - On the serial collection page, select multiple issues and click the "Edit serials" button. - Testing with a subscription for which an item record is NOT created when receiving: - Changing the status to "Arrived" or "Claimed" should change the "Expected on" date to today's date. Selecting any other status should leave the "expected on" date as it was or return it to its original value. - Test that the "Multi receiving" button works correctly. - Testing with a subscription for which an item record IS created when receiving: - Changing the status of an issue should work as above but should also trigger the appearance of the item add form when the status is "Arrived" or "Claimed," and hide the form otherwise. - Cliking the "Item" link at the top of the item add form should hide it. - Clicking the "Add item" link under any issue should display the item add form. - In the item add form, test that repeatable fields are correctly duplicated when you click the "clone" button. - On the "Supplemental issue" line, changing the status to "Arrived" should work as described above. Changing the status on this line to "Claimed" should only change the "Expected on" date. - Adding regular and supplemental issues should work correctly. Signed-off-by: Frédéric Demians Works as described. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17012] Remove more event attributes from administration templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17012] Remove more event attributes from administration templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17012 Jonathan Druart changed: What|Removed |Added Attachment #53857|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 53885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53885&action=edit Bug 17012 - Remove more event attributes from administration templates There are several administration templates which still contain event attributes. This patch move event definition to the JavaScript. To test you must have the SMSSendDriver system preference set to "Email." Apply the patch and go to Administration. - In Global system preferences, change the value of any input or select and then click the "Cancel" link for that section. After confirming your choice, the page should reload with your changes reset. - In Circulation and fine rules, edit any existing rule. In the editing row, click the "Clear" button. The data for that rule should be cleared. - In Transport cost matrix, make any change to the matrix. Submitting the form should work correctly. - In MARC bibliographic framework, choose 'MARC structure' for any framework. - Checking or unchecking the 'Display only used tags/subfields' checkbox should reload the page and change the display according to your choice. - In Did you mean?, make changes to the existing configuration. - Clicking "Cancel" should reload the page and discard your changes. - Clicking "Save configuration" should correcly save your changes. - In SMS cellular providers, click to edit any existing provider. Clicking the "Cancel" link should cancel the editing process and return you to the list of providers. Signed-off-by: Frédéric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17011] Remove "onblur" event attribute from some templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17011 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17011] Remove "onblur" event attribute from some templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17011 Jonathan Druart changed: What|Removed |Added Attachment #53868|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 53886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53886&action=edit Bug 17011 - Remove "onblur" event attribute from some templates Several templates have an "onblur" event attribute in the markup. This patch moves the onblur event definition into the JavaScript. To test, apply the patch and clear your browser cache if necessary. In Administration -> Authority types: - Choose "New authority type." - Enter any text into the "Authority type" field. - Moving the cursor focus away from this field should convert your text to uppercase. In Administration -> MARC bibliographic framework: - Choose "New framework." - Enter any text into the "Framework code" field. - Moving the cursor focus away from this field should convert your text to uppercase. In Administration -> Currencies and exchange rates: - Choose "New currency." - Enter any text into the "Currency" field. - Moving the cursor focus away from this field should convert your text to uppercase. In Administration -> Item types - Choose "New item type." - Enter any text into the "Item type" field. - Moving the cursor focus away from this field should convert your text to uppercase. Signed-off-by: Frédéric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16978] Add delete reports user permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16978] Add delete reports user permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 Jonathan Druart changed: What|Removed |Added Attachment #53741|0 |1 is obsolete|| Attachment #53871|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 53887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53887&action=edit Bug 16978: Add delete reports user permission This splits off the delete capability from the create reports permission. >From a UI perspective there were CSS issues, that this patch set hackily bypasses. Perhaps someone else can amend this enhancement with the required changes so that the extra column at the beginning of the table can be removed when the user does not have delete capability. TEST PLAN - 1) back up db 2) apply patch 3) ./installer/data/mysql/updatedatabase.pl -- should run without issue. 4) in mysql: > drop database ... > create database ... -- totally blanks it for fresh web install 5) run web install -- installing should have no issues 6) go to a patron 7) set permissions 8) expand the reports permission -- should have delete reports now 9) click help and scroll down to 'Granular Reports Permissions' right at the bottom. -- there should be a new delete_reports section 10) Head over to guided reports and build a few reports. -- as system account user, delete stuff should all be visible. 11) Find a patron, set all permissions, except delete reports. 12) log out and then log in as the modified patron 13) Head over the save reports -- none of the delete options should be available to the user. 14) run koha qa test tools 15) restore db Followed test plan. Additionally tried to delete using params in URL (not possible, OK) Signed-off-by: Marc Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16978] Add delete reports user permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 --- Comment #11 from Jonathan Druart --- Created attachment 53888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53888&action=edit Bug 16978: Followup - Copy create_report permissions for delete_report This patch should deal with comment #6's point of where a user who has create, but not execute permissions, would lose delete ability. Users with create and execute permissions would already have delete as well. TEST PLAN - 1) Back up db 2) drop database koha_library; 3) create database koha_library; 4) web install with all sample data with system user 6) log into staff client as system user 7) make sample koha admin user a superlibrarian 8) set username and password for sample koha admin user 9) log out and log in as koha admin 10) Create a user (USER_A) with permissions: create_reports and execute_reports. 11) Create a user (USER_B) with permissions: create_reports, but not execute_reports. 12) Create a user (USER_C) with permissions: execute_reports, but not create_reports. 13) Create a user (USER_D) with no report permissions. 14) Run the atomic update. 15) Check USER_A permissions -- should have delete_reports 16) Check USER_B -- should have delete_reports 17) Check USER_C -- should NOT have delete_reports 18) Check USER_D -- should NOT have delete_reports 19) run koha qa test tools 20) restore db Signed-off-by: Frédéric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter and update master version number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013 --- Comment #4 from Jonathan Druart --- Comment on attachment 53869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53869 Bug 17013 - build-git-snapshot: add basetgz parameter and update master version number Review of attachment 53869: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17013&attachment=53869) - ::: debian/build-git-snapshot @@ +31,4 @@ > my $buildresult; > my $distribution='squeeze-dev'; > my $git_checks='all'; > +my $version='16.06~git'; Should not we create a subroutine to guess the version? Otherwise we will have to update it every 6 months :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Frédéric Demians changed: What|Removed |Added Attachment #53878|0 |1 is obsolete|| --- Comment #25 from Frédéric Demians --- Created attachment 53889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53889&action=edit Bug 13895: Fixed QA demands Signed-off-by: Frédéric Demians Fix QA, and fix tests failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895
Lari Taskula changed:
What|Removed |Added
Attachment #51303|0 |1
is obsolete||
--- Comment #26 from Lari Taskula ---
Created attachment 53890
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53890&action=edit
[SIGNED-OFF] Bug 13895: Add API routes for checkouts retrieval and renewal
GET /checkouts?borrowernumber={borrowernumber}
GET /checkouts/{checkout_id}
PUT /checkouts/{checkout_id}
+ unit tests in t/db_dependent/api/v1/checkouts.t
Test plan:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
cookie). You should have permission circulate_remaining_permissions.
2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
XXX with a borrowernumber that has checkouts) and check you receive
correct data
3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
existing checkout id) and check you receive correct data
4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
the maximum number of renewals is reached (you should have a 403
error)
5. Run unit tests in t/db_dependent/api/v1/checkouts.t
Depends on bug 15126
Signed-off-by: Benjamin Rokseth
Signed-off-by: Lari Taskula
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Lari Taskula changed: What|Removed |Added Attachment #53889|0 |1 is obsolete|| --- Comment #27 from Lari Taskula --- Created attachment 53891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53891&action=edit [SIGNED-OFF] Bug 13895: Fixed QA demands Signed-off-by: Frédéric Demians Fix QA, and fix tests failing Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What|Removed |Added CC||eric.be...@inlibro.com, ||francois.charbonnier@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #28 from Lari Taskula --- What about user who does not have 'circulate_remaining_permissions' permission, but wants to access his own checkouts or renew his own checkouts if OpacRenewalAllowed is on? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15126] REST API: Use newer version of Swagger2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #53 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #40) > (In reply to Jonathan Druart from comment #38) > > (In reply to Julian Maurice from comment #32) > > > Created attachment 50142 [details] [review] [review] [review] > > > Bug 15126: Update patron definition > > > > Julian, I think we need tests to make sure the swagger file will be always > > up-to-date with the DB structure. Any ideas how we could do that? > > Maybe that should be a coding guideline/QA requisite, that every endpoint > has a proper set of unit tests, including this check on the swagger files. > I'd vote for discussing this on the next dev meeting to gather broader > opinions. This has never been done and the json file is not up-to-date: checkprevcheckout and updated_on are missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16825] Add API route for getting an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart --- items.new_status is missing in the swagger file. Please have a look at bug 15126 comment 53. We need a way to keep this file up-to-date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17013] build-git-snapshot: add basetgz parameter and update master version number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17013 --- Comment #5 from Mirko Tietgen --- (In reply to Jonathan Druart from comment #4) > Should not we create a subroutine to guess the version? > Otherwise we will have to update it every 6 months :) I think we did something similar in some other place. Do you remember where? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #4 from Jonathan Druart --- CONFLICT (content): Merge conflict in misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl CONFLICT (content): Merge conflict in C4/Letters.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #11 from Jonathan Druart --- Tomás, don't you think we should try and fill the interface column for existing values? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17017] New: Dependency fixes for 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017 Bug ID: 17017 Summary: Dependency fixes for 16.05 Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mi...@abunchofthings.net QA Contact: testo...@bugs.koha-community.org CC: mi...@abunchofthings.net Things I did for 16.05.02. Should go in 16.05.03. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17017] Dependency fixes for 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017 Mirko Tietgen changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mi...@abunchofthings.net |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Owen Leonard changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 --- Comment #14 from Owen Leonard --- I think Variant III is the best. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What|Removed |Added Attachment #53423|0 |1 is obsolete|| --- Comment #53 from Jonathan Druart --- Created attachment 53892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53892&action=edit Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType This unnecessary complicated subroutine returned an arrayref and an hashref of the patron categories available for the logged in user, for a given category_type, ordered by categorycode. This can now be done with the search_limited method. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by categorycode. - Add/edit a patron, change his/her patron category value. - On the 3 following reports: reports/bor_issues_top.pl reports/borrowers_out.pl reports/cat_issues_top.pl The display for these 3 reports are different than the 2 from the first patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by categorycode and the ones limited to other libraries are not displayed (should certainly be fixed). Note that the big part of this patch has already been tested before (update child related: CATCODE_MULTI). Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Attachment #52913|0 |1 is obsolete|| Attachment #52914|0 |1 is obsolete|| Attachment #52915|0 |1 is obsolete|| Attachment #52916|0 |1 is obsolete|| Attachment #52917|0 |1 is obsolete|| Attachment #52918|0 |1 is obsolete|| Attachment #52919|0 |1 is obsolete|| Attachment #52920|0 |1 is obsolete|| --- Comment #47 from Jonathan Druart --- Created attachment 53893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53893&action=edit Bug 15758: Koha::Libraries - Remove GetBranchName This is the fourth and last patch set to remove C4::Branch. The real purpose of this patch is to standardise and refactor some code which is related to the libraries selection/display. Its unconfessed purpose is to remove the C4::Branch package. Before this patch set, only 6 subroutines still existed in the C4::Branch package: - GetBranchName - GetBranchesLoop - mybranch - onlymine - GetBranches - GetBranch GetBranchName basically returns the branchname for a given branchcode. The branchname is only used for a display purpose and we don't need to retrieve it in package or pl scripts (unless for a few exceptions). We have a `Branches` template plugin with a `GetName` method which does exactly this job. To achieve this removal, we will use this template plugin and delete the GetBranchName from pl and pm files. The `Branches.all()` will now select the library of the logged in user if no `selected` parameter has been passed. This new behavior could cause regressions, for instance there are some places where we do not want an option preselected (batch item modification for instance), keep that in mind when testing. GetBranchesLoop took 3 parameters: $branch and $onlymine. The first one was used to set a "selected" flag, for a display purpose: select an option in the libraries dropdown lists. The second one was useless: If not passed or set to 0, the `C4::Branch::onlymine` subroutine was called. This onlymine flag was use to know if the logged in user was able to see other libraries infos. A patron can see the infos from other libraries if IndependentBranches is not set OR if he has the superlibrarian permission. Prior to this patch set, the "onlymine test" was done on different places (neworderempty.pl, additem.pl, holidays.pl, etc.), including the Branches TT plugin. In this patch set, this test is only done on one place (C4::Context::only_my_library, code moved from C4::Branch::onlymine). To accomplish the same job as this subroutine, we just need to call the `Branches.all()` method from the `Branches` TT plugin. It already accepts a `selected` parameter to set a flag on the option to select. To avoid the repetitive [% IF selected %][% ELSE %][% END %] pattern, a new `html_helpers` TT include file has been created, it defines an `options_for_libraries` block, which takes a `selected` parameter. We could imagine to use this include file for other selects. The 'mybranch` and `onlymine` subroutines of the C4::Branch package have been moved to C4::Context. onlymine has been renamed with only_my_library. There are only 4 occurrences of it, against 11 before this patch set. There 2 subroutines are Context-centric and it makes sense to put them in `C4::Context` (at least it's the least worst place!) GetBranches is the tricky part of this patch set: It retrieves all the libraries, independently of the value of IndependentBranches. To keep the same way as the existing calls of `Branches.all()`, I have added a `unfiltered` parameter. If set, the `Branches.all()` will call a usual Koha::Libraries->search method, otherwise Koha::Libraries->search_filtered will be called. This new method will check if the logged in user is allowed to see other libraries or only its library. Note that this `GetBranches` subroutine also created a `category` key: it allowed to get the list of groups (of libraries) where this library existed. Thanks to a previous patch set (bug 15295), this value was not used anymore (I may have missed something!). Note that the only use of `GetBranch` was buggy (see bug 15746). Test plan (for the whole patch set): The best way to test this whole patch set is to test with 2 instances: 1 with the patch set applied, 1 using master, to be sure there is no regression. It would be good to test
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #48 from Jonathan Druart --- Created attachment 53894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53894&action=edit Bug 15758: Koha::Libraries - Remove GetBranchesLoop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #49 from Jonathan Druart --- Created attachment 53895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53895&action=edit Bug 15758: Koha::Libraries - Move mybranch to C4::Context -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #51 from Jonathan Druart --- Created attachment 53897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53897&action=edit Bug 15758: Koha::Libraries - Move onlymine to C4::Context::only_my_library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #52 from Jonathan Druart --- Created attachment 53898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53898&action=edit Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #53 from Jonathan Druart --- Created attachment 53899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53899&action=edit Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #54 from Jonathan Druart --- Created attachment 53900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53900&action=edit Bug 15758: Koha::Libraries - Do not select an option if selected is defined This will certainly need a few more tweaks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #50 from Jonathan Druart --- Created attachment 53896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53896&action=edit Bug 15758: Koha::Libraries - Remove GetBranches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17018] New: Split AdvancedSearchTypes for staff and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Bug ID: 17018 Summary: Split AdvancedSearchTypes for staff and OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org It would be nice if you could configure AdvancedSearchTypes differently for staff and opac advanced search. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #29 from Lari Taskula --- Created attachment 53901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53901&action=edit Bug 13895: Allow user to access their own checkouts and renew them Let user access their own checkouts and if OpacRenewalAllowed system preference is on, also let user to renew their checkouts. Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie) with a Patron that has no permissions. This Patron will be referred as "your patron" or "your borrowernumber" below. 2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace XXX with your borrowernumber) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace XXX with someone else's borrowernumber) and check you get a permission error. 4. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an existing checkout id of your Patron) and check you receive correct data 5. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an existing checkout id of some other Patron) and check you get a permission error. 6. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY, replace YYY with existing checkout id of some other Patron. You should get a permission error. 7. Set system preference OpacRenewalAllowed to 0. 8. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY. YYY should be checkout id of checkout for your patron. You should get a permission error. 9. Set system preference OpacRenewalAllowed to 1. 10. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until the maximum number of renewals is reached (you should have a 403 error). YYY should be checkout id of checkout for your patron. 11. Run unit tests in t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Lari Taskula changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17017] Dependency fixes for 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017 --- Comment #1 from Mirko Tietgen --- Created attachment 53902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53902&action=edit Bug 17017 Dependency fixes for 16.05 Things I did for 16.05.02. Should go in 16.05.03. Adds to PerlDependencies.pm: IO::Socket::IP Readonly Readonly::XS Adds overrides to debian/list-deps: IO::Socket::IP => 'perl-modules (>= 5.20.0) | libio-socket-ip-perl' Swagger2 => 'libswagger2-perl (>= 0.59)' and an up to date debian/control based on that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17017] Dependency fixes for 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017 Mirko Tietgen changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17017] Dependency fixes for 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17017 Mirko Tietgen changed: What|Removed |Added CC||frede...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17019] New: debian/changelog update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019 Bug ID: 17019 Summary: debian/changelog update Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mi...@abunchofthings.net QA Contact: testo...@bugs.koha-community.org CC: mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17019] debian/changelog update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019 Mirko Tietgen changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mi...@abunchofthings.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17019] debian/changelog update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019 --- Comment #1 from Mirko Tietgen --- Created attachment 53903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53903&action=edit Bug 17019 - debian/changelog update This has not been updated for a while. I plan to add the stable releases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17019] debian/changelog update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019 Mirko Tietgen changed: What|Removed |Added CC||frede...@tamil.fr Status|NEW |Needs Signoff --- Comment #2 from Mirko Tietgen --- Should go in 16.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17020] New: findborrower is not used in circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020 Bug ID: 17020 Summary: findborrower is not used in circulation.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org It's passed to the template but never used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What|Removed |Added Blocks|14568 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14423] Multiple XSS and XSRF issues in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14423 Jonathan Druart changed: What|Removed |Added Blocks||14568 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16599] XSS found in opac-shareshelf.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16599 Jonathan Druart changed: What|Removed |Added Blocks||14568 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16478] Translation breaks display of Checkout history in tab Checkouts / On-site-checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Jonathan Druart changed: What|Removed |Added Blocks|14568 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14416] Stored XSS flaw affects OPAC and Staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14416 Jonathan Druart changed: What|Removed |Added Blocks||14568 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16478] Translation breaks display of Checkout history in tab Checkouts / On-site-checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Jonathan Druart changed: What|Removed |Added Blocks||14568 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6934] New report Cash Register Statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #103 from Francois Charbonnier --- (In reply to Katrin Fischer from comment #102) > (In reply to Francois Charbonnier from comment #96) > > (In reply to Katrin Fischer from comment #59) > > > > > - What is the definition of an "Active transaction"? (was not clear to me, > > > so asking :) ) > > > > The idea behind "Active transactions" is to help balance cash register > > transactions. In other words, how much goes in or how much goes out the cash > > register. The active transactions group what patrons paid or gave as credit > > to the library, which means what went IN the register. > > > > The code works this way : it takes all transactions where account types are > > NOT "F" (Fine), "FU" (Fine unpaid), "FOR" (Forgiven), "M" (Sundry), "L" > > (Lost). > > Sorry, I still don't get it :( The list of excluded fine types looks a bit > arbitrary to me - what about custom MANUAL_INV values? And what is left by > excluding those? Hey Katrin, But you do get that "active transaction" groups all transactions where patrons give money to the library, right ? The logic should be different. What do you think of grouping the relevant account types, "Pay" and "C" (are there other?) instead of excluding this list? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17027] New: contril file update for 3.22
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027 Bug ID: 17027 Summary: contril file update for 3.22 Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mi...@abunchofthings.net QA Contact: testo...@bugs.koha-community.org CC: mi...@abunchofthings.net I updated the control file for 3.22.09. This should go in 3.22.10. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17027] contril file update for 3.22
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027 --- Comment #1 from Mirko Tietgen --- Created attachment 53904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53904&action=edit Bug 17027 I updated the control file for 3.22.09. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17027] control file update for 3.22
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027 Mirko Tietgen changed: What|Removed |Added Summary|contril file update for |control file update for |3.22|3.22 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17020] findborrower is not used in circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020 --- Comment #1 from Jonathan Druart --- Created attachment 53905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53905&action=edit Bug 17020: Do no pass findborrower to the template Indeed, it's not used! Test plan: git grep '\[% findborrower' should not return any result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17020] findborrower is not used in circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17020 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
