date:20171029

[Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #19 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #15)
> Alex, some remarks:
> 1. take a look at basic_workflow.t, there are some changes you did not take
> into account (19337)
> 2. Tests must create the data they need and delete them. Here you are using
> the FA framework and modify it. That means the tests will fail if executed
> twice.
> 3. The cleanup method is wrong, it should not be a method as the different
> selenium test files will have different a cleanup.
> 4. t::lib::Selenium::pause_driver does not work as you would like?

I didn't look to see if the code actually address points 2-4. I believe my
patches deal with 1. I'm going to set this to Failed QA, even though the tests
ran successfully.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

--- Comment #17 from M. Tompsett  ---
Created attachment 68832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68832=edit
Bug 19243: Patch t/lib/Selenium to use ENV and fix login.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

--- Comment #18 from M. Tompsett  ---
Created attachment 68833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68833=edit
Bug 19243: Change to use ENV and fix passwords

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #16 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #15)
> 4. t::lib::Selenium::pause_driver does not work as you would like?

Where is t::lib::Selenium{anything}?
It's not in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17610] [16.11.x] Allow the number of plack workers and max connections to be set in koha-conf.xml

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610

--- Comment #23 from Pongtawat  ---
Thank you for signing off.
Now I see hope that this might get pushed into the next 16.11 update :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19189] Reserving and renewing item in OPAC selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189

--- Comment #3 from M. Tompsett  ---
Created attachment 68831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68831=edit
Bug 19189: Change to use ENV, fix login and passwords

The kohadevbox has admin/admin set, so for testing when
creating the initial superuser, if you wish to minimize
effort, use admin/admin. Otherwise, make sure to:
export KOHA_USER={whatever your user is}
export KOHA_PASS={whatever your password is}
before attempting to run the test.

Also, this test was failing because of a validation check on
the passwords requiring uppercase letters, lowercase letters,
and numbers. Changed the sample data passwords to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19189] Reserving and renewing item in OPAC selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett  ---
04:32:37.504 INFO - Executing: [find element: By.xpath: //input[@value="Confirm
hold"]])
04:32:37.652 WARN - Exception thrown
org.openqa.selenium.NoSuchElementException: Unable to locate element:
{"method":"xpath","selector
":"//input[@value=\"Confirm hold\"]"}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185

--- Comment #4 from M. Tompsett  ---
Even with my attached patch, I hit problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185

--- Comment #3 from M. Tompsett  ---
Created attachment 68830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68830=edit
Bug 19185: Change to use ENV, fix login and passwords

The kohadevbox has admin/admin set, so for testing when
creating the initial superuser, if you wish to minimize
effort, use admin/admin. Otherwise, make sure to:
export KOHA_USER={whatever your user is}
export KOHA_PASS={whatever your password is}
before attempting to run the test.

Also, this test was failing because 'sub auth' was using
the ugliest of xpath's to find the submit button.
I've noticed the other selenium tests have similar functions.
It might be an idea to build a t/lib/Selenium.pm so as to
reduce code duplication and older versions differing from
newer versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19184] Purchase workflow selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19184

--- Comment #4 from M. Tompsett  ---
Created attachment 68829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68829=edit
Bug 19184: Change to use ENV, fix login and passwords

The kohadevbox has admin/admin set, so for testing when
creating the initial superuser, if you wish to minimize
effort, use admin/admin. Otherwise, make sure to:
export KOHA_USER={whatever your user is}
export KOHA_PASS={whatever your password is}
before attempting to run the test.

Also, this test was failing because of a validation check on
the passwords requiring uppercase letters, lowercase letters,
and numbers. Changed the sample data passwords to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19184] Purchase workflow selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19184

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #3 from M. Tompsett  ---
3926bc45bd)] -> xpath:
/html/body/div/div[4]/div/div[1]/div[1]/div/div[2]/div/ul/li[7]/a]]
04:07:43.320 INFO - Executing: [find element: By.xpath:
//a[@href="/cgi-bin/koha/opac-suggestions
.pl?op=add"]])
04:07:43.465 WARN - Exception thrown
org.openqa.selenium.NoSuchElementException: Unable to locate element:
{"method":"xpath","selector
":"//a[@href=\"/cgi-bin/koha/opac-suggestions.pl?op=add\"]"}
Command duration or timeout: 17 milliseconds

I'll be attaching my patch which got me this far at least.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19183] Acquisition module setup selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19183

--- Comment #4 from M. Tompsett  ---
Created attachment 68828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68828=edit
Bug 19183: Change to use ENV, fix login and passwords

The kohadevbox has admin/admin set, so for testing when
creating the initial superuser, if you wish to minimize
effort, use admin/admin. Otherwise, make sure to:
export KOHA_USER={whatever your user is}
export KOHA_PASS={whatever your password is}
before attempting to run the test.

Also, this test was failing because of a validation check on
the passwords requiring uppercase letters, lowercase letters,
and numbers. Changed the sample data passwords to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19183] Acquisition module setup selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19183

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett  ---
Shucks! The code was going well enough with my minor tweaks. Then we had to
fail.

03:49:22.872 INFO - Done: [send keys: 16 [[FirefoxDriver: firefox on LINUX
(cf0c8120-4c1d-4466-bd
5f-c7cb104dcccb)] -> xpath: //input[@id="budget_period_description"]], [T, e,
s, t,  , b, u, d, g
, e, t, 2]]
03:49:22.875 INFO - Executing: [find element: By.xpath:
/html/body/div[4]/div/div[1]/div/form/fie
ldset[1]/ol/li[5]/input])
03:49:22.914 INFO - Done: [find element: By.xpath:
/html/body/div[4]/div/div[1]/div/form/fieldset
[1]/ol/li[5]/input]
03:49:22.917 INFO - Executing: [click: 17 [[FirefoxDriver: firefox on LINUX
(cf0c8120-4c1d-4466-b
d5f-c7cb104dcccb)] -> xpath:
/html/body/div[4]/div/div[1]/div/form/fieldset[1]/ol/li[5]/input]])
03:49:23.148 WARN - Exception thrown
org.openqa.selenium.WebDriverException: Element is not clickable at point
(341.70001220703125, 47
6.838964844). Other element would receive the click: 
Command duration or timeout: 81 milliseconds

I'll attach my patch, but this is Failed QA. :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19182] Item search in intranet and OPAC selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19182

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19182] Item search in intranet and OPAC selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19182

--- Comment #5 from M. Tompsett  ---
Created attachment 68827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68827=edit
Bug 19182: Change to use ENV, fix login and passwords

The kohadevbox has admin/admin set, so for testing when
creating the initial superuser, if you wish to minimize
effort, use admin/admin. Otherwise, make sure to:
export KOHA_USER={whatever your user is}
export KOHA_PASS={whatever your password is}
before attempting to run the test.

Also, this test was failing because of a validation check on
the passwords requiring uppercase letters, lowercase letters,
and numbers. Changed the sample data passwords to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19182] Item search in intranet and OPAC selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19182

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66504|0   |1
is obsolete||

--- Comment #4 from M. Tompsett  ---
Created attachment 68826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68826=edit
Bug 19182 - Selenium test for searching for an item in the intranet and OPAC

This Selenium test goes through the process of creating a category and
patron user (as is completed in the basic_workflow.t test). Then this
newly created patron user is used to create a new biblio and add items
to that biblio.

The item search functionality in the intranet and OPAC is used to try to
find the biblio. If results to the item search query are displayed
then the test outputs 'Found item in inranet' and 'Found item in
OPAC' are shown

Test plan (this test plan includes how to install Selenium as well as how to
run this test, for the benefit of people who have not got Selenium installed on
their machines):

1. wget
https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar

2. vim /etc/apt/sources.list.d/firefox.list

3. Paste into the file:
deb http://packages.linuxmint.com debian import

4. sudo apt-get update

5. sudo apt-get install firefox

6. sudo apt-get install xvfb

7. Set the SELENIUM_PATH vartiable:
SELENIUM_PATH=/home/vagrant/kohaclone/selenium-server-standalone-2.53.0.jar

8. Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null &

9. DISPLAY=:1 java -jar $SELENIUM_PATH

Note: This will start up the selenium server. Everytime you want to shut
down this terminal window and want to restart Selenium just run the step
9 command to restart the Selenium server

10. Open a new terminal window and write in:
git clone https://github.com/gempesaw/Selenium-Remote-Driver --branch
build/master --single-branch --depth 1

11. cd Selenium-Remote-Driver

12. perl Makefile.PL

13. make

14. make test

15. sudo make install

16. Now everything is installed and you can et up for running the
selenium tests

17. Create a superlibrarian user with the username koha and password
koha

18. If your usual port configuration for the intranet and OPAC is 8081
and 8080 respectively then set the staffClientBaseURL and OPACBaseURL
system preferences to localhost:8080 and localhost:80 respectively

19. Ensure your catalogue is empty

20. Clear and rebuild your Koha index:
sudo koha-shell 

21. export the PERL5LIB variable

22. zebraidx -c /etc/koha/sites//zebra-authorities-dom.cfg
-g iso2709 -d authorities init

23. zebraidx -c /etc/koha/sites//zebra-biblios.cfg -g
iso2709 -d biblios init

24. exit

25. sudo su

26. sudo koha-rebuild-zebra -f -v  

27. exit

28. sudo koha-shell 

29. perl t/db_dependent/selenium/authenticate.t

30. The test should pass.
Note: The time_diff comments in the test output showing what the test is
doing

Note: If you have issues with installing Selenium and
Selenium::Remote::Driver please write a comment on the bug report and I
will be more than happy to create a screencapture video showing all the
steps

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181

M. Tompsett  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #9 from M. Tompsett  ---
The readability of this code is a vast improvement over bug 18974. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66505|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 68824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68824=edit
Bug 19181 - Selenium test for logging into the Koha intranet and OPAC

This selenium test goes through the process of creating a category and
patron user (as is completed in the basic_workflow.t test) then the
superlibrarian used to create them is logged out and the newly created
patron user authenticates into the OPAC and staff intranet therefore testing
the
authenitcation of both.

Test plan (this test plan includes how to install Selenium as well as
how to run this test, for the benefit of people who have not got
Selenium installed on their machines):

1. wget
https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar

2. vim /etc/apt/sources.list.d/firefox.list

3. Paste into the file:
deb http://packages.linuxmint.com debian import

4. sudo apt-get update

5. sudo apt-get install firefox

6. sudo apt-get install xvfb

7. Set the SELENIUM_PATH vartiable:
SELENIUM_PATH=/home/vagrant/kohaclone/selenium-server-standalone-2.53.0.jar

8. Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null &

9. DISPLAY=:1 java -jar $SELENIUM_PATH

Note: This will start up the selenium server. Everytime you want to shut
down this terminal window and want to restart Selenium just run the step
9 command to restart the Selenium server

10. Open a new terminal window and write in:
git clone https://github.com/gempesaw/Selenium-Remote-Driver --branch
build/master --single-branch --depth 1

11. cd Selenium-Remote-Driver

12. perl Makefile.PL

13. make

14. make test

15. sudo make install

16. Now everything is installed and you can et up for running the selenium
tests

17. Create a superlibrarian user with the username koha and password
koha

18. If your usual port configuration for the intranet and OPAC is 8081
and 8080 respectively then set the staffClientBaseURL and OPACBaseURL
system preferences to localhost:8080 and localhost:80 respectively

19. sudo koha-shell 

20. perl t/db_dependent/selenium/authenticate.t

21. The test should pass.
Note: The time_diff comments in the test output showing what the test is
doing

Note: If you have issues with installing Selenium and
Selenium::Remote::Driver please write a comment on the bug report and I
will be more than happy to create a screencapture video showing all the
steps

Sponsored-By: Catalyst IT

https://bugs.koha-community.org/show_bug.cgi?id=19181

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181

--- Comment #8 from M. Tompsett  ---
Created attachment 68825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68825=edit
Bug 19181: Change to use ENV, fix login and passwords

The kohadevbox has admin/admin set, so for testing when
creating the initial superuser, if you wish to minimize
effort, use admin/admin. Otherwise, make sure to:
export KOHA_USER={whatever your user is}
export KOHA_PASS={whatever your password is}
before attempting to run the test.

Also, this test was failing because of a validation check on
the passwords requiring uppercase letters, lowercase letters,
and numbers. Changed the sample data passwords to fix.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #62438|0   |1
is obsolete||

--- Comment #126 from Srdjan Jankovic  ---
Created attachment 68822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68822=edit
bug_11213: Added XSLTParse4Display() to Items test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #68646|0   |1
is obsolete||

--- Comment #127 from Srdjan Jankovic  ---
Created attachment 68823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68823=edit
bug_11213: Check for $item->{itype} presence to avoid warning

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #62436|0   |1
is obsolete||

--- Comment #124 from Srdjan Jankovic  ---
Created attachment 68820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68820=edit
bug_11213: Include XSLT processing for searchResults() test

* Added template paths to temp test dir, so XSLT templates can be picked
  up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #62437|0   |1
is obsolete||

--- Comment #125 from Srdjan Jankovic  ---
Created attachment 68821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68821=edit
bug_11213: GetItemsInfo() test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #62435|0   |1
is obsolete||

--- Comment #123 from Srdjan Jankovic  ---
Created attachment 68819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68819=edit
bug_11213: whitespace correction

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #62434|0   |1
is obsolete||

--- Comment #122 from Srdjan Jankovic  ---
Created attachment 68818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68818=edit
bug_11213: Changed XSLTParse4Display() interface

The list of biblio items is passed on now, instead of GetItemsInfo() being
called. This is because the callers already have the list ready, so the
GetItemsInfo() call is being duplicated unnecessarily.
Search::searchResults() builds items list from XML, and that one is
passed instead.

* XSLT::XSLTParse4Display()
- supply the items list as input param
- removed hidden items list param - hidden should not be in the items
  list
- changed buildKohaItemsNamespace() accordingly

* Items
- added sort_by input param to GetItemsInfo()

* catalogue/detail.pl, opac/opac-detail.pl, shelfpage()
- added items list to the XSLTParse4Display() call

* Search::searchResults()
- include all available info when building items lists
- added combined items list (available, on loan, other) to the
  XSLTParse4Display() call

To test:
This change is a noop, so following screens need to be checked against
any changes:
* Intranet:
- catalogue/search.pl (results)
- catalogue/detail.pl
- virtualshelves/shelves.pl
* Opac
- opac-search.pl (results, hidelostitems syspref on and off)
- opac-detail.pl
- opac-shelves.pl

The display should stay the same before and after patch. The speed
should increase though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mtomp...@hotmail.com

--- Comment #11 from M. Tompsett  ---
The maintainability of this code is really difficult, because the xpath's used
are cryptic. I would recommend adding less cryptic xpath's (id based) and/or
comments describing what is being clicked or filled in. I'll let QA'rs decide
if it is Failed QA for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974

--- Comment #10 from M. Tompsett  ---
Created attachment 68817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68817=edit
Bug 18974: Change to use ENV variables and fix login bug

The kohadevbox has admin/admin set, so for testing when
creating the initial superuser, if you wish to minimize
effort, use admin/admin. Otherwise, make sure to:
export KOHA_USER={whatever your user is}
export KOHA_PASS={whatever your password is}
before attempting to run the test.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66509|0   |1
is obsolete||

--- Comment #9 from M. Tompsett  ---
Created attachment 68816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68816=edit
Bug 18974 - Selenium test for cataloguing MARC21 records and adding items

This Selenium test performs the cataloging workflow starting on the
intranets home page and then using z39.50 targets to add a MARC record.
After that items are added to the MARC record

Test plan (this test plan includes how to install Selenium as well as how to
run this test, for the benefit of people who have not got
Selenium installed on their machines):

1. wget
https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar

2. vim /etc/apt/sources.list.d/firefox.list

3. Paste into the file:
deb http://packages.linuxmint.com debian import

4. sudo apt-get update

5. sudo apt-get install firefox

6. sudo apt-get install xvfb

7. Set the SELENIUM_PATH vartiable:
SELENIUM_PATH=/home/vagrant/kohaclone/selenium-server-standalone-2.53.0.jar

8. Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null &

9. DISPLAY=:1 java -jar $SELENIUM_PATH

Note: This will start up the selenium server. Everytime you want to
shutdown this terminal window and want to restart Selenium just run the step 9
command to restart the Selenium server

10. Open a new terminal window and write in:
git clone https://github.com/gempesaw/Selenium-Remote-Driver --branch
build/master --single-branch --depth 1

11. cd Selenium-Remote-Driver

12. perl Makefile.PL

13. make

14. make test

15. sudo make install

16. Now everything is installed and you can et up for running the
selenium tests

17. Drop and recreate you Koha database and restart memcached

18. Go through the web installer (installing sample z39.50 targets) and
the onboarding tool

19. Create a superlibrarian user with the username koha and password koha

20. If your usual port configuration for the intranet and OPAC is
8081 and 8080 respectively then set the staffClientBaseURL and OPACBaseURL
system preferences to localhost:8080 and localhost:80 respectively

21. sudo koha-shell 

22. perl t/db_dependent/selenium/cataloging_workflow.t

23. The test should pass.
Note: The time_diff comments in the test output showing what the
test is doing

Note: If you have issues with installing Selenium and
Selenium::Remote::Driver please write a comment on the bug report
and I will be more than happy to create a screencapture video showing all the
steps

Sponsored-By: Catalyst IT

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302

--- Comment #2 from Josef Moravec  ---
Comment on attachment 67124
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67124
Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest

Review of attachment 67124:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19302=67124)
-

::: C4/Circulation.pm
@@ +2665,5 @@
> +next if IsItemOnHoldAndFound( $itemnumber );
> +for my $borrowernumber (@borrowernumbers) {
> +my $patron = $patrons{$borrowernumber} //= 
> Koha::Patrons->find( $borrowernumber );
> +next unless IsAvailableForItemLevelRequest($item, 
> $patron);
> +next unless CanItemBeReserved($b,$itemnumber);

Shouldn't $b be $borrowernumber ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16865] Patron self registration: hiding lbranchcode also hides email

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

Katrin Fischer  changed:

   What|Removed |Added

Summary|marking branchcode unwanted |Patron self registration:
   |breaks self registration|hiding lbranchcode also
   ||hides email

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16865] marking branchcode unwanted breaks self registration

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
The problem is that when hiding the branchcode, which is desirable for singel
branch libraries, the email disappears. And without the email the verification
process breaks. 

Normal is ok, becuase you can have work around it, but would be nice to see
fixed. I see no reason why there should be any link between hiding email and
branch.

Also: altcontactnote can't be hidden... haven't investigated deeper yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19299] Replace C4::Reserves::GetReservesForBranch with Koha::Holds-> waiting

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19299] Replace C4::Reserves::GetReservesForBranch with Koha::Holds-> waiting

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299

Josef Moravec  changed:

   What|Removed |Added

  Attachment #67118|0   |1
is obsolete||

--- Comment #3 from Josef Moravec  ---
Created attachment 68815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68815=edit
Bug 19299: Replace C4::Reserves::GetReservesForBranch with Koha::Holds->waiting

GetReservesForBranch simply returns the waiting holds, for a specific
branch of not. This can easily be replaced with a call to
Koha::Holds->waiting

To avoid any regressions, I reuse the exact conditions (priority = 0),
but I do not think it is useful.

Test plan:
Make sure the holds information are correctly displayed on the waiting
holds screen.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17610] [16.11.x] Allow the number of plack workers and max connections to be set in koha-conf.xml

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610

Josef Moravec  changed:

   What|Removed |Added

  Attachment #64699|0   |1
is obsolete||

--- Comment #22 from Josef Moravec  ---
Created attachment 68814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68814=edit
Bug 17610 - (16.11.x) Allow the number of plack workers and max connections to
be set in koha-conf.xml

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17610] [16.11.x] Allow the number of plack workers and max connections to be set in koha-conf.xml

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into Koha directory perl modules

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into Koha directory perl modules

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212

--- Comment #22 from Josef Moravec  ---
Comment on attachment 66570
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66570
Bug 18212 - Moved all sql queries out aqplan.pl into Koha::Libraries.pm,
Koha::ItemType.pm, Koha::AuthorisedValue.pm files

Review of attachment 66570:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18212=66570)
-

::: C4/Acquisition.pm
@@ +3055,5 @@
> +});
> +return $authvalues;
> +}
> +
> +

You don't need this, you use Koha::AuthorisedValues module directly

::: Koha/AuthorisedValue.pm
@@ +174,5 @@
> + order_by => [qw/ lib /]
> +});
> +return @Getauthorised_values;
> +};
> +

You don't need this, you use Koha::AuthorisedValues module directly

@@ +187,5 @@
> +Koha::AuthorisedValues->new()->search({
> + category => { 'like','%a%'},
> + });
> +return @distinctauthorised_values;
> +};

You don't need this, you use Koha::AuthorisedValues module directly

::: Koha/ItemType.pm
@@ +116,5 @@
> + my $sth   = $dbh->prepare($query);
> + $sth->execute();
> + return $sth;
> +}
> +

You don't need this, just use Koha::ItemTypes->search_with_localization

::: Koha/Libraries.pm
@@ +65,5 @@
> +my $sth   = $dbh->prepare($query);
> +$sth->execute();
> +return $sth;
> +}
> +

Use Koha::Libraries->search for getting all libraries.

::: admin/aqplan.pl
@@ +110,4 @@
>  my $budgets_ref = GetBudgetHierarchy( $budget_period_id, 
> $show_mine?$template->{VARS}->{'USER_INFO'}->{'branchcode'}:'', 
> $show_mine?$template->{VARS}->{'USER_INFO'}->{'borrowernumber'}:'' );
>  
>  # build categories list
> +my @DistinctAuthValues = Koha::AuthorisedValue->GetDistinctCat();

should be something like:

my $acq_categories = Koha::AuthorisedValueCategories->search( { category => {
like => 'A%' } } );

@@ +116,5 @@
>  my @category_list;
>  
>  # a hash, to check that some hardcoded categories exist.
>  my %categories;
> +while ( my ($category) = each @DistinctAuthValues ) {

while ( my $category = $acq_categories->next ) {

@@ +191,4 @@
>  }
>  # 
>  if ( $authcat =~ m/^Asort/ ) {
> +my @AuthValues = Koha::AuthorisedValue->GetAuthValues($authcat);

my $AuthValues = Koha::AuthorisedValues->search ( { category => $authcat } );

@@ +225,4 @@
>  }
>  
>  elsif ( $authcat eq 'ITEMTYPES' ) {
> + my $sth = Koha::ItemType->GetItemTypes($dbh);

Koha::ItemTypes->search_with_localization

@@ +237,4 @@
>  
>  } elsif ( $authcat eq 'BRANCHES' ) {
>  
> +my $sth = Koha::Libraries->GetBranches($dbh);

Koha::Libraries->search

@@ +249,3 @@
>  } elsif ($authcat) {
> +
> +my $sth = Koha::AuthorisedValue->GetAuthValues($authcat,$dbh);

Koha::AuthorisedValues->search ( { category => $authcat } );

::: t/db_dependent/AuthorisedValues.t
@@ +100,5 @@
> +   {
> +order_by => [qw/ lib /]
> +   });
> +};
> +

If you want to test some subroutine, you can't just redefine it in the test.
You need to use it from the place where it is defined... but you do not need
this sub routine at all, so no need to add this test

@@ +111,5 @@
> +   Koha::AuthorisedValues->new()->search({
> +  category => { 'like','%a%'},
> +   });
> +}
> +

If you want to test some subroutine, you can't just redefine it in the test.
You need to use it from the place where it is defined... but you do not need
this sub routine at all, so no need to add this test

::: t/db_dependent/Koha/ItemTypes.t
@@ +126,5 @@
> +my $sth   = $dbh->prepare($query);
> +$sth->execute();
> +return $sth->rows;
> +}
> +

If you want to test some subroutine, you can't just redefine it in the test.
You need to use it from the place where it is defined... but you do not need
this sub routine at all, so no need to add this test

::: t/db_dependent/Koha/Libraries.t
@@ +92,5 @@
> +my $sth   = $dbh->prepare($query);
> +$sth->execute();
> +return $sth->rows;
> +}
> +

If you want to test some subroutine, you can't just redefine it in the test.
You need to use it from the place where it is defined... but you do not need
this sub routine at all, so no need to add this test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17956] Provide additional functionality in the onboarding tool through configuring z-targets , and providing information on setting up SIP and LDAP services

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17956

Josef Moravec  changed:

   What|Removed |Added

  Attachment #65448|0   |1
is obsolete||

--- Comment #18 from Josef Moravec  ---
Created attachment 68813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68813=edit
Bug 17956 - Additional koha service information for end of onboarding tool

This template contains information about LDAP and SIP and how to set
them up with Koha.
In addition to configuring z-targets

Test plan:
1. Drop and recreate your Koha database

2. Restart memcached

3. Go through the web installer and onboarding tool and notice after
creating the circulation rule the next screen provides a 'Start using
Koha' button which when clicked prompts you to enter the administrator
account credentials you used to create an account in the onboarding tool

4. Apply patch

5. Repeat steps 1, 2

6. Go through the web installer and onboarding tool (on the final screen
in the onboarding tool click on the new 'Learn more about Koha' button)

7. The onboardingstep6.tt screen will appear. Click on LDAP
radiobutton and click 'Submit' and further instructions on installing LDAP
will appear.

8. Click 'Back' and the screen in step 5 will be displayed

9. Click the 'SIP' radiobutton and click 'Submit; and further
instructions on setting up SIP will appear

10. Click 'Back'

11. Click both 'LDAP' and 'SIP' and notice that both the LDAP and SIP
information is displayed

12. Click 'Back' and click 'Configure z-targets in Koha' and notice
how the staff interface login page appears.

13. Repeat steps 1,2 and 6

14. Click the 'Start using Koha' button

15. Login prompt will appear. Enter the administrator account credentials you
used to create an
account in the onboarding tool

Sponsored-By: Catalyst IT

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17956] Provide additional functionality in the onboarding tool through configuring z-targets , and providing information on setting up SIP and LDAP services

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17956

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Josef Moravec  changed:

   What|Removed |Added

  Attachment #68605|0   |1
is obsolete||

--- Comment #7 from Josef Moravec  ---
Created attachment 68812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68812=edit
Bug 19191 - Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Run updatedatabase.pl
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Josef Moravec  changed:

   What|Removed |Added

 Blocks||19545


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19545
[Bug 19545] Make possible to turn off (and on) sending payment receipts by
email
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19545] Make possible to turn off (and on) sending payment receipts by email

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19545

Josef Moravec  changed:

   What|Removed |Added

 Depends on||19191


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191
[Bug 19191] Add ability to email receipts for account payments and write-offs
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19545] New: Make possible to turn off (and on) sending payment receipts by email

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19545

Bug ID: 19545
   Summary: Make possible to turn off (and on) sending payment
receipts by email
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: josef.mora...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

As proposed here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191#c4

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||josef.mora...@gmail.com

--- Comment #11 from Josef Moravec  ---
Kyle, it's nice feature, and I really would like to have it in Koha.

But qa tools are complaining about this:

 FAIL   Koha/Patrons.pm
   FAIL   valid
Useless use of anonymous hash ({}) in void context 

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt
   FAIL   forbidden patterns
forbidden pattern: tab char (line 30)
forbidden pattern: tab char (line 33)
forbidden pattern: tab char (line 50)
forbidden pattern: tab char (line 39)
forbidden pattern: tab char (line 42)
forbidden pattern: tab char (line 49)
forbidden pattern: tab char (line 36)
forbidden pattern: tab char (line 123)
forbidden pattern: tab char (line 46)
forbidden pattern: tab char (line 51)
forbidden pattern: tab char (line 32)
forbidden pattern: tab char (line 41)
forbidden pattern: tab char (line 40)
forbidden pattern: tab char (line 55)
forbidden pattern: tab char (line 34)
forbidden pattern: tab char (line 122)
forbidden pattern: tab char (line 53)
forbidden pattern: tab char (line 127)
forbidden pattern: tab char (line 38)
forbidden pattern: tab char (line 37)
forbidden pattern: tab char (line 35)
forbidden pattern: tab char (line 126)
forbidden pattern: tab char (line 48)
forbidden pattern: tab char (line 43)
forbidden pattern: tab char (line 29)
forbidden pattern: tab char (line 52)
forbidden pattern: tab char (line 125)
forbidden pattern: tab char (line 124)
forbidden pattern: tab char (line 31)
forbidden pattern: tab char (line 47)
forbidden pattern: tab char (line 54)
forbidden pattern: tab char (line 45)
forbidden pattern: tab char (line 44)
forbidden pattern: tab char (line 121)
forbidden pattern: tab char (line 120)

 FAIL   members/merge-patrons.pl
   FAIL   valid
Useless use of anonymous hash ({}) in void context 

 FAIL   t/db_dependent/Patrons.t
   FAIL   forbidden patterns
forbidden pattern: tab char (line 149)
forbidden pattern: tab char (line 148)
   FAIL   valid
Useless use of anonymous hash ({}) in void context

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #4 from Josef Moravec  ---
Created attachment 68811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68811=edit
Bug 19289: Use the ACQ framework to display bibliographic details

The ACQ MARC framework is only used for the ‘Item’ block.
This patch add the ability to define biblio fields (!= 995 or 952) to
customize the display of the bibliographic details when ordering.

This new feature is controlled by a new pref:
UseACQFrameworkForBiblioRecords

Test plan:
- Create a new installation to populate the ACQ framework correctly
- Set the pref UseACQFrameworkForBiblioRecords to "Use"
- Create a new order
=> You will see the lib from the ACQ framework
- Add/remove/update biblio subfields in the ACQ framework
- Create a new order
=> You should see the new subfields displayed

Note for QA: I though I would be able to refactor existing code to make
it more flexible, but it is a bit messy and lost a lot of time. I
finally decided to copy/paste the existing code. I simplified it as, I
think, we do not want the plugin, etc. like in the full biblio editor.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Josef Moravec  changed:

   What|Removed |Added

  Attachment #68640|0   |1
is obsolete||
  Attachment #68641|0   |1
is obsolete||

--- Comment #3 from Josef Moravec  ---
Created attachment 68810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68810=edit
Bug 19289: Add existing fields to the ACQ framework

When ordering, the bibliographic details contain the title, author,
publisher code, publication year, isbn and series info.
To avoid regression to provide the same behaviour, we will add these
fields to the ACQ framework

NOTE: This patch makes the change only for
  - en
  - fr / unimarc complet

Other frameworks will be updated before to be pushed, to avoid
unecessary rebases

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||josef.mora...@gmail.com

--- Comment #121 from Josef Moravec  ---
Needs adaptation at least because of bug 17248

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19537] Authorities search doesn' t correctly populate subfield $2 source of heading

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537

Josef Moravec  changed:

   What|Removed |Added

  Attachment #68677|0   |1
is obsolete||

--- Comment #2 from Josef Moravec  ---
Created attachment 68809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68809=edit
Bug 19537: Correct addition of source subfield from authorities

To test:
1 - Find or create a subject authority
2 - Define 008/11 as 's' or 'r'
3 - Add 2nd indicator '7' to main heading
4 - Open or create a bibliographic record
5 - Link to the authority created above
6 - Subfield $2 is not set
7 - Apply patch
8 - Repeat linking, subfield $2 should be set

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19537] Authorities search doesn' t correctly populate subfield $2 source of heading

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19423] DecreaseLoanHighHolds.t is failing randomly

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19193] When displaying the fines of the guarantee on the guarantor account, price is not in correct format.

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19193

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17664] Silence non-zebra warnings in t/db_dependent/Search.t

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17664

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #12 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19345] SendMail error does not display error message in password recovery

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19345

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19398] Wrong date format in quick patron search table

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19398

--- Comment #6 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19386] t/db_dependent/SIP/Patron.t is failing randomly

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19386

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19405] t/db_dependent/api/v1/holds.t fails randomly

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19405

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |FIXED

--- Comment #4 from Katrin Fischer  ---
Tests fail when this is applied to 16.11.x, skipping.

Test Summary Report
---
t/db_dependent/api/v1/holds.t (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 4 tests but ran 0.
Files=1, Tests=0,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.25 cusr  0.35
csys =  1.62 CPU)
Result: FAIL
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove -v
t/db_dependent/api/v1/holds.t 
t/db_dependent/api/v1/holds.t .. 
1..4
Can't locate object method "build_object" via package "t::lib::TestBuilder" at
t/db_dependent/api/v1/holds.t line 67.
# Looks like your test exited with 255 before it could output anything.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 4/4 subtests 

Test Summary Report
---
t/db_dependent/api/v1/holds.t (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 4 tests but ran 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19403] Again and again, Circulation.t is failing randomly

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Depends on a bug that is not in 16.11.x (didn't apply). Please fix dependencies
if you want this to be included.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16726] Text in Preferences search box does not clear

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726

--- Comment #28 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19392] auth_values_input_www.t does not clean up

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19392

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18422] Add Select2 to authority editor

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18422

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19307] t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #8 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19344] DB fields login_attempts and lang may be inverted

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19344

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
Both dependent bugs are not part of 16.11.x, so this should not be needed
there. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19317] Move of checkouts - Remove leftover

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
The removed lines don't appear to exist in 16.11.x. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer  ---
Patches don't apply cleanly on 16.11.x, please rebase if you want this to be
included.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16463] OPAC discharge page should warn the user about checkouts before they request

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463

--- Comment #9 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19195] Noisy warns when creating or editing a basket

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19195

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999

--- Comment #23 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.14.

Thx, Alex!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19425] Adding orders from order file with multiple budgets per record triggers error

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19425

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #13 from Katrin Fischer  ---
This doesn't apply cleanly on 16.11.x and I am not sure if it's needed. Please
verify and rebase if you want this to be included.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19135] AllowHoldsOnPatronsPossessions is not working

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135

--- Comment #16 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19415] FindDuplicateAuthority is searching on biblioserver since 16.05

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19415

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19374] CircSidebar overlapping transferred items table

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |FIXED

--- Comment #10 from Katrin Fischer  ---
Depend on bug 16530 which is not part of 16.11.x, skipping.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19329] IntranetSlipPrinterJS label is obsoleted

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Katrin Fischer  ---
Depends on bug 17014 which is not in 16.11.x, skipping.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #10 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19296] Tax is being subtracted from orders when vendor price does not include gst and ordering from a file

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19296

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #30 from Katrin Fischer  ---
Missing too many Elasticsearch patches in 16.11.x by now - skipping.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19296] Tax is being subtracted from orders when vendor price does not include gst and ordering from a file

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19296

--- Comment #11 from Katrin Fischer  ---
Dependent bug is not in 16.11.x, skipping.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19180] Vendor name is missing from breadcrumbs when closing an order

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180

--- Comment #17 from Katrin Fischer  ---
Doesn't apply cleanly to 16.11.x (second patch conflicts), please rebase if you
want this to be included.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16204] Show friendly error message when trying to edit record which no longer exists

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16204

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15644] City dropdown default selection when modifying a patron matches only on city

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15644

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #8 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

Note: French format doesn't exist in 16.11.x and has been removed from the
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18742] Circulation statistics wizard no longer exports the total row

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19337] Allow basic_workflow.t be configured by ENV

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19337

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

--- Comment #18 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068

--- Comment #15 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12346] False patron modification alerts on members-home.pl

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #14 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #37 from Katrin Fischer  ---
Doesn't apply cleanly on 16.11.x, please rebase if you want this to be
included.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18801] Merging authorities has an invalid 'Default' type in the merge framework selector

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18801

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #28 from Katrin Fischer  ---
I am not sure about this comment:

NOTE: The proposed solution restores consistency, but will remove hidden
fields from the MARC record.

Nick or Marcel, can you please explain and advise if this should go into
16.11.x?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19262] pod_spell.t does not work

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19544] New: Add manual contributors to the release notes

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19544

Bug ID: 19544
   Summary: Add manual contributors to the release notes
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Release tools
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
CC: ch...@bigballofwax.co.nz

It would be neat if we could add manual contributors to the release notes
automatically.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19117] paycollect.pl is vulnerable for CSRF attacks

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19117

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #10 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18956] Possible privacy breach with OPAC password recovery

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18956

--- Comment #26 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19333] XSS vulnerability in opac-shelves

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19333

--- Comment #9 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776

--- Comment #23 from Katrin Fischer  ---
I had a really small conflict, but don't understand the code well enough to
risk it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776

--- Comment #22 from Barry Cannon  ---
I didn't have any problems applying to 16.11.13. However, I tested again and on
16.11.10 it works fine but as soon as I upgrade to 16.11.13 and re-apply the
patch the shib error returns.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19543] Koha does not reserve an item if there is one available in another library.

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19543

Cristian  changed:

   What|Removed |Added

  Attachment #68792|Erro na reserva quando há   |Error in reservation when
description|itens disponíveis em outra  |there are items available
   |biblioteca  |in another library

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19543] Koha does not reserve an item if there is one available in another library.

2017-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19543

Cristian  changed:

   What|Removed |Added

Summary|Sistema não faz reserva de  |Koha does not reserve an
   |item caso tenha algum   |item if there is one
   |disponível em outra |available in another
   |biblioteca. |library.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 106 matches

Mail list logo