[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Ere Maijala changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Ere Maijala --- I think this needs to display some sort of progress message. Otherwise it looks like it just hangs with high CPU usage. And please fix "elastic search" to "Elasticsearch" in the comment while at it. :) It would also be useful to check from which array a record is missing and tell it to the user. Since we already have the information in the arrays, let's help the user out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #4 from Michal Denar --- Hi Nick, I troed to test it with Kohadevbox, but get this error on step 3: Can't locate Koha/Items.pm in @INC (you may need to install the Koha::Items module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at compare_es_to_db.pl line 33. BEGIN failed--compilation aborted at compare_es_to_db.pl line 33. I'm really not sure about this issue. It can be based at Kohadevbox instalation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #146 from Julian Maurice --- (In reply to Caroline Cyr La Rose from comment #145) > Woohoo! I did my first contextualization (locally)! > > I was wondering what is the process to add a contextualization to the > community file? Do I just submit the .tt file in a bug? It probably wouldn't > be relevant to all languages... Glad to hear it! :) You should create a new bug report and submit your changes in the form of a .patch file. See https://wiki.koha-community.org/wiki/Submitting_A_Patch for more informations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #6 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #5) > (In reply to Jonathan Druart from comment #4) > > vagrant@kohadevbox:misc4dev(master)$ sudo koha-z3950-responder --enable > > kohadev > > cp: cannot stat '/etc/koha/z3950/*': No such file or directory > > > > > > Where/How is this directory created? > > I think it is missing in cp_debian_files.pl or smth What about the debian package? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #42 from Jonathan Druart --- Created attachment 95079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95079&action=edit Bug 23075: (follow-up) Dissallow transparent redirects GET request redirects were causing the http URL to 'pass' our 'good url' test for http => https redirected mana servers. However, on the subsquent POST request to get a mana security token we would fail as the POST was not transparently redirected. This patch changes the request to be a simple_request so we will catch bad urls earlier and it also prevents submissions for security tokens if the configured URL is identified as bad. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #44 from Jonathan Druart --- Created attachment 95081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95081&action=edit Bug 23075: Correct indendation Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart changed: What|Removed |Added Attachment #95074|0 |1 is obsolete|| Attachment #95075|0 |1 is obsolete|| Attachment #95076|0 |1 is obsolete|| --- Comment #41 from Jonathan Druart --- Created attachment 95078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95078&action=edit Bug 23075: Report if mana-kb server is not found This patch adds a status check into the mana configuration page and prompts the user to ask an adminstrator to check the configured mana service url. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #43 from Jonathan Druart --- Created attachment 95080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95080&action=edit Bug 23075: Do not 'Send' if the url is not correct Just in case. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #15 from Martin Renvoize --- Created attachment 95082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95082&action=edit Bug 23523: (RM follow-up) Failing tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #5 from Ere Maijala --- That's a weird one. The script worked for me in my dev environment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #16 from Martin Renvoize --- My followup gets the tests passing but I'm pretty confident it's not right :(. The deeper down this rabbit hole I dive the less confidence in this original patchset I have I'm afraid. So, digging deeply it seems that unitprice is pretty much always passed into populate_order_with_prices (regardless of whether you have entered such a price into the UI at order time). If you have not entered a such a price then it will fallback to using 'ecost' which is calculated clientside by JS and added to a readonly form field. As such, the t/Prices.t (which before my patch always submitted ecost = unitprice), should continue to pass but it does not.. this to my highlights an issue somewhere, but I'm stuck regarding finding it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Jonathan Druart changed: What|Removed |Added Attachment #95069|0 |1 is obsolete|| Attachment #95070|0 |1 is obsolete|| Attachment #95071|0 |1 is obsolete|| Attachment #95072|0 |1 is obsolete|| Attachment #95073|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 95083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95083&action=edit Bug 23414: Use Koha Item objects in buildKohaItemsNamespace Removing the use of C4::GetItemsInfo cuts down on the number of DB requests and speeds things up To test I added 100 items to each of the first 20 records returned by a search for 'a' I saw a reduction from ~30 seconds to ~26 seconds This also makes the code a little cleaner and moves us toward the Koha namespace To test: 1 - Perform a search in the OPAC and STaff Client with the Browser Console opened (F12) 2 - View the netwrok tab and see how long the pages take to load 3 - Apply the patches, restart all the things 4 - Repeat and note if the results are returned faster Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #24 from Jonathan Druart --- Created attachment 95084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95084&action=edit Bug 23414: Prefetch transfers, use only default framework, use elsif This further cleans up the code, before we tested each condition though we return only one status line. Koha mappings can no longer differ by framework so we don't need to fetch the biblio framework Prefetching should offer a boost To test: Same as before - there is not as big a boost form this, but there shouldn't be a hit Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #25 from Jonathan Druart --- Created attachment 95085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95085&action=edit Bug 23414: Easy readability and simplify logic in buildKohaItemsNamespace This patch improves true/false logic and avoid autovivication. Also note that xml_escape already deals with empty string. An unecessary call to GetReserveStatus is removed. Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #27 from Jonathan Druart --- Created attachment 95087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95087&action=edit Bug 23414: Unit tests To test: 1 - Apply this patch alone 2 - prove -v t/db_dependent/XSLT.t 3 - All pass 4 - Apply other patches 5 - prove -v t/db_dependent/XSLT.t 6 - All pass Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #26 from Jonathan Druart --- Created attachment 95086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95086&action=edit Bug 23414: Use effective_itemtype We should use effective_itemtype instead of itype to take the item-level_itypes pref into account. Note that we should not need to test for the existence of the key as we now assume that item types are correctly set to a valid item type. Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #28 from Jonathan Druart --- Created attachment 95088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95088&action=edit Bug 23414: Add tests for previous effective_itemtype change Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #29 from Jonathan Druart --- Created attachment 95089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95089&action=edit Bug 23414: Replace delimiter of regexs to ease readability Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831
--- Comment #6 from Ere Maijala ---
Nick, one more thing: you can make the ES cursor a zillion times faster by not
retrieving any of the stored fields:
my $scroll = $es->scroll_helper(
index => $searcher->get_elasticsearch_params->{index_name},
size => 5000,
body => {
query => {
match_all => {}
},
stored_fields => []
},
scroll_in_qs => 1,
);
I'd also run the id comparison regardless of whether record counts match since
there's could be a case where they do but the records still differ.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #30 from Jonathan Druart --- Sorry, scope creep... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 Jonathan Druart changed: What|Removed |Added Attachment #94680|0 |1 is obsolete|| Attachment #95001|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 95090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95090&action=edit Bug 23719: Allow searching specific fields for matching authorities in ES To test: 1 - Export your authorities via Tools->Export data 2 - Define a record matching rule in Admin->Record matchign rules Use index: LC-card-number field: 010$a 3 - Stage the exported records for import and use the rule created above for matching 4 - The process does not complete 5 - Check intranet error logs - exception on unknown marclist 6 - Apply patch 7 - Repeat 8 - Success! 9 - prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 --- Comment #12 from Jonathan Druart --- Created attachment 95091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95091&action=edit Bug 23719: (follow-up) Add warn when passed invalid search field in marclist Note: I also remove warnings for undefined operation in this patch, is a trivial fix To test: prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 --- Comment #9 from Jonathan Druart --- Created attachment 95092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95092&action=edit Bug 5365: Make more clear how to reopen a basket in a basket group The "reopen basket" button will be visible but disabled if the basket cannot be reopened. A tooltip is attached to the button to add more information. Note that the export button is still hidden, would it makes sense to display it (visible and active)? Test plan: - Create a basket - Close it - Go to the basket detail view => The reopen button should be displayed and enabled - Attach it to a basket group - Go to the basket detail view => The reopen button should be displayed but disabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org --- Comment #10 from Jonathan Druart --- This patch only addresses what is described in the title of this bug report => Display the button, but disabled, if the basket cannot be reopened. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23467] BlockExpiredPatronOpacActions is causing screen to duplicate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23467] BlockExpiredPatronOpacActions is causing screen to duplicate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Jonathan Druart changed: What|Removed |Added Keywords||rel_19_11_candidate Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23467] BlockExpiredPatronOpacActions is causing screen to duplicate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 --- Comment #4 from Jonathan Druart --- Created attachment 95093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95093&action=edit Bug 23467: Exit after output_html - opac-reserve.pl To avoid double screen There are several ways to recreate the issue, the easiest is: /cgi-bin/koha/opac-reserve.pl?biblionumber= You should see "ERROR: No record id specified." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Jonathan Druart changed: What|Removed |Added Summary|BlockExpiredPatronOpacActio |Duplicated screen if error |ns is causing screen to |in opac-reserve.pl |duplicate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Jonathan Druart changed: What|Removed |Added Depends on||22542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22542 [Bug 22542] Back browser should not allow to see other patrons details (see bug 5371) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22542] Back browser should not allow to see other patrons details (see bug 5371)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22542 Jonathan Druart changed: What|Removed |Added Blocks||23467 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 [Bug 23467] Duplicated screen if error in opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23961] Menu "add subcription fields" has disappeared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||22851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 [Bug 22851] Navigation links in the serials module should be styled the same as other modules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22851] Navigation links in the serials module should be styled the same as other modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 Jonathan Druart changed: What|Removed |Added Blocks||23961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 [Bug 23961] Menu "add subcription fields" has disappeared -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23961] Menu "add subcription fields" has disappeared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 --- Comment #1 from Jonathan Druart --- Created attachment 95094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95094&action=edit Bug 23961: (bug 22851 follow-up) Restore Add subscription fields link This fix a wrong rebase conflict resolution from commit 414869eb9d7b29754b75bd0c798d6a566df88a7e Bug 22851: Style navigation links in serials modules like same links in other modules It only affects 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23961] Menu "add subcription fields" has disappeared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22851] Navigation links in the serials module should be styled the same as other modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #9 from Jonathan Druart --- (In reply to Lucas Gass from comment #8) > backported to 18.11.x for 18.11.08 Something went wrong during the backport, see bug 23961. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23961] Menu "add subcription fields" has disappeared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 --- Comment #2 from Jonathan Druart --- Also, the Mana link is removed. It does not exist yet in 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #10 from Katrin Fischer --- Hi all, as there are some concerns about the datatables plugin used, could it be an option to see how it was solved for the subscription (separate tabs for active and closed subscriptions) and if this could be a way to avoid the plugin? If it turns out that we can't do without the plugin for now, we could still maybe add it with a FIXME. Would that be agreeable? Then this leaves updating the number displayed on the bug (comment#8). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23961] [18.11] Menu "add subcription fields" has disappeared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Katrin Fischer changed: What|Removed |Added Summary|Menu "add subcription |[18.11] Menu "add |fields" has disappeared |subcription fields" has ||disappeared CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23961] [18.11] Menu "add subcription fields" has disappeared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23961] [18.11] Menu "add subcription fields" has disappeared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Katrin Fischer changed: What|Removed |Added Attachment #95094|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 95095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95095&action=edit Bug 23961: (bug 22851 follow-up) Restore Add subscription fields link This fix a wrong rebase conflict resolution from commit 414869eb9d7b29754b75bd0c798d6a566df88a7e Bug 22851: Style navigation links in serials modules like same links in other modules It only affects 18.11.x Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23961] [18.11] Menu "add subcription fields" has disappeared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Katrin Fischer changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer --- Lucas, this is 18.11 only - please push! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #11 from Martin Renvoize --- I don't mind whether we use tabs or a single table and filter.. there's precedence for both. I really don't like the idea of introducing a new dependency that is already officially deprecated, so if there's any way to work around that then I'd be onboard with it. Hope that helps guide this.. it's a nice feature and would be good to get moving again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #17 from Jonathan Druart --- 1. If empty, should not we not update the password? I get a "too_weak" error. 2. You forgot to adjust the CLI script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 Nick Clemens changed: What|Removed |Added Attachment #89228|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 95096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95096&action=edit Bug 22828: Elasticsearch - display errors encountered during indexing on the command line To test: 1 - Use the Koha sample data, or insert a blank 245$b into a record (easiest way is using advanced cataloging editor 2 - Reindex elasticsearch 3 - Check the ES count on the about page 4 - Check the count in the DB (SELECT count(*) FROM biblio) 5 - They don't match! 6 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v 7 - No errors indicated 8 - Apply patch 9 - perl misc/search_tools/rebuild_elasticsearch.pl -v 10 - You should be notified of an error 11 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v 12 - You should be notified of the specific biblio with an error and a (somewhat) readable reason 13 - perl misc/search_tools/rebuild_elasticsearch.pl 14 - No output -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Katrin Fischer changed: What|Removed |Added Attachment #95093|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 95097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95097&action=edit Bug 23467: Exit after output_html - opac-reserve.pl To avoid double screen There are several ways to recreate the issue, the easiest is: /cgi-bin/koha/opac-reserve.pl?biblionumber= You should see "ERROR: No record id specified." Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 Ere Maijala changed: What|Removed |Added Attachment #95096|0 |1 is obsolete|| --- Comment #7 from Ere Maijala --- Created attachment 95098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95098&action=edit Bug 22828: Elasticsearch - display errors encountered during indexing on the command line To test: 1 - Use the Koha sample data, or insert a blank 245$b into a record (easiest way is using advanced cataloging editor 2 - Reindex elasticsearch 3 - Check the ES count on the about page 4 - Check the count in the DB (SELECT count(*) FROM biblio) 5 - They don't match! 6 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 7 - No errors indicated 8 - Apply patch 9 - perl misc/search_tools/rebuild_elastic_search.pl -v 10 - You should be notified of an error 11 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 12 - You should be notified of the specific biblio with an error and a (somewhat) readable reason 13 - perl misc/search_tools/rebuild_elastic_search.pl 14 - No output Signed-off-by: Ere Maijala -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Katrin Fischer changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #6 from Katrin Fischer --- Nudging it further. I tested both, the way Jonathan suggested with the missing parameter and the original problem case with the holds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #18 from Jonathan Druart --- Created attachment 95100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95100&action=edit Bug 21249: Made the SQL INSERT statement idempotent Sponsored-BY: Brimbank Library, Australia Signed-off-by: Amandine Zocca Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #19 from Jonathan Druart --- Created attachment 95101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95101&action=edit Bug 21249: Code cleaning Trying to make the code a bit more readable removing unecessary variables and parenthesis. Code is duplicated but no idea where we could move it to. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart changed: What|Removed |Added Attachment #93345|0 |1 is obsolete|| Attachment #93346|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart --- Created attachment 95099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95099&action=edit Bug 21249: New syspref controlling branch fields queried against selected library group value in advanced search This commit allows librarians to choose whether they want to query the homebranch, holdingbranch or homebranch AND holdingbranch when they set a library group search condition in the staff client and OPAC advanced searches. Test plan: 1. Apply patch and run ./updatedatabase.pl in the koha shell 2. Restart memcached and plack 3. In the staff client go to Administration->Global system preferences and search for the systempreference: AdvancedSearchBranchFieldToUse and notice by default it is set to 'homebranch and holdingbranch' 4. Create a library group. Create a subgroup from the library group and add several library branches to the sub group. 5. Note down the barcode of an item to use for testing searching. Make sure the items homebranch and holdingbranch are different and the items homebranch is a child of the sub group created in step 4 6. Perform an Advanced search in the staff client and write in the item barcode as the keyword and select the sub group in the 'Location and availability' section. 7. Submit the search query and notice the item with a homebranch existing in the selected sub group is returned. This proves that when the AdvancedSearchBranchFieldToUse syspref is set to 'homebranch and holdingbranch' the homebranch value is checked. Also note at the top of the search result page the search query is listed: Results of search with limit(s): '(homebranch: or holdingbranch: or homebranch: or holdingbranch: )' 8. Now edit the item making sure the homebranch branch is not in the sub group, and making sure the holdingbranch is in the sub group. This is to test that holdingbranch is indeed being checked when the AdvancedSearchBranchFieldToUse is set to 'homebranch and holdingbranch' 9. Repeat step 6 and notice the item with a holdingbranch existing in the selected library group is returned. 10. Change the value of the AdvancedSearchBranchFieldToUse syspref to 'holdingbranch' and repeat step 6 and again notice the item with a holdingbranch existing in the selected library group is returned. Also note the search query at the top of the page is: "Results of search with limit(s): '(holdingbranch: or holdingbranch: )'" this shows holdingbranch not homebranch is a condition in the query 11. Change the value of the AdvancedSearchBranchFieldToUse syspref to 'homebranch' 12. Change the item homebranch back to a branch that is in the sub group and change the holdingbranch value to a library branch that is not in the sub group. 13. Repeat step 6 and notice the item with the homebranch in the selected library group is returned, so we know the homebranch is being checked. Also note the search query at the top of the page is: " Results of search with limit(s): '(homebranch: or homebranch: )'" this shows homebranch not holdingbranch is a condition in the query. Sponsored-By: Brimbank Library Signed-off-by: Amandine Zocca Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Passed QA |Failed QA --- Comment #20 from Jonathan Druart --- (In reply to Katrin Fischer from comment #16) > Hi Alex, > > some small stuff: > > 1) The pref name and pref description use 'branch' according to our > terminology guidelines 'library' should be used. This would also be > consistent with other prefs using 'home library' and 'holding library' (see > OPAC results library, OpacLocationOnDetail, ...) > > 2) The pref description always talks about the advanced search, but I think > this applies to the branch selection on the simple search > (OpacAddMastheadLibraryPulldown) too or should apply to it to have > consistent behaviour - can you clarify? > > 3) You are missing the change to sysprefs.sql. Sorry, I missed that comment! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23976] New: limit ill by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23976 Bug ID: 23976 Summary: limit ill by patron category Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: ha...@orex.es Koha administer could limit article request by patron category at circulation rules, but ill that it could cost more money is open to all type of patron it should be desirable if ill requests could be also limited by patroncategory like article request.. the limitation could be placed at syspref or also at circulation rules... perhaps better at syspref as itemtype could noe match with ill destination -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23976] limit ill by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23976 Hugo Agud changed: What|Removed |Added Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 Katrin Fischer changed: What|Removed |Added Assignee|katrin.fisc...@bsz-bw.de|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23752] Search all z39.50 / SRU targets and resource discovery layer / open link resolver from any ILL backend
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23752 Hugo Agud changed: What|Removed |Added CC||ha...@orex.es Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23752] Search all z39.50 / SRU targets and resource discovery layer / open link resolver from any ILL backend
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23752 --- Comment #1 from Hugo Agud --- It should be desirable if administrator could select what z39.50 assign to ill backends. not all z39. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 --- Comment #5 from Tomáš Wünsch --- Not sure how to help. You can login into our 19.05: https://demo.koha.cz/ user demo passwd demo -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 Marcel de Rooy changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #18 from Nick Clemens --- Created attachment 95103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95103&action=edit Bug 23523: (follow-up) Clarify meaning configurations in tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Nick Clemens changed: What|Removed |Added Attachment #95082|0 |1 is obsolete|| --- Comment #17 from Nick Clemens --- Created attachment 95102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95102&action=edit Bug 23523: (follow-up) Adjust tests for new expectations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809
--- Comment #18 from Marcel de Rooy ---
(In reply to Julian Maurice from comment #17)
> I don't know if it's perlish or not. To me it just feels natural to always
> get a value (even if that value is undef) when I call find. And when you
> think about it, that's what we get actually by being forced to put scalar in
> front of `find` calls.
https://metacpan.org/pod/Perl::Critic::Policy::Subroutines::ProhibitExplicitReturnUndef
Inspired by Damian's best practices.
Note that my $object; ... return $object; is almost the same.
But this is not an argument to not allow an exception from the rule ;)
The only thing we should not do is:
@array = Koha::Objects->find($x);
if( @array ) {
etc.
Because that condition would always be true. Similarly, foreach( ..->find )
would not work.
if( Koha::Objects->find($x) ) would be just fine however and probably what we
need most.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809
--- Comment #19 from Marcel de Rooy ---
(In reply to Julian Maurice from comment #17)
> It would be great to have Jonathan's opinion as he wrote the patch for bug
> 18539
Looking back, I think that the biggest problem was using ->find in parameter
hashes like { var1 => KO->find, var2 => etc }. Here we have list context and if
there was no result, we were returning an empty list causing a parameter/value
shift.
This comes from:
return unless $result;
Since your patch does not return empty list, we would not suffer from that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Martin Renvoize changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #19 from Martin Renvoize --- Thanks Nick, this looks good now.. followups pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #4 from Katrin Fischer --- Created attachment 95104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95104&action=edit PDF highlighting the problematic behaviour -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23977] New: tag 110 not published at isbd tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23977 Bug ID: 23977 Summary: tag 110 not published at isbd tab Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: ha...@orex.es QA Contact: testo...@bugs.koha-community.org Tag 110$ doesn't display at ISBD view at opac and staff, even exists and it is defined at syspref and at marc framework -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23886] autocreate thumbnail for pdfs or images hosted at koha repository
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23886 Hugo Agud changed: What|Removed |Added Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23882] Use xslt or notice for sending results by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23882 Hugo Agud changed: What|Removed |Added Change sponsored?|Sponsored |Seeking developer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23832] 001 control number auto complet or copy from 999c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23832 Hugo Agud changed: What|Removed |Added Change sponsored?|Sponsored |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23831] Allow public reports to add parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23831 Hugo Agud changed: What|Removed |Added Change sponsored?|Sponsored |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23977] tag 110 not published at isbd tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23977 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Have you checked the visibility settings in the framework? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23977] tag 110 not published at isbd tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23977 --- Comment #2 from Hugo Agud --- yes, I have checked it a Nombre de entidad corporativa o nombre de jurisdicción como elemento de entrada Tab:1, Not repeatable, Not mandatory, | Authority:CORPO_NAME, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23977] tag 110 not published at isbd tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23977 --- Comment #3 from Katrin Fischer --- I meant the checkboxes on the advanced settings for the subfields you want to see. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 Jonathan Druart changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #5 from Jonathan Druart --- So, I tried to install MySQL 5.5 on a debian 9 (old stable, stretch) and realized that it was not possible. Then I found this: https://mariadb.com/kb/en/library/moving-from-mysql-to-mariadb-in-debian-9/ Which basically says that it's expected and that Debian does no longer provide a MySQL package. So I feel like we are good here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added Severity|major |blocker --- Comment #5 from Katrin Fischer --- Updating to blocker, as this ends in data loss (original item values can't be restored) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 --- Comment #6 from Katrin Fischer --- (In reply to Tomáš Wünsch from comment #5) > Not sure how to help. You can login into our 19.05: > https://demo.koha.cz/ > user demo > passwd demo Hi Tomas, the Advanced Editor appears to be turned off on that one and I don't have access to the system preferences with that login. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 Katrin Fischer changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens changed: What|Removed |Added Attachment #95077|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 95105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95105&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elasticsearch.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Katrin Fischer changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #20 from Jonathan Druart --- From 18539: """ Reading https://perlmaven.com/how-to-return-undef-from-a-function this sound like the more correct behaviour. """ That is why I picked this solution. I am not against another one, but what would be the gain? Behave as DBIx::Class::ResultSet::find? Ok I am good with that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Katrin Fischer changed: What|Removed |Added Attachment #95092|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 95106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95106&action=edit Bug 5365: Make more clear how to reopen a basket in a basket group The "reopen basket" button will be visible but disabled if the basket cannot be reopened. A tooltip is attached to the button to add more information. Note that the export button is still hidden, would it makes sense to display it (visible and active)? Test plan: - Create a basket - Close it - Go to the basket detail view => The reopen button should be displayed and enabled - Attach it to a basket group - Go to the basket detail view => The reopen button should be displayed but disabled Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 --- Comment #12 from Katrin Fischer --- This one is in the top 10 of repeated support questions for us, so happy to see this change. We could refine the wording of the tooltip a little bit maybe, but it's ok to go in as is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #8 from Ere Maijala --- Nick, did you consider my suggestion about more informative result display: It would also be useful to check from which array a record is missing and tell it to the user. Since we already have the information in the arrays, let's help the user out. Also, maybe a running counter when fetching the records? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 --- Comment #7 from Katrin Fischer --- (In reply to Katrin Fischer from comment #6) > (In reply to Tomáš Wünsch from comment #5) > > Not sure how to help. You can login into our 19.05: > > https://demo.koha.cz/ > > user demo > > passwd demo > > Hi Tomas, the Advanced Editor appears to be turned off on that one and I > don't have access to the system preferences with that login. I've tested in the Catalyst demo that uses https, but the Advanced editor loads: https://demo-intra.mykoha.co.nz/cgi-bin/koha/cataloguing/editor.pl#new/ (https://koha-community.org/demo/) Tested in Firefox on Ubuntu. Did I miss something form the test plan? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] New: notes field in saved reports should allow HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Bug ID: 23978 Summary: notes field in saved reports should allow HTML Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: th...@lib.auth.gr QA Contact: testo...@bugs.koha-community.org In recent Koha 18.11, parsing of HTML tags was removed from many fields for security reasons. However, as also seen in 22938, 22702, 22501, 23194, 23683 there are places where HTML (or at leas line breaks!) are required, or the output is too messy. The 'notes' field in the "Guided reports wizard › Saved reports" displays the data that is previously entered in a textarea. However, the guided_reports_start.tt does not parse the HTML (nor line breaks), so the output in the resulting table is all in one line! As with the other patches, I propose that we allow HTML in report notes, so one can use strong/italics/colors/urls in notes, and most importantly, line breaks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
