[Koha-bugs] [Bug 29313] How can do the setup of HP printer using 123.hp.setup?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29313 butlerkaci changed: What|Removed |Added URL||https://www.howdoisetup.com ||/hp-printer-setup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29313] New: How can do the setup of HP printer using 123.hp.setup?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29313 Bug ID: 29313 Summary: How can do the setup of HP printer using 123.hp.setup? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: butlerkac...@gmail.com QA Contact: testo...@bugs.koha-community.org 123.hp.setup - Ways to Connect HP Printer to Router (Wireless Setup) • Firstly, turn on your wireless printer and use the touch screen display to set up the HP printer in a wireless manner. • Now from the touch screen, press the ‘setup’ button and select the ‘network’ option from the menu. • Thereafter select the wireless network setup wizard from the ‘network’ menu. HP printer will look for the wireless routers open in the range. Select your network from the list. • Enter the detail such as WEP/WPA for the network and then press ‘done. Now press ‘OK’ to confirm the settings. Then you have to Press ‘OK’ to print the wireless test report. • The HP printer has been set up on your wireless network. • Lastly, download and install the printer driver from the 123.hp.setup page to finish the process. https://www.howdoisetup.com/hp-printer-setup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28453] Update pagination subroutine to generate Bootstrap markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind --- Things noted from testing: - Administration -> Record matching rules: with 30 entries the pagination bar didn't appear (both before and after the patch was applied) - I'm assuming it should have kicked in at 20? - Cataloging -> MARC Editor -> Tag using unimarc_field_210c value builder: this worked after patch applied (before the patch was applied I couldn't get any results). However, when you click on the controls for anything after page 1, it says no results (even when there are more than 20 results). - Tools > Comments: The pagination only appears at the bottom - should this be added at the top as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29272] API not respecting $category->effective_change_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29272 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29272] API not respecting $category->effective_change_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29272 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 126814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126814=edit Bug 29272: (QA follow-up) Category setup overrides syspref This patch removes an early short-circuit we had, which wasn't correct regarding the OpacPasswordChange syspref. If a patron category is allowed to change password, it overrides the syspref. To test: 1. Tests still pass. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 David Nind changed: What|Removed |Added Attachment #124987|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 126813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126813=edit Bug 28910: Correct eslint errors in OPAC basket.js This patch corrects eslint errors in the OPAC copy of basket.js: Indentation inconsistencies, undeclared variables, unused functions, etc. To test, apply the patch and test the "Cart" functionality in the OPAC: - In the OPAC, add an item to the cart. - A popup message should appear telling you the item has been added. - The "Add to cart" link should update to read "In your cart." - The count if cart items in the header should be updated. - The "In your cart (remove)" link should work correctly. - Test this process from both the search results and detail pages. - Open the cart. - The cart should open correctly. - In the cart, test all the controls: - More details - Send - Download - Empty and close - Hide window - Print - Select all / clear all - With checked items: - Remove - Add to list - Place hold - Tag The following unused functions were removed: readCookieValue, AllAreChecked, SelectAll, and quit. A search of the Koha codebase should return no results from the opac-tmpl directory. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29272] API not respecting $category->effective_change_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29272 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- From the last comments I understand that another change is required - moving to FQA for the follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5528] Analytical records support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5528 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #473 from Marcel de Rooy --- I wrote two follow-ups now. WIll attach them tomorrow. But did look a bit closer to analytical records in Koha and they are quite different from what is done here. They use 773 but thats about it. So there seems to be no reason to braid(?) them together here. Making the analytics disappear when there are components. Note: the components here work with 773 and record control numbers looked up in biblio records. Analytics works different, storing item numbers(!) in 773$9. This seems to be something that we add on top of MARC21, if I understand correctly (so no default MARC21). Conclusion: We should keep them really separate from each other. Will have to add that to my follow-up still. Which should be very trivial. Katrin: Could you confirm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28761] Item status shows incorrectly on opac-course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer --- There is a problem here with item type 'not for loan' set: Without the patch: - Mark an item type as not for loan in administration - Make sure one item of that item type is on course reserve - Check the detail page, it shows as: not for loan - Check course reserves: it shows as: available With the patch: - It shows as Available on both detail and course reserves page The correct behaviour would be to show "not for loan" on both, so this introduces a regression. Lucas - when you follow-up, can you please add Kelly's sign-off line? So we don't forget about it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Katrin Fischer changed: What|Removed |Added Attachment #125110|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 126812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126812=edit Bug 24674: (follow-up) Simpler regex The 'Polish notation' actually simplifies things. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Katrin Fischer changed: What|Removed |Added Attachment #125109|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 126811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126811=edit Bug 24674: Adjust tests and add new ones to cover changes Signed-off-by: Marcel de Rooy Rebased 21-09-21. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Katrin Fischer changed: What|Removed |Added Attachment #125108|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 126810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126810=edit Bug 24674: Uncertain years for publicationyear/copyrightdate -- corrected This is a correction to Bug 11046: YYY-, YY--, Y---, are also correct according to ISBD: uncertain year, but certain decade/century (cf. n. 4.3.8 in ISBD Consolidated Edition of 2011). (Question mark is not mandatory.) In addition, in Poland a form with one only dash is quite common, like YY- (== YY--). Signed-off-by: Marcel de Rooy See last follow-up. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer --- I am sorry Nick, but the Audience sub type doesn't stick and I couldn't spot the mistake. Please also fix your missing TT filters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29126] Accessibility: More corrections to contrast in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Katrin Fischer changed: What|Removed |Added Attachment #126661|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 126809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126809=edit Bug 29126: (follow-up) Correct color of btn-link class in striped tables Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29126] Accessibility: More corrections to contrast in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Katrin Fischer changed: What|Removed |Added Attachment #126054|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 126808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126808=edit Bug 29126: Accessibility: More corrections to contrast in the OPAC This patch makes a few more corrections to OPAC CSS in order to avoid having elements which lack sufficient contrast, in particular parts of the interface where a standard-colored link appears on a darker background. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) Check the following pages/areas: - Breadcrumbs navigation - Datatables buttons (on the "Your summary" page) - Bibliographic view tabs (Normal/MARC/ISBD) on the bibliographic detail pages. - "Action" menu on the bibliographic detail pages: Place hold, print, etc. - Links inside "striped" tables: Links on the alternate grey background are darker to increase contrast. - Sidebar links on user pages: Your summary, your charges, etc. - Tag cloud: Approved tags in the weighted list. Signed-off-by: Jérémy Breuillard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29126] Accessibility: More corrections to contrast in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29126] Accessibility: More corrections to contrast in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 --- Comment #8 from Katrin Fischer --- The previous issue has went away, thx for the follow-up! I notice that we are now using 2 different "blues" for lighter and darker background. Example: http://localhost:8080/cgi-bin/koha/opac-readingrecord.pl * Links in the tabbed navigation on the left (#006394) * Table export options etc. on top of the table or "titles" in the table on dark background(#005580) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #472 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #471) > Why pass the same biblionumber here when running through all component > records? Beginning to understand some of what happened here ;) Finally :) We still need a bit of fixing things that may have been broken during the process. Changing status. Will be submitting a follow-up. Dont touch please (today or tomorrow). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 --- Comment #6 from Katrin Fischer --- I am still having local issues with yamlxs, so can't finish here right now :( Leaving that here in case someone can help me fix: t/db_dependent/Koha/Plugins/Plugins.t 6/61 new(): failed: couldn't load CGI::Session::Serialize::yamlxs: Can't locate CGI/Session/Serialize/yamlxs.pm in @INC (you may need to install the CGI::Session::Serialize::yamlxs module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base t/db_dependent/Koha/Plugins/../../../lib/plugins) at (eval 1739) line 2. # Looks like your test exited with 2 just after 38. t/db_dependent/Koha/Plugins/Plugins.t Dubious, test returned 2 (wstat 512, 0x200) Failed 23/61 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #14 from Katrin Fischer --- I noticed a small inconsistency with the red buttons. Compare: * Patron account > Search history > Remove selected searches * Patron account > Your summary > Holds > Cancel The first is much paler than the second. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Attachment #126660|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 126807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126807=edit Bug 29036: (follow-up) Improve the use of variables to keep colors consistent This patch modifies the OPAC SCSS so that a "base theme color" variable is defined which can be used to color button backgrounds and similar elements. The patch also moves some other colors into variables and removes some unused CSS. The Koha logo which is displayed in the upper left corner of the OPAC has been modified to use the same color. To test, apply the patch and repeat the previous test plan. Signed-off-by: jeremy breuillard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Attachment #126659|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 126806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126806=edit Bug 29036: Accessibility OPAC buttons don't have sufficient contrast This patch changed the base colour of OPAC buttons to increase the contrast ratio, improving accessibility and making the button text easier to read. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check the contrast ratio on the OPAC 2. Confirm that the OPAC buttons don't have sufficient colour contrast 3. Apply the patch and rebuild css: yarn build --view opac 4. Use the accessibility tool to confirm the button contrast ratio now meets minimum accessibility requirements 5. Check that the OPAC still looks ok after the changes Signed-off-by: Owen Leonard Signed-off-by: jeremy breuillard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28101] Accessibility: OPAC - Breadcrumbs should be more accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28101 Katrin Fischer changed: What|Removed |Added Attachment #126028|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 126805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126805=edit Bug 28101: Update breadcrumb markup in the OPAC for consistency and accessibility Modified breadcrumbs to be accessible, in particular for a screen-reader. Also ensured the breadcrumbs were all consistent. Made the block of breadcrumbs to be a with an ordered list inside. The last breadcrumb also has aria-current="page" to specify that it is the current page. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Confirm that OPAC templates are updated consistently to use breadcrumbs markup beginning with '' - Pages in the OPAC should look consistent, with the last breadcrumb styled as text and with the "aria-current" attribute "page." Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28101] Accessibility: OPAC - Breadcrumbs should be more accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28101 Katrin Fischer changed: What|Removed |Added Attachment #125184|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 126804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126804=edit Bug 28101: changed styling for breadcrumbs Updates opac.scss file so the breadcrumbs will appear the same as Bug 27846 (Staff Client breadcrumbs). This works but the file may need to be changed/cleaned up so that there is not unnecessary information in it. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28101] Accessibility: OPAC - Breadcrumbs should be more accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28101 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29227] Patron messaging preferences digest show as editable but are not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29227 Katrin Fischer changed: What|Removed |Added Attachment #126310|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 126803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126803=edit Bug 29227: Patron messaging preferences digest show as editable but are not On moremember.pl we load the messaging preferences for display only, we do not need to load the JS for editing the preferences To test: 0 - Enable EnhancedMessagingPreferences 1 - Load the detais tab for a member 2 - Note the digest column in messaging preferences is clickable 3 - Apply patch 4 - Reload, it is not clickable 5 - Confirm editing the patron (or their messaging prefs) works as expected Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29227] Patron messaging preferences digest show as editable but are not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29227 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29207] Restore Getopt::Long config to not ignore cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Katrin Fischer changed: What|Removed |Added Attachment #126686|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 126802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126802=edit Bug 29207: Getopt::Long should not ignore cases To avoid Getopt::Long treating upper case and lower case options, this patch restores removed ":config no_ignore_case". Steps to reproduce: 1. Start koha-z3950-responder deamon for any instance. 2. Check z3950.log log file, there should be "[fatal] Failed to listen on ...-koha-z3950" in it. 3. Alternatively you can "curl localhost:2100/biblios?version=1.1 -v" to ensure that it doesn't work "Failed to connect to localhost port 2100: Connection refused". 4. Apply the patch. 5. Stop and start daemon again. 6. Check the logs again, there should be no new error there. 7. Same way do the curl to ensure that this time it listens on that port. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29207] Restore Getopt::Long config to not ignore cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29186] Move reports result limit menu into toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29186 Katrin Fischer changed: What|Removed |Added Attachment #126672|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 126801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126801=edit Bug 29186: (QA follow-up) Correct the check for showing limit menu The template conditional for showing the limit menu should be changed to: [% IF ( unlimited_total > 10 && limit <= 1000 ) %] - "unlimited_total > 10" so that the "rows per page" button only shows if there are more than 10 total results, because 10 is the smallest increment the "rows per page" control offers. - "limit <= 1000" so that the "rows per page" button will show when the current result limit is less than or equal to 1000, because 1000 is the upper limit to the "rows per page" control. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29186] Move reports result limit menu into toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29186 Katrin Fischer changed: What|Removed |Added Attachment #125888|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 126800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126800=edit Bug 29186: Move reports result limit menu into toolbar This patch creates a new Bootstrap button menu for selecting the number of search results to be shown. This replaces the HTML . To test, apply the patch and go to Reports -> Saved reports. - Test the appearance and functionality of the "Rows per page" button in various situations: - A report that returns more than 10 results - A report that returns fewer than 10 results - A report that returns no results - Test that the batch operations button menu appears correctly when there are biblionumbers, itemnumbers, or cardnumbers in the results. - When there are no results, or fewer than 10 results with no batch operations possible the toolbar shouldn't appear at all. Signed-off-by: George Williams Signed-off-by: George Williams Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29186] Move reports result limit menu into toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29186 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29312] New: Punctuation: Total number of results: 961 (300 shown) .
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Bug ID: 29312 Summary: Punctuation: Total number of results: 961 (300 shown) . Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org This is from the results of a saved SQL report: Total number of results: 961 (300 shown) . We should either remove the extra . or remove the extra space. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29299] Reindent serials search template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29299 Katrin Fischer changed: What|Removed |Added Attachment #126678|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 126799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126799=edit Bug 29299: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29299] Reindent serials search template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29299 Katrin Fischer changed: What|Removed |Added Attachment #126677|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 126798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126798=edit Bug 29299: Reindent serials search template This patch updates the serials search template to give it consistent indentation. The patch also moves one section of markup: The section is moved to after in order to conform to current standards. To test, apply the patch and go to Serials -> Search subscriptions (in the header). - Serials search should work correctly and the page should look correct. - With Mana enabled, click on the "Search on Mana" link in the sidebar. - Searches of Mana should work correctly too. - If you view the diff while ignoring whitespace the only changes should be the move of and places where line breaks were introduced. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29299] Reindent serials search template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29299 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29306] Holds.t: Fix Use of uninitialized value $_ in concatenation (.) or string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29306 Katrin Fischer changed: What|Removed |Added Attachment #126691|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 126797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126797=edit Bug 29306: Fix warning on undefined $_ in Holds.t Use of uninitialized value $_ in concatenation (.) or string at t/db_dependent/Holds.t line 1658. Results from copying line 70. Test plan: Run Holds.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29306] Holds.t: Fix Use of uninitialized value $_ in concatenation (.) or string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29306 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29270] Use flatpickr and futuredate on reserve/request.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29270 Katrin Fischer changed: What|Removed |Added Attachment #126680|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 126796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126796=edit Bug 29270: Remove flatpickr instantiation from request.tt The JS code is only used when placing a hold for club BUT the date inputs are not displayed there. Test plan: Place holds for patrons and clubs and confirm that the two date inputs are working correctly Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29270] Use flatpickr and futuredate on reserve/request.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29270 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
