[Koha-bugs] [Bug 30296] Correct path for cookie bibs_selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30296 --- Comment #5 from Marcel de Rooy --- (In reply to wainuiwitikapark from comment #4) > I need to backport this to 19.11.x right? Yes 20.11 and lower -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #14 from Fridolin Somers --- I'm testing. Looks good but I see some issues : When hovering button "Move hold to top/bottom" we see that horizontal line color does not change. This is because it is not part of the icon, it is a CSS border. Looks dangerous to me. Why is icon for "Toggle lower priority" different from "Move hold to bottom" ? I propose we use "angle" FA icons : https://fontawesome.com/v4/icon/angle-down https://fontawesome.com/v4/icon/angle-double-down Single arrow for "Move hold up/down" and double arrow for "Move hold to top/bottom". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29957] Cookies not removed after logout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957 --- Comment #73 from Marcel de Rooy --- Created attachment 131856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131856&action=edit Bug 29957: Add example lines in koha-conf.xml Test plan: Just comments. Nothing to test. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23376] Cleanup order receive page code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #28 from Emmi Takkinen --- Created attachment 131857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131857&action=edit Bug 23376: Fix template error on order receive page Order receive page dies on error 500 if orders quantityreceived is more than 0. The error logs reads: "Template process failed: undef error - The method Koha::Item->count is not covered by tests!" In template orderreceive.tt we have "order.items.count" not "orders.items.count" as it should be. Note! It seems that this error doesn't occur if template param edit is set as 1. To test: 1. Find order with quantityreceived value more than 0. 2. Try to receive this order. => Error 500 page is displayed. 3. Apply patch 4. Repeat steps 1 and 2. => Order receive page is displayed normally. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23376] Cleanup order receive page code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Emmi Takkinen changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Bug 8179 depends on bug 23376, which changed state. Bug 23376 Summary: Cleanup order receive page code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21811] Add warning when order receive form is saved without entering 'quantity received'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Bug 21811 depends on bug 23376, which changed state. Bug 23376 Summary: Cleanup order receive page code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26730] Cannot receive orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26730 Bug 26730 depends on bug 23376, which changed state. Bug 23376 Summary: Cleanup order receive page code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27671] Missing include in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27671 Bug 27671 depends on bug 23376, which changed state. Bug 23376 Summary: Cleanup order receive page code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Bug 28627 depends on bug 23376, which changed state. Bug 23376 Summary: Cleanup order receive page code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Bug 28881 depends on bug 23376, which changed state. Bug 23376 Summary: Cleanup order receive page code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30061] Simplify Koha::Patron->get_age
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30061 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30061] Simplify Koha::Patron->get_age
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30061 Marcel de Rooy changed: What|Removed |Added Attachment #131360|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 131858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131858&action=edit Bug 30061: Make Koha::Patron->get_age use DateTime math This patch does what the title says. Instead of converting dates to strings and performing math manually, we can just use the DateTime objects we have and calculate the DateTime::Duration there's between them, to get the years count. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30061] Simplify Koha::Patron->get_age
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30061 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Patch complexity|Trivial patch |Small patch Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #4 from Marcel de Rooy ---
Please show that it breaks in your test. And that your change resolves that.
And tell me what this does:
+my $mocked_context = Test::MockModule->new('C4::Context');
+$mocked_context->mock( 'yaml_preference', sub {
+return { biblionumber => [ $biblio2->biblionumber ] };
+});
I think it is useless code.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30008] Software error in details.pl when invalid MARCXML and showing component records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30008 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30008] Software error in details.pl when invalid MARCXML and showing component records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30008 Marcel de Rooy changed: What|Removed |Added Attachment #131855|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 131859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131859&action=edit Bug 30008: (bug 29690 follow-up) Fix Invalid data, cannot decode metadata object Test plan: 1 - Find a record in the staff catalog 2 - Edit the record 3 - In the 520 notes field, add an ASCII escape character (27 decimal, 1b hex) On ubuntu Ctrl+Shift+u, then 1b, enter 4 - Save the record 5 - Set syspref ShowComponentRecords to 'both...' 6 - On record details: New->New child record 7 - Save the record 8 - Attempt to view the parent record in the staff client and opac Signed-off-by: Fridolin Somers Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30008] Software error in details.pl when invalid MARCXML and showing component records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30008
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
|y.org |
CC||m.de.r...@rijksmuseum.nl
--- Comment #5 from Marcel de Rooy ---
Small note:
+if ( my $components = $marc_record ?
$biblio->get_marc_components(C4::Context->preference('MaxComponentRecords')) :
undef ) {
From a theoretical perspective I would prefer to test $biblio here instead of
$marc_record.
If there is a biblio object, I can call it and if there is somehow no marc
record, then I expect no components back ;)
But it works, ok.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30307] 21.11 files contain strings from master (Recalls)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30307 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28301] Add ability to force re-run of a particular DB update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28301 --- Comment #6 from Jonathan Druart --- (In reply to Fridolin Somers from comment #5) > (In reply to Jonathan Druart from comment #4) > > I think it's actually no longer needed with bug 25078. > > But how do you run a particular DBRev perl file ? What would be the use case? Now the update process stops when an error happens. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29915] Anonymous session generates 1 new session ID per hit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29915 Jonathan Druart changed: What|Removed |Added Component|Koha|Authentication CC||dpav...@rot13.org QA Contact||testo...@bugs.koha-communit ||y.org Group|Koha security | Product|Koha security |Koha --- Comment #117 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #116) > Can we move this one out of security btw ? Yes, done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||m.de.r...@rijksmuseum.nl
--- Comment #34 from Marcel de Rooy ---
From the third patch:
my $delimiter = C4::Context->preference('CSVDelimiter') || ';';
+$delimiter = "\t" if $delimiter eq 'tabulation';
my $delimiter = C4::Context->preference('CSVDelimiter') || ',';
+$delimiter = "\t" if $delimiter eq 'tabulation';
+my $delimiter = C4::Context->preference('CSVDelimiter') || ',';
+$delimiter = "\t" if $delimiter eq 'tabulation';
In addition to last comment of Jonathan, if we are adding a function now to
control behavior, we should not need to 'fiddle' anymore like in the above
lines. Call the function and thats it.
Which probably means move the function out of the template plugin, and only
leave a wrapper there.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #920 from Jonathan Druart --- (In reply to Fridolin Somers from comment #919) > Failures appears on several runs : > https://jenkins.koha-community.org/view/master/job/Koha_Master_U21/115/ > > I think it comes from DT comparison : > > my $expected_due_date = dt_from_string->add( days => 3 ); > is( dt_from_string( $recall->checkout->date_due ), $expected_due_date, > "Checkout due date has correctly been extended by recall_due_date_interval > days" ); > is( $due_date, $expected_due_date, "Due date correctly returned" ); > > $recall->checkout->date_due is a date in ISO string, compare to a DateTime > object. > > How is it in other places ? The error is: 23:08:40 koha_1 | # got: '2022-03-20T22:08:39' 23:13:07 koha_1 | # expected: '2022-03-20T22:08:40' You need to compare dates using t::lib::Dates::compare -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #5 from Jonathan Druart --- Did you git bisect already? It's weird that this is only happening on U18. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30008] Software error in details.pl when invalid MARCXML and showing component records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30008
--- Comment #6 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #5)
> Small note:
>
> +if ( my $components = $marc_record ?
> $biblio->get_marc_components(C4::Context->preference('MaxComponentRecords'))
> : undef ) {
>
> From a theoretical perspective I would prefer to test $biblio here instead
> of $marc_record.
> If there is a biblio object, I can call it and if there is somehow no marc
> record, then I expect no components back ;)
> But it works, ok.
No, that's the point. You can have a $biblio but no $marc_record.
The error will happen later in get_components_query.
It's what we decided earlier on bug 29690, we are dealing on invalid MARC
*only* on this view. We add a big warning and data has to be fixed.
There is also misc/maintenance/search_for_data_inconsistencies.pl that can
catch such problems.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #37 from Jonathan Druart --- Can we get this moving please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30315] New: Calendar widget no longer translates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30315 Bug ID: 30315 Summary: Calendar widget no longer translates Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr The 'old' calendar widget does no longer translate in 20.11. We have just updated to the latest version 20.11.16. To test: * Run 20.11.x * Install translatons, de-DE should be complete * Activate language for staff interface in system preferences * Go to patrons and open any patron account * Look at the date widgets for date of birth, expiration date * Verify day names and buttons remained English, while rest of page has been translated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29723] Add a "Configure table" button for KohaTable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #2 from Jonathan Druart --- Owen, do you think we need this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30315] Calendar widget no longer translates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30315 --- Comment #1 from Katrin Fischer --- Strings are from de-DE-messages-js.po, but I could verify that the translation of the .js messages works fine in other places. Example: https://translate.koha-community.org/de/20.11/translate/de-DE-messages-js.po#unit=15031161&offset=0 * Add something to your cart in staff * Add something to your cart in staff _again_ * Verify pop-up message is translated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #921 from Fridolin Somers --- Ah super, thanks a lot. I've pushed a fix on test suite to master : Bug 19532: (RM follow-up) Fix dates compare in recalls tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30008] Software error in details.pl when invalid MARCXML and showing component records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30008 --- Comment #7 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #6) > > No, that's the point. You can have a $biblio but no $marc_record. > The error will happen later in get_components_query. If there is an error in that sub, it needs a fix :) Currently, Koha does not like biblios without MARC record. It will certainly trigger problems elsewhere too. But simply stated, if there is no MARC, there are no components. And as I said, this is just a theoretical discussion. > It's what we decided earlier on bug 29690, we are dealing on invalid MARC > *only* on this view. We add a big warning and data has to be fixed. > There is also misc/maintenance/search_for_data_inconsistencies.pl that can > catch such problems. Good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 --- Comment #6 from Fridolin Somers --- (In reply to Jonathan Druart from comment #5) > Did you git bisect already? Oh I don't know how to do that. > > It's weird that this is only happening on U18. Indeed, maybe a behavior in perl lib that changed, I could not find. DateTime lib is a Titanic lib. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28301] Add ability to force re-run of a particular DB update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28301 --- Comment #7 from Fridolin Somers --- For example checking that it can be run several times. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29910] Purge old Hea data periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29910 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #16 from Jonathan Druart --- Added the following cronjob: 0 1 1 * * /usr/bin/mysqldump heastats | gzip > /home/hea/dumps/$(date +%Y-%m-%d)-heastats.sql.gz && /usr/bin/mysql -e "DELETE FROM installation WHERE modification_time < DATE_SUB(NOW(), INTERVAL 6 MONTH);" It will dump the DB and remove all installations without changes in the last 6 months. First (manual) run removed 6123 installations. 8744 still in DB. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28301] Add ability to force re-run of a particular DB update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28301 --- Comment #8 from Jonathan Druart --- (In reply to Fridolin Somers from comment #7) > For example checking that it can be run several times. It should be done when it's still an atomic update :) Once it's in dbrev, such test should have been done already. I am not against the idea, but I don't understand what it will bring us. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486
--- Comment #9 from Marcel de Rooy ---
-my $newincbiblioitemnumber=$biblioitemnumber+1;
-$dbh->do("UPDATE biblioitems SET biblioitemnumber = ? WHERE biblionumber =
?;", undef, $newincbiblioitemnumber, $biblionumber );
my $updatedrecord = GetMarcBiblio({
Name of $updatedrecord might be a bit confusing now ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29596] Add Yiddish language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 --- Comment #22 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #21) > Yiddish also needs to be added to the translation platform, right? Because > it isn't. Not necessarily. We only add new languages to the translation platform if someone wants to work on them, this is here was added for search in Advanced search. The other way around it's required. Every language you can translate Koha into should also be in the tables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 --- Comment #4 from Jonathan Druart --- Created attachment 131860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131860&action=edit Bug 30199: [ALTERNATIVE-PATH] Do not generate jtw if patron does not exist -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #5 from Jonathan Druart --- Good catch, Kyle! Can you have a look at this alternative patch please? I think the correct fix is to not generate the JWT if the patron's info are not valid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28301] Add ability to force re-run of a particular DB update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28301 --- Comment #9 from Fridolin Somers --- (In reply to Jonathan Druart from comment #8) > It should be done when it's still an atomic update :) A correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Jonathan Druart changed: What|Removed |Added Depends on||29543 --- Comment #6 from Jonathan Druart --- Certainly caused by bug 29543. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 [Bug 29543] Self-checkout allows returning everybody's loans -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 Jonathan Druart changed: What|Removed |Added Blocks||30199 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Marcel de Rooy changed: What|Removed |Added Attachment #129608|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 131861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131861&action=edit Bug 29486: _koha_marc_update_bib_ids no longer needed for GetMarcBiblio This subroutine is ensuring that the biblionumber and biblioitemnumber will be part of the MARC record. We should not need that, unless there is something broken somewhere else. This line has been added by the following commit: commit 4e95e94727b09b33d2f6c597bdd218a59dcc3681 Bug 6789: biblios with many items can result in broken search results link """ To this end, it also moves the fix_biblio_ids portion of get_corrected_marc_record out of rebuild_zebra.pl, and makes it a part of GetMarcBiblio (right before EmbedItemsInMarcBiblio, so the 952s still come last). fix_biblio_ids is kept as a subroutine for the deletion portion of rebuild_zebra.pl, which still uses it. """ But it does not explain why it's better to have it in GetMarcBiblio. If we need it for the reindexation process, we shouldn't impact GetMarcBiblio which is used from several different places. We might then consider adding the fix_biblio_ids call to rebuild_zebra.pl, but I am failing to understand in which cases it could be useful. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Marcel de Rooy changed: What|Removed |Added Attachment #129609|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 131862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131862&action=edit Bug 29486: Fix tests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Marcel de Rooy changed: What|Removed |Added Attachment #129610|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 131863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131863&action=edit Bug 29486: Add check in search_for_data_inconsistencies.pl If the MARC record does not contain the correct biblionumber of biblioitemnumber, the script will display the following warning: == Bibliographic records have MARCXML without biblionumber or biblioitemnumber == * Biblionumber 4242 has '1' in 999$c * Biblionumber 4242 has biblioitemnumber '4242' but should be '1' in 999$d => The bibliographic records must have the biblionumber and biblioitemnumber in MARCXML Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29910] Purge old Hea data periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29910 --- Comment #17 from Marcel de Rooy --- Great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30222] Auto_renew_digest still sends every day when renewals are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #13 from Jonathan Druart --- IMO no more change should be done to this script before its code is moved and covered by tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29307] marc record fetched twice in detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29307] marc record fetched twice in detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart changed: What|Removed |Added Attachment #126791|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 131864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131864&action=edit Bug 29307: Remove unecessary marc record fetch on detail.pl We were fetching the MARC::Record twice here. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29307] marc record fetched twice in detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #0) > Either we assume the MARC::XML that is stored is correct, or we need to add > more StripNonXmlChars calls. And, so? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart changed: What|Removed |Added Depends on||29486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Jonathan Druart changed: What|Removed |Added Blocks||29697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Comment #57 from Marcel de Rooy ---
+my $marc_flavour = C4::Context->preference('marcflavour');
+my $biblio_metadata = $resultset->find({
+'biblionumber' => $biblionumber,
+'format' => 'marcxml',
+'marcflavour' => $marc_flavour
+});
+my $marc_xml = $biblio_metadata->metadata;
+$marc_xml = StripNonXmlChars($marc_xml);
+
+my $record = eval {
+MARC::Record::new_from_xml($marc_xml, 'UTF-8', $marc_flavour)
+};
+if (!$record) {
You test $record, but you should have tested $biblio_metadata too ?
Otherwise you already crash on ->metadata..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #58 from Marcel de Rooy ---
+return unless (@{$record_ids} || @{$deleted_record_ids} && $format ne
'csv');
Parentheses here would be more helpful inside. The outer ones are not needed.
But in order to read easier, you could do A || ( B && C )
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Martin Renvoize changed: What|Removed |Added Attachment #131861|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 131865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131865&action=edit Bug 29486: _koha_marc_update_bib_ids no longer needed for GetMarcBiblio This subroutine is ensuring that the biblionumber and biblioitemnumber will be part of the MARC record. We should not need that, unless there is something broken somewhere else. This line has been added by the following commit: commit 4e95e94727b09b33d2f6c597bdd218a59dcc3681 Bug 6789: biblios with many items can result in broken search results link """ To this end, it also moves the fix_biblio_ids portion of get_corrected_marc_record out of rebuild_zebra.pl, and makes it a part of GetMarcBiblio (right before EmbedItemsInMarcBiblio, so the 952s still come last). fix_biblio_ids is kept as a subroutine for the deletion portion of rebuild_zebra.pl, which still uses it. """ But it does not explain why it's better to have it in GetMarcBiblio. If we need it for the reindexation process, we shouldn't impact GetMarcBiblio which is used from several different places. We might then consider adding the fix_biblio_ids call to rebuild_zebra.pl, but I am failing to understand in which cases it could be useful. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Martin Renvoize changed: What|Removed |Added Attachment #131862|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 131866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131866&action=edit Bug 29486: Fix tests Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Martin Renvoize changed: What|Removed |Added Attachment #131863|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 131867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131867&action=edit Bug 29486: Add check in search_for_data_inconsistencies.pl If the MARC record does not contain the correct biblionumber of biblioitemnumber, the script will display the following warning: == Bibliographic records have MARCXML without biblionumber or biblioitemnumber == * Biblionumber 4242 has '1' in 999$c * Biblionumber 4242 has biblioitemnumber '4242' but should be '1' in 999$d => The bibliographic records must have the biblionumber and biblioitemnumber in MARCXML Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #59 from Marcel de Rooy ---
sub export
binmode $fh, ':encoding(UTF-8)' unless $format eq 'csv';
} else {
binmode STDOUT, ':encoding(UTF-8)' unless $format eq 'csv';
What happens if we choose csv? Are we not doing UTF-8 ?
Later we do:
print marc2csv( $record_ids, $csv_profile_id, $itemnumbers );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #16 from Martin Renvoize --- This makes a lot of sense and works as expected, no regressions found, tests passing and QA script happy Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #60 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #58)
> +return unless (@{$record_ids} || @{$deleted_record_ids} && $format ne
> 'csv');
>
> Parentheses here would be more helpful inside. The outer ones are not needed.
> But in order to read easier, you could do A || ( B && C )
And functionally: why not deleted records in csv ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #61 from Marcel de Rooy ---
+my ($record_type) = @_;
+my $validator = $encoding_validator->('Record');
+$validator = $encoding_validator->('Deleted record');
Deleted flag ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com --- Comment #19 from Cab Vinton --- ASSIGNED status does indeed appear dubious, but don't feel qualified to update. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #62 from Marcel de Rooy ---
-my $record = _get_record_for_export( { %$params, record_id =>
$record_id } );
+for my $record (@records, @deleted_records) {
+print MARC::File::XML::record($record);
Noting that get_record_for_export does a lot more and we seem to loose that
now?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #63 from Marcel de Rooy --- Ok, not all my questions have the same importance and I realize that this dev is already too long in the pipeline, but I like to have feedback now. Changing status to reflect that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29307] marc record fetched twice in detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart changed: What|Removed |Added Resolution|--- |DUPLICATE Status|ASSIGNED|RESOLVED --- Comment #9 from Jonathan Druart --- Will be fixed by bug 29697. *** This bug has been marked as a duplicate of bug 29697 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #12 from Jonathan Druart --- *** Bug 29307 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart changed: What|Removed |Added Depends on||30008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30008 [Bug 30008] Software error in details.pl when invalid MARCXML and showing component records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30008] Software error in details.pl when invalid MARCXML and showing component records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30008 Jonathan Druart changed: What|Removed |Added Blocks||29697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 --- Comment #64 from Cab Vinton --- (In reply to Katrin Fischer from comment #56) > From looking at the patch set this will only appear in the command line > script. But as this has been waiting a while now, I suggest we file a > separate report for making this available on GUI side. What do you think? I missed this earlier, but Yes, a separate report for the GUI side makes sense. I would wait until this one is fully signed off, but others are welcome to proceed if they wish. Not sure how prevalent this is, but I believe quite a few union catalogs still ask contributing members to regularly send updates w/ lists of records added & deleted. So this feature would come in handy for all the folks who don't have access to the command line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart changed: What|Removed |Added Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 --- Comment #20 from Jonathan Druart --- (In reply to Cab Vinton from comment #19) > ASSIGNED status does indeed appear dubious, but don't feel qualified to > update. Adjusted to NEW. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart changed: What|Removed |Added Attachment #129757|0 |1 is obsolete|| Attachment #129758|0 |1 is obsolete|| Attachment #129759|0 |1 is obsolete|| Attachment #129760|0 |1 is obsolete|| Attachment #129761|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 131868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131868&action=edit Bug 29697: Special case - opac not needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #14 from Jonathan Druart --- Created attachment 131869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131869&action=edit Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #15 from Jonathan Druart --- Created attachment 131870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131870&action=edit Bug 29697: Remove GetHiddenItemnumbers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #16 from Jonathan Druart --- Created attachment 131871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131871&action=edit Bug 29697: Use flag embed_items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #17 from Jonathan Druart --- Created attachment 131872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131872&action=edit Bug 29697: Fix tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #18 from Jonathan Druart --- Created attachment 131873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131873&action=edit Bug 29697: Deal with the degraded view in detail.pl In detail.pl we must provide a degraded view with an error message about invalid MARC::Record. We are then forced to reproduce the GetMarcBiblio behaviour and call StripNonXmlChars on the MARC::XML -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #19 from Jonathan Druart --- Ready for signoff! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29723] Add a "Configure table" button for KohaTable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #3 from Jonathan Druart --- Created attachment 131874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131874&action=edit Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29723] Add a "Configure table" button for KohaTable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Jonathan Druart changed: What|Removed |Added Attachment #131874|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart changed: What|Removed |Added Attachment #129789|0 |1 is obsolete|| --- Comment #88 from Jonathan Druart --- Created attachment 131875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131875&action=edit Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart changed: What|Removed |Added Attachment #131703|0 |1 is obsolete|| --- Comment #89 from Jonathan Druart --- Created attachment 131876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131876&action=edit Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #15 from Owen Leonard --- Created attachment 131877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131877&action=edit Bug 29057: (follow-up) Make arrow border hover state the correct color -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180 George Veranis changed: What|Removed |Added Patch complexity|--- |Trivial patch CC||gvera...@dataly.gr Assignee|koha-b...@lists.koha-commun |gvera...@dataly.gr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #16 from Owen Leonard --- Created attachment 131878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131878&action=edit Screenshot of interface using angle icons (In reply to Fridolin Somers from comment #14) > Why is icon for "Toggle lower priority" different from "Move hold to bottom" > ? I think it should be different because it performs a different function. I think the current version with the arrow images is confusing because they're not different enough. The angle icons are not my top choice, but it is nice that there could be three variations on the same one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize changed: What|Removed |Added Attachment #131605|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 131879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131879&action=edit Bug 30275: Add checkout_renewals table This patch adds the new checkout_renewals table using an atomicupdate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize changed: What|Removed |Added Attachment #131606|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 131880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131880&action=edit Bug 30275: Generated kohastructure.sql This kohastructure update was generated using `koha-dump --schema-only` in koha-testing-docker once the atomicupdate had been run against the previous atomicupdate patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize changed: What|Removed |Added Attachment #131607|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 131881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131881&action=edit Bug 30275: DBIC Schema Changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize changed: What|Removed |Added Attachment #131608|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 131882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131882&action=edit Bug 30275: Record renewals -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize changed: What|Removed |Added Attachment #131609|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 131883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131883&action=edit Bug 30275: DBIC Schema Additions Add checkout and old_checkout relations to CheckoutRenewal schema and mark 'seen' as a boolean. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize changed: What|Removed |Added Attachment #131610|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 131884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131884&action=edit Bug 30275: Add Koha::Objects for Renewals Add Koha::Checkouts::Renewals|Renewal classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize changed: What|Removed |Added Attachment #131611|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 131885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131885&action=edit Bug 30275: Rename issues.renewals to issues.renewals_count Rename the issues.renewals field to renewals_count to prevent a method name collision with the new relation accessor introduced by this patchset. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize changed: What|Removed |Added Attachment #131612|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 131886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131886&action=edit Bug 30275: renewals_count DBIC Update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize changed: What|Removed |Added Attachment #131613|0 |1 is obsolete|| --- Comment #35 from Martin Renvoize --- Created attachment 131887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131887&action=edit Bug 30275: Add 'renewals' relation to Issue Schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
