[Koha-bugs] [Bug 30866] In unit tests, validate CCL queries using ZOOM::Query::CCL2RPN

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30866

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30865

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30865] Koha::Biblio->get_components_query should double quote Host-item search

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30866

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30866] In unit tests, validate CCL queries using ZOOM::Query::CCL2RPN

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30866

--- Comment #1 from David Cook  ---
The tricky part of course is that we build/mangle/manipulate/transform queries
all over the place so this might be easier said than done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30866] New: In unit tests, validate CCL queries using ZOOM::Query::CCL2RPN

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30866

Bug ID: 30866
   Summary: In unit tests, validate CCL queries using
ZOOM::Query::CCL2RPN
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

We should validate that we're creating correct CCL in Koha using our unit
tests.

I've included a simple example at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175#c522

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30865] Koha::Biblio->get_components_query should double quote Host-item search

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865

--- Comment #2 from David Cook  ---
Created attachment 135445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135445=edit
Bug 30865: Double-quote Host-item in Koha::Biblio->get_components_query

This patch adds double quotes around the term qualified by "Host-item"
in Koha::Biblio->get_components_query().

Without them, reserved charactrs like "=" will cause syntax errors like
"CCL parsing error (10014) Unknown qualifier ZOOM for query:
Host-item=(MyTitle = Mysubtitle)
at /usr/share/koha/lib/C4/Search.pm line 245."

Test plan:
0) Don't apply the patch
1) Create biblio with title and subtitle like (MyTitle : MySubtitle)
2) Note the warning "There was an error searching for
analytic records, please see the logs for details." on the detail page

3) Apply the patch
4) koha-plack --restart kohadev

5) Refresh the detail page
6) Note that the warning message is gone

7) prove t/db_dependent/Koha/Biblio.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30865] Koha::Biblio->get_components_query should double quote Host-item search

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #20 from David Cook  ---
Bumping into this again because of Bug 30865 but escaping a semicolon won't be
enough.

You'd have to escape question marks as well, since they're a special case which
is only handled by "Special attribute combos" (see
https://software.indexdata.com/yaz/doc/tools.html#ccl.qualifiers)

There's % and ! as well as proximity operators. 

Also >=, <=, <>, >, and < as relational operators.

In the end I think it's just easier to compose queries more carefully, and go
the route I'm going with bug 30865.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30865] Koha::Biblio->get_components_query should double quote Host-item search

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865

--- Comment #1 from David Cook  ---
Reference on Elasticsearch syntax:
https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html#query-string-syntax

Reference on CCL/Zebra syntax:
https://software.indexdata.com/yaz/doc/tools.html#ccl.syntax

The CCL documentation isn't great and Koha has never handled CCL very well...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #524 from David Cook  ---
(In reply to David Cook from comment #522)
>
> Regarding Zebra, we actually have the tools to easily catch this in our unit
> tests:
> 

Except of course we're feeding the output of "get_components_query" into
$searcher->simple_search_compat or into search.pl/opac-search.pl "q" parameter
which both transform the query differently (both for Zebra and for
Elasticsearch so we get at least 4x more things to check). 

Well... if it were easy it would already be done 藍. Someday...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30865] Koha::Biblio->get_components_query should double quote Host-item search

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865

David Cook  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30865

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

David Cook  changed:

   What|Removed |Added

 Blocks||30865


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865
[Bug 30865] Koha::Biblio->get_components_query should double quote Host-item
search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30865] Koha::Biblio->get_components_query should double quote Host-item search

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29418
 Depends on||11175


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
[Bug 11175] Show the parent record's component parts in the detailed views
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30865] New: Koha::Biblio->get_components_query should double quote Host-item search

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865

Bug ID: 30865
   Summary: Koha::Biblio->get_components_query should double quote
Host-item search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

As noted at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175#c522 and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418#c11, an
unquoted Host-item query returned by Koha::Biblio->get_components_query can
cause syntax errors in Zebra.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29418

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=11175

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #523 from David Cook  ---
(In reply to David Cook from comment #522)
> (In reply to Martin Renvoize from comment #520)
> > Nice one.. faith in community restored.. sorry for being grumpy
> 
> Now I'm feeling grumpy reading through these patches again .
> 

Actually now that I think about it... I feel like I've already grumped about
this code recently...

Ah yes: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418#c16

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #522 from David Cook  ---
(In reply to Martin Renvoize from comment #520)
> Nice one.. faith in community restored.. sorry for being grumpy

Now I'm feeling grumpy reading through these patches again .

(In reply to Marcel de Rooy from comment #499)
> Created attachment 126883 [details] [review]
> Bug 11175: (QA follow-up) Move get_component_part_query

This patch removed the double-quotes from the search terms which causes this to
break when using Zebra if you're using a title like "MyTitle: MySubtitle" since
the following query is a syntax error:

Host-item=(MyTitle= MySubtitle)

It should be:

Host-item=("MyTitle= MySubtitle")

According to
https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html#query-string-syntax,
it looks like Elasticsearch works the same way. 

Single words don't need to be quoted but terms consisting of more than one word
do.

Regarding Zebra, we actually have the tools to easily catch this in our unit
tests:

#!/usr/bin/perl
use strict;
use warnings;
use C4::Context;
use ZOOM;
my $Zconn = C4::Context->Zconn;
eval {
my $bad = ZOOM::Query::CCL2RPN->new("Host-item=(MyTitle=
MySubtitle)",$Zconn);
};
warn $@ if $@;
my $good = ZOOM::Query::CCL2RPN->new('Host-item=("MyTitle=
MySubtitle")',$Zconn);

That code will output the following error:

ZOOM error 10014 "CCL parsing error" (addinfo: "Unknown qualifier") from
diag-set 'ZOOM' at test.pl line 10.

It looks like
https://metacpan.org/pod/Search::Elasticsearch::Compat::QueryParser#check()
could provide similar error checking for Elasticsearch. 

If we just syntax checked our query strings, we'd run into far fewer
problems... 

Anyway, I'll open a new bug report for this one. I just figured it would be
good for folk to hear about it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30859] Upgrade jQuery Validation plugin from v1.19.1

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30733] Simplify translatable strings

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733

--- Comment #22 from Victor Grousset/tuxayo  ---
Created attachment 135444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135444=edit
Bug 30733: Move all semicolons inside the translatable strings

In the 1st patch, sometimes they where left out

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30859] Upgrade jQuery Validation plugin from v1.19.1

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
I've signed off, but noted these things - these are the same behaviour as in
current master:

- New patron category: password expiration field is not validated - can enter
anything, if not valid is blank on edit (have logged as bug 30864).

- Patron changing their password from their account (change your password):
this form (as well as the forgotten password form) work "differently", with any
error messages shown in a text block above the form instead of highlight errors
in red. This is the current behaviour, and things validate as expected.

Other testing notes (koha-testing-docker): to enable forgotten password
recovery, the system preference is OpacResetPassword.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30864] New: Patron category form - no validation for password expiration field

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864

Bug ID: 30864
   Summary: Patron category form - no validation for password
expiration field
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: da...@davidnind.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When creating a patron category or editing an existing one, there is no
validation for the "Password expiration" field.

If letters or other characters are entered, there is no error message and if
not a number whatever is entered is not saved.

To replicate:
1. Go to Administration > Patrons and circulation > Patron categories.
2. Add a new patron category (or edit an existing category).
3. For the "Password expiration" field, enter letters or characters such as
L$%.
4. For the "Age required" field, enter letters or characters.
5. Note that for the "Age required" field you are prompted to "Please enter
only digits", but for "Password expiration" there is no validation error
message.
6. If you save with letters or other characters in the "Password expiration"
field, it is shown as a "-" on the patron categories list and is blank when you
edit the category.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30859] Upgrade jQuery Validation plugin from v1.19.1

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859

David Nind  changed:

   What|Removed |Added

 Attachment #135420|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 135443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135443=edit
Bug 30859: Upgrade jQuery Validation plugin from v1.19.1

This patch updates the jQuery Validation plugin in both the OPAC and
staff interface. This upgrade brings the plugin to the current latest
version (1.19.4) which includes compatibility fixes for the latest
version of jQuery.

To test, apply the patch and test various forms in the OPAC and staff
interface to confirm that validation is still working correctly.

In the OPAC:

- Patron self-registration: Required fields, password match
  and complexity. Test also the "Forgot password" and "Change password"
  interfaces.

In the staff interface, for example:

- Patrons -> Patron password change: Required fields, password match and
  complexity.
- Administration -> Patron categories -> New category:
  - Required fields
  - One or the other enrollment period inputs
  - Digits required in password expiration, age required, upper age
limit
  - Numbers required in enrollment and hold fee.
- Administration -> Budgets -> New budget:
  - Required fields
  - End date must be after start date
- Administration -> Cities & towns: Required fields

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30859] Upgrade jQuery Validation plugin from v1.19.1

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Failed QA

--- Comment #4 from David Nind  ---
Everything is working as expected, except for the second last step: no
messages, such as "There are no ungrouped baskets.", are shown on the group
edit form if there are no rows.

A nice improvement as well, I like the tables and the action buttons (add to
group/remove) compared with the drag and drop.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29374] searchResults explodes if biblio record has been deleted

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29374

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|21.11.00|21.11.00,21.05.15
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||and...@bywatersolutions.com

--- Comment #4 from Andrew Fuerste-Henry  ---
Pushed to 21.05.x for 21.05.15

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/