[Koha-bugs] [Bug 36466] Incorrect date value stored when "Published on" or "Expected on" are empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36466
Emmi Takkinen changed:
What|Removed |Added
Attachment #164254|0 |1
is obsolete||
CC||emmi.takki...@koha-suomi.fi
--- Comment #6 from Emmi Takkinen ---
Created attachment 164306
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164306&action=edit
Bug 36466: Incorrect date value stored when 'Published on' or 'Expected on' are
empty
When we edit a serial and we leave the date fields ('Published on' or
'Expected on') empty incorrect date are saved in the database -00-00
instade of current date and we get Error 500
to reproduce
1. Connect to staff interface
2. Go to Serials and create a new subscription
3. Click on Serial collection in the left menu (and note the
Subscription numnber)
4. Select a serial to edit and Click on «Edit serials»
5. In the Serial edition form, delete «Published on > and « Expected on
» dates and save
> Error 500 page is displayed
6. Check the value of «Published on > and « Expected on » dates in the
database
select planneddate,publisheddate from serial where
subscriptionid=;
--> planneddate publisheddate have «-00-00» value
7. Apply the patch
8. repeat step 2, 3, 4, 5, 6
-> Error 500 page is no more displayed
-> «Published on » and « Expected on » field have today date
Signed-off-by: Owen Leonard
Signed-off-by: Emmi Takkinen
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36466] Incorrect date value stored when "Published on" or "Expected on" are empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36466 Emmi Takkinen changed: What|Removed |Added Attachment #164255|0 |1 is obsolete|| --- Comment #7 from Emmi Takkinen --- Created attachment 164307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164307&action=edit Bug 36466: (follow-up) Adding atomicupdate file to fix -00-00 in serial table Signed-off-by: Owen Leonard Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34826] Circulation rules edit row select elements don't always update when selecting new row for editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34826 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi --- Comment #4 from Emmi Takkinen --- I believe this is a same problem which was discovered in bug 34585. I wrote second patch "Bug 34585: Fix behaviour of select dropdowns when editing circulation rules" to fix this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34826] Circulation rules edit row select elements don't always update when selecting new row for editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34826 Emmi Takkinen changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34585 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34585] "When to charge" columns value not copied when editing circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34585 Emmi Takkinen changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34826 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36495] Add resource_not_found() and resource_deleted() helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495
--- Comment #6 from Jonathan Druart ---
Yes I agree with Martin, we should adjust "Object".
I think we shouldn't use the generic "Object" term. For GET
/patrons/{patron_id}/holds/{hold_id} we certainly want to see the difference
between "Patron not found" and "Hold not found".
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #85 from Jonathan Druart --- Created attachment 164308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164308&action=edit Bug 33568: Remove debug_display This is useless, we could move it to its own bug report if needed. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #86 from Jonathan Druart --- Created attachment 164309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164309&action=edit Bug 33568: Starting up Copying the same thead and making a new table using the REST API endpoint Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #87 from Jonathan Druart --- Created attachment 164310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164310&action=edit Bug 33568: Display string version of coded values + format dates Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #88 from Jonathan Druart --- Created attachment 164311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164311&action=edit Bug 33568: can_be_edited Not sure if this is ideal but at least the algorithm complexity is way better than before! Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #89 from Jonathan Druart --- Created attachment 164312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164312&action=edit Bug 33568: Display item type image Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #90 from Jonathan Druart --- Created attachment 164313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164313&action=edit Bug 33568: Restore class names on th's Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #91 from Jonathan Druart --- Created attachment 164314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164314&action=edit Bug 33568: Cover images Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #92 from Jonathan Druart --- Created attachment 164315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164315&action=edit Bug 33568: Hide empty columns Instead of relying on the existence of data in at least one item we are going to hide empty columns. That could be confusing: it does not mean items on another page do not have data for this column. The user can still display the column using the "Columns" visibility button, and filter on the column. I think this is an acceptable behaviour. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #93 from Jonathan Druart --- Created attachment 164316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164316&action=edit Bug 33568: Temporary set searchable to false where no data Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #94 from Jonathan Druart --- Created attachment 164317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164317&action=edit Bug 33568: fix DataTables bKohaColumnsUseNames Looks like this bug does not exist in Koha, but we hit it here. Could be moved to its own bug. Compare with ../includes/columns_settings.inc (code that is used prior to this change) Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #95 from Jonathan Druart --- Created attachment 164318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164318&action=edit Bug 33568: Add columns visibility Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #96 from Jonathan Druart --- Created attachment 164319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164319&action=edit Bug 33568: Remove visibility conditions Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #97 from Jonathan Druart --- Created attachment 164320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164320&action=edit Bug 33568: Fix search on item type Is this good? Cannot we return incorrect results here? Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #98 from Jonathan Druart --- Created attachment 164321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164321&action=edit Bug 33568: Shelving location Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #99 from Jonathan Druart --- Created attachment 164322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164322&action=edit Bug 33568: Item groups FIXME - we need tests, but I'd like to make sure there is no an easier way to do this many to many things. Tomas? Filter on the "Item group" column needs to be tested! Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #100 from Jonathan Druart --- Created attachment 164323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164323&action=edit Bug 33568: enumchron/volinfo Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #101 from Jonathan Druart --- Created attachment 164324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164324&action=edit Bug 33568: Status FIXME We need tests here! See the FIXME in the code, we are losing the ability to search on the status, but this is really impossible to implement if we are not storing the status (DB or search engine). Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #102 from Jonathan Druart --- Created attachment 164325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164325&action=edit Bug 33568: Add link to moredetail Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #103 from Jonathan Druart --- Created attachment 164326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164326&action=edit Bug 33568: URI Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #104 from Jonathan Druart --- Created attachment 164327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164327&action=edit Bug 33568: Display stringified version of copy_number FIXME - should we apply the same test for other row._strings occurrences, in case they are not linked with an AV cat? Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #105 from Jonathan Druart --- Created attachment 164328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164328&action=edit Bug 33568: public notes Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #106 from Jonathan Druart --- Created attachment 164329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164329&action=edit Bug 33568: Host title See FIXMEs! Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #107 from Jonathan Druart --- Created attachment 164330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164330&action=edit Bug 33568: Print label button Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #108 from Jonathan Druart --- Created attachment 164331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164331&action=edit Bug 33568: Restore action buttons Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #109 from Jonathan Druart --- Created attachment 164332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164332&action=edit Bug 33568: Separate holdings This needs to be well tested! Sysprefs SeparateHoldings and SeparateHoldingsBranch As well as the "Lost items in staff interface" that can be defined at patron's category level. This patch is simply restoring the previous behaviour but I think we could do better. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
--- Comment #110 from Jonathan Druart ---
Created attachment 164333
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164333&action=edit
Bug 33568: Course reserves
FIXME We need tests here
FIXME/TODO - Isn't it possible to replace all this mess with the
following Koha::Item method and a new DBIC rs?
sub courses {
my ($self) = @_;
return Koha::Courses->search(
{ 'ci.itemnumber' => $self->itemnumber },
{ join=> { course_reserves => 'ci' } }
);
}
Signed-off-by: Owen Leonard
Signed-off-by: Laurence Rault
Signed-off-by: Emily Lamancusa
Signed-off-by: Tomás Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #111 from Jonathan Druart --- Created attachment 164334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164334&action=edit Bug 33568: Escape all the things Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #112 from Jonathan Druart --- Created attachment 164335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164335&action=edit Bug 33568: Restore filters FIXME - If we click 'show filters' the 'columns' list does not contain all the columns. We are destroying the DT and the hidden columns are removed from the dom. I think there are 2 possible solutions here: 1. don't destroy but adjust the 'dom' parameter of DT (I didn't manage to make this work correctly, because of the th filters) 2. Move the th definition in the JS init of DT Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #113 from Jonathan Druart --- Created attachment 164336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164336&action=edit Bug 33568: Fix action links display Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #114 from Jonathan Druart --- Created attachment 164337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164337&action=edit Bug 33568: Preserve item selection across pagination and filtering BTW Do we really need StaffDetailItemSelection? Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #115 from Jonathan Druart --- Created attachment 164338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164338&action=edit Bug 33568: Use as_due_date to display due dates Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #116 from Jonathan Druart --- Created attachment 164339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164339&action=edit Bug 33568: Display library names instead of codes for transfers Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #117 from Jonathan Druart --- Created attachment 164340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164340&action=edit Bug 33568: Bug 33568: Display library names instead of codes for first hold Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #118 from Jonathan Druart --- Created attachment 164341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164341&action=edit Bug 33568: Bug 33568: Display library names instead of codes for recall Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #119 from Jonathan Druart --- Created attachment 164342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164342&action=edit Bug 33568: Display the desk name for the first hold Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #120 from Jonathan Druart --- Created attachment 164343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164343&action=edit Bug 33568: Restore bundle items Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #121 from Jonathan Druart --- Created attachment 164344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164344&action=edit Bug 33568: Restore host records Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #122 from Jonathan Druart --- Created attachment 164345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164345&action=edit Bug 33568: Restore analytics FIXME We cannot have the usual _count/+count pattern for the REST API, I think it's acceptable FIXME We lost the sort on this column, not a big deal IMO Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #123 from Jonathan Druart --- Created attachment 164346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164346&action=edit Bug 33568: Move code to a dedicated include file Not very nice but at least the code is isolated in a separate file and reduce the size of detail.tt We could also move the code related to the item bundle that is included inside this same table. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #124 from Jonathan Druart --- Created attachment 164347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164347&action=edit Bug 33568: Fix DT dom and remove DT info if not needed Was there a real need to deal with a specific dom? The "no filter" view was not really light, only the column filters were shown/hidden. This patch is suggesting to remove all the DT info in case the table is displaying all the items of the bibliographic record: Pagination, filtering, buttons, etc. This patch is for discussion. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #125 from Jonathan Druart --- Created attachment 164348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164348&action=edit Bug 33568: Fix select/clear all links Follow-up for "Bug 33568: Preserve item selection across pagination and filtering" FIXME We should deal with the items selection in a better way, but I would not consider it blocker, that can be done later. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #126 from Jonathan Druart --- Created attachment 164349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164349&action=edit Bug 33568: Add search on home and holding library's names QUESTION - Do we prefer this or a dropdown list in the column filter header? Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #127 from Jonathan Druart --- Created attachment 164350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164350&action=edit Bug 33568: Prevent 500 when filtering by item type (FIXMEs) See FIXMEs added by this patch Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #128 from Jonathan Druart --- Created attachment 164351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164351&action=edit Bug 33568: (follow-up) Restore filters This is a bit ugly but fixes the problem raised in the previous commit, as well as others for instance comment 18 "* Click 'show filters', 'hide filters' and repeat X 2 - status column disappears?" Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #129 from Jonathan Druart --- Created attachment 164352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164352&action=edit Bug 33568: Fix local cover images We need to reprocess the images when the table is refreshed, to do that we teach verify_cover_images to go through a given container instead of the whole document, and pass a call back function to build_items_table that will be called when DataTables will have redrawn the table (drawCallback). Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #130 from Jonathan Druart --- Created attachment 164353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164353&action=edit Bug 33568: Fix 'actions' links when filters are shown/hidden It also fixes a problem when "Select all" was clicked, the checkbox selection was not kept when the table was refreshed (was comparing string and integer, parseInt needed) Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #131 from Jonathan Druart --- Created attachment 164354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164354&action=edit Bug 33568: (bug 34226 follow-up) Add type=date to date columns Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #132 from Jonathan Druart --- Created attachment 164355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164355&action=edit Bug 33568: Do not embed library names Performance for 1000 items from 30s to 22s It replaces the input in the column header filter with a dropdown list. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36498] Allow ability to set display order when adding an item group from additem.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36498 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #133 from Jonathan Druart --- Created attachment 164356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164356&action=edit Bug 33568: Do not embed item types Performance for 1000 items from 22 to 19s It replaces the input in the column header filter with a dropdown list. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36498] Allow ability to set display order when adding an item group from additem.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36498 David Nind changed: What|Removed |Added Attachment #164303|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 164357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164357&action=edit Bug 36498: Add ability to set item group display order from additem.tt To test: 1. Apply patch, restart_all 2. System preferences -> EnableItemGroups, set to 'Enable'. 3. Find a record and create at least 1 item group. 4. Go to Add item 5. Scroll to the bottom and look for 'Options' underneath 'Add to item group' 6. In the dropdown select 'Create new item group' 7. There should be fields for 'Name' and 'Display order'. 8. Make sure you can add a new item group with and without a display order set. If no display order is set it should default to 0. 9. Try to add a non numerical display order, you should not be able to. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #134 from Jonathan Druart --- Created attachment 164358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164358&action=edit Bug 33568: follow-up for 29523 Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #135 from Jonathan Druart --- Created attachment 164359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164359&action=edit Bug 33568: Add some missing StaffDetailItemSelection conditionals Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #136 from Jonathan Druart --- Created attachment 164360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164360&action=edit Bug 33568: Hide holdings tabs if empty (SeparateHoldings) See comment 34. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #137 from Jonathan Druart --- Created attachment 164361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164361&action=edit Bug 33568: JSON-encode html output of build_table This prevents error with quotes coming from translations Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #138 from Jonathan Druart --- Created attachment 164362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164362&action=edit Bug 33568: Fix ordering Use search_ordered for default ordering It also fixes a crash when StaffDetailItemSelection is turned off. Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #139 from Jonathan Druart --- Created attachment 164363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164363&action=edit Bug 33568: Do not display 'null' when no barcode Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #140 from Jonathan Druart --- Created attachment 164364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164364&action=edit Bug 33568: Hide 'Host records' if EasyAnalyticalRecords is off Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #141 from Jonathan Druart --- Created attachment 164365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164365&action=edit Bug 33568: Fix popup behaviour for SpineLabelShowPrintOnBibDetails Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #142 from Jonathan Druart --- Created attachment 164366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164366&action=edit Bug 33568: Restore link to patron Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #143 from Jonathan Druart --- Created attachment 164367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164367&action=edit Bug 33568: Restore column filters when StaffDetailItemSelection is off Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #144 from Jonathan Druart --- Created attachment 164368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164368&action=edit Bug 33568: Fix patron_to_html display Take HidePatronName into account Display cardnumber Remove parenthesis around cardnumber if the name is hidden Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
--- Comment #145 from Jonathan Druart ---
Created attachment 164369
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164369&action=edit
Bug 33568: (follow-up) Fix ordering - WIP
This is not working. We are still getting the error
Unable to programatically derive a required group_by from the supplied order_by
criteria. To proceed either add an explicit group_by, or simplify your order_by
to only include plain columns (supplied order_by: 'lpad_copynumber').
To recreate the problem you can go to detail.pl and search for something
Without search the query is working.
The problem appears when the query has WHERE parameters added and "GROUP
BY" is added.
DBIC is adding to the GROUP BY what is added to the select, but does not
handle this situation (not a plain column).
You can play with:
1.
Remove from Koha::Items->search_ordered
475 'lpad_copynumber',
=> all good
2. Remove the following block from
/usr/share/perl5/DBIx/Class/Storage/DBIHacks.pm
584 # only consider real columns (for functions the user got to do an
explicit group_by)
585 my $chunk_ci;
586 if (
587 @{$order_by[$o_idx]} != 1
588 or
589 # only declare an unknown *plain* identifier as "leftover" if we are
called with
590 # aliastypes to examine. If there are none - we are still in
_resolve_attrs, and
591 # can just assume the user knows what they want
592 ( ! ( $chunk_ci = $colinfos->{$order_by[$o_idx][0]} ) and
$attrs->{_aliastypes} )
593 ) {
594 push @$leftovers, $order_by[$o_idx][0];
595 }
=> all good
I don't know if we are doing something wrong here, but I have no idea
how we can build the group_by explicitely.
Is there another way to do this?
Signed-off-by: Laurence Rault
Signed-off-by: Emily Lamancusa
Signed-off-by: Tomás Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #146 from Jonathan Druart --- Created attachment 164370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164370&action=edit Bug 33568: Fix columns shift when pref are off From comment 66: If StaffDetailItemSelection and/or LocalCoverImages is turned off, the alignment of the drop-down filters for the other columns is offset by 1 for each of the two sysprefs that is disabled Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #147 from Jonathan Druart --- Created attachment 164371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164371&action=edit Bug 33568: Remove LPAD ordering This is coming from bug 3521 it seems. And we are going to deal with this later if people complains. kidclamp> the performance issue for sites with many copies is bigger than sorting issues imho kidclamp> drop the LPAD I say :-) Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #148 from Jonathan Druart --- Created attachment 164372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164372&action=edit Bug 33568: serialitem => serial_item Signed-off-by: Tomas Cohen Arazi Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #149 from Jonathan Druart --- Created attachment 164373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164373&action=edit Bug 33568: POD fixes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #150 from Jonathan Druart --- Created attachment 164374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164374&action=edit Bug 33568: Add hint on the table settings admin page Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #151 from Jonathan Druart --- Thanks Tomas! I have added Laurence and Emily as well as yours. Laurence and Emily have done extended testing and I think they deserve their signed-off-by lines on this one. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 --- Comment #7 from Jonathan Druart --- > Created attachment 164294 [details] [review] > Bug 36483: Patrons.pm use case > > This case brought my attention as there was a different 'user' parameter > being passed. > It turns out we already thought about this, and `objects.to_api` is of > course always passing it :-D Do we have a test for this? I don't find it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36416] Check out using CirculateILL is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36416 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36416] Check out using CirculateILL is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36416 David Nind changed: What|Removed |Added Attachment #163802|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 164375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164375&action=edit Bug 36416: Fix cud-check_out 1) Install FreeForm and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Checkout to branch b_36243 cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Enable CirculateILL sys pref 4) Create a new ILL request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set "type" = Book and enter '42' on the cardnumber input, click "Create" 6) On the top toolbar, click "Confirm" and confirm the following screen. 7) You now have a new option "Check out" on the toolbar. Click on it. Notice it explodes. 8) Apply patch. Repeat. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 --- Comment #67 from Katrin Fischer --- Missing patches pushed to master! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #152 from Katrin Fischer --- (In reply to Jonathan Druart from comment #151) > Thanks Tomas! > I have added Laurence and Emily as well as yours. > Laurence and Emily have done extended testing and I think they deserve their > signed-off-by lines on this one. Totally agree, thanks for thinking of it! My goal is to push this before leaving for Marseille. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 --- Comment #16 from Katrin Fischer --- Could it be a different branch or some uncommitted changes? Some additional step missing to activate the changes? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36369] Make APIClient be more useful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369 --- Comment #14 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #13) > (In reply to Jonathan Druart from comment #11) > > 2. So far we have decided to provide what is implemented/used. With this we > > will offer in the view usage of routes that may not be implemented yet. > > Am I right to interpret what you say like: 'if the Vue page doesn't allow > deleting the resource, we shouldn't implement a delete() method'? > > It feels to me that this shouldn't be an issue... and would allow people to > reuse this more? Yes it is what I meant for "used". And I agree it is not really a problem. However it can be a problem for "implemented": If the endpoint does not exist in the controller should we provide it in the api-client? It does not make sense to me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 --- Comment #17 from Jake Deery --- When I look at the raw CSS files on this server, they match what is on my box: https://bugs.koha-community.org/bugzilla3/skins/contrib/KohaV2/global.css Could be the cache? On my bugzilla box, I have a cronjob running every 60 seconds: find /srv/www/bugzilla.llownd.net/bugzilla5/data/assets -name '*.css' -delete -print find /srv/www/bugzilla.llownd.net/bugzilla5/data/assets -name '*.js' -delete -print Maybe a similar task needs running on this server? Of course, check there is nothing essential in that directory first! Thanks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36424] Database update 22.06.00.078 breaks update process (II)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #4 from Pedro Amorim --- (In reply to Pablo AB from comment #3) > @Pedro, after ~8', the output of search_for_data_inconsistencies.pl was: > > ``` > == Items do not have itype defined == > * Item with itemnumber=39024 does not have a itype value, > additionally no item type defined for biblionumber=22362 > [7 similar lines] > => The system preference item-level_itypes expects item types to be defined > at item level > ``` > > Are you sure this version should have `audit_database.pl`? Is not there. > > BTW, `perldoc search_for_data_inconsistencies.pl` return a malformed output. You're right, apologies. audit_database.pl was added by bug 34064 in version 23.11, although you likely would be able to backport it for this specific use case. Looking at 220600078.pl, what you could do, before upgrading, is manually check the output of SHOW CREATE TABLE reserves; SHOW CREATE TABLE old_reserves; SHOW CREATE TABLE item_groups; and compare that with what's in kohastructure.sql. This may provide some clues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36098] Create Koha::Session module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36098 --- Comment #23 from Frédéric Demians --- Backported to 22.11.x for 22.11.16 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755 --- Comment #49 from Frédéric Demians --- Backported to 22.11.x for 22.11.16 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36197] Allow for OPAC unauthenticated ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim changed: What|Removed |Added Depends on||35604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 [Bug 35604] ILL - Allow for automatic backend selection -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 Pedro Amorim changed: What|Removed |Added Blocks||36197 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 [Bug 36197] Allow for OPAC unauthenticated ILL request -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 Pedro Amorim changed: What|Removed |Added URL||https://github.com/PTFS-Eur ||ope/koha/tree/bug_35604 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36501] New: purchase suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36501 Bug ID: 36501 Summary: purchase suggestions Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.dru...@gmail.com Reporter: sistemak.media...@tabakalera.eus Hello, We have instaled Koha 23.05 and I am realized that the patrons can´t follow their purchase suggestions from the Opac. It can make a suggestions but yhen the user can´t follow from the Opac profile the state of the suggestion. Do anybody know something about that? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33849] Duplicate patron warning resets borrowers branch if different than logged in user's branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33849 --- Comment #3 from Emmi Takkinen --- Did some digging, code comes from bug 6116. Patch says: >When adding a patron who is a child, the default library is not set when >defining a guarantor, this patch corrects the problem. >More, for children with no guarantors, the default branch is the >editing branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36495] Add resource_not_found() and resource_deleted() helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495
--- Comment #7 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #6)
> Yes I agree with Martin, we should adjust "Object".
> I think we shouldn't use the generic "Object" term. For GET
> /patrons/{patron_id}/holds/{hold_id} we certainly want to see the difference
> between "Patron not found" and "Hold not found".
I didn't do it right away so we could discuss it on the dev meeting. I agree we
should make them specific. Not sure if it would be an issue that we expose the
non existence of a (patron?) id this way. But as we are using ->search_limited,
that should be covered (i.e. the consumer wouldn't know what makes is 'not
exist').
Side note: I picked 'Resource' instead of object for the fallback case :-P.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33849] Duplicate patron warning resets borrowers branch if different than logged in user's branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33849 --- Comment #4 from Emmi Takkinen --- (In reply to Emmi Takkinen from comment #3) > Did some digging, code comes from bug 6116. Patch says: > > >When adding a patron who is a child, the default library is not set when > >defining a guarantor, this patch corrects the problem. > >More, for children with no guarantors, the default branch is the > >editing branch. Actually, it's not this, it's bug 1164. " Fix for bug 1164, child branch not defaulting to guarantor's on add child". It probably fixes the original issue it was supposed to fix, but this definitely causes issues with other patron categories. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36492] memcached: Unclear where the pid file of memcached should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36492 --- Comment #1 from Marcel de Rooy --- Changing the conf file is not the complete answer. Actually this fix from https://github.com/saz/puppet-memcached/issues/27 does it the other way around: mkdir /var/run/memcached chown memcache:memcache /var/run/memcached memcached.conf should (still) contain: -P /var/run/memcached/memcached.pid What happens now when stopping and starting? (Note that /etc/init.d/memcached stop does not work! Try: start-stop-daemon --stop --quiet --oknodo --retry 5 --name memcached) In var/run: -rw-r--r-- 1 rootroot 5 Apr 3 13:24 memcached.pid In var/run/memcached: -rw-r--r-- 1 memcache memcache 6 Apr 3 13:24 memcached.pid Both files contain the same PID but the latter one contains a newline too. A new stop/start will create new pid files. No warnings anymore. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi --- Comment #68 from Emmi Takkinen --- I'm currently facing problem with patron search in current master. There is an error in browsers console > Uncaught ReferenceError: defer_loading is not defined It seems last patch here is actually missing the variable defer_loading. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36502] New: Independent branches should not prevent holds if canreservefromotherbranches is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 Bug ID: 36502 Summary: Independent branches should not prevent holds if canreservefromotherbranches is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: laura.escami...@bywatersolutions.com Reporter: laura.escami...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Libraries with IndependentBranches enabled would still like to place holds on items from other branches if they have canreservefromotherbranches enabled as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36501] purchase suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36501 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24879] Add missing authentication checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24879 Fridolin Somers changed: What|Removed |Added Group|Koha security | QA Contact||testo...@bugs.koha-communit ||y.org Component|Koha|Architecture, internals, ||and plumbing Product|Koha security |Koha Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35960] XSS in staff login form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35960 Fridolin Somers changed: What|Removed |Added Product|Koha security |Koha Version|unspecified |master QA Contact||testo...@bugs.koha-communit ||y.org Component|Koha|Architecture, internals, ||and plumbing Group|Koha security | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36244] Template toolkit syntax not escaped in letter templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36244 Fridolin Somers changed: What|Removed |Added QA Contact||testo...@bugs.koha-communit ||y.org Product|Koha security |Koha Group|Koha security | Version|unspecified |master Component|Koha|Architecture, internals, ||and plumbing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
