[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master, along with follow-ups to update a couple new calls to output_pref() and to improve the POD. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Galen Charlton changed: What|Removed |Added Keywords||rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 --- Comment #8 from Jonathan Druart --- Created attachment 20906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20906&action=edit Bug 10380: Followup Change prototype for output_pref routine Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 --- Comment #7 from Jonathan Druart --- Galen, should I switch this report to 'Passed QA'? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 --- Comment #6 from Jonathan Druart --- (In reply to Galen Charlton from comment #5) > Setting to "In discussion" pending the patch submitter answering the > question I posed in comment 4. Oops sorry Galen, I did not see it! dt is an abbreviation for datetime, not date. So I don't think "date" is an appropriate name. However we could choose "datetime" instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Galen Charlton changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #5 from Galen Charlton --- Setting to "In discussion" pending the patch submitter answering the question I posed in comment 4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380
--- Comment #4 from Galen Charlton ---
(In reply to comment #1)
> This patch changes it prototype to
> output_pref({
> dt => $dt,
If we switch to named parameters, we may as well avoid over-abbreviating.
Would there be any objection to a followup that renames 'dt' to 'date'?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380
Kyle M Hall changed:
What|Removed |Added
Attachment #18597|0 |1
is obsolete||
--- Comment #3 from Kyle M Hall ---
Created attachment 19188
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19188&action=edit
Bug 10380: Change prototype for output_pref routine
Koha::DateUtils::output_pref takes 4 parameters and the last one is a
boolean, so some calls are:
output_pref($dt, undef, undef, 1)
This patch changes it prototype to
output_pref({
dt => $dt,
dateformat => $dateformat,
timeformat => $timeformat,
dateonly => $boolean
});
an alternative is to call the output_pref routine with a datetime
object, without using an hashref:
output_pref($dt);
Signed-off-by: Srdjan
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380
Srdjan Jankovic changed:
What|Removed |Added
Attachment #18517|0 |1
is obsolete||
--- Comment #2 from Srdjan Jankovic ---
Created attachment 18597
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18597&action=edit
[SIGNED-OFF] Bug 10380: Change prototype for output_pref routine
Koha::DateUtils::output_pref takes 4 parameters and the last one is a
boolean, so some calls are:
output_pref($dt, undef, undef, 1)
This patch changes it prototype to
output_pref({
dt => $dt,
dateformat => $dateformat,
timeformat => $timeformat,
dateonly => $boolean
});
an alternative is to call the output_pref routine with a datetime
object, without using an hashref:
output_pref($dt);
Signed-off-by: Srdjan
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380
--- Comment #1 from Jonathan Druart ---
Created attachment 18517
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18517&action=edit
Bug 10380: Change prototype for output_pref routine
Koha::DateUtils::output_pref takes 4 parameters and the last one is a
boolean, so some calls are:
output_pref($dt, undef, undef, 1)
This patch changes it prototype to
output_pref({
dt => $dt,
dateformat => $dateformat,
timeformat => $timeformat,
dateonly => $boolean
});
an alternative is to call the output_pref routine with a datetime
object, without using an hashref:
output_pref($dt);
Test plan:
Go on some page where dates are displayed (circulation, laterorder,
member page, etc.).
Launch the unit tests file t/DateUtils.t.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
