[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #245 from Tomás Cohen Arazi  ---
(In reply to Tomás Cohen Arazi from comment #244)
> Feature pushed to master.
> 
> Good job Jonatahn! and thanks Maurice for the followup.

Jonathan and Julian :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #244 from Tomás Cohen Arazi  ---
Feature pushed to master.

Good job Jonatahn! and thanks Maurice for the followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #243 from Tomás Cohen Arazi  ---
Created attachment 43076
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43076=edit
Bug 10855: (RM followup) DBIx update

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #241 from Jonathan Druart  
---
Created attachment 42333
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42333=edit
Bug 10855: (follow-up) Bug 10855: Remove additional field values when
subscription is removed

The subscriptionid should not be escaped and placeholders used.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #242 from Jonathan Druart  
---
Back in the RM queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42310|0   |1
is obsolete||

--- Comment #240 from Jonathan Druart  
---
Created attachment 42332
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42332=edit
Bug 10855: Remove additional field values when subscription is removed

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38555|0   |1
is obsolete||

--- Comment #232 from Julian Maurice  ---
Created attachment 42303
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42303=edit
Bug 10855: Squash several fixes

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38556|0   |1
is obsolete||

--- Comment #233 from Julian Maurice  ---
Created attachment 42304
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42304=edit
Bug 10855: Fix QA issues

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38553|0   |1
is obsolete||

--- Comment #230 from Julian Maurice  ---
Created attachment 42301
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42301=edit
Bug 10855: Search subscriptions by additional fields

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38552|0   |1
is obsolete||

--- Comment #229 from Julian Maurice  ---
Created attachment 42300
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42300=edit
Bug 10855: New fields on adding/updating a subscription

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #225 from Julian Maurice  ---
Created attachment 42296
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42296=edit
Bug 10855: Remove additional field values when subscription is removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38551|0   |1
is obsolete||

--- Comment #228 from Julian Maurice  ---
Created attachment 42299
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42299=edit
Bug 10855: interface configuration for adding new fields to subscriptions

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38550|0   |1
is obsolete||

--- Comment #227 from Julian Maurice  ---
Created attachment 42298
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42298=edit
Bug 10855: Add unit tests for the new package Koha::AdditionalField

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38549|0   |1
is obsolete||

--- Comment #226 from Julian Maurice  ---
Created attachment 42297
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42297=edit
Bug 10855: Add the new package Koha::AdditionalField

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38554|0   |1
is obsolete||

--- Comment #231 from Julian Maurice  ---
Created attachment 42302
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42302=edit
Bug 10855: Search subscriptions by additional fields on the claim page

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38561|0   |1
is obsolete||

--- Comment #238 from Julian Maurice  ---
Created attachment 42309
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42309=edit
Bug 10855: Update database entry

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38558|0   |1
is obsolete||

--- Comment #235 from Julian Maurice  ---
Created attachment 42306
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42306=edit
Bug 10855: Additional marc fields are not inserted

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38557|0   |1
is obsolete||

--- Comment #234 from Julian Maurice  ---
Created attachment 42305
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42305=edit
Bug 10855: search with exact match if linked to an AV

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38560|0   |1
is obsolete||

--- Comment #237 from Julian Maurice  ---
Created attachment 42308
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42308=edit
Bug 10855: (follow-up) Search subscriptions by additional fields

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #42296|0   |1
is obsolete||

--- Comment #239 from Julian Maurice  ---
Created attachment 42310
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42310=edit
Bug 10855: Remove additional field values when subscription is removed

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

   What|Removed |Added

  Attachment #38559|0   |1
is obsolete||

--- Comment #236 from Julian Maurice  ---
Created attachment 42307
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42307=edit
Bug 10855: Make tests to pass

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
   Assignee|jonathan.dru...@bugs.koha-c |julian.maur...@biblibre.com
   |ommunity.org|

--- Comment #224 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Julian, there is a bug here.
The additional_field_values entries are not deleted when a subscription is
deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855
Bug 10855 depends on bug 11944, which changed state.

Bug 11944 Summary: Cleanup Koha UTF-8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #223 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
(In reply to Nicole C. Engard from comment #222)

The query works for me, maybe you was using an old patchset?
With the last patches, the correct collation (utf8_unicode_ci) is used for the
new tables.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #222 from Nicole C. Engard neng...@gmail.com ---
There is a problem here - if you query these new tables and some of the old
tables you get an error :


ERROR 1267 (HY000): Illegal mix of collations (utf8_unicode_ci,IMPLICIT) and
(utf8_general_ci,IMPLICIT) for operation '='


Here's the query - we should probably fix the collation on the new table and/or
the old tables.


select s.subscriptionid, b.title 
from serial s 
left join biblio b using (biblionumber) 
left join additional_field_values d on (d.record_id=s.subscriptionid) 
left join authorised_values v on (d.value=v.authorised_value)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36364|0   |1
is obsolete||

--- Comment #211 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38551
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38551action=edit
Bug 10855: interface configuration for adding new fields to subscriptions

This patch adds an interface configuration for adding fields to
subscriptions.

Test plan:
- go to serials/serials-home.pl
- click on the Add subscription fields link on the left of the screen
- try to add/update/delete new fields
You are not abble to add a field with an authorised value category and a
marcfield. Columns are sortable
- for the rest, you should have, at least:
  * a new field named af1, sortable, linked to a category
  * a new field named af2, sortable, linked to a marcfield
  * a new field named af3, not sortable

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36366|0   |1
is obsolete||

--- Comment #213 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38553
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38553action=edit
Bug 10855: Search subscriptions by additional fields

Now you will abble to search subscriptions by additional fields.
The additional field values will be displayed in the table results.

Test plan:
- go on the subscriptions advanced search page
  (serials/serials-search.pl).
- verify all searchable additional fields are displayed on the form.
- combine 1 or more values and verify results are consistent.
- verify the values are displayed in new columns of the table.
- for field linked to an authorised value category, the description is
  displayed (not the code).

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36367|0   |1
is obsolete||

--- Comment #214 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38554
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38554action=edit
Bug 10855: Search subscriptions by additional fields on the claim page

Test plan:
- create some serials in late.
- go on serials/claims.pl.
- choose a vendor.
- verify that additional fields are displayed in new columns.
- try filters on columns.
- verify there is no regression on this page.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36368|0   |1
is obsolete||

--- Comment #215 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38555
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38555action=edit
Bug 10855: Squash several fixes

Bug 10855: FIX: Add additional fields for closed subscriptions

Bug 10855: Fix instance vs static method

This patch fixes the error message.
The 3 modified routines *are* static methods.

Bug 10855: FIX conflicts with bug 7688

Bug 10855: Fix typo addition_fields - additional_fields

Bug 10855: A partial search should return the subscriptions

If a search on an additional fields is done using a partial string
(foo and the defined value is foobar), the subscription should
appear in the result list.

Test plan:
Try to search a part of the string for an additional field.

Bug 10855: Filtering on additional fields don't work if value is equal to 0

If you tried to filter on an additional field linked to an authorised
value, that did not work if the value was 0.

Bug 10855: Remove the advanced serial search box on the serial home page

Bug 10855: FIX an add field should not be created if the marc field does not
exist.

This patch fixes the following:
Create an add fields linked to a nonexistent marc field (does not exist
in serials).
Edit a subscription and save.
Without this patch, an error occured:
Software error:
DBD::mysql::db do failed: Column 'value' cannot be null at
/var/root-koha/bug-10855/Koha/AdditionalField.pm line 107.

Bug 10855: Fix Type table vs tablename

Koha::AdditionalField-all method take tablename not table in
parameter.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36363|0   |1
is obsolete||

--- Comment #210 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38550
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38550action=edit
Bug 10855: Add unit tests for the new package Koha::AdditionalField

Test plan:
- prove t/db_dependent/AdditionalField.t

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36369|0   |1
is obsolete||

--- Comment #216 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38556
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38556action=edit
Bug 10855: Fix QA issues

This patch fixes the following QA issues:

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
  FAIL   forbidden patterns
   forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug
10626) (line 2)

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
  FAIL   forbidden patterns
   forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug
10626) (line 2)

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
  FAIL   forbidden patterns
   forbidden pattern: To include datatables files, please use the include
file (see bug 10868) (line 12)

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36362|0   |1
is obsolete||

--- Comment #209 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38549
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38549action=edit
Bug 10855: Add the new package Koha::AdditionalField

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36365|0   |1
is obsolete||

--- Comment #212 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38552
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38552action=edit
Bug 10855: New fields on adding/updating a subscription

This patch adds the ability to add values for additional fields when
adding/updating a subscription.

Test plan (test the following on adding a new subscription and on
editing an existent one):
- add/edit a subscription.
- verify all additional fields appears into the Additional fields
  block.
- fill a value for af1 and af3.
- fill others values if you are adding a new subscription.
- save.
- verify values appears on the detail of the subscription page.
- verify the af2 field is automatically filled with the specified
  marc field of the notice.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36374|0   |1
is obsolete||

--- Comment #221 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38561
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38561action=edit
Bug 10855: Update database entry

Add 2 tables: additional_fields and additional_field_values

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36372|0   |1
is obsolete||

--- Comment #219 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38559
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38559action=edit
Bug 10855: Make tests to pass

Some recent changes in master make these tests fail.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36371|0   |1
is obsolete||

--- Comment #218 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38558
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38558action=edit
Bug 10855: Additional marc fields are not inserted

In subscription-add.pl, the code for inserting additional_fields is not
the same for updating and inserting.
This patch refactores this code in code to do the same tests.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36370|0   |1
is obsolete||

--- Comment #217 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38557
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38557action=edit
Bug 10855: search with exact match if linked to an AV

If a field is linked to an AV, the search should be an exact match.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36373|0   |1
is obsolete||

--- Comment #220 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38560
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38560action=edit
Bug 10855: (follow-up) Search subscriptions by additional fields

1 occurrence of KohaAuthorisedValues had not been replaced with
AuthorisedValues on fixing a previous conflict.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Signed Off  |Failed QA

--- Comment #194 from Brendan Gallagher bren...@bywatersolutions.com ---
Jonathan - 

updatabase just needs a quick rebase.  

Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Failed to merge in the changes.
Patch failed at 0001 Bug 10855: Update database entry

Thanks - Then I can test/qa.

-Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35369|0   |1
is obsolete||

--- Comment #207 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36373
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36373action=edit
Bug 10855: (follow-up) Search subscriptions by additional fields

1 occurrence of KohaAuthorisedValues had not been replaced with
AuthorisedValues on fixing a previous conflict.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35221|0   |1
is obsolete||

--- Comment #205 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36371
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36371action=edit
Bug 10855: Additional marc fields are not inserted

In subscription-add.pl, the code for inserting additional_fields is not
the same for updating and inserting.
This patch refactores this code in code to do the same tests.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35220|0   |1
is obsolete||

--- Comment #204 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36370
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36370action=edit
Bug 10855: search with exact match if linked to an AV

If a field is linked to an AV, the search should be an exact match.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36359|0   |1
is obsolete||

--- Comment #208 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36374
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36374action=edit
Bug 10855: Update database entry

Add 2 tables: additional_fields and additional_field_values

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35309|0   |1
is obsolete||

--- Comment #206 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36372
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36372action=edit
Bug 10855: Make tests to pass

Some recent changes in master make these tests fail.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35218|0   |1
is obsolete||

--- Comment #203 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36369
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36369action=edit
Bug 10855: Fix QA issues

This patch fixes the following QA issues:

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
  FAIL   forbidden patterns
   forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug
10626) (line 2)

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
  FAIL   forbidden patterns
   forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug
10626) (line 2)

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
  FAIL   forbidden patterns
   forbidden pattern: To include datatables files, please use the include
file (see bug 10868) (line 12)

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35215|0   |1
is obsolete||

--- Comment #200 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36366
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36366action=edit
Bug 10855: Search subscriptions by additional fields

Now you will abble to search subscriptions by additional fields.
The additional field values will be displayed in the table results.

Test plan:
- go on the subscriptions advanced search page
  (serials/serials-search.pl).
- verify all searchable additional fields are displayed on the form.
- combine 1 or more values and verify results are consistent.
- verify the values are displayed in new columns of the table.
- for field linked to an authorised value category, the description is
  displayed (not the code).

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35212|0   |1
is obsolete||

--- Comment #197 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36363
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36363action=edit
Bug 10855: Add unit tests for the new package Koha::AdditionalField

Test plan:
- prove t/db_dependent/AdditionalField.t

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35217|0   |1
is obsolete||

--- Comment #202 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36368
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36368action=edit
Bug 10855: Squash several fixes

Bug 10855: FIX: Add additional fields for closed subscriptions

Bug 10855: Fix instance vs static method

This patch fixes the error message.
The 3 modified routines *are* static methods.

Bug 10855: FIX conflicts with bug 7688

Bug 10855: Fix typo addition_fields - additional_fields

Bug 10855: A partial search should return the subscriptions

If a search on an additional fields is done using a partial string
(foo and the defined value is foobar), the subscription should
appear in the result list.

Test plan:
Try to search a part of the string for an additional field.

Bug 10855: Filtering on additional fields don't work if value is equal to 0

If you tried to filter on an additional field linked to an authorised
value, that did not work if the value was 0.

Bug 10855: Remove the advanced serial search box on the serial home page

Bug 10855: FIX an add field should not be created if the marc field does not
exist.

This patch fixes the following:
Create an add fields linked to a nonexistent marc field (does not exist
in serials).
Edit a subscription and save.
Without this patch, an error occured:
Software error:
DBD::mysql::db do failed: Column 'value' cannot be null at
/var/root-koha/bug-10855/Koha/AdditionalField.pm line 107.

Bug 10855: Fix Type table vs tablename

Koha::AdditionalField-all method take tablename not table in
parameter.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35216|0   |1
is obsolete||

--- Comment #201 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36367
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36367action=edit
Bug 10855: Search subscriptions by additional fields on the claim page

Test plan:
- create some serials in late.
- go on serials/claims.pl.
- choose a vendor.
- verify that additional fields are displayed in new columns.
- try filters on columns.
- verify there is no regression on this page.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35211|0   |1
is obsolete||

--- Comment #196 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36362
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36362action=edit
Bug 10855: Add the new package Koha::AdditionalField

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35213|0   |1
is obsolete||

--- Comment #198 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36364
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36364action=edit
Bug 10855: interface configuration for adding new fields to subscriptions

This patch adds an interface configuration for adding fields to
subscriptions.

Test plan:
- go to serials/serials-home.pl
- click on the Add subscription fields link on the left of the screen
- try to add/update/delete new fields
You are not abble to add a field with an authorised value category and a
marcfield. Columns are sortable
- for the rest, you should have, at least:
  * a new field named af1, sortable, linked to a category
  * a new field named af2, sortable, linked to a marcfield
  * a new field named af3, not sortable

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35214|0   |1
is obsolete||

--- Comment #199 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36365
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36365action=edit
Bug 10855: New fields on adding/updating a subscription

This patch adds the ability to add values for additional fields when
adding/updating a subscription.

Test plan (test the following on adding a new subscription and on
editing an existent one):
- add/edit a subscription.
- verify all additional fields appears into the Additional fields
  block.
- fill a value for af1 and af3.
- fill others values if you are adding a new subscription.
- save.
- verify values appears on the detail of the subscription page.
- verify the af2 field is automatically filled with the specified
  marc field of the notice.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #35310|0   |1
is obsolete||

--- Comment #195 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 36359
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36359action=edit
Bug 10855: Update database entry

Add 2 tables: additional_fields and additional_field_values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on|13596   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #193 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Paola Rossi from comment #192)
 Created attachment 35556 [details]
 screen-sandbox-8
 
 Thanks, Jonathan.
 
 The incremental-filtering-of-diacritics error happens because
 rows in the table are shown even if the filtering values are not
 present for that row, in spite of disappear.
 This error occurs only in the filters at the bottom of the columns,
 not at the top Search filter (OK).
 
 The error occurs on master too (I used the sandbox 8): see the attached
 screen.

Outch, weird. Could you please open a new bug report for this problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #192 from Paola Rossi paola.ro...@cineca.it ---
Created attachment 35556
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35556action=edit
screen-sandbox-8

Thanks, Jonathan.

The incremental-filtering-of-diacritics error happens because
rows in the table are shown even if the filtering values are not
present for that row, in spite of disappear.
This error occurs only in the filters at the bottom of the columns,
not at the top Search filter (OK).

The error occurs on master too (I used the sandbox 8): see the attached screen.

In the filtering on sandbox, I've added the diacritics in any position of the
string value [i.e. in the middle of the value, at right, aso] one by one, and
each diacritic as the last input char for that column.

The error occurs only using this browser :
Firefox [version 35.0.1]

On the contrary these browsers are OK:
IE 11.0
Opera 12.16
Google Chrome 40.0

Being this error present in the master, it's not related to this bug 10855.
So this bug could be signed off in relation of this error.

About the 3 points at comment 190, I think that I can pass this patch to the
Sign off status.

[I only attach the screen.]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #190 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Paola Rossi from comment #189)

Hello Paola,

Thanks for this complete feedback :)

  FILTERING
 No limitation happened in the resulting table in 30 seconds (ERROR).
 After 30 sec, I added ò at the right of the value, so I was
 incrementally filtering by perioàò.
 No limitation happened in the resulting table in 30 seconds (ERROR).

1 sec should be enough, the results are filtered on client-side.
I am sorry but I don't reproduce your problem.
On the serial claims page (but tested also on the serials result page), I have
10 subscriptions, 3 of them have Psychologies as a value of an additional
field named testé.
If I enter Psycho in the filter, I got the 3 (OK).
If I enter Psychoé, Psychoà or whatever different of Psychol, the table
displays no result.

 NB1
 (A) categories names [not the limited AVs' drop down list, like manual says]
 are shown among search fields on the left on searching subscriptions.
 
 IMO these branches-limited AV could also be displayed in the (A) drop down
 list (A), to be available to the selecting user.
 Assigning an attribute is not modifying/adding a value to a category. So IMO 
 the (B) drop down list could also be shown.
 In simple terms the limit in 3.18 manual would be updated from:
 To have it show
 to:
 A branch-limited AV is always shown to all libraries. To have it added and
 modified

Yes, I see what you meant.
I don't really know what is the behavior to have here, I would prefer to wait
for the QA step before submitting a new patch for that.
This point could be relevant.

 NB2. This patch is closely related to authorized valuescategories 
 [adding/modifying].
 http://manual.koha-community.org/3.18/en/basicparams.html#authorizedvalues
 point 232: Limit your Category to 10 characters  (something short to make
 it clear what the category is for)
 
 The user of this enhancement 10855 would probably be interested in using
 more 
 than 10 chars. This manual's warning limit might be increased.

The manual is right, for 3.18.
But since bug 13379 (pushed to master), authorised_values.category is a
varchar(32).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #191 from Jonathan Druart jonathan.dru...@biblibre.com ---
It would be great if you managed to reproduce the filtering issue on a sandbox
(and tell me which one you have used) or took a screenshot before and after you
filled the filter with the diacritic character.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #189 from Paola Rossi paola.ro...@cineca.it ---
Thanks, Jonathan.
I've applied the [13] patches against master 3.19.00.006 head 13526 (!).

As required in comment 172 [but I think that this step could also be added 
to the test plan in comment 171]
- try filters on columns.
a particular problem arose on FILTERING. See below.

Moreover, being this patch closely related to authorized values and categories, 
I was in doubt about the displaying of the branch-limited additional values, as 
it is described by 3.18 manual. I've provided a possible solution. Please 
see all in the NB.1 below.

I think that on FILTERING there can be an error.
For now I pass the patch in the Failed QA status.

If FILTERING is not an error, and displaying AV is not a problem, and no other 
follow up is needed, I can sign off this patch attaching the 13 patches as 
usual.

 FILTERING
RIGHT:
Some subscriptions had periodicals in a field of theirs. I've selected all of
 them in some way.
Filtering by perioa at once no subscription was expected to be selected.
It happened in 1 second (RIGHT) [subscriptions disappeared]
I cancelled all the filter value: all those subscriptions were expected to be 
selected.
It happened in 1 second (RIGHT) [subscriptions appeared again]
[Now there was no filter value]
Filtering by perioà at once [CTRL v] no subscription were expected to
selected.
It happened in 1 second (RIGHT).
RIGHT Incremental filtering:
Filtering by perio at once all those subscriptions were expected to be 
selected.
It happened (RIGHT): nothing changed in the table.
I added a at the right of the value, so I was incrementally filtering by
perioa.
No subscription were expected to selected.
It happened in 1 second (RIGHT).

ERROR: Incremental filtering by adding diacritics exited in ERROR:
Some subscriptions had periodicals in a field of theirs. I've selected all of 
them in some way.
Filtering by perio all subscriptions were filtered (OK, like above RIGHT).
I added à at the right of the value, so I was incrementally filtering by
perioà.
No limitation happened in the resulting table in 30 seconds (ERROR).
After 30 sec, I added ò at the right of the value, so I was incrementally
filtering by perioàò.
No limitation happened in the resulting table in 30 seconds (ERROR).

This error didn't happened adding incrementally to perio:
a Japanese (会) char, 
a number,
a Greek (γ) char.

This error occurred either on searching subscriptions' table or on serials 
claims' one.
 FILTERING's ERROR END

NB1. A special case of authorized values is about categories with 
branches-limited AV. See:
http://manual.koha-community.org/3.18/en/basicparams.html#authorizedvalues
At point 232, [3.18] manual says about their setting:
If you would like to limit this authorized value category to only specific 
libraries you can choose them from the 'Branches limitation' menu. To have it 
show for all libraries just choose 'All branches' at the top of the list.

This patch's behaviour about the branches-limited AVs was OK (RIGHT).
At my tests, patch is OK [=as plan require] on a category whose AVs are all
branch-limited, and 
also on a category whose AVs are a mixture of limited and not-limited.
As desired and required by this patch's test plans:
branches-limited AV are displayed on viewing a subscription,
(subscription-detail.pl)
(B) categories names [not the limited AVs' drop down list, like manual says]
are shown on editing a subscription (subscription-add.pl)
branches-limited AV are all displayed in the resulting tables,
branches-limited AV are all filter-able in the resulting tables,
(A) categories names [not the limited AVs' drop down list, like manual says]
are shown among search fields on the left on searching subscriptions.

IMO these branches-limited AV could also be displayed in the (A) drop down list
(A), to be available to the selecting user.
Assigning an attribute is not modifying/adding a value to a category. So IMO 
the (B) drop down list could also be shown.
In simple terms the limit in 3.18 manual would be updated from:
To have it show
to:
A branch-limited AV is always shown to all libraries. To have it added and
modified

Otherwise, if the current manual prevales, the part of this patch requiring to 
show AdVs could need to be reviewed. 
[Or Additional Values are not exactly a kind of Authorized Values.]

Anyway, now this sentence of the manual:
If you would like to limit this authorized value category to only specific
libraries you can choose them from the 'Branches limitation' menu.
appears a little generic to me, not enough to let understand the limit. 
The sentence could also be changed into:
If you would like to limit this 

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #187 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35369
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35369action=edit
Bug 10855: (follow-up) Search subscriptions by additional fields

1 occurrence of KohaAuthorisedValues had not been replaced with
AuthorisedValues on fixing a previous conflict.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #188 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Paola Rossi from comment #186)
 In the Close (X) tag the MARC additional fields of the subscriptions were
 displayed (RIGHT) whilst the category additional fields were not displayed
 (I think it was an ERROR).

Good catch!
This is fixed with the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Depends on||13596

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #183 from Paola Rossi paola.ro...@cineca.it ---
Thanks, Jonathan.

I've applied the 12 patches against master 3.19.00.006 head 12889.

In Comment 168:
Test plan:
- prove t/db_dependent/AdditionalField.t

OK!

In Comment 169:
Test plan:
- go to serials/serials-home.pl
- click on the Add subscription fields link on the left of the screen
- try to add/update/delete new fields

I've added a new field with no Authorised value category and no MARC field
[either searchable or not-searchable].

I think this is an error.

For now I pass the patch to Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #184 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Paola Rossi from comment #183)
 I've added a new field with no Authorised value category and no MARC field
 [either searchable or not-searchable].
 
 I think this is an error.

No, it is just a free text.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #185 from Paola Rossi paola.ro...@cineca.it ---
(In reply to Jonathan Druart from comment #184)
 (In reply to Paola Rossi from comment #183)
  I've added a new field with no Authorised value category and no MARC field
  [either searchable or not-searchable].
  
  I think this is an error.
 
 No, it is just a free text.

Thanks, Jonathan. So I turn back to Needs Signed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #186 from Paola Rossi paola.ro...@cineca.it ---
(In reply to Jonathan Druart from comment #171)
 Created attachment 35215 [details] [review]
 Bug 10855: Search subscriptions by additional fields
 
 Now you will abble to search subscriptions by additional fields.
 The additional field values will be displayed in the table results.
 
 Test plan:
 - go on the subscriptions advanced search page
   (serials/serials-search.pl).
 - verify all searchable additional fields are displayed on the form.
 - combine 1 or more values and verify results are consistent.
 - verify the values are displayed in new columns of the table.
 - for field linked to an authorised value category, the description is
   displayed (not the code).

I've applied the patches.

Everything was OK as required in the Open (X) tag (RIGHT).

In the Close (X) tag the MARC additional fields of the subscriptions were
displayed (RIGHT) whilst the category additional fields were not displayed (I
think it was an ERROR).

I pass the patch to Failed QA status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #181 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35309
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35309action=edit
Bug 10855: Make tests to pass

Some recent changes in master make these tests fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #35219|0   |1
is obsolete||

--- Comment #182 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35310
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35310action=edit
Bug 10855: Update database entry

Add 2 tables: additional_fields and additional_field_values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #179 from Paola Rossi paola.ro...@cineca.it ---
I've applied the 11 patches against master 3.19.00.006 head 12889

Then:
prove t/db_dependent/AdditionalField.t
t/db_dependent/AdditionalField.t .. 1/37 Undefined subroutine
C4::Bookseller::AddBookseller called at t/db_dependent/AdditionalField.t line
110.
# Looks like you planned 37 tests but ran 20.
# Looks like your test exited with 255 just after 20.
t/db_dependent/AdditionalField.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 17/37 subtests 

Test Summary Report
---
t/db_dependent/AdditionalField.t (Wstat: 65280 Tests: 20 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 37 tests but ran 20.
Files=1, Tests=20,  1 wallclock secs ( 0.00 usr  0.02 sys +  0.76 cusr  0.11
csys =  0.89 CPU)
Result: FAIL

So I pass the patch to Failed QA status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #180 from Paola Rossi paola.ro...@cineca.it ---
I add to my last comment (179):
NB. about the 9-th patch, the updated database has no COLLATE.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #170 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35214
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35214action=edit
Bug 10855: New fields on adding/updating a subscription

This patch adds the ability to add values for additional fields when
adding/updating a subscription.

Test plan (test the following on adding a new subscription and on
editing an existent one):
- add/edit a subscription.
- verify all additional fields appears into the Additional fields
  block.
- fill a value for af1 and af3.
- fill others values if you are adding a new subscription.
- save.
- verify values appears on the detail of the subscription page.
- verify the af2 field is automatically filled with the specified
  marc field of the notice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #173 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35217
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35217action=edit
Bug 10855: Squash several fixes

Bug 10855: FIX: Add additional fields for closed subscriptions

Bug 10855: Fix instance vs static method

This patch fixes the error message.
The 3 modified routines *are* static methods.

Bug 10855: FIX conflicts with bug 7688

Bug 10855: Fix typo addition_fields - additional_fields

Bug 10855: A partial search should return the subscriptions

If a search on an additional fields is done using a partial string
(foo and the defined value is foobar), the subscription should
appear in the result list.

Test plan:
Try to search a part of the string for an additional field.

Bug 10855: Filtering on additional fields don't work if value is equal to 0

If you tried to filter on an additional field linked to an authorised
value, that did not work if the value was 0.

Bug 10855: Remove the advanced serial search box on the serial home page

Bug 10855: FIX an add field should not be created if the marc field does not
exist.

This patch fixes the following:
Create an add fields linked to a nonexistent marc field (does not exist
in serials).
Edit a subscription and save.
Without this patch, an error occured:
Software error:
DBD::mysql::db do failed: Column 'value' cannot be null at
/var/root-koha/bug-10855/Koha/AdditionalField.pm line 107.

Bug 10855: Fix Type table vs tablename

Koha::AdditionalField-all method take tablename not table in
parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #172 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35216
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35216action=edit
Bug 10855: Search subscriptions by additional fields on the claim page

Test plan:
- create some serials in late.
- go on serials/claims.pl.
- choose a vendor.
- verify that additional fields are displayed in new columns.
- try filters on columns.
- verify there is no regression on this page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #175 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35219
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35219action=edit
Bug 10855: Update database entry

Add 2 tables: additional_fields and additional_field_values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #171 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35215
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35215action=edit
Bug 10855: Search subscriptions by additional fields

Now you will abble to search subscriptions by additional fields.
The additional field values will be displayed in the table results.

Test plan:
- go on the subscriptions advanced search page
  (serials/serials-search.pl).
- verify all searchable additional fields are displayed on the form.
- combine 1 or more values and verify results are consistent.
- verify the values are displayed in new columns of the table.
- for field linked to an authorised value category, the description is
  displayed (not the code).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #176 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35220
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35220action=edit
Bug 10855: search with exact match if linked to an AV

If a field is linked to an AV, the search should be an exact match.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #174 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35218
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35218action=edit
Bug 10855: Fix QA issues

This patch fixes the following QA issues:

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
  FAIL   forbidden patterns
   forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug
10626) (line 2)

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
  FAIL   forbidden patterns
   forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug
10626) (line 2)

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
  FAIL   forbidden patterns
   forbidden pattern: To include datatables files, please use the include
file (see bug 10868) (line 12)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #177 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35221
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35221action=edit
Bug 10855: Additional marc fields are not inserted

In subscription-add.pl, the code for inserting additional_fields is not
the same for updating and inserting.
This patch refactores this code in code to do the same tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28929|0   |1
is obsolete||
  Attachment #28930|0   |1
is obsolete||
  Attachment #28931|0   |1
is obsolete||
  Attachment #28932|0   |1
is obsolete||
  Attachment #28933|0   |1
is obsolete||
  Attachment #28934|0   |1
is obsolete||
  Attachment #28935|0   |1
is obsolete||
  Attachment #28936|0   |1
is obsolete||
  Attachment #28937|0   |1
is obsolete||
  Attachment #28938|0   |1
is obsolete||
  Attachment #28939|0   |1
is obsolete||
  Attachment #28940|0   |1
is obsolete||
  Attachment #28941|0   |1
is obsolete||
  Attachment #29161|0   |1
is obsolete||

--- Comment #167 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35211
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35211action=edit
Bug 10855: Add the new package Koha::AdditionalField

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #169 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35213
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35213action=edit
Bug 10855: interface configuration for adding new fields to subscriptions

This patch adds an interface configuration for adding fields to
subscriptions.

Test plan:
- go to serials/serials-home.pl
- click on the Add subscription fields link on the left of the screen
- try to add/update/delete new fields
You are not abble to add a field with an authorised value category and a
marcfield. Columns are sortable
- for the rest, you should have, at least:
  * a new field named af1, sortable, linked to a category
  * a new field named af2, sortable, linked to a marcfield
  * a new field named af3, not sortable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #168 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35212
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35212action=edit
Bug 10855: Add unit tests for the new package Koha::AdditionalField

Test plan:
- prove t/db_dependent/AdditionalField.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

--- Comment #178 from Jonathan Druart jonathan.dru...@biblibre.com ---
Back to needs signoff for even more fun :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Depends on|13239   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Depends on||13239

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |BLOCKED
 Depends on||11944

--- Comment #166 from Jonathan Druart jonathan.dru...@biblibre.com ---
Hello Paola,
Thanks for testing and for your patience, but I don't manage to retest this
development every time I rebase it.
I would prefer to see bug 11944 pushed before continuing here.
I mark this enh blocked by 11944.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #164 from Paola Rossi paola.ro...@cineca.it ---

Thanks, Jonathan. Now the problem in comment 161 is OK.

I've applied against master 3.17.00.008

A) In the result table of closed subscriptions, on advanced search, the
category additional fields are not shown.

B) In the advanced search, in the result table of open SS, the name Routing
list is posed on the wrong column, at the left of the column about routing
lists.

C) updatedatabase needs to be updated from DBversion 3.15.00.XXX.

So I've passed the patch to Failed QA status.

Note-1. If the additional fields are a lot, the table is very large.
Some columns, such as ISSN, don't need so much width.
Perhaps the functions (reopen, new, serial receive, issue history, ...) would
be better seen at the left part of the rows.

Note-2 Multiple occurrences of a MARC subfield: The patch filles Additional
MARC fields with 1 subfield only
2-1: on repeatable MARC fields:
I've create a subscription about a biblio whose 650 is triple; 650$v is present
in all the three occurrences of 650.
I've added an additional MARC field linked to 650$v.
The field of the subscription is only filled with one occurrence of the 3 650$v
subfields.

2.2: on repeated subfields in a MARC field:
I've create a subscription about a biblio with one 650 and two 650$x in it.
I've added an additional MARC field linked to 650$x.
The field of the subscription is only filled with the first occurrence of the 2
650$x subfields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #165 from Paola Rossi paola.ro...@cineca.it ---
I beg your pardon, and add a further 3-rd note at comment 164.

Note-3: On claims, Send notification has sent nothing.
But it has happened on master too.
So I've not been able to test a good regression of the Send notification.
On the contrary, testing Download selected claims has been OK.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #29095|0   |1
is obsolete||

--- Comment #162 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29161
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29161action=edit
Bug 10855: FIX bad merge conflicts

This patch fixes a bad merge conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #163 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Paola Rossi from comment #161)
 The problem was fixed in the table results of the open subscriptions, 
 but not in the table results of the closed ones, same page.

Arg, sorry. That should be fixed now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/