[Koha-bugs] [Bug 18900] Wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Bug 18900 depends on bug 18471, which changed state. Bug 18471 Summary: Receiving order with unitprice greater than 1000 processing incorrectly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] Wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Bug 18900 depends on bug 18471, which changed state. Bug 18471 Summary: Receiving order with unitprice greater than 1000 processing incorrectly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 What|Removed |Added Status|CLOSED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] Wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERSchanged: What|Removed |Added CC||victor.grous...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] Wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Katrin Fischerchanged: What|Removed |Added Summary|wrong number format in |Wrong number format in |receiving order |receiving order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Mason Jameschanged: What|Removed |Added CC||m...@kohaaloha.com --- Comment #16 from Mason James --- Pushed to 16.05.x, for 16.05.17 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 --- Comment #15 from Katrin Fischer--- These patches have been pushed to 16.11.x and will be in 16.11.12. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERSchanged: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #14 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.04. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Tomás Cohen Arazichanged: What|Removed |Added Attachment #65628|0 |1 is obsolete|| --- Comment #12 from Tomás Cohen Arazi --- Created attachment 65761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65761=edit Bug 18900: wrong number format in receiving order Bug 18471 added number formating in order receive. I found a bug generated by this. Koha::Number::Price defines methods to (un)format price depending on CurrencyFormat syspref. The bug is that for CurrencyFormat US, some params are not defined in this module so there are retrieved from system locale. If system locale is not en_US, the params will be wrong. For example fr_FR will define ',' as decimal and so saved unit price is divided by 1000. To recreate: - On a server with locale 'fr_FR' - With Plack mode - Set CurrencyFormat on 'US' - Open a basket - Place an order for an item - Close basket - Receive order with changing 'Actual Cost' to '1,234' - Note the 'Actual Cost' is now '1.23' - Run unit test t/Number/Price.t without and with patch Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 --- Comment #11 from Tomás Cohen Arazi--- Created attachment 65760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65760=edit Bug 18900: (QA followup) Make tests conditional to locale existence It is important to highlight that tests have been skipped instead of having them pass on the absence of the required fr_FR.UTF-8 locale installed on the system. This patch does that check and effectively skips them. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Tomás Cohen Arazichanged: What|Removed |Added Attachment #65627|0 |1 is obsolete|| --- Comment #10 from Tomás Cohen Arazi --- Created attachment 65759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65759=edit Bug 18900: add UT to Number/Price.t This patch adds unit tests to t/Number/Price.t in order to valid the problem. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 --- Comment #9 from Katrin Fischer--- Tests pass ok, no regressions found. We also have seen some strange phenomenons with prices and Plack, this might help in other cases too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 --- Comment #8 from Katrin Fischer--- Created attachment 65628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65628=edit [SIGNED OFF] Bug 18900 - wrong number format in receiving order Bug 18471 added number formating in order receive. I found a bug generated by this. Koha::Number::Price defines methods to (un)format price depending on CurrencyFormat syspref. The bug is that for CurrencyFormat US, some params are not defined in this module so there are retrieved from system locale. If system locale is not en_US, the params will be wrong. For example fr_FR will define ',' as decimal and so saved unit price is divided by 1000. To recreate: - On a server with locale 'fr_FR' - With Plack mode - Set CurrencyFormat on 'US' - Open a basket - Place an order for an item - Close basket - Receive order with changing 'Actual Cost' to '1,234' - Note the 'Actual Cost' is now '1.23' - Run unit test t/Number/Price.t without and with patch Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Katrin Fischerchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Katrin Fischerchanged: What|Removed |Added Attachment #64839|0 |1 is obsolete|| Attachment #64840|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 65627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65627=edit [SIGNED OFF] Bug 18900 - add UT to Number/Price.t This patch adds unit tests to t/Number/Price.t in order to valid the problem. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Baptistechanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18186 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- Hi Fridolin, we also had some bad luck with Plack and amounts - see bug 18186! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERSchanged: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERSchanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 --- Comment #5 from Fridolin SOMERS--- Created attachment 64840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64840=edit Bug 18900 - wrong number format in receiving order Bug 18471 added number formating in order receive. I found a bug generated by this. Koha::Number::Price defines methods to (un)format price depending on CurrencyFormat syspref. The bug is that for CurrencyFormat US, some params are not defined in this module so there are retrieved from system locale. If system locale is not en_US, the params will be wrong. For example fr_FR will define ',' as decimal and so saved unit price is divided by 1000. To recreate: - On a server with locale 'fr_FR' - With Plack mode - Set CurrencyFormat on 'US' - Open a basket - Place an order for an item - Close basket - Receive order with changing 'Actual Cost' to '1,234' - Note the 'Actual Cost' is now '1.23' - Run unit test t/Number/Price.t without and with patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18900] wrong number format in receiving order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERSchanged: What|Removed |Added Summary|Receiving order with|wrong number format in |unitprice multiples by 1000 |receiving order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/