[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Michaela Sieber changed: What|Removed |Added Blocks||34171 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34171 [Bug 34171] item_barcode_transform does not work when moving items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Blocks||31482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482 [Bug 31482] Label creator does not call item_barcode_transform plugin hook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Blocks||31252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252 [Bug 31252] Advanced search in staff interface should call barcodedecode if the search index is a barcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Blocks||31253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253 [Bug 31253] Item search in staff interface should call barcodedecode if the search index is a barcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Bug 26351 depends on bug 28026, which changed state. Bug 28026 Summary: Add a 'call_recursive' method to Koha::Plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Bug 26351 depends on bug 27526, which changed state. Bug 27526 Summary: Remove Mod/AddItemFromMarc from additem.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #108 from Fridolin Somers --- This is great. I've edited "First version" in https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29114 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #107 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #106 from Kyle M Hall --- (In reply to Jonathan Druart from comment #105) > I've squashed all the patches (the diff is much more easier to read!) and > rebased it on top of bug 27526. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added Depends on||27526 --- Comment #105 from Jonathan Druart --- I've squashed all the patches (the diff is much more easier to read!) and rebased it on top of bug 27526. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added Attachment #124258|0 |1 is obsolete|| Attachment #124259|0 |1 is obsolete|| Attachment #124260|0 |1 is obsolete|| Attachment #124261|0 |1 is obsolete|| Attachment #124262|0 |1 is obsolete|| Attachment #124263|0 |1 is obsolete|| Attachment #124264|0 |1 is obsolete|| Attachment #124265|0 |1 is obsolete|| Attachment #124266|0 |1 is obsolete|| Attachment #124313|0 |1 is obsolete|| Attachment #125447|0 |1 is obsolete|| Attachment #125763|0 |1 is obsolete|| Attachment #125764|0 |1 is obsolete|| --- Comment #104 from Jonathan Druart --- Created attachment 125765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125765=edit Bug 26351: Add plugin hooks to transform item barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the item barcode field on the checkin and checkout pages, and anywhere else you can scan an item barcode, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Note the letters are removed by Koha! Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize Bug 26351: (QA follow-up) Fix QA script issue * Fixes issue with barcode generate stub so perlcritic is happy * Removes extra semicolon from return call in configure method Signed-off-by: Martin Renvoize Bug 26351: Add unit tests Signed-off-by: Martin Renvoize Bug 26351: (QA follow-up) Remove unused method barcode_transform Signed-off-by: Martin Renvoize Bug 26351: (QA follow-up) Rename barcode_transform to item_barcode_transform Signed-off-by: Martin Renvoize Bug 26351: (QA follow-up) Barcodes inputted into Koha should always pass though barcodedecode Signed-off-by: Martin Renvoize Bug 26351: (QA follow-up) Catch one last case of itemBarcodeInputFilter Signed-off-by: Martin Renvoize Bug 26351: (QA follow-up) Fix Checkouts.t Signed-off-by: Martin Renvoize Bug 26351: Use call_recursive() as a replacement for call() The method `call()` is not sufficient for barcode transformations. It's possible that more than one barcode transformation plugin will be installed. The `call_recursive()` method takes the output of the first plugin and uses it as the input for the next plugin and so on. This allowes each plugin to see the current version of the barcode and modify it if necessary. Signed-off-by: Martin Renvoize Bug 26351: Fix t/db_dependent/Koha/Plugins/Circulation_hooks.t Bug 26351: Revert improper change to unit test, fix number of tests Bug 26351: Remove uneeded use Koha::Plugins statements Left over from previous changes Bug 26351: Add missing barcodedecode import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #103 from Jonathan Druart --- Created attachment 125764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125764=edit Bug 26351: Add missing barcodedecode import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #102 from Jonathan Druart --- Created attachment 125763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125763=edit Bug 26351: Remove uneeded use Koha::Plugins statements Left over from previous changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #101 from Kyle M Hall --- Created attachment 125447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125447=edit Bug 26351: Revert improper change to unit test, fix number of tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #100 from Jonathan Druart --- Failing test: # Failed test 'Only four plugins found via a metadata tag' # at /kohadevbox/koha/t/db_dependent/Koha/Plugins/Plugins.t line 129. # got: '2' # expected: '4' # Looks like you failed 1 test of 2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #99 from Kyle M Hall --- Created attachment 124313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124313=edit Bug 26351: Fix t/db_dependent/Koha/Plugins/Circulation_hooks.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #98 from Jonathan Druart --- t/db_dependent/Koha/Plugins/Circulation_hooks.t is failing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #97 from Jonathan Druart --- Created attachment 124266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124266=edit Bug 26351: Use call_recursive() as a replacement for call() The method `call()` is not sufficient for barcode transformations. It's possible that more than one barcode transformation plugin will be installed. The `call_recursive()` method takes the output of the first plugin and uses it as the input for the next plugin and so on. This allowes each plugin to see the current version of the barcode and modify it if necessary. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #96 from Jonathan Druart --- Created attachment 124265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124265=edit Bug 26351: (QA follow-up) Fix Checkouts.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #95 from Jonathan Druart --- Created attachment 124264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124264=edit Bug 26351: (QA follow-up) Catch one last case of itemBarcodeInputFilter Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #94 from Jonathan Druart --- Created attachment 124263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124263=edit Bug 26351: (QA follow-up) Barcodes inputted into Koha should always pass though barcodedecode Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #93 from Jonathan Druart --- Created attachment 124262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124262=edit Bug 26351: (QA follow-up) Rename barcode_transform to item_barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #92 from Jonathan Druart --- Created attachment 124261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124261=edit Bug 26351: (QA follow-up) Remove unused method barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #91 from Jonathan Druart --- Created attachment 124260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124260=edit Bug 26351: Add unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #90 from Jonathan Druart --- Created attachment 124259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124259=edit Bug 26351: (QA follow-up) Fix QA script issue * Fixes issue with barcode generate stub so perlcritic is happy * Removes extra semicolon from return call in configure method Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added Attachment #122433|0 |1 is obsolete|| Attachment #122434|0 |1 is obsolete|| Attachment #122435|0 |1 is obsolete|| Attachment #122436|0 |1 is obsolete|| Attachment #122437|0 |1 is obsolete|| Attachment #122438|0 |1 is obsolete|| Attachment #122439|0 |1 is obsolete|| Attachment #122440|0 |1 is obsolete|| Attachment #122441|0 |1 is obsolete|| --- Comment #89 from Jonathan Druart --- Created attachment 124258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124258=edit Bug 26351: Add plugin hooks to transform item barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the item barcode field on the checkin and checkout pages, and anywhere else you can scan an item barcode, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Note the letters are removed by Koha! Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added Attachment #122442|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #88 from Jonathan Druart --- > Created attachment 122442 [details] [review] > Bug 26351: Clean up includes in Circulation.pm This patch does not belong here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Nick Clemens changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #87 from Kyle M Hall --- Created attachment 122442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122442=edit Bug 26351: Clean up includes in Circulation.pm Circulation.pm has so many includes that the same module is getting used multiple times without developers noticing it is already beuing used. This commit separates use lines by namespace and sorts them, removing duplicate and unnecessary use lines. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #86 from Kyle M Hall --- Created attachment 122441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122441=edit Bug 26351: Use call_recursive() as a replacement for call() The method `call()` is not sufficient for barcode transformations. It's possible that more than one barcode transformation plugin will be installed. The `call_recursive()` method takes the output of the first plugin and uses it as the input for the next plugin and so on. This allowes each plugin to see the current version of the barcode and modify it if necessary. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #85 from Kyle M Hall --- Created attachment 122440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122440=edit Bug 26351: (QA follow-up) Fix Checkouts.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #84 from Kyle M Hall --- Created attachment 122439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122439=edit Bug 26351: (QA follow-up) Catch one last case of itemBarcodeInputFilter Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #83 from Kyle M Hall --- Created attachment 122438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122438=edit Bug 26351: (QA follow-up) Barcodes inputted into Koha should always pass though barcodedecode Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #82 from Kyle M Hall --- Created attachment 122437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122437=edit Bug 26351: (QA follow-up) Rename barcode_transform to item_barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #81 from Kyle M Hall --- Created attachment 122436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122436=edit Bug 26351: (QA follow-up) Remove unused method barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #80 from Kyle M Hall --- Created attachment 122435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122435=edit Bug 26351: Add unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #79 from Kyle M Hall --- Created attachment 122434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122434=edit Bug 26351: (QA follow-up) Fix QA script issue * Fixes issue with barcode generate stub so perlcritic is happy * Removes extra semicolon from return call in configure method Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Attachment #118681|0 |1 is obsolete|| Attachment #118682|0 |1 is obsolete|| Attachment #118683|0 |1 is obsolete|| Attachment #118684|0 |1 is obsolete|| Attachment #118685|0 |1 is obsolete|| Attachment #118686|0 |1 is obsolete|| Attachment #118687|0 |1 is obsolete|| Attachment #118688|0 |1 is obsolete|| Attachment #118689|0 |1 is obsolete|| Attachment #118690|0 |1 is obsolete|| --- Comment #78 from Kyle M Hall --- Created attachment 122433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122433=edit Bug 26351: Add plugin hooks to transform item barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the item barcode field on the checkin and checkout pages, and anywhere else you can scan an item barcode, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Note the letters are removed by Koha! Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added Status|Passed QA |BLOCKED --- Comment #77 from Jonathan Druart --- Kyle, this is still blocked by bug 28026. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added Status|Passed QA |BLOCKED --- Comment #76 from Jonathan Druart --- Blocked by bug 28026. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #75 from Martin Renvoize --- Passed QA again.. as it all works well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #118657|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #118658|0 |1 is obsolete|| --- Comment #74 from Martin Renvoize --- Created attachment 118690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118690=edit Bug 26351: Clean up includes in Circulation.pm Circulation.pm has so many includes that the same module is getting used multiple times without developers noticing it is already beuing used. This commit separates use lines by namespace and sorts them, removing duplicate and unnecessary use lines. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #73 from Martin Renvoize --- Created attachment 118689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118689=edit Bug 26351: Use call_recursive() as a replacement for call() The method `call()` is not sufficient for barcode transformations. It's possible that more than one barcode transformation plugin will be installed. The `call_recursive()` method takes the output of the first plugin and uses it as the input for the next plugin and so on. This allowes each plugin to see the current version of the barcode and modify it if necessary. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #118656|0 |1 is obsolete|| --- Comment #72 from Martin Renvoize --- Created attachment 118688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118688=edit Bug 26351: (QA follow-up) Fix Checkouts.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #118655|0 |1 is obsolete|| --- Comment #71 from Martin Renvoize --- Created attachment 118687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118687=edit Bug 26351: (QA follow-up) Catch one last case of itemBarcodeInputFilter Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #118654|0 |1 is obsolete|| --- Comment #70 from Martin Renvoize --- Created attachment 118686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118686=edit Bug 26351: (QA follow-up) Barcodes inputted into Koha should always pass though barcodedecode Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #118653|0 |1 is obsolete|| --- Comment #69 from Martin Renvoize --- Created attachment 118685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118685=edit Bug 26351: (QA follow-up) Rename barcode_transform to item_barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #118652|0 |1 is obsolete|| --- Comment #68 from Martin Renvoize --- Created attachment 118684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118684=edit Bug 26351: (QA follow-up) Remove unused method barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #118651|0 |1 is obsolete|| --- Comment #67 from Martin Renvoize --- Created attachment 118683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118683=edit Bug 26351: Add unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #118650|0 |1 is obsolete|| --- Comment #66 from Martin Renvoize --- Created attachment 118682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118682=edit Bug 26351: (QA follow-up) Fix QA script issue * Fixes issue with barcode generate stub so perlcritic is happy * Removes extra semicolon from return call in configure method Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #118649|0 |1 is obsolete|| --- Comment #65 from Martin Renvoize --- Created attachment 118681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118681=edit Bug 26351: Add plugin hooks to transform item barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the item barcode field on the checkin and checkout pages, and anywhere else you can scan an item barcode, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Note the letters are removed by Koha! Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Depends on||28026 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 [Bug 28026] Add a 'call_recursive' method to Koha::Plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #64 from Kyle M Hall --- Created attachment 118658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118658=edit Bug 26351: Clean up includes in Circulation.pm Circulation.pm has so many includes that the same module is getting used multiple times without developers noticing it is already beuing used. This commit separates use lines by namespace and sorts them, removing duplicate and unnecessary use lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #63 from Kyle M Hall --- Created attachment 118657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118657=edit Bug 26351: Add call_recursive() as a replacement for call() The method call() is not sufficient for barcode transformations. It's possible that more than one barcode transformation plugin will be installed. call_recursive() takes the output of the first plugin and uses it as the input for the next plugin and so on. This allowes each plugin to see the current version of the barcode and modify it if necessary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #62 from Kyle M Hall --- Created attachment 118656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118656=edit Bug 26351: (QA follow-up) Fix Checkouts.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #61 from Kyle M Hall --- Created attachment 118655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118655=edit Bug 26351: (QA follow-up) Catch one last case of itemBarcodeInputFilter Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #60 from Kyle M Hall --- Created attachment 118654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118654=edit Bug 26351: (QA follow-up) Barcodes inputted into Koha should always pass though barcodedecode Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #59 from Kyle M Hall --- Created attachment 118653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118653=edit Bug 26351: (QA follow-up) Rename barcode_transform to item_barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #58 from Kyle M Hall --- Created attachment 118652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118652=edit Bug 26351: (QA follow-up) Remove unused method barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #57 from Kyle M Hall --- Created attachment 118651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118651=edit Bug 26351: Add unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #56 from Kyle M Hall --- Created attachment 118650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118650=edit Bug 26351: (QA follow-up) Fix QA script issue * Fixes issue with barcode generate stub so perlcritic is happy * Removes extra semicolon from return call in configure method Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Attachment #115172|0 |1 is obsolete|| Attachment #115173|0 |1 is obsolete|| Attachment #115174|0 |1 is obsolete|| Attachment #115175|0 |1 is obsolete|| Attachment #115176|0 |1 is obsolete|| Attachment #115177|0 |1 is obsolete|| Attachment #115178|0 |1 is obsolete|| Attachment #115179|0 |1 is obsolete|| Attachment #115180|0 |1 is obsolete|| --- Comment #55 from Kyle M Hall --- Created attachment 118649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118649=edit Bug 26351: Add plugin hooks to transform item barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the item barcode field on the checkin and checkout pages, and anywhere else you can scan an item barcode, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Note the letters are removed by Koha! Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #54 from Martin Renvoize --- I'm also not entirely sure about the final followup.. it feels like the intention of ->call is to loop through available plugins too.. call_recursive is almost a match code wise. I think it'll be difficult for developers to know which of the two methods to call when.. and perhaps difficult for plugin developers to understand what they should be returning... something that can be fed back into @args or something entirely different.. Hmm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #53 from Martin Renvoize --- Sorry dude, this needs a rebase.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #52 from Kyle M Hall --- (In reply to Jonathan Druart from comment #42) > Isn't there a problem if several plugins has the method defined? Looks like call() get modified so it no longer works for this patch set. I've introduced call_recursive() ( not technically recursive, can be renamed ) that fixes this and allows for multiple barcode transformation plugins to be called in succession! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #51 from Kyle M Hall --- Created attachment 115180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115180=edit Bug 26351: Add call_recursive() as a replacement for call() The method call() is not sufficient for barcode transformations. It's possible that more than one barcode transformation plugin will be installed. call_recursive() takes the output of the first plugin and uses it as the input for the next plugin and so on. This allowes each plugin to see the current version of the barcode and modify it if necessary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #50 from Kyle M Hall --- Created attachment 115179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115179=edit Bug 26351: (QA follow-up) Fix Checkouts.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #49 from Kyle M Hall --- Created attachment 115178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115178=edit Bug 26351: (QA follow-up) Catch one last case of itemBarcodeInputFilter Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #48 from Kyle M Hall --- Created attachment 115177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115177=edit Bug 26351: (QA follow-up) Barcodes inputted into Koha should always pass though barcodedecode Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #47 from Kyle M Hall --- Created attachment 115176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115176=edit Bug 26351: (QA follow-up) Rename barcode_transform to item_barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #46 from Kyle M Hall --- Created attachment 115175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115175=edit Bug 26351: (QA follow-up) Remove unused method barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #45 from Kyle M Hall --- Created attachment 115174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115174=edit Bug 26351: Add unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #44 from Kyle M Hall --- Created attachment 115173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115173=edit Bug 26351: (QA follow-up) Fix QA script issue * Fixes issue with barcode generate stub so perlcritic is happy * Removes extra semicolon from return call in configure method Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Attachment #113571|0 |1 is obsolete|| Attachment #113572|0 |1 is obsolete|| Attachment #113573|0 |1 is obsolete|| Attachment #113574|0 |1 is obsolete|| Attachment #113575|0 |1 is obsolete|| Attachment #113576|0 |1 is obsolete|| Attachment #113577|0 |1 is obsolete|| Attachment #113578|0 |1 is obsolete|| --- Comment #43 from Kyle M Hall --- Created attachment 115172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115172=edit Bug 26351: Add plugin hooks to transform item barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the item barcode field on the checkin and checkout pages, and anywhere else you can scan an item barcode, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Note the letters are removed by Koha! Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #42 from Jonathan Druart --- Isn't there a problem if several plugins has the method defined? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #41 from Jonathan Druart
---
Hum, there is something wrong here.
Plugin has:
sub item_barcode_transform {
my ( $self, $barcode ) = @_;
$barcode =~ s|0|X|g;
return $barcode;
}
Checkout "0101"
I get "Barcode not found The barcode was not found: 1"
I am expecting "Barcode not found The barcode was not found: X1X1"
It would be nice to have the example plugin updated.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Nick Clemens changed: What|Removed |Added Keywords|release-notes-needed| CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Text to go in the||This enhancement adds a release notes||plugin hook to transform ||item barcodes scanned in to ||Koha. For example, if you ||need to alter your scanned ||item barcodes, but your ||scanners cannot be ||programmed to do so, a ||plugin could be written to ||handle that change in Koha ||instead. One example would ||be to drop the first and ||last characters of the ||scanned barcode, which may ||be check digits rather than ||part of the barcode itself. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #40 from Fridolin Somers --- I update the doc in https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #37 from Kyle M Hall --- Created attachment 113576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113576=edit Bug 26351: (QA follow-up) Barcodes inputted into Koha should always pass though barcodedecode Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #39 from Kyle M Hall --- Created attachment 113578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113578=edit Bug 26351: (QA follow-up) Fix Checkouts.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #38 from Kyle M Hall --- Created attachment 113577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113577=edit Bug 26351: (QA follow-up) Catch one last case of itemBarcodeInputFilter Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #35 from Kyle M Hall --- Created attachment 113574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113574=edit Bug 26351: (QA follow-up) Remove unused method barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #34 from Kyle M Hall --- Created attachment 113573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113573=edit Bug 26351: Add unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
