[Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field

2020-12-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206

Fridolin Somers  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |INVALID

--- Comment #5 from Fridolin Somers  ---
O thanks a lot.

Field issues is indeed type sum.
This is for the best ;)

I mark this as invalid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field

2020-12-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206

--- Comment #4 from Nick Clemens  ---
(In reply to Fridolin Somers from comment #3)
> (In reply to Nick Clemens from comment #2)
> > Elastic uses the sum of the 'issues' field which is set to the default of
> > '952l' - so it should match the output when the totalissues field is counted
> > using items.
> Ah sure.
> But I don't see where Elastic does this sum ?

https://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/SearchEngine/Elasticsearch.pm;h=4a2d75d03decd5413ceb1969601d561ae8251f3f;hb=HEAD#l645

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field

2020-12-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206

--- Comment #3 from Fridolin Somers  ---
(In reply to Nick Clemens from comment #2)
> Elastic uses the sum of the 'issues' field which is set to the default of
> '952l' - so it should match the output when the totalissues field is counted
> using items.
Ah sure.
But I don't see where Elastic does this sum ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field

2020-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #2 from Nick Clemens  ---
Elastic uses the sum of the 'issues' field which is set to the default of
'952l' - so it should match the output when the totalissues field is counted
using items.

If you want it to match totalissues using statistics table, then we could map
it to 942$0

Using the sum of the issues from items means we don't rely on the cronjob to
update_totalissues which is maybe a good thing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field

2020-12-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206

Fridolin Somers  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field

2020-12-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206

--- Comment #1 from Fridolin Somers  ---
Created attachment 114344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114344=edit
Bug 27206: Elasticsearch sort by popularity must use totalissues search field

With Zebra search engine, sort by popularity uses search field 9003.
This is from bib1.att : att 9003totalissues
'totalissues' beeing on 942$0

Actually Elasticsearch sort by popularity uses search field 'issues' :
https://git.koha-community.org/Koha-community/Koha/src/commit/cae0ef76f398bb3d9f60235ff10611cc8d8eacb7/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm#L593

Test plan :
1) Use zebra search engine
2) Perform some checkouts and checkins
3) Run misc/cronjobs/update_totalissues.pl
4) Perform a search sorting on popularity
5) Change search engine to Elasticsearch
6) Rebuild all biblios : misc/search_tools/rebuild_elasticsearch.pl -b
7) Perform same search sorting on popularity
=> You should get same order

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field

2020-12-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206

Fridolin Somers  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field

2020-12-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206

Fridolin Somers  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/