[Koha-bugs] [Bug 9266] Untranslated strings in tags moderation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9266] Untranslated strings in tags moderation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9266] Untranslated strings in tags moderation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #7 from Mason James --- > Signed-off-by: Chris Cormack > Signed-off-by: Mason James QA-comment: tested ok, passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9266] Untranslated strings in tags moderation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Mason James changed: What|Removed |Added Attachment #17761|0 |1 is obsolete|| --- Comment #6 from Mason James --- Created attachment 17778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17778&action=edit Bug 9266 - Untranslated strings in tags moderation There are a couple of English strings in tags moderation JavaScript which are not properly enclosed in the _() function enabling translation. As a result, clicking a translated 'Approve' or 'Reject' button in the table of tags would change the button's neighbor's label to the English string. This patch corrects it. To test, apply the patch and regenerate a translation to test with. Go to Tools -> Tags and find a list of tags to moderate (pending, approved, or rejected). When you click on an 'Approve' or 'Reject' tag in the table of tags, the buttons in each Approve/Reject pair should retain their correct translated label. For instance, looking at approved tags in French: [ Approuvé ] [ Rejeter ] Clicking the "Rejetee" button should change the state to: [ Approuver ] [ Rejetée ] Clicking "Approuver" should return the buttons to the first state. Signed-off-by: Chris Cormack Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9266] Untranslated strings in tags moderation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Mason James changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9266] Untranslated strings in tags moderation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Chris Cormack changed: What|Removed |Added Attachment #17730|0 |1 is obsolete|| Status|Needs Signoff |Signed Off Assignee|oleon...@myacpl.org |ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Created attachment 17761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17761&action=edit Signed off patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9266] Untranslated strings in tags moderation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 --- Comment #4 from Owen Leonard --- Created attachment 17730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17730&action=edit Bug 9266 - Untranslated strings in tags moderation There are a couple of English strings in tags moderation JavaScript which are not properly enclosed in the _() function enabling translation. As a result, clicking a translated 'Approve' or 'Reject' button in the table of tags would change the button's neighbor's label to the English string. This patch corrects it. To test, apply the patch and regenerate a translation to test with. Go to Tools -> Tags and find a list of tags to moderate (pending, approved, or rejected). When you click on an 'Approve' or 'Reject' tag in the table of tags, the buttons in each Approve/Reject pair should retain their correct translated label. For instance, looking at approved tags in French: [ Approuvé ] [ Rejeter ] Clicking the "Rejetee" button should change the state to: [ Approuver ] [ Rejetée ] Clicking "Approuver" should return the buttons to the first state. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9266] Untranslated strings in tags moderation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9266] Untranslated strings in tags moderation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Summary|Managing tags / reject: |Untranslated strings in |Error "Unbekannte Operation |tags moderation |(ablehnen)" in translated | |staff client| --- Comment #3 from Owen Leonard --- Since the patch for Bug 10022 fixes the original problem described in this bug I'm having Katrin's #2 problem above take over this report: > 2) When you use the 'reject' and 'accept' links in the list of terms, after > rejecting or accepting one of the buttons appears in English. I could not reproduce this problem: > 1) On the OPAC detail page there is a little icon in front of 'Add' that is > missing in the German templates before 'Hinzufügen'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
