[Koha-bugs] [Bug 9947] Creating item for received serial prefills enumchron subfield

2013-04-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9947

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.8.x and 3.10.x will be in 3.8.12 and 3.10.5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9947] Creating item for received serial prefills enumchron subfield

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9947

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9947] Creating item for received serial prefills enumchron subfield

2013-03-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9947

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9947] Creating item for received serial prefills enumchron subfield

2013-03-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9947

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #17074|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 17084
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17084action=edit
[PASSED QA] Bug 9947 - Creating item for received serial prefills enumchron
subfield

In serial receiving :
When creating an item for an issue, a javascript prefilles the $h subfield with
issue number.
This is for MARC21, in UNIMARC serial number is on $v.

This patch replaces hard-coded value with the subfield mapped with
items.enumchron.

Test plan :
- Set Koha to MARC mapping of items.enumchron on a subfield other than $h,
ie $z
- Go to a serial subscription detail with Serial receipt creates an item
record
- Click on Receive
- On an issue, click on Click to add item
= Check that issue number is copied into selected subfield, ie $z
You may test that with no mapping of items.enumchron there is no javascript
error

Signed-off-by: Chris Cormack chr...@catalyst.net.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Nice catch! Works as advertised.
All tests  pass after fixing tabulation characters in serials-edit.tt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9947] Creating item for received serial prefills enumchron subfield

2013-03-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9947

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #17084|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 17085
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17085action=edit
[PASSED QA] Bug 9947 - Creating item for received serial prefills enumchron
subfield

In serial receiving :
When creating an item for an issue, a javascript prefilles the $h subfield with
issue number.
This is for MARC21, in UNIMARC serial number is on $v.

This patch replaces hard-coded value with the subfield mapped with
items.enumchron.

Test plan :
- Set Koha to MARC mapping of items.enumchron on a subfield other than $h,
ie $z
- Go to a serial subscription detail with Serial receipt creates an item
record
- Click on Receive
- On an issue, click on Click to add item
= Check that issue number is copied into selected subfield, ie $z
You may test that with no mapping of items.enumchron there is no javascript
error

Signed-off-by: Chris Cormack chr...@catalyst.net.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Nice catch! Works as advertised.
All tests pass after fixing tabulation characters in serials-edit.tt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9947] Creating item for received serial prefills enumchron subfield

2013-03-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9947

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9947] Creating item for received serial prefills enumchron subfield

2013-03-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9947

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9947] Creating item for received serial prefills enumchron subfield

2013-03-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9947

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #16976|0   |1
is obsolete||

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 17074
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17074action=edit
Bug 9947 - Creating item for received serial prefills enumchron subfield

In serial receiving :
When creating an item for an issue, a javascript prefilles the $h subfield with
issue number.
This is for MARC21, in UNIMARC serial number is on $v.

This patch replaces hard-coded value with the subfield mapped with
items.enumchron.

Test plan :
- Set Koha to MARC mapping of items.enumchron on a subfield other than $h,
ie $z
- Go to a serial subscription detail with Serial receipt creates an item
record
- Click on Receive
- On an issue, click on Click to add item
= Check that issue number is copied into selected subfield, ie $z
You may test that with no mapping of items.enumchron there is no javascript
error

Signed-off-by: Chris Cormack chr...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9947] Creating item for received serial prefills enumchron subfield

2013-03-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9947

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co
   |ity.org |m

--- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 16976
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16976action=edit
Proposed patch

See commit comment

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9947] Creating item for received serial prefills enumchron subfield

2013-03-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9947

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/