[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #29 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #28142|0 |1 is obsolete|| --- Comment #28 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 28291 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28291action=edit [PASSED QA] Bug 9088: Neworderempty should preselect the only active fund This patch makes the following changes to the template: [1] If you add an order line, and you have one active fund (and zero or more inactive funds), the only active fund is preselected. [2] If you modify an order line while its fund is inactive, it now shows the label (inactive) behind the fund name. (Note that other inactive funds may come up when clicking 'Show all' as they did before.) [3] Corrected some indentation in this template part. Test plan: [1] Add an order line while having one active fund. Is it selected? [2] Add an order line while having two or more active funds. No fund should be preselected. [3] Modify an order line with an active fund. Is it still selected? [4] Modify an order line with an inactive fund F2 (while having one active fund F1; note that this test explicitly wants F1 to be before F2). Check if F2 is selected and is labeled inactive. [5] (Bonus points:) Modify an order line that refers to a deleted fund. If you edit this order, the fund combo should say: Select a fund. (Note: if you delete a fund, the budget_id in aqorders remains.) Signed-off-by: Paola Rossi paola.ro...@cineca.it I test against master 3.15.00.051 I test against all the three options of the AcqCreateItem: placing an order receiving an order cataloging the record All is OK. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||paola.ro...@cineca.it --- Comment #25 from Paola Rossi paola.ro...@cineca.it --- I test against master 3.15.00.051 I test against all the three options of the AcqCreateItem, : placing an order receiving an order cataloging the record All is OK. I pass the patch to Signed Off status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #28043|0 |1 is obsolete|| --- Comment #26 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 28142 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28142action=edit Bug 9088: Neworderempty should preselect the only active fund This patch makes the following changes to the template: [1] If you add an order line, and you have one active fund (and zero or more inactive funds), the only active fund is preselected. [2] If you modify an order line while its fund is inactive, it now shows the label (inactive) behind the fund name. (Note that other inactive funds may come up when clicking 'Show all' as they did before.) [3] Corrected some indentation in this template part. Test plan: [1] Add an order line while having one active fund. Is it selected? [2] Add an order line while having two or more active funds. No fund should be preselected. [3] Modify an order line with an active fund. Is it still selected? [4] Modify an order line with an inactive fund F2 (while having one active fund F1; note that this test explicitly wants F1 to be before F2). Check if F2 is selected and is labeled inactive. [5] (Bonus points:) Modify an order line that refers to a deleted fund. If you edit this order, the fund combo should say: Select a fund. (Note: if you delete a fund, the budget_id in aqorders remains.) Signed-off-by: Paola Rossi paola.ro...@cineca.it I test against master 3.15.00.051 I test against all the three options of the AcqCreateItem: placing an order receiving an order cataloging the record All is OK. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #27 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Paola Rossi from comment #25) I test against master 3.15.00.051 I test against all the three options of the AcqCreateItem, : placing an order receiving an order cataloging the record All is OK. I pass the patch to Signed Off status. Thanks, Paola. I added your signoff line to the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #27712|0 |1 is obsolete|| --- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 28043 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28043action=edit Bug 9088: Neworderempty should preselect the only active fund This patch makes the following changes to the template: [1] If you add an order line, and you have one active fund (and zero or more inactive funds), the only active fund is preselected. [2] If you modify an order line while its fund is inactive, it now shows the label (inactive) behind the fund name. (Note that other inactive funds may come up when clicking 'Show all' as they did before.) [3] Corrected some indentation in this template part. Test plan: [1] Add an order line while having one active fund. Is it selected? [2] Add an order line while having two or more active funds. No fund should be preselected. [3] Modify an order line with an active fund. Is it still selected? [4] Modify an order line with an inactive fund F2 (while having one active fund F1; note that this test explicitly wants F1 to be before F2). Check if F2 is selected and is labeled inactive. [5] (Bonus points:) Modify an order line that refers to a deleted fund. If you edit this order, the fund combo should say: Select a fund. (Note: if you delete a fund, the budget_id in aqorders remains.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #22 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to M. Tompsett from comment #21) Sorry, but guidelines should be followed. :( At least in this case. Have to repeat the option tag now a few times in the if-then-else of the new patch. Slightly less readable. (Also stumbled about the selected attribute; too bad you can't say selected= when you do not want to select..) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #27191|0 |1 is obsolete|| --- Comment #23 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 27712 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27712action=edit Bug 9088: Neworderempty should preselect the only active fund This patch makes the following changes to the template: [1] If you add an order line, and you have one active fund (and zero or more inactive funds), the only active fund is preselected. [2] If you modify an order line while its fund is inactive, it now shows the label (inactive) behind the fund name. (Note that other inactive funds may come up when clicking 'Show all' as they did before.) [3] Corrected some indentation in this template part. Test plan: [1] Add an order line while having one active fund. Is it selected? [2] Add an order line while having two or more active funds. No fund should be preselected. [3] Modify an order line with an active fund. Is it still selected? [4] Modify an order line with an inactive fund F2 (while having one active fund F1; note that this test explicitly wants F1 to be before F2). Check if F2 is selected and is labeled inactive. [5] (Bonus points:) Modify an order line that refers to a deleted fund. If you edit this order, the fund combo should say: Select a fund. (Note: if you delete a fund, the budget_id in aqorders remains.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #20 from M. Tompsett mtomp...@hotmail.com --- Comment on attachment 27191 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27191 Bug 9088: Neworderempty should preselect the only active fund Review of attachment 27191: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=9088attachment=27191) - ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt @@ +425,5 @@ +[% FOREACH budget_loo IN budget_loop %] +option value=[% budget_loo.b_id %] +[% IF budget_loo.b_sel %] +[% active_count = 0 #select no other fund %] +selected=selected Sorry, but this violates HTML1 in the coding guidelines. http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||mtomp...@hotmail.com --- Comment #21 from M. Tompsett mtomp...@hotmail.com --- Sorry, but guidelines should be followed. :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Summary|neworderempty should|neworderempty should |preselect the only fund |preselect the only active ||fund for new orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #16 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Katrin Fischer from comment #15) Hm, die we uncover another bug here? It seems one of those days... I think when modifying an existing order, it should always preselect what's in the database, even if the fund has been marked inactive since or was inactive when selected. If we need to preselect 'show all' in order to make that work, I guess we need to do that. I was thinking in the same direction. New patch forthcoming (need to adjust a few lines more..) No need to preselect Show all btw. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #27067|0 |1 is obsolete|| --- Comment #17 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 27188 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27188action=edit Bug 9088: Neworderempty should preselect the only active fund This patch makes the following changes to the template: [1] If you add an order line, and you have one active fund (and zero or more inactive funds), the only active fund is preselected. [2] If you modify an order line while its fund is inactive, it now shows the label (inactive) behind the fund name. (Note that other inactive funds may come up when clicking 'Show all' as they did before.) [3] Corrected some indentation in this template part. Test plan: [1] Add an order line while having one active fund. Is it selected? [2] Add an order line while having two or more active funds. No fund should be preselected. [3] Modify an order line with an active fund. Is it still selected? [4] Modify an order line with an inactive fund F2 (while having one active fund F1; note that this test explicitly wants F1 to be before F2). Check if F2 is selected and is labeled inactive. [5] (Bonus points:) Modify an order line that refers to a deleted fund. If you edit this order, the fund combo should say: Select a fund. (Note: if you delete a fund, the budget_id in aqorders remains.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #27188|0 |1 is obsolete|| --- Comment #18 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 27191 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27191action=edit Bug 9088: Neworderempty should preselect the only active fund This patch makes the following changes to the template: [1] If you add an order line, and you have one active fund (and zero or more inactive funds), the only active fund is preselected. [2] If you modify an order line while its fund is inactive, it now shows the label (inactive) behind the fund name. (Note that other inactive funds may come up when clicking 'Show all' as they did before.) [3] Corrected some indentation in this template part. Test plan: [1] Add an order line while having one active fund. Is it selected? [2] Add an order line while having two or more active funds. No fund should be preselected. [3] Modify an order line with an active fund. Is it still selected? [4] Modify an order line with an inactive fund F2 (while having one active fund F1; note that this test explicitly wants F1 to be before F2). Check if F2 is selected and is labeled inactive. [5] (Bonus points:) Modify an order line that refers to a deleted fund. If you edit this order, the fund combo should say: Select a fund. (Note: if you delete a fund, the budget_id in aqorders remains.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9088] neworderempty should preselect the only active fund for new orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088 --- Comment #19 from M. de Rooy m.de.r...@rijksmuseum.nl --- Couldn't resist adjusting indentation in the commit message too :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
